)]}'
{"id":"openstack%2Fopenstacksdk~859396","triplet_id":"openstack%2Fopenstacksdk~master~I176e4e1c139c6dd9fe758b8ee8e129007337eb58","project":"openstack/openstacksdk","branch":"master","topic":"network-filters","attention_set":{},"removed_from_attention_set":{"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-10-01 08:34:53.000000000","reason":"Change was abandoned"},"27900":{"account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"last_update":"2022-10-01 08:34:53.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I176e4e1c139c6dd9fe758b8ee8e129007337eb58","subject":"Restore functionality to search for network resources by name and id","status":"ABANDONED","created":"2022-09-27 09:35:06.000000000","updated":"2022-10-01 08:34:53.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a925df341b0565f993e323b20b6c43955f08517e","_number":859396,"virtual_id_number":859396,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-09-27 11:05:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-27 09:44:36.000000000","updated_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2022-09-27 11:05:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d3ed404149087751c6a02491a5a8a718f82e615f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-09-27 09:35:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8621f536fdb18d0d2549c9142908a815ce8c5680","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-27 11:05:14.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/3d2a7654461f4aa5af9500c977a15d36\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4a540e6bd3ea41f0bcc2745ac48d0bf2 : SUCCESS in 4m 27s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/468cdbdd62934d1da55772c9f38713fe : SUCCESS in 4m 50s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/dfe93cedc0e64b489d8526e1a1026051 : SUCCESS in 5m 01s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/04974e870ed44197aa347ec53c2f4518 : FAILURE in 1h 01m 59s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/987877f045dd4831ad0bde6c7e96594b : SUCCESS in 4m 45s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/dbfe2228a1df45ccbf32b1fa8a4c679f : SUCCESS in 4m 32s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/d84012b2a439465197297b0431e5bd2a : SUCCESS in 5m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/df78ae75ffad49d19000eb9e73c8348a : SUCCESS in 10m 07s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/19ddf0b919af482883c0377cffdf2a0d : SUCCESS in 1h 10m 09s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/29347dd3cbb84b87a0723286bac428cc : SUCCESS in 16m 01s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/a5ef428645524818a24965d14bce9c03 : SUCCESS in 39m 45s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/1d6ff403b9b845dd9fc40a9eaa1d583c : FAILURE in 44m 50s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/fd36d6259e2e43e1bc0b1dc297d532a6 : FAILURE in 1h 22m 52s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/9b5cc0c9e91843fa877e450e79f0c653 : FAILURE in 42m 36s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/936ea762a1544758b8c0930d7c311525 : FAILURE in 39m 20s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/1c9fc97e478d4146bb4be56d9037f948 : SUCCESS in 34m 54s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/bcd77daef4da4eb7989433a008b3cbee : SUCCESS in 29m 13s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/1bc45c8b7830426a8a372df3e4a1cb91 : SUCCESS in 34m 00s (non-voting)\n- openstacksdk-functional-devstack-legacy https://zuul.opendev.org/t/openstack/build/a3ec2b9900d5485eba89f1d02b90e2d3 : FAILURE in 37m 15s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/f5b2a929a0c847b98f4778be011d889a : SUCCESS in 48m 51s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/d20be9d246704ef181cf152bf8838c7b : SUCCESS in 1h 01m 20s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/a6ddd32264404cefa1f082a8eb504624 : FAILURE in 12m 09s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/a16cede50ed14507992e2734608bd0b8 : FAILURE in 45m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a925df341b0565f993e323b20b6c43955f08517e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-10-01 08:34:53.000000000","message":"Abandoned\n\nObsoleted by https://review.opendev.org/c/openstack/openstacksdk/+/859845","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"902907ae06d51bdc7949b2029717d106835008b0","revisions":{"902907ae06d51bdc7949b2029717d106835008b0":{"kind":"REWORK","_number":1,"created":"2022-09-27 09:35:06.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/96/859396/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/96/859396/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/96/859396/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/96/859396/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/96/859396/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/96/859396/1"}}},"commit":{"parents":[{"commit":"9b1c4333526862d0edfc8e5f7bd421b0065b06db","subject":"Merge \"Add support for fault object per Server API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/9b1c4333526862d0edfc8e5f7bd421b0065b06db"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-09-27 09:34:56.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-09-27 09:34:56.000000000","tz":120},"subject":"Restore functionality to search for network resources by name and id","message":"Restore functionality to search for network resources by name and id\n\nUp to openstacksdk 0.61.0 it was possible to use search_* functions\nsuch as search_networks() to find network resources by name or id.\n\nCommit 6db391f674 [1] changed the behaviour of search_* functions to\nonly allow finding resources by name. It passed the name_or_id\nparameter as a query parameter \u0027name\u0027 to the OpenStack API for server\nside filtering. But server side filtering does not allow to filter by\nids.\n\nThis patch restores the previous behaviour by utilizing the private\n_utils._filter_list() function which is used e.g. by openstacksdk\u0027s\ncloud layer functions related to keystone/identity [2].\n\n[1] https://opendev.org/openstack/openstacksdk/commit/6db391f674077970b113006e52eeac103b6c1dea\n[2] https://opendev.org/openstack/openstacksdk/src/commit/9b1c4333526862d0edfc8e5f7bd421b0065b06db/openstack/cloud/_identity.py#L102\n\nChange-Id: I176e4e1c139c6dd9fe758b8ee8e129007337eb58\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/902907ae06d51bdc7949b2029717d106835008b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/902907ae06d51bdc7949b2029717d106835008b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
