)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"942bf258495cfac245a9251c53d67b37bf8cc89a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9d53958_94e76758","updated":"2022-10-06 14:07:32.000000000","message":"Annoyingly, the details endpoint returns tags as an array[1], so this might not be as simple.\n\n[1] https://docs.openstack.org/api-ref/orchestration/v1/index.html?expanded\u003dshow-stack-details-detail#show-stack-details","commit_id":"96b851d3b4aeb42cd2a0e5551ce63f2474023472"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"b6fc3cba516443bd5fc6ddc2a5fb1faffe8b2b7e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"12350e71_55674abc","in_reply_to":"c9d53958_94e76758","updated":"2022-10-06 19:24:47.000000000","message":"Good catch! Marking as unresolved to keep awareness for this.","commit_id":"96b851d3b4aeb42cd2a0e5551ce63f2474023472"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"b6fc3cba516443bd5fc6ddc2a5fb1faffe8b2b7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b910014c_cd92d3fc","updated":"2022-10-06 19:24:47.000000000","message":"Marking this as work in progress because both Rafael and Stephen raised valid concerns and suggested a different approach.","commit_id":"8a1eb5104b3cad84302045107d58ae377bd9e795"}],"openstack/orchestration/v1/stack.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7801b834e5ba0697b2551c9b2e5864b88410149c","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    status_reason \u003d resource.Body(\u0027stack_status_reason\u0027)"},{"line_number":89,"context_line":"    #: One or more simple string tags to associate with the stack. To associate"},{"line_number":90,"context_line":"    #: multiple tags with a stack, separate the tags with commas."},{"line_number":91,"context_line":"    tags \u003d resource.Body(\u0027tags\u0027)"},{"line_number":92,"context_line":"    #: A dict containing the template use for stack creation."},{"line_number":93,"context_line":"    template \u003d resource.Body(\u0027template\u0027, type\u003ddict)"},{"line_number":94,"context_line":"    #: Stack template description text. Currently contains the same text"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8252ac_811e1475","line":91,"updated":"2022-10-06 14:49:41.000000000","message":"Is there any chance we could treat this like a list still? If you overrode \u0027_prepare_request_body\u0027 here that should do the trick.\n\n  def _prepare_request_body(self, patch, prepend_key):\n      body \u003d super()._prepare_request_body(patch, prepend_key)\n      if prepend_key:\n          body \u003d body[self.resource_key]\n\n      if \u0027tags\u0027 in body:\n          body[\u0027tags\u0027] \u003d \u0027,\u0027.join(body[\u0027tags\u0027])\n          \n      if prepend_key:\n          body[self.resource_key] \u003d body\n\n      return body\n\nThere\u0027s probably a bit more to do but that (i.e. when parsing the response) but this should be a start?","commit_id":"96b851d3b4aeb42cd2a0e5551ce63f2474023472"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"b6fc3cba516443bd5fc6ddc2a5fb1faffe8b2b7e","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    status_reason \u003d resource.Body(\u0027stack_status_reason\u0027)"},{"line_number":89,"context_line":"    #: One or more simple string tags to associate with the stack. To associate"},{"line_number":90,"context_line":"    #: multiple tags with a stack, separate the tags with commas."},{"line_number":91,"context_line":"    tags \u003d resource.Body(\u0027tags\u0027)"},{"line_number":92,"context_line":"    #: A dict containing the template use for stack creation."},{"line_number":93,"context_line":"    template \u003d resource.Body(\u0027template\u0027, type\u003ddict)"},{"line_number":94,"context_line":"    #: Stack template description text. Currently contains the same text"}],"source_content_type":"text/x-python","patch_set":1,"id":"79adc7f0_7d697584","line":91,"in_reply_to":"bf8252ac_811e1475","updated":"2022-10-06 19:24:47.000000000","message":"Oh, I like your approach more than converting \u0027tags\u0027 to plain strings. I am not sure what the implications of this are..\n\nFeel free to play with and edit this patch!","commit_id":"96b851d3b4aeb42cd2a0e5551ce63f2474023472"}]}
