)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"30c194b9d401908ba1c9306abec7e6992408fd83","unresolved":true,"context_lines":[{"line_number":9,"context_line":"- Add resource for Metadata definition resource types Glance v2"},{"line_number":10,"context_line":"  API(https://docs.openstack.org/api-ref/image/v2/metadefs-index.html#metadata-definition-resource-types)"},{"line_number":11,"context_line":"- Change method names and adjust spacing"},{"line_number":12,"context_line":"- Resolve merge conflict"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8ac7d15e69cb5cb017fe93e38736b8dbee9ae2f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"835ad84c_e29b27d2","line":12,"updated":"2022-11-21 16:31:41.000000000","message":"You shouldn\u0027t add this to the commit message. This makes sense in the context of a Gerrit review but doesn\u0027t make sense once the code is merged. I would recommend a Gerrit comment instead if you\u0027d like to highlight things like this.","commit_id":"c52f2decd3b2b2f7b3cde811d9fbf6d1cd7a352c"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"dda2553646564d3600dbc17960c0bb8d17f512f4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- Add resource for Metadata definition resource types Glance v2"},{"line_number":10,"context_line":"  API(https://docs.openstack.org/api-ref/image/v2/metadefs-index.html#metadata-definition-resource-types)"},{"line_number":11,"context_line":"- Change method names and adjust spacing"},{"line_number":12,"context_line":"- Resolve merge conflict"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8ac7d15e69cb5cb017fe93e38736b8dbee9ae2f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"898300c6_f9cd7343","line":12,"in_reply_to":"835ad84c_e29b27d2","updated":"2022-11-22 13:32:41.000000000","message":"Okay, Thanks!","commit_id":"c52f2decd3b2b2f7b3cde811d9fbf6d1cd7a352c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63be8bfff51c184dab1f2a556dba3eebb0fb91fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8de48ff_088ccdcd","updated":"2022-10-18 13:49:50.000000000","message":"Couple of nits but nothing big. Nice work. Fix those and I\u0027m happy","commit_id":"02d417e011f042567a4353fe957682e407126f19"}],"openstack/image/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63be8bfff51c184dab1f2a556dba3eebb0fb91fd","unresolved":true,"context_lines":[{"line_number":771,"context_line":"        return self._list(_metadef_resource_type.MetadefResourceType, **query)"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d METADEF RESOURCE TYPES ASSOCIATION\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":774,"context_line":"    def metadef_resource_type_associate(self, metadef_namespace, **attrs):"},{"line_number":775,"context_line":"        \"\"\"Creates a resource type association between a namespace"},{"line_number":776,"context_line":"            and the resource type specified in the body of the request."},{"line_number":777,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"77b4ccac_1df6deeb","line":774,"updated":"2022-10-18 13:49:50.000000000","message":"Also, we usually name these as \u0027{action}_{resource}\u0027, so this should read e.g.:\n\n  def associate_metadef_resource_type_with_metadef_namespace(...):\n\nor:\n\n  def associate_metadef_resource_type(...):\n\nor simply:\n\n  def create_metadef_resource_type_association(...):","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"9b000b6aa65cd4f0b0b1485aaa5571c6ffa73ea7","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        return self._list(_metadef_resource_type.MetadefResourceType, **query)"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d METADEF RESOURCE TYPES ASSOCIATION\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":774,"context_line":"    def metadef_resource_type_associate(self, metadef_namespace, **attrs):"},{"line_number":775,"context_line":"        \"\"\"Creates a resource type association between a namespace"},{"line_number":776,"context_line":"            and the resource type specified in the body of the request."},{"line_number":777,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6299941b_8e2825c1","line":774,"in_reply_to":"77b4ccac_1df6deeb","updated":"2022-10-24 11:11:52.000000000","message":"Yes, I\u0027d replaced method name to \u0027create_metadef_resource_type_association\u0027, Thanks.","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63be8bfff51c184dab1f2a556dba3eebb0fb91fd","unresolved":true,"context_lines":[{"line_number":790,"context_line":"            namespace_name\u003dnamespace_name,"},{"line_number":791,"context_line":"            **attrs)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def metadef_resource_type_deassociate(self, metadef_resource_type,"},{"line_number":794,"context_line":"                                          metadef_namespace,"},{"line_number":795,"context_line":"                                          ignore_missing\u003dTrue):"},{"line_number":796,"context_line":"        \"\"\"Removes a resource type association in a namespace."}],"source_content_type":"text/x-python","patch_set":1,"id":"bc0e8b26_09a44c74","line":793,"range":{"start_line":793,"start_character":30,"end_line":793,"end_character":41},"updated":"2022-10-18 13:49:50.000000000","message":"disassociate (dis-, not de-)","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"9b000b6aa65cd4f0b0b1485aaa5571c6ffa73ea7","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            namespace_name\u003dnamespace_name,"},{"line_number":791,"context_line":"            **attrs)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def metadef_resource_type_deassociate(self, metadef_resource_type,"},{"line_number":794,"context_line":"                                          metadef_namespace,"},{"line_number":795,"context_line":"                                          ignore_missing\u003dTrue):"},{"line_number":796,"context_line":"        \"\"\"Removes a resource type association in a namespace."}],"source_content_type":"text/x-python","patch_set":1,"id":"c08a783a_1c18e61f","line":793,"range":{"start_line":793,"start_character":30,"end_line":793,"end_character":41},"in_reply_to":"bc0e8b26_09a44c74","updated":"2022-10-24 11:11:52.000000000","message":"I\u0027d changed method name more clearly. (not use de-), Thanks.","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63be8bfff51c184dab1f2a556dba3eebb0fb91fd","unresolved":true,"context_lines":[{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def metadef_resource_type_deassociate(self, metadef_resource_type,"},{"line_number":794,"context_line":"                                          metadef_namespace,"},{"line_number":795,"context_line":"                                          ignore_missing\u003dTrue):"},{"line_number":796,"context_line":"        \"\"\"Removes a resource type association in a namespace."},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        :param metadef_resource_type: The value can be either the name of"}],"source_content_type":"text/x-python","patch_set":1,"id":"5989cd67_6680e710","line":795,"updated":"2022-10-18 13:49:50.000000000","message":"nit: Could you put these on their own lines?\n\n  def associate_metadef_resource_type(\n      self,\n      metadef_resource_type,\n      metadef_namespace,\n      ignore_missing\u003dTrue,\n  ):","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"9b000b6aa65cd4f0b0b1485aaa5571c6ffa73ea7","unresolved":false,"context_lines":[{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def metadef_resource_type_deassociate(self, metadef_resource_type,"},{"line_number":794,"context_line":"                                          metadef_namespace,"},{"line_number":795,"context_line":"                                          ignore_missing\u003dTrue):"},{"line_number":796,"context_line":"        \"\"\"Removes a resource type association in a namespace."},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        :param metadef_resource_type: The value can be either the name of"}],"source_content_type":"text/x-python","patch_set":1,"id":"77e8318d_74dd6468","line":795,"in_reply_to":"5989cd67_6680e710","updated":"2022-10-24 11:11:52.000000000","message":"Thank you! I changed.","commit_id":"02d417e011f042567a4353fe957682e407126f19"}],"openstack/tests/functional/image/v2/test_metadef_resource_type.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63be8bfff51c184dab1f2a556dba3eebb0fb91fd","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        resource_type_name \u003d \u0027test-resource-type\u0027"},{"line_number":35,"context_line":"        resource_type \u003d {\u0027name\u0027: resource_type_name}"},{"line_number":36,"context_line":"        self.metadef_resource_type \\"},{"line_number":37,"context_line":"            \u003d self.conn.image.metadef_resource_type_associate("},{"line_number":38,"context_line":"                metadef_namespace\u003dnamespace,"},{"line_number":39,"context_line":"                **resource_type"},{"line_number":40,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae16458_aebb6e5b","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":14},"updated":"2022-10-18 13:49:50.000000000","message":"nit: can you put this on the line above?","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"9b000b6aa65cd4f0b0b1485aaa5571c6ffa73ea7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        resource_type_name \u003d \u0027test-resource-type\u0027"},{"line_number":35,"context_line":"        resource_type \u003d {\u0027name\u0027: resource_type_name}"},{"line_number":36,"context_line":"        self.metadef_resource_type \\"},{"line_number":37,"context_line":"            \u003d self.conn.image.metadef_resource_type_associate("},{"line_number":38,"context_line":"                metadef_namespace\u003dnamespace,"},{"line_number":39,"context_line":"                **resource_type"},{"line_number":40,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5229772f_2103889f","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":14},"in_reply_to":"3ae16458_aebb6e5b","updated":"2022-10-24 11:11:52.000000000","message":"Yes, I changed. Thanks.","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63be8bfff51c184dab1f2a556dba3eebb0fb91fd","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        self.conn.image.metadef_resource_type_deassociate("},{"line_number":77,"context_line":"            self.metadef_resource_type,"},{"line_number":78,"context_line":"            metadef_namespace\u003dself.metadef_namespace"},{"line_number":79,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"a33fb54a_f240c986","line":79,"updated":"2022-10-18 13:49:50.000000000","message":"This should happen in tearDown to ensure it actually happens. Otherwise, if the test fails this won\u0027t be cleaned up","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9083b98156e20415da1e8ac100b267179244c892","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.conn.image.metadef_resource_type_deassociate("},{"line_number":77,"context_line":"            self.metadef_resource_type,"},{"line_number":78,"context_line":"            metadef_namespace\u003dself.metadef_namespace"},{"line_number":79,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"238679da_900e57cf","line":79,"in_reply_to":"770c21ea_4380f7ad","updated":"2022-10-26 09:17:24.000000000","message":"Ack, thanks for the context. A comment here would be helpful for others who make the mistake I made","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"159a5f8ddcee18fc6cb37384372112ee127f9a81","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.conn.image.metadef_resource_type_deassociate("},{"line_number":77,"context_line":"            self.metadef_resource_type,"},{"line_number":78,"context_line":"            metadef_namespace\u003dself.metadef_namespace"},{"line_number":79,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"770c21ea_4380f7ad","line":79,"in_reply_to":"7e2a05be_7e870bd3","updated":"2022-10-26 06:10:31.000000000","message":"Done","commit_id":"02d417e011f042567a4353fe957682e407126f19"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"9b000b6aa65cd4f0b0b1485aaa5571c6ffa73ea7","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        self.conn.image.metadef_resource_type_deassociate("},{"line_number":77,"context_line":"            self.metadef_resource_type,"},{"line_number":78,"context_line":"            metadef_namespace\u003dself.metadef_namespace"},{"line_number":79,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e2a05be_7e870bd3","line":79,"in_reply_to":"a33fb54a_f240c986","updated":"2022-10-24 11:11:52.000000000","message":"I noticed that when the \u0027namespace\u0027 will be deleted in tearDown, resource type associations that are dependent on the \u0027namespace\u0027 will be also deleted without explicitly deletion.","commit_id":"02d417e011f042567a4353fe957682e407126f19"}]}