)]}'
{"openstack/image/v2/_proxy.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f41b339ce1ba3929e1054a547d9968aedea29b0","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        self,"},{"line_number":54,"context_line":"        image,"},{"line_number":55,"context_line":"        method\u003d\u0027glance-direct\u0027,"},{"line_number":56,"context_line":"        *,"},{"line_number":57,"context_line":"        uri\u003dNone,"},{"line_number":58,"context_line":"        remote_region\u003dNone,"},{"line_number":59,"context_line":"        remote_image_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ae6c4b0_22484295","line":56,"updated":"2022-12-08 19:15:34.000000000","message":"This will break existing code that uses uri as a positional parameter, like in the tests before this patch. I think this requires at least a warning in the reno.","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"724b63b5504f9c06a01f3db3e24e438c9f72374c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self,"},{"line_number":54,"context_line":"        image,"},{"line_number":55,"context_line":"        method\u003d\u0027glance-direct\u0027,"},{"line_number":56,"context_line":"        *,"},{"line_number":57,"context_line":"        uri\u003dNone,"},{"line_number":58,"context_line":"        remote_region\u003dNone,"},{"line_number":59,"context_line":"        remote_image_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"24c2c7c3_47a3e07c","line":56,"in_reply_to":"4ae6c4b0_22484295","updated":"2023-01-13 17:26:48.000000000","message":"I considered it but decided not to because it felt a little too...specific. Since you\u0027ve also suggested it, I went ahead and added it.","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f41b339ce1ba3929e1054a547d9968aedea29b0","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            service."},{"line_number":85,"context_line":"        :param remote_region:"},{"line_number":86,"context_line":"            The remote glance region to download the image from when using"},{"line_number":87,"context_line":"            glance-direct."},{"line_number":88,"context_line":"        :param remote_image_id:"},{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."}],"source_content_type":"text/x-python","patch_set":4,"id":"2b225854_7564b4fd","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":25},"updated":"2022-12-08 19:15:34.000000000","message":"Do you mean \"glance-download\" here?","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"724b63b5504f9c06a01f3db3e24e438c9f72374c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            service."},{"line_number":85,"context_line":"        :param remote_region:"},{"line_number":86,"context_line":"            The remote glance region to download the image from when using"},{"line_number":87,"context_line":"            glance-direct."},{"line_number":88,"context_line":"        :param remote_image_id:"},{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."}],"source_content_type":"text/x-python","patch_set":4,"id":"85d8b6be_a7e612f6","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":25},"in_reply_to":"2b225854_7564b4fd","updated":"2023-01-13 17:26:48.000000000","message":"Done","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f41b339ce1ba3929e1054a547d9968aedea29b0","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            The remote glance region to download the image from when using"},{"line_number":87,"context_line":"            glance-direct."},{"line_number":88,"context_line":"        :param remote_image_id:"},{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."},{"line_number":91,"context_line":"        :param remote_service_interface:"},{"line_number":92,"context_line":"            The remote glance service interface to use when uding"}],"source_content_type":"text/x-python","patch_set":4,"id":"06c1e01c_e82b89c7","line":89,"range":{"start_line":89,"start_character":32,"end_line":89,"end_character":34},"updated":"2022-12-08 19:15:34.000000000","message":"This seems one \"of\" too much","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"724b63b5504f9c06a01f3db3e24e438c9f72374c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            The remote glance region to download the image from when using"},{"line_number":87,"context_line":"            glance-direct."},{"line_number":88,"context_line":"        :param remote_image_id:"},{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."},{"line_number":91,"context_line":"        :param remote_service_interface:"},{"line_number":92,"context_line":"            The remote glance service interface to use when uding"}],"source_content_type":"text/x-python","patch_set":4,"id":"0e723d71_819b3d00","line":89,"range":{"start_line":89,"start_character":32,"end_line":89,"end_character":34},"in_reply_to":"06c1e01c_e82b89c7","updated":"2023-01-13 17:26:48.000000000","message":"Done","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f41b339ce1ba3929e1054a547d9968aedea29b0","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            glance-direct."},{"line_number":88,"context_line":"        :param remote_image_id:"},{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."},{"line_number":91,"context_line":"        :param remote_service_interface:"},{"line_number":92,"context_line":"            The remote glance service interface to use when uding"},{"line_number":93,"context_line":"            glance-download"}],"source_content_type":"text/x-python","patch_set":4,"id":"547b676e_04c05534","line":90,"updated":"2022-12-08 19:15:34.000000000","message":"dito","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"724b63b5504f9c06a01f3db3e24e438c9f72374c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            glance-direct."},{"line_number":88,"context_line":"        :param remote_image_id:"},{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."},{"line_number":91,"context_line":"        :param remote_service_interface:"},{"line_number":92,"context_line":"            The remote glance service interface to use when uding"},{"line_number":93,"context_line":"            glance-download"}],"source_content_type":"text/x-python","patch_set":4,"id":"6f659e63_b429f623","line":90,"in_reply_to":"547b676e_04c05534","updated":"2023-01-13 17:26:48.000000000","message":"Done","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f41b339ce1ba3929e1054a547d9968aedea29b0","unresolved":true,"context_lines":[{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."},{"line_number":91,"context_line":"        :param remote_service_interface:"},{"line_number":92,"context_line":"            The remote glance service interface to use when uding"},{"line_number":93,"context_line":"            glance-download"},{"line_number":94,"context_line":"        :param store:"},{"line_number":95,"context_line":"            Used when enabled_backends is activated in glance. The value"}],"source_content_type":"text/x-python","patch_set":4,"id":"343da8c1_9571f05f","line":92,"range":{"start_line":92,"start_character":60,"end_line":92,"end_character":65},"updated":"2022-12-08 19:15:34.000000000","message":"using","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"724b63b5504f9c06a01f3db3e24e438c9f72374c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            The ID of the image of to import from the remote glance when using"},{"line_number":90,"context_line":"            glance-direct."},{"line_number":91,"context_line":"        :param remote_service_interface:"},{"line_number":92,"context_line":"            The remote glance service interface to use when uding"},{"line_number":93,"context_line":"            glance-download"},{"line_number":94,"context_line":"        :param store:"},{"line_number":95,"context_line":"            Used when enabled_backends is activated in glance. The value"}],"source_content_type":"text/x-python","patch_set":4,"id":"a3af5210_cfef484e","line":92,"range":{"start_line":92,"start_character":60,"end_line":92,"end_character":65},"in_reply_to":"343da8c1_9571f05f","updated":"2023-01-13 17:26:48.000000000","message":"Done","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f41b339ce1ba3929e1054a547d9968aedea29b0","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            the stores where the data has been correctly uploaded."},{"line_number":114,"context_line":"            Default is True."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :returns: None"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        image \u003d self._get_resource(_image.Image, image)"},{"line_number":119,"context_line":"        if all_stores and (store or stores):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ea79fba5_952adf89","line":116,"updated":"2022-12-08 19:15:34.000000000","message":"This needs amending, too. The return value might also be worth getting mentioned in th reno.","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84344c375510f2b7b2b28651c7ebd97e32d87ca8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            the stores where the data has been correctly uploaded."},{"line_number":114,"context_line":"            Default is True."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :returns: None"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        image \u003d self._get_resource(_image.Image, image)"},{"line_number":119,"context_line":"        if all_stores and (store or stores):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3053d1f7_22c1b7be","line":116,"in_reply_to":"ea79fba5_952adf89","updated":"2023-01-13 17:26:56.000000000","message":"Done","commit_id":"0111029ac3e87291098582e60dc17ffecfc94630"}]}
