)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a04e78d4d70961c99c136ce58d5561989e68cb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56654fff_5c0383f0","updated":"2022-12-20 08:52:40.000000000","message":"Thanks a lot for this patch, important feature gap fix.\n\nMaybe it would also be worth a release note?","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"42ad96ceb792fa02d972bedf82cd1d2ce04ac067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56cdc283_3ce7bc4a","updated":"2022-12-29 10:15:14.000000000","message":"I still would like to see a release note, please let me know if I should add it for you.","commit_id":"f269a22ee669e052c66d314b5520d30ca83038a2"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"7c974e75f5d383ef9450f98dd2b85e7d56b6671c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4262dfc6_f2b0476c","in_reply_to":"56cdc283_3ce7bc4a","updated":"2023-01-02 10:47:41.000000000","message":"added","commit_id":"f269a22ee669e052c66d314b5520d30ca83038a2"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"0451ea98a0e6169e8f1789ebf9a027e3915db9d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36d63cd4_d6fe5792","updated":"2023-01-02 12:15:05.000000000","message":"recheck (whatever happened here)","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"}],"openstack/cloud/_network.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a04e78d4d70961c99c136ce58d5561989e68cb1","unresolved":true,"context_lines":[{"line_number":2168,"context_line":"        :param string ipv6_address_mode: IPv6 address mode. Valid values are:"},{"line_number":2169,"context_line":"            \u0027dhcpv6-stateful\u0027, \u0027dhcpv6-stateless\u0027, or \u0027slaac\u0027."},{"line_number":2170,"context_line":"        :param string prefixlen: The prefix length to use for subnet allocation"},{"line_number":2171,"context_line":"            from a subnet pool."},{"line_number":2172,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2173,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2174,"context_line":"            the ``cidr`` argument when enabling this option."}],"source_content_type":"text/x-python","patch_set":2,"id":"0eef5f5d_bcd757ad","line":2171,"range":{"start_line":2171,"start_character":19,"end_line":2171,"end_character":30},"updated":"2022-12-20 08:52:40.000000000","message":"Nit: subnetpool","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"b46dbce2400dde5b1cbfa12231217c162ef45e24","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"        :param string ipv6_address_mode: IPv6 address mode. Valid values are:"},{"line_number":2169,"context_line":"            \u0027dhcpv6-stateful\u0027, \u0027dhcpv6-stateless\u0027, or \u0027slaac\u0027."},{"line_number":2170,"context_line":"        :param string prefixlen: The prefix length to use for subnet allocation"},{"line_number":2171,"context_line":"            from a subnet pool."},{"line_number":2172,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2173,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2174,"context_line":"            the ``cidr`` argument when enabling this option."}],"source_content_type":"text/x-python","patch_set":2,"id":"6974d408_9b360933","line":2171,"range":{"start_line":2171,"start_character":19,"end_line":2171,"end_character":30},"in_reply_to":"0eef5f5d_bcd757ad","updated":"2022-12-22 13:44:34.000000000","message":"thanks. fixed","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a04e78d4d70961c99c136ce58d5561989e68cb1","unresolved":true,"context_lines":[{"line_number":2170,"context_line":"        :param string prefixlen: The prefix length to use for subnet allocation"},{"line_number":2171,"context_line":"            from a subnet pool."},{"line_number":2172,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2173,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2174,"context_line":"            the ``cidr`` argument when enabling this option."},{"line_number":2175,"context_line":"        :param string subnetpool_id: Use this specific subnetpool for"},{"line_number":2176,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2177,"context_line":"            the ``cidr`` argument when enabling this option."}],"source_content_type":"text/x-python","patch_set":2,"id":"b36410fc_ce5c1e7e","line":2174,"range":{"start_line":2173,"start_character":45,"end_line":2174,"end_character":60},"updated":"2022-12-20 08:52:40.000000000","message":"This sounds wrong to me, the default value for cidr is None, so it should be just fine to not specify that argument at all? Copying from other funcs maybe something like:\n\nOnly one of `cidr` , `use_default_subnetpool` and `subnetpool_id` may be specified at the same time.","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"b46dbce2400dde5b1cbfa12231217c162ef45e24","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"        :param string prefixlen: The prefix length to use for subnet allocation"},{"line_number":2171,"context_line":"            from a subnet pool."},{"line_number":2172,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2173,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2174,"context_line":"            the ``cidr`` argument when enabling this option."},{"line_number":2175,"context_line":"        :param string subnetpool_id: Use this specific subnetpool for"},{"line_number":2176,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2177,"context_line":"            the ``cidr`` argument when enabling this option."}],"source_content_type":"text/x-python","patch_set":2,"id":"6c1fe11e_01de642f","line":2174,"range":{"start_line":2173,"start_character":45,"end_line":2174,"end_character":60},"in_reply_to":"b36410fc_ce5c1e7e","updated":"2022-12-22 13:44:34.000000000","message":"thanks fixed","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a04e78d4d70961c99c136ce58d5561989e68cb1","unresolved":true,"context_lines":[{"line_number":2172,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2173,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2174,"context_line":"            the ``cidr`` argument when enabling this option."},{"line_number":2175,"context_line":"        :param string subnetpool_id: Use this specific subnetpool for"},{"line_number":2176,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2177,"context_line":"            the ``cidr`` argument when enabling this option."},{"line_number":2178,"context_line":"        :param kwargs: Key value pairs to be passed to the Neutron API."},{"line_number":2179,"context_line":"        :returns: The created network ``Subnet`` object."}],"source_content_type":"text/x-python","patch_set":2,"id":"7c1bee01_f743cdcf","line":2176,"range":{"start_line":2175,"start_character":37,"end_line":2176,"end_character":44},"updated":"2022-12-20 08:52:40.000000000","message":"The first sentence should simply be:\n\nUse this subnetpool to obtain a CIDR.\n\nThe second sentence should be amended matching the comment above.","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"b46dbce2400dde5b1cbfa12231217c162ef45e24","unresolved":false,"context_lines":[{"line_number":2172,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2173,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2174,"context_line":"            the ``cidr`` argument when enabling this option."},{"line_number":2175,"context_line":"        :param string subnetpool_id: Use this specific subnetpool for"},{"line_number":2176,"context_line":"            ``ip_version`` to obtain a CIDR. It is required to pass ``None`` to"},{"line_number":2177,"context_line":"            the ``cidr`` argument when enabling this option."},{"line_number":2178,"context_line":"        :param kwargs: Key value pairs to be passed to the Neutron API."},{"line_number":2179,"context_line":"        :returns: The created network ``Subnet`` object."}],"source_content_type":"text/x-python","patch_set":2,"id":"073f6895_434ba719","line":2176,"range":{"start_line":2175,"start_character":37,"end_line":2176,"end_character":44},"in_reply_to":"7c1bee01_f743cdcf","updated":"2022-12-22 13:44:34.000000000","message":"thanks fixed","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a04e78d4d70961c99c136ce58d5561989e68cb1","unresolved":true,"context_lines":[{"line_number":2201,"context_line":""},{"line_number":2202,"context_line":"        if cidr and uses_subnetpool:"},{"line_number":2203,"context_line":"            raise exc.OpenStackCloudException("},{"line_number":2204,"context_line":"                \u0027arg:cidr must be set to None when use_default_subnetpool \u003d\u003d \u0027"},{"line_number":2205,"context_line":"                \u0027True\u0027)"},{"line_number":2206,"context_line":""},{"line_number":2207,"context_line":"        # Be friendly on ip_version and allow strings"}],"source_content_type":"text/x-python","patch_set":2,"id":"f47fbf36_136b9045","line":2204,"updated":"2022-12-20 08:52:40.000000000","message":"This message also needs amending. Maybe\n\narg:cidr and subnetpool may not be used at the same time","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"b46dbce2400dde5b1cbfa12231217c162ef45e24","unresolved":false,"context_lines":[{"line_number":2201,"context_line":""},{"line_number":2202,"context_line":"        if cidr and uses_subnetpool:"},{"line_number":2203,"context_line":"            raise exc.OpenStackCloudException("},{"line_number":2204,"context_line":"                \u0027arg:cidr must be set to None when use_default_subnetpool \u003d\u003d \u0027"},{"line_number":2205,"context_line":"                \u0027True\u0027)"},{"line_number":2206,"context_line":""},{"line_number":2207,"context_line":"        # Be friendly on ip_version and allow strings"}],"source_content_type":"text/x-python","patch_set":2,"id":"f996c850_fc3744ca","line":2204,"in_reply_to":"f47fbf36_136b9045","updated":"2022-12-22 13:44:34.000000000","message":"thanks fixed","commit_id":"13317870d9132064988b376060e4f139ff86c173"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"42ad96ceb792fa02d972bedf82cd1d2ce04ac067","unresolved":true,"context_lines":[{"line_number":2175,"context_line":"            ``ip_version`` to obtain a CIDR. Only one of ``cidr``,"},{"line_number":2176,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2177,"context_line":"            at the same time."},{"line_number":2178,"context_line":"        :param string subnetpool_id: Use this subnetpool to obtain a CIDR."},{"line_number":2179,"context_line":"            Only one of ``cidr``, ``use_default_subnetpool`` and"},{"line_number":2180,"context_line":"            ``subnetpool_id`` may be specified at the same time."},{"line_number":2181,"context_line":"        :param kwargs: Key value pairs to be passed to the Neutron API."}],"source_content_type":"text/x-python","patch_set":3,"id":"749b7b47_264ac2a8","line":2178,"updated":"2022-12-29 10:15:14.000000000","message":"Sorry for coming up with yet another idea, but should we make this \"subnetpool_name_or_id\" similar to how we treat the network? Seems to be much more user friendly to be able to specify the pool by name, too.","commit_id":"f269a22ee669e052c66d314b5520d30ca83038a2"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"7c974e75f5d383ef9450f98dd2b85e7d56b6671c","unresolved":true,"context_lines":[{"line_number":2175,"context_line":"            ``ip_version`` to obtain a CIDR. Only one of ``cidr``,"},{"line_number":2176,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2177,"context_line":"            at the same time."},{"line_number":2178,"context_line":"        :param string subnetpool_id: Use this subnetpool to obtain a CIDR."},{"line_number":2179,"context_line":"            Only one of ``cidr``, ``use_default_subnetpool`` and"},{"line_number":2180,"context_line":"            ``subnetpool_id`` may be specified at the same time."},{"line_number":2181,"context_line":"        :param kwargs: Key value pairs to be passed to the Neutron API."}],"source_content_type":"text/x-python","patch_set":3,"id":"b55458a9_be86b294","line":2178,"in_reply_to":"749b7b47_264ac2a8","updated":"2023-01-02 10:47:41.000000000","message":"sounds good, fixed","commit_id":"f269a22ee669e052c66d314b5520d30ca83038a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"541e3d6825931736fc1b399a56db2f27a22f57a9","unresolved":false,"context_lines":[{"line_number":2175,"context_line":"            ``ip_version`` to obtain a CIDR. Only one of ``cidr``,"},{"line_number":2176,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2177,"context_line":"            at the same time."},{"line_number":2178,"context_line":"        :param string subnetpool_id: Use this subnetpool to obtain a CIDR."},{"line_number":2179,"context_line":"            Only one of ``cidr``, ``use_default_subnetpool`` and"},{"line_number":2180,"context_line":"            ``subnetpool_id`` may be specified at the same time."},{"line_number":2181,"context_line":"        :param kwargs: Key value pairs to be passed to the Neutron API."}],"source_content_type":"text/x-python","patch_set":3,"id":"3e498a10_419f1d88","line":2178,"in_reply_to":"b55458a9_be86b294","updated":"2023-01-04 12:13:00.000000000","message":"Done","commit_id":"f269a22ee669e052c66d314b5520d30ca83038a2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b14dd538da503e329330e9bf73f229f43b79bf6","unresolved":true,"context_lines":[{"line_number":467,"context_line":"        \"\"\""},{"line_number":468,"context_line":"        return self.network.find_subnet_pool("},{"line_number":469,"context_line":"            name_or_id\u003dname_or_id,"},{"line_number":470,"context_line":"            ignore_missing\u003dTrue)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def create_network("},{"line_number":473,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8951a752_68d216b6","line":470,"updated":"2023-01-04 16:47:41.000000000","message":"I\u0027m not sure whether having a dedicated function that only wraps another function call is worth the effort.\n\nAlso I don\u0027t think we want ignore_missing\u003dTrue, or is there a reason that we need to create our own exception here?","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"a559b16a1e21eeceb454590678acc29e520b6673","unresolved":true,"context_lines":[{"line_number":467,"context_line":"        \"\"\""},{"line_number":468,"context_line":"        return self.network.find_subnet_pool("},{"line_number":469,"context_line":"            name_or_id\u003dname_or_id,"},{"line_number":470,"context_line":"            ignore_missing\u003dTrue)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def create_network("},{"line_number":473,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b6bcb11f_abfd46fe","line":470,"in_reply_to":"8951a752_68d216b6","updated":"2023-01-05 08:12:14.000000000","message":"my idea was to keep it consistent with the `get_network` and `get_subnet` method so that getting a subnetpool works in the same way","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a6a23aa36aef2c4528057c6f546d23a3c834861","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        \"\"\""},{"line_number":468,"context_line":"        return self.network.find_subnet_pool("},{"line_number":469,"context_line":"            name_or_id\u003dname_or_id,"},{"line_number":470,"context_line":"            ignore_missing\u003dTrue)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def create_network("},{"line_number":473,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b110e352_39d5c6cf","line":470,"in_reply_to":"b6bcb11f_abfd46fe","updated":"2023-08-29 13:45:33.000000000","message":"Yeah, let\u0027s tackle this in an all or nothing manner.","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b14dd538da503e329330e9bf73f229f43b79bf6","unresolved":true,"context_lines":[{"line_number":2132,"context_line":"        :param string network_name_or_id: The unique name or ID of the attached"},{"line_number":2133,"context_line":"            network. If a non-unique name is supplied, an exception is raised."},{"line_number":2134,"context_line":"        :param string cidr: The CIDR.  Only one of ``cidr``,"},{"line_number":2135,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2136,"context_line":"            at the same time."},{"line_number":2137,"context_line":"        :param int ip_version: The IP version, which is 4 or 6."},{"line_number":2138,"context_line":"        :param bool enable_dhcp: Set to ``True`` if DHCP is enabled and"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2b78f97_8dd6599d","line":2135,"range":{"start_line":2135,"start_character":45,"end_line":2135,"end_character":58},"updated":"2023-01-04 16:47:41.000000000","message":"Nit: Update the name here","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"a559b16a1e21eeceb454590678acc29e520b6673","unresolved":true,"context_lines":[{"line_number":2132,"context_line":"        :param string network_name_or_id: The unique name or ID of the attached"},{"line_number":2133,"context_line":"            network. If a non-unique name is supplied, an exception is raised."},{"line_number":2134,"context_line":"        :param string cidr: The CIDR.  Only one of ``cidr``,"},{"line_number":2135,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2136,"context_line":"            at the same time."},{"line_number":2137,"context_line":"        :param int ip_version: The IP version, which is 4 or 6."},{"line_number":2138,"context_line":"        :param bool enable_dhcp: Set to ``True`` if DHCP is enabled and"}],"source_content_type":"text/x-python","patch_set":4,"id":"eca630f8_8a08bd27","line":2135,"range":{"start_line":2135,"start_character":45,"end_line":2135,"end_character":58},"in_reply_to":"e2b78f97_8dd6599d","updated":"2023-01-05 08:12:14.000000000","message":"fixed","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f23aa60bd8904f9c1695a43fd1cf82f91f7543b1","unresolved":false,"context_lines":[{"line_number":2132,"context_line":"        :param string network_name_or_id: The unique name or ID of the attached"},{"line_number":2133,"context_line":"            network. If a non-unique name is supplied, an exception is raised."},{"line_number":2134,"context_line":"        :param string cidr: The CIDR.  Only one of ``cidr``,"},{"line_number":2135,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2136,"context_line":"            at the same time."},{"line_number":2137,"context_line":"        :param int ip_version: The IP version, which is 4 or 6."},{"line_number":2138,"context_line":"        :param bool enable_dhcp: Set to ``True`` if DHCP is enabled and"}],"source_content_type":"text/x-python","patch_set":4,"id":"33924693_b903b546","line":2135,"range":{"start_line":2135,"start_character":45,"end_line":2135,"end_character":58},"in_reply_to":"eca630f8_8a08bd27","updated":"2023-09-05 10:34:27.000000000","message":"Done","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b14dd538da503e329330e9bf73f229f43b79bf6","unresolved":true,"context_lines":[{"line_number":2184,"context_line":"            from a subnetpool."},{"line_number":2185,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2186,"context_line":"            ``ip_version`` to obtain a CIDR. Only one of ``cidr``,"},{"line_number":2187,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2188,"context_line":"            at the same time."},{"line_number":2189,"context_line":"        :param string subnetpool_name_or_id: The unique name or id of the"},{"line_number":2190,"context_line":"            subnetpool to obtain a CIDR from. Only one of ``cidr``,"}],"source_content_type":"text/x-python","patch_set":4,"id":"21a536fe_de4c19c1","line":2187,"range":{"start_line":2187,"start_character":45,"end_line":2187,"end_character":58},"updated":"2023-01-04 16:47:41.000000000","message":"and here","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f23aa60bd8904f9c1695a43fd1cf82f91f7543b1","unresolved":false,"context_lines":[{"line_number":2184,"context_line":"            from a subnetpool."},{"line_number":2185,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2186,"context_line":"            ``ip_version`` to obtain a CIDR. Only one of ``cidr``,"},{"line_number":2187,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2188,"context_line":"            at the same time."},{"line_number":2189,"context_line":"        :param string subnetpool_name_or_id: The unique name or id of the"},{"line_number":2190,"context_line":"            subnetpool to obtain a CIDR from. Only one of ``cidr``,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0d9bc398_f01f7eaa","line":2187,"range":{"start_line":2187,"start_character":45,"end_line":2187,"end_character":58},"in_reply_to":"0ba26e7b_3a04608c","updated":"2023-09-05 10:34:27.000000000","message":"Done","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"a559b16a1e21eeceb454590678acc29e520b6673","unresolved":true,"context_lines":[{"line_number":2184,"context_line":"            from a subnetpool."},{"line_number":2185,"context_line":"        :param bool use_default_subnetpool: Use the default subnetpool for"},{"line_number":2186,"context_line":"            ``ip_version`` to obtain a CIDR. Only one of ``cidr``,"},{"line_number":2187,"context_line":"            ``use_default_subnetpool`` and ``subnetpool_id`` may be specified"},{"line_number":2188,"context_line":"            at the same time."},{"line_number":2189,"context_line":"        :param string subnetpool_name_or_id: The unique name or id of the"},{"line_number":2190,"context_line":"            subnetpool to obtain a CIDR from. Only one of ``cidr``,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ba26e7b_3a04608c","line":2187,"range":{"start_line":2187,"start_character":45,"end_line":2187,"end_character":58},"in_reply_to":"21a536fe_de4c19c1","updated":"2023-01-05 08:12:14.000000000","message":"fixed","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b14dd538da503e329330e9bf73f229f43b79bf6","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"            subnetpool \u003d self.get_subnetpool(subnetpool_name_or_id)"},{"line_number":2229,"context_line":"            if not subnetpool:"},{"line_number":2230,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":2231,"context_line":"                    \"Subnetpool %s not found.\" % subnetpool_name_or_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"        # Be friendly on ip_version and allow strings"},{"line_number":2234,"context_line":"        if isinstance(ip_version, str):"}],"source_content_type":"text/x-python","patch_set":4,"id":"b0c57a46_46ac373c","line":2231,"updated":"2023-01-04 16:47:41.000000000","message":"See above, if we don\u0027t set ignore_missing, we don\u0027t need to handle this case here.","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"a559b16a1e21eeceb454590678acc29e520b6673","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"            subnetpool \u003d self.get_subnetpool(subnetpool_name_or_id)"},{"line_number":2229,"context_line":"            if not subnetpool:"},{"line_number":2230,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":2231,"context_line":"                    \"Subnetpool %s not found.\" % subnetpool_name_or_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"        # Be friendly on ip_version and allow strings"},{"line_number":2234,"context_line":"        if isinstance(ip_version, str):"}],"source_content_type":"text/x-python","patch_set":4,"id":"babe04bb_6d4025c5","line":2231,"in_reply_to":"b0c57a46_46ac373c","updated":"2023-01-05 08:12:14.000000000","message":"as written above. I wanted to keep the behaviour of the method consistent","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a6a23aa36aef2c4528057c6f546d23a3c834861","unresolved":false,"context_lines":[{"line_number":2228,"context_line":"            subnetpool \u003d self.get_subnetpool(subnetpool_name_or_id)"},{"line_number":2229,"context_line":"            if not subnetpool:"},{"line_number":2230,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":2231,"context_line":"                    \"Subnetpool %s not found.\" % subnetpool_name_or_id)"},{"line_number":2232,"context_line":""},{"line_number":2233,"context_line":"        # Be friendly on ip_version and allow strings"},{"line_number":2234,"context_line":"        if isinstance(ip_version, str):"}],"source_content_type":"text/x-python","patch_set":4,"id":"47270721_98adfa3f","line":2231,"in_reply_to":"babe04bb_6d4025c5","updated":"2023-08-29 13:45:33.000000000","message":"You\u0027d still need to catch and transform the exception from `ResourceNotFound` (which `resource.Resource.find` returns if it can\u0027t find something and `ignore_missing\u003dFalse`) to `OpenStackCloudException`","commit_id":"64933a782afb79b3d3eb55982b344cb8e0158682"}]}