)]}'
{"id":"openstack%2Fopenstacksdk~869201","triplet_id":"openstack%2Fopenstacksdk~stable%2Fyoga~Ibf4a16e544921ec914f6e23112e0fc37a12096a5","project":"openstack/openstacksdk","branch":"stable/yoga","topic":"tox4","hashtags":[],"change_id":"Ibf4a16e544921ec914f6e23112e0fc37a12096a5","subject":"Update tox.ini for tox v4 compatibility","status":"MERGED","created":"2023-01-04 12:18:02.000000000","updated":"2023-01-11 14:39:31.000000000","submitted":"2023-01-11 14:37:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"869201-tox4","meta_rev_id":"ebaecfa4ea0397827259ca0a48761370fa29b3c6","_number":869201,"virtual_id_number":869201,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-01-11 14:37:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2023-01-11 12:50:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2023-01-11 12:50:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-04 12:18:02.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"CC"},{"updated":"2023-01-04 12:20:12.000000000","updated_by":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"reviewer":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"state":"CC"},{"updated":"2023-01-04 13:50:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"13f89fac247af34a68a22c9d3962c6e86410529d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-01-04 12:18:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"10400c2ca23f8c51fe523c366e12248dd2bc2d5c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-04 13:50:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/de91bcf2055e40ba8b9ffaf45e0fc925\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1ab32dc456784d2a878625cbc4a2f6f2 : SUCCESS in 3m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/04816624022d4221b628c5fb6c4b4a70 : SUCCESS in 3m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f740233e99a548338ab73117b36a52ba : SUCCESS in 3m 39s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/467f6f88991348ce95eec3aeb27b10ef : SUCCESS in 45m 25s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/9417cc29937d4ced8b9d5718e34dbcf4 : SUCCESS in 4m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0ee043a9fc6241f9b1ea5b1c6d4cb338 : SUCCESS in 7m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f6b909b634d14e2ea9f61b42f1bdfea4 : SUCCESS in 3m 20s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/60e78d35b21e4a48a8e130f8c4e24040 : SUCCESS in 19m 32s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/ca50e0468ca049fba6ee6f586014c7e7 : SUCCESS in 12m 32s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c5ae6dd2bcd94da59e2dad2ab05801e2 : SUCCESS in 44m 03s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/676b585312174e2c9211463443b645a1 : SUCCESS in 1h 25m 26s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/1b6d28bc22ba4cdf9f6cc285ff79e5c9 : SUCCESS in 54m 12s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/20cd3b9af57b4b3e8441203f9d0c33e5 : FAILURE in 50m 09s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/6ef2988ce1184c5f8898de30aedd64f7 : SUCCESS in 39m 03s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/13a0f2fabba9488d9521806d862c81bc : FAILURE in 39m 29s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/337bb566454642f685dd46432c9c21cd : SUCCESS in 1h 06m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"24e8f60e4589dc4da8de1c338e24ca5d663cc0a0","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-01-11 12:50:15.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4cc6c90532bab368ed1b3591f9676f1477901893","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-11 12:51:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"973ed536a7703b7cedf894c1c5f57fb7da7632d6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-11 14:37:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/67af6e5551674309961f9460064106e8\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd9c5ed655f84c60a6dcd4db10849995 : SUCCESS in 3m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/becc4d6e9f0d48b1a515670979801492 : SUCCESS in 6m 15s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d8876b5e92934335ada64a3300501c38 : SUCCESS in 4m 06s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/4ae839dc1fac4024a415d4d12b66cd49 : SUCCESS in 35m 58s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/43e8dc62936e4a7ab9df2d97e85fd86c : SUCCESS in 5m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/55cff380a460450bb5829c83c7aa71b2 : SUCCESS in 6m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/fd9438230be84ba5b15e2422f5c5693d : SUCCESS in 4m 40s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/92528c3564bd416c9cbb4a9825e63e5a : SUCCESS in 18m 21s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/8b740d8123184c1c95e5b4d18a5674b9 : SUCCESS in 14m 00s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c8456ec033d0438b8d69882ca31b07e2 : SUCCESS in 58m 45s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/df30af68e8f14a1a83dab662e5cd8a4c : SUCCESS in 1h 41m 38s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/a84955afa75f42bb877500b27c27a867 : SUCCESS in 49m 34s","accounts_in_message":[],"_revision_number":1},{"id":"769797b8e183b3cbb2af5e05a168fc71a5174c05","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-11 14:37:56.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"ebaecfa4ea0397827259ca0a48761370fa29b3c6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-11 14:39:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8092c5d3394e4d978eaf386cf4afdb3c\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa2e793c51e4458fb73ae1ae4351869e : SUCCESS in 50s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/60b6bd49d7f94cdba40e674b65ba937d : SUCCESS in 39s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f41a20395b989de9a250ea292b0f0441c1d9657d","revisions":{"f41a20395b989de9a250ea292b0f0441c1d9657d":{"kind":"REWORK","_number":1,"created":"2023-01-04 12:18:02.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/01/869201/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/01/869201/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/01/869201/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/01/869201/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/01/869201/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/01/869201/1"}}},"commit":{"parents":[{"commit":"fd300de63f5a7a9c7760d69a2d7ce248e058bd61","subject":"Update TOX_CONSTRAINTS_FILE for stable/yoga","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/fd300de63f5a7a9c7760d69a2d7ce248e058bd61"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2022-12-15 16:53:07.000000000","tz":-480},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-01-04 12:17:52.000000000","tz":0},"subject":"Update tox.ini for tox v4 compatibility","message":"Update tox.ini for tox v4 compatibility\n\nTox v4 made a number of changes that break compatibility with old tox v3\ntox.ini files. In particular openstacksdk lists env vars for passenv on\na single line separating them with spaces. This is no longer allowed and\nproduces this error:\n\n  failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found \u0027OS_* OPENSTACKSDK_*\u0027\n\nWe can fix this by listing each value on a single line which we do here.\n\nNOTE(stephenfin): Modified to include change\nIce5ef168891fe35c4447468dd0d7956ef04db090 which fixes some nits with the\noriginal change.\n\nDepends-On: https://review.opendev.org/c/openstack/python-openstackclient/+/868430\nChange-Id: Ibf4a16e544921ec914f6e23112e0fc37a12096a5\n(cherry picked from commit a0f969cf92691c4c8beeeedd69d9884923a92c0e)\n(cherry picked from commit 5d395a3136d31406b5f82b52c71cab900a784a13)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f41a20395b989de9a250ea292b0f0441c1d9657d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f41a20395b989de9a250ea292b0f0441c1d9657d"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[]}