)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6eea73757b8fe90ec0bca13d9bdc20ec50c253a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe3ff23a_3c795562","updated":"2023-01-30 11:09:42.000000000","message":"This change will break existing users, as now workflow is changed (not sure that we can use docs as source of truth in this case)","commit_id":"715ab5bb31143d5612ad9ab034dd0f85e92101c0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"7e3979e3f50e52445755eabae40d0591246ba2b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"862ac53b_b1299a49","updated":"2023-01-30 11:18:23.000000000","message":"This is not going to break users, since making this step is a bug contradicting the documentation. Everybody who wanted to use Prom needed to explicitly pass registry. We can make an explicit note in the releasenotes for that.\nI have actually even a feeling that the behavior could have changed in some prometheus_client release.","commit_id":"715ab5bb31143d5612ad9ab034dd0f85e92101c0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e4bafaf19ea7f6166b5d707979e2c5feab59bef5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45255d82_ff306bd2","in_reply_to":"862ac53b_b1299a49","updated":"2023-01-30 11:43:02.000000000","message":"This is a bug in documentation if you think that code is your source of truth. I\u0027m not sure what is worse to break users who did development by relying on the code, or change behaviour according to docs. This fix doesn\u0027t look like a big change so maybe we can avoid breaking existing behaviour? Alternative variant of implementation https://review.opendev.org/c/openstack/openstacksdk/+/872067","commit_id":"715ab5bb31143d5612ad9ab034dd0f85e92101c0"}],"openstack/config/cloud_region.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a3fd05cd0af284b179b25e1ab1bcd4e010d60c65","unresolved":true,"context_lines":[{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def get_prometheus_histogram(self):"},{"line_number":1066,"context_line":"        registry \u003d self.get_prometheus_registry()"},{"line_number":1067,"context_line":"        if not registry or not prometheus_client:"},{"line_number":1068,"context_line":"            return"},{"line_number":1069,"context_line":"        # We have to hide a reference to the histogram on the registry"},{"line_number":1070,"context_line":"        # object, because it\u0027s collectors must be singletons for a given"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc17fbcf_82517939","side":"PARENT","line":1067,"range":{"start_line":1067,"start_character":31,"end_line":1067,"end_character":48},"updated":"2023-01-30 12:49:07.000000000","message":"if we are going with this approach the import checks looks redundant please drop them.","commit_id":"e84deaa56a6869a3c884aa94131168d812d530dd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"423cfb1352536860a6b186560a03d8c4c1afe0f4","unresolved":true,"context_lines":[{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def get_prometheus_histogram(self):"},{"line_number":1066,"context_line":"        registry \u003d self.get_prometheus_registry()"},{"line_number":1067,"context_line":"        if not registry or not prometheus_client:"},{"line_number":1068,"context_line":"            return"},{"line_number":1069,"context_line":"        # We have to hide a reference to the histogram on the registry"},{"line_number":1070,"context_line":"        # object, because it\u0027s collectors must be singletons for a given"}],"source_content_type":"text/x-python","patch_set":2,"id":"d147e1dd_b24087d0","side":"PARENT","line":1067,"range":{"start_line":1067,"start_character":31,"end_line":1067,"end_character":48},"in_reply_to":"bc17fbcf_82517939","updated":"2023-01-30 13:39:07.000000000","message":"no, this check is absolutely not redundant. Please check the following code. Every metrics library on our side is imported in the way that it doesn\u0027t break openstacksdk from working if required client lib is not available. This is the design choice.","commit_id":"e84deaa56a6869a3c884aa94131168d812d530dd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a99ded65f6d8b367e8db61a6b092c8fd53ada7ad","unresolved":true,"context_lines":[{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def get_prometheus_histogram(self):"},{"line_number":1066,"context_line":"        registry \u003d self.get_prometheus_registry()"},{"line_number":1067,"context_line":"        if not registry or not prometheus_client:"},{"line_number":1068,"context_line":"            return"},{"line_number":1069,"context_line":"        # We have to hide a reference to the histogram on the registry"},{"line_number":1070,"context_line":"        # object, because it\u0027s collectors must be singletons for a given"}],"source_content_type":"text/x-python","patch_set":2,"id":"61b71b96_18558b43","side":"PARENT","line":1067,"range":{"start_line":1067,"start_character":31,"end_line":1067,"end_character":48},"in_reply_to":"d147e1dd_b24087d0","updated":"2023-04-13 15:06:33.000000000","message":"It\u0027s not clear cut. With this change, we won\u0027t ever auto-instantiate \u0027_collector_registry\u0027 and the user will have to pass \u0027collector_registry\u0027 to the constructor when creating this. However, we don\u0027t enforce that \u0027collector_registry\u0027 is an object generated by \u0027prometheus_client\u0027, so we can\u0027t _really_ be sure that this library exists.\n\nPerhaps we should remove this change and hard fail if the library doesn\u0027t exist since that implies either (a) an broken environment or (more likely) (b) that the user provided nonsense input for the \u0027collector_registry\u0027 argument?","commit_id":"e84deaa56a6869a3c884aa94131168d812d530dd"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"105c8e66cca388aa98d28845ffaab35c1ca0a22a","unresolved":true,"context_lines":[{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def get_prometheus_histogram(self):"},{"line_number":1066,"context_line":"        registry \u003d self.get_prometheus_registry()"},{"line_number":1067,"context_line":"        if not registry or not prometheus_client:"},{"line_number":1068,"context_line":"            return"},{"line_number":1069,"context_line":"        # We have to hide a reference to the histogram on the registry"},{"line_number":1070,"context_line":"        # object, because it\u0027s collectors must be singletons for a given"}],"source_content_type":"text/x-python","patch_set":2,"id":"7d6429ac_8db2afcd","side":"PARENT","line":1067,"range":{"start_line":1067,"start_character":31,"end_line":1067,"end_character":48},"in_reply_to":"d147e1dd_b24087d0","updated":"2023-01-30 17:42:02.000000000","message":"we can simplify here with `if not registry`\n\nwe don\u0027t need `or not prometheus_client` as when user is passing collector explicitly the prometheus client is installed.","commit_id":"e84deaa56a6869a3c884aa94131168d812d530dd"}]}