)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3e653cf0904bcf02ff9476d1c790bd8a3059e43a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"support notification vmoves for masakari"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Masakari provides a new \u0027VMove\u0027 api, which could help users to insight"},{"line_number":10,"context_line":"the process or result of the host recovery workflow."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3da3024a8f34563bf0bff3924ce6ad8ac18a3018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a05f2f61_32323849","line":9,"range":{"start_line":9,"start_character":63,"end_line":9,"end_character":70},"updated":"2023-01-30 08:31:13.000000000","message":"gain insight into","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d69b7a491f9c1a7543b5f48dc495606531153ea4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"support notification vmoves for masakari"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Masakari provides a new \u0027VMove\u0027 api, which could help users to insight"},{"line_number":10,"context_line":"the process or result of the host recovery workflow."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3da3024a8f34563bf0bff3924ce6ad8ac18a3018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"eeb64bd7_5ed1faa5","line":9,"range":{"start_line":9,"start_character":63,"end_line":9,"end_character":70},"in_reply_to":"a05f2f61_32323849","updated":"2023-01-30 10:40:53.000000000","message":"Done","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d69b7a491f9c1a7543b5f48dc495606531153ea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cffbbb2e_f92c04c9","updated":"2023-01-30 10:40:53.000000000","message":"LGTM","commit_id":"205766a3bb8d70908f74a45a1b6edfa204e2d53f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee611aa51bbbe788f1b3e3bb6cc5dadbeeabf746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"78f31fe6_7e80b8ea","updated":"2023-01-31 09:23:36.000000000","message":"Some small nits. Looks pretty good though","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"129d83e16fac5fd8b75d3790affe305bda89d3a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"922f2b9c_1550d94f","updated":"2023-01-31 10:45:58.000000000","message":"(just fixed the unit test in the meantime)","commit_id":"3cbc4b36282982896658195d518f44e375881ceb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1053a20d21031e8f7487545c5ae8d4866794e465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de512e28_00edbc6f","updated":"2023-01-31 10:46:14.000000000","message":"@Sue, please check Stephen\u0027s comments","commit_id":"3cbc4b36282982896658195d518f44e375881ceb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9e58226b74fec726c5ebee13d66fa4dd38cda9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fc3205bd_53d6941f","updated":"2023-02-10 14:44:28.000000000","message":"May we get this in? 😊","commit_id":"c66323299efbc8001784c55c11dd5e313724c183"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cb6603f1e93629ca1ba69ccbbc30380154bbf5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"06a4afeb_9b4ab68c","updated":"2023-04-21 16:32:48.000000000","message":"If someone can fix the two nits here, I\u0027ll happily approve this","commit_id":"c7eeeb6e572cc927d568b69cf98e58976827f8f8"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"bd02d6f192c98dd38d1ccc79393c9571c6e96a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2d4fb39b_88705f07","updated":"2023-05-29 06:49:17.000000000","message":"recheck","commit_id":"e240fc8582a30b32e00578e66061ad8ba585a2c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d9fe59f08943553efd61d793066f96b5da2ad43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a38cd87c_a1e8e28b","updated":"2023-05-29 09:56:35.000000000","message":"I think there\u0027s more we can do to improve this but at least it\u0027s locally consistent.\n\nI fixed the style issues.","commit_id":"e05b82cb38a2a1c4ace3f759033c2e1f6e7e7dfa"}],"openstack/instance_ha/v1/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee611aa51bbbe788f1b3e3bb6cc5dadbeeabf746","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param notification_id: The ID of a notification."},{"line_number":232,"context_line":"        :param vmove: The value can be the ID of a vmove or a :class:"},{"line_number":233,"context_line":"            `~masakariclient.sdk.ha.v1.vmove.VMove` instance."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :returns: One :class:`~masakariclient.sdk.ha.v1.vmove.VMove`"},{"line_number":236,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":4,"id":"c2c8e03e_6d979961","line":233,"updated":"2023-01-31 09:23:36.000000000","message":"nit: these are backwards","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cb6603f1e93629ca1ba69ccbbc30380154bbf5d","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param notification_id: The ID of a notification."},{"line_number":232,"context_line":"        :param vmove: The value can be the ID of a vmove or a :class:"},{"line_number":233,"context_line":"            `~masakariclient.sdk.ha.v1.vmove.VMove` instance."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :returns: One :class:`~masakariclient.sdk.ha.v1.vmove.VMove`"},{"line_number":236,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":4,"id":"bbbdffd7_f59170b0","line":233,"in_reply_to":"5054bb91_a0958c01","updated":"2023-04-21 16:32:48.000000000","message":"Nope. New comment","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4632c1eb93a52916de04268c50422d9d582d9956","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param notification_id: The ID of a notification."},{"line_number":232,"context_line":"        :param vmove: The value can be the ID of a vmove or a :class:"},{"line_number":233,"context_line":"            `~masakariclient.sdk.ha.v1.vmove.VMove` instance."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :returns: One :class:`~masakariclient.sdk.ha.v1.vmove.VMove`"},{"line_number":236,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":4,"id":"5054bb91_a0958c01","line":233,"in_reply_to":"c2c8e03e_6d979961","updated":"2023-02-01 09:29:00.000000000","message":"Was this redone properly?","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cb6603f1e93629ca1ba69ccbbc30380154bbf5d","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param notification_id: The ID of a notification."},{"line_number":232,"context_line":"        :param vmove: The value can be the ID of one vmove or one"},{"line_number":233,"context_line":"            \u0027VMove\u0027 resource class."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :returns: one \u0027VMove\u0027 resource class."},{"line_number":236,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":8,"id":"490f5669_afac2e42","line":233,"updated":"2023-04-21 16:32:48.000000000","message":"These are still backwards 😞","commit_id":"c7eeeb6e572cc927d568b69cf98e58976827f8f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c3ae4a97e5833488e0f959a7ce2ad66b6455cb7d","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param notification_id: The ID of a notification."},{"line_number":232,"context_line":"        :param vmove: The value can be the ID of one vmove or one"},{"line_number":233,"context_line":"            \u0027VMove\u0027 resource class."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :returns: one \u0027VMove\u0027 resource class."},{"line_number":236,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":8,"id":"7325262c_3fbced28","line":233,"in_reply_to":"490f5669_afac2e42","updated":"2023-05-29 09:42:55.000000000","message":"Still not done, but recommenting on latest revision","commit_id":"c7eeeb6e572cc927d568b69cf98e58976827f8f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cb6603f1e93629ca1ba69ccbbc30380154bbf5d","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        if notification_id is None:"},{"line_number":242,"context_line":"            raise exceptions.InvalidRequest("},{"line_number":243,"context_line":"                \"\u0027notification_id\u0027 must be specified.\")"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        vmove_id \u003d resource.Resource._get_id(vmove)"},{"line_number":246,"context_line":"        return self._get(_vmove.VMove, vmove_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"c52e9c1d_db8662ef","line":243,"updated":"2023-04-21 16:32:48.000000000","message":"Why not just make notification_id a required parameter (i.e. drop `\u003dNone`)?","commit_id":"c7eeeb6e572cc927d568b69cf98e58976827f8f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c3ae4a97e5833488e0f959a7ce2ad66b6455cb7d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        if notification_id is None:"},{"line_number":242,"context_line":"            raise exceptions.InvalidRequest("},{"line_number":243,"context_line":"                \"\u0027notification_id\u0027 must be specified.\")"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        vmove_id \u003d resource.Resource._get_id(vmove)"},{"line_number":246,"context_line":"        return self._get(_vmove.VMove, vmove_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7156f747_6799f605","line":243,"in_reply_to":"c52e9c1d_db8662ef","updated":"2023-05-29 09:42:55.000000000","message":"Done","commit_id":"c7eeeb6e572cc927d568b69cf98e58976827f8f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c3ae4a97e5833488e0f959a7ce2ad66b6455cb7d","unresolved":true,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :param notification_id: The ID of a notification."},{"line_number":236,"context_line":"        :param vmove: The value can be the ID of one vmove or a"},{"line_number":237,"context_line":"            class `~masakariclient.sdk.ha.v1.vmove.VMove` instance."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        :returns: one \u0027VMove\u0027 resource class."},{"line_number":240,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":11,"id":"e57ac42d_51bf98bb","line":237,"updated":"2023-05-29 09:42:55.000000000","message":"These are still backwards:\n\n```\n:param vmove: ...\n:param notification_id: ...\n```","commit_id":"113eced2e3bba9ecc48ebc0b3a3074aa61d6e3af"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7793f0fe9ec61bfc3bbaf4b67605eadecb2c56","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :param notification_id: The ID of a notification."},{"line_number":236,"context_line":"        :param vmove: The value can be the ID of one vmove or a"},{"line_number":237,"context_line":"            class `~masakariclient.sdk.ha.v1.vmove.VMove` instance."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        :returns: one \u0027VMove\u0027 resource class."},{"line_number":240,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":11,"id":"d537bda9_d8da4b15","line":237,"in_reply_to":"e57ac42d_51bf98bb","updated":"2023-05-29 09:51:13.000000000","message":"Done","commit_id":"113eced2e3bba9ecc48ebc0b3a3074aa61d6e3af"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d9fe59f08943553efd61d793066f96b5da2ad43","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            **query,"},{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_vmove(self, vmove, notification_id):"},{"line_number":238,"context_line":"        \"\"\"Get a single vmove."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        :param vmove: The value can be the ID of one vmove or a"}],"source_content_type":"text/x-python","patch_set":12,"id":"34f7265d_e62309fc","line":237,"updated":"2023-05-29 09:56:35.000000000","message":"Typically we do these backwards, so that the they\u0027re in path order, i.e. the path is `GET /v1/notifications/{notification_id}/vmoves/{vmove_id}` so we do `notification_id`, `vmove_id`. However, I note that the rest of this file is done the other way around so we probably want to stay locally consistent 😞\n\nIt probably would be better to rename `notification_id` to `notification` and allow users to pass a `Notification` object though, but again we should really fix the rest of these arguments if we do that (so `segment_id` -\u003e `segment`","commit_id":"e05b82cb38a2a1c4ace3f759033c2e1f6e7e7dfa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"16e7a2630cb58b6ee8037b0a23fdbcc362bf97ba","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            **query,"},{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_vmove(self, vmove, notification_id):"},{"line_number":238,"context_line":"        \"\"\"Get a single vmove."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        :param vmove: The value can be the ID of one vmove or a"}],"source_content_type":"text/x-python","patch_set":12,"id":"a4d36736_eb8757b5","line":237,"in_reply_to":"08631bda_2e3315f5","updated":"2023-07-18 09:44:41.000000000","message":"If this is the case, doesn\u0027t that mean `get_notification` and possibly others are wrong? If I call `get_notification` with a `Notification` resource, what will happen?\n\nIt sounds like we need to add a `_get_uuid` helper to `Resource`, which you can use instead of `_get_id`?","commit_id":"e05b82cb38a2a1c4ace3f759033c2e1f6e7e7dfa"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"d0f70efdfc2a583e0005984bee2418f31f22ea68","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            **query,"},{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_vmove(self, vmove, notification_id):"},{"line_number":238,"context_line":"        \"\"\"Get a single vmove."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        :param vmove: The value can be the ID of one vmove or a"}],"source_content_type":"text/x-python","patch_set":12,"id":"efa55628_b6179562","line":237,"in_reply_to":"34f7265d_e62309fc","updated":"2023-07-17 07:07:10.000000000","message":"In Masakari, it uses \u0027notification_id\u0027 instead of \u0027notification\u0027 in the api path. If allowing users to pass a \u0027notification\u0027 objects, we need to optimize the api in new patches.\nSame as \u0027segment_id\u0027.","commit_id":"e05b82cb38a2a1c4ace3f759033c2e1f6e7e7dfa"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"2fb3b79169b5e63cfa640d927a35f2814108722b","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            **query,"},{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_vmove(self, vmove, notification_id):"},{"line_number":238,"context_line":"        \"\"\"Get a single vmove."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        :param vmove: The value can be the ID of one vmove or a"}],"source_content_type":"text/x-python","patch_set":12,"id":"08631bda_2e3315f5","line":237,"in_reply_to":"569ff18c_7d7f62f4","updated":"2023-07-18 02:04:25.000000000","message":"In fact，the Masakari api only accepts UUID of the objects. If allow to accept resource object， ‘resource.Resource._get_id’ only get the id instead of uuid of the object. It doesn\u0027t works.\nI prefer not to use resource object as the input parameter.","commit_id":"e05b82cb38a2a1c4ace3f759033c2e1f6e7e7dfa"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"345089345f8abf3eb2573e794219a7866147d45d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            **query,"},{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_vmove(self, vmove, notification_id):"},{"line_number":238,"context_line":"        \"\"\"Get a single vmove."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        :param vmove: The value can be the ID of one vmove or a"}],"source_content_type":"text/x-python","patch_set":12,"id":"5d7c914e_53dce938","line":237,"in_reply_to":"a4d36736_eb8757b5","updated":"2023-07-24 12:11:17.000000000","message":"It needn\u0027t to add _get_uuid helper to Resource, because it is an URI parameter.","commit_id":"e05b82cb38a2a1c4ace3f759033c2e1f6e7e7dfa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bf6f0e565b390919bbe7c1480cefb1f777f5f298","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            **query,"},{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def get_vmove(self, vmove, notification_id):"},{"line_number":238,"context_line":"        \"\"\"Get a single vmove."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        :param vmove: The value can be the ID of one vmove or a"}],"source_content_type":"text/x-python","patch_set":12,"id":"569ff18c_7d7f62f4","line":237,"in_reply_to":"efa55628_b6179562","updated":"2023-07-17 10:15:15.000000000","message":"No, look at the API parameters you have: you have a `vmove` parameter which can be an ID or an object, but the API only accepts IDs. To allow this, you have a call to `resource.Resource._get_id`. You can do the same thing for a notification object:\n\n```\ndef get_vmove(self, vmove, notification):\n    # ...\n    notification_id \u003d resource.Resource._get_id(notification)\n    return self._get(\n        _vmove.VMove,\n        vmove_id,\n        notification_id\u003dnotification_id,\n    )\n```\n\nAssuming this makes sense, you should update the docstring and do the same for the `vmoves()` method.","commit_id":"e05b82cb38a2a1c4ace3f759033c2e1f6e7e7dfa"}],"openstack/instance_ha/v1/vmove.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3e653cf0904bcf02ff9476d1c790bd8a3059e43a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    message \u003d resource.Body(\"message\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":59,"context_line":"        \"sort_key\", \"sort_dir\", notification_uuid\u003d\"notification_uuid\","},{"line_number":60,"context_line":"        type\u003d\"type\", status\u003d\"status\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3dd6784_7207d25d","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":30},"updated":"2023-01-30 08:31:13.000000000","message":"do we support these keys in the API? I think not","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"6cd38d60d2e85571c8bf0753013032acb5da1f58","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    message \u003d resource.Body(\"message\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":59,"context_line":"        \"sort_key\", \"sort_dir\", notification_uuid\u003d\"notification_uuid\","},{"line_number":60,"context_line":"        type\u003d\"type\", status\u003d\"status\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"e87976ad_52c8cd18","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":30},"in_reply_to":"97437e1c_400ce152","updated":"2023-01-31 06:42:36.000000000","message":"It supports \u0027sort_key\u0027, \u0027sort_dir\u0027, \u0027limit\u0027 and \u0027marker\u0027 in the API.","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d69b7a491f9c1a7543b5f48dc495606531153ea4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    message \u003d resource.Body(\"message\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":59,"context_line":"        \"sort_key\", \"sort_dir\", notification_uuid\u003d\"notification_uuid\","},{"line_number":60,"context_line":"        type\u003d\"type\", status\u003d\"status\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"97437e1c_400ce152","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":30},"in_reply_to":"d3dd6784_7207d25d","updated":"2023-01-30 10:40:53.000000000","message":"Done","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6a81ea2b1809457e2b2e308440359b991116f95b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    message \u003d resource.Body(\"message\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":59,"context_line":"        \"sort_key\", \"sort_dir\", notification_uuid\u003d\"notification_uuid\","},{"line_number":60,"context_line":"        type\u003d\"type\", status\u003d\"status\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"56b7fe7e_c59c0707","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":30},"in_reply_to":"e87976ad_52c8cd18","updated":"2023-01-31 08:22:34.000000000","message":"Ok, let\u0027s restore the 2 wrongly removed ones.","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3e653cf0904bcf02ff9476d1c790bd8a3059e43a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    message \u003d resource.Body(\"message\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":59,"context_line":"        \"sort_key\", \"sort_dir\", notification_uuid\u003d\"notification_uuid\","},{"line_number":60,"context_line":"        type\u003d\"type\", status\u003d\"status\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"afae0877_2cb4f6cf","line":60,"range":{"start_line":59,"start_character":32,"end_line":60,"end_character":37},"updated":"2023-01-30 08:31:13.000000000","message":"these are the same on both sides so can be given using the string-only shortcuts (no remapping is needed); also notification_uuid is already in the path string, not in the query string","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d69b7a491f9c1a7543b5f48dc495606531153ea4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    message \u003d resource.Body(\"message\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":59,"context_line":"        \"sort_key\", \"sort_dir\", notification_uuid\u003d\"notification_uuid\","},{"line_number":60,"context_line":"        type\u003d\"type\", status\u003d\"status\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"299682b5_5fd14762","line":60,"range":{"start_line":59,"start_character":32,"end_line":60,"end_character":37},"in_reply_to":"afae0877_2cb4f6cf","updated":"2023-01-30 10:40:53.000000000","message":"Done","commit_id":"e8f5340cf86eab7aabacc7c9f82f5f6d37b109b8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee611aa51bbbe788f1b3e3bb6cc5dadbeeabf746","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    #: A UUID of representing this vmove"},{"line_number":32,"context_line":"    uuid \u003d resource.Body(\"uuid\")"},{"line_number":33,"context_line":"    #: The notification UUID this vmove belongs to"},{"line_number":34,"context_line":"    notification_uuid \u003d resource.Body(\"notification_uuid\")"},{"line_number":35,"context_line":"    #: A created time of this vmove"},{"line_number":36,"context_line":"    created_at \u003d resource.Body(\"created_at\")"},{"line_number":37,"context_line":"    #: A latest updated time of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c4a4abf_c6c161aa","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":21},"updated":"2023-01-31 09:23:36.000000000","message":"notification_id\n\nLater: ah, wait, this will probably conflict with notification_id Path parameter?","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"19347cc9cb2d3434ad348620333dc2bba0f74950","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    #: A UUID of representing this vmove"},{"line_number":32,"context_line":"    uuid \u003d resource.Body(\"uuid\")"},{"line_number":33,"context_line":"    #: The notification UUID this vmove belongs to"},{"line_number":34,"context_line":"    notification_uuid \u003d resource.Body(\"notification_uuid\")"},{"line_number":35,"context_line":"    #: A created time of this vmove"},{"line_number":36,"context_line":"    created_at \u003d resource.Body(\"created_at\")"},{"line_number":37,"context_line":"    #: A latest updated time of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b9476ca_19a3112c","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":21},"in_reply_to":"7c4a4abf_c6c161aa","updated":"2023-01-31 12:05:43.000000000","message":"In fact, they are the same value.","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee611aa51bbbe788f1b3e3bb6cc5dadbeeabf746","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    #: A latest updated time of this vmove"},{"line_number":38,"context_line":"    updated_at \u003d resource.Body(\"updated_at\")"},{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c4cc5e5_79e2078d","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":17},"updated":"2023-01-31 09:23:36.000000000","message":"server_id","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"19347cc9cb2d3434ad348620333dc2bba0f74950","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    #: A latest updated time of this vmove"},{"line_number":38,"context_line":"    updated_at \u003d resource.Body(\"updated_at\")"},{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d7d90ae_c724b1b2","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":17},"in_reply_to":"1c4cc5e5_79e2078d","updated":"2023-01-31 12:05:43.000000000","message":"It uses \"instance_uuid\" and \"instance_name\" in Masakari objects and database, and Masakariclient.\nI prefer to the same key, to be consistency.","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4632c1eb93a52916de04268c50422d9d582d9956","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    #: A latest updated time of this vmove"},{"line_number":38,"context_line":"    updated_at \u003d resource.Body(\"updated_at\")"},{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0a6677_b6fa3dd6","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":17},"in_reply_to":"57cf109d_1f2ef136","updated":"2023-02-01 09:29:00.000000000","message":"Done","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b269a6309067e2ef94ad1ec91f1e9974fb164545","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    #: A latest updated time of this vmove"},{"line_number":38,"context_line":"    updated_at \u003d resource.Body(\"updated_at\")"},{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"d2a0c1ca_014148c5","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":17},"in_reply_to":"7d7d90ae_c724b1b2","updated":"2023-01-31 15:18:14.000000000","message":"Unfortunately tis is an openstacksdk thing. We need to be consistent in openstacksdk, more so than masakari.","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"b076a91965c8986680ebc701ed86f38691d77d57","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    #: A latest updated time of this vmove"},{"line_number":38,"context_line":"    updated_at \u003d resource.Body(\"updated_at\")"},{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"57cf109d_1f2ef136","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":17},"in_reply_to":"d2a0c1ca_014148c5","updated":"2023-02-01 00:58:10.000000000","message":"I noticed it simultaneously uses \u0027instance_id\u0027, \u0027instance_uuid\u0027, and \u0027server_id\u0027 in openstacksdk. If it is just a new specification, I correct this patch.","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ee611aa51bbbe788f1b3e3bb6cc5dadbeeabf746","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"},{"line_number":44,"context_line":"    source_host \u003d resource.Body(\"source_host\")"},{"line_number":45,"context_line":"    #: The dest host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"a751582d_e7937b1c","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":17},"updated":"2023-01-31 09:23:36.000000000","message":"server_name","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b269a6309067e2ef94ad1ec91f1e9974fb164545","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"},{"line_number":44,"context_line":"    source_host \u003d resource.Body(\"source_host\")"},{"line_number":45,"context_line":"    #: The dest host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"d6b57643_48e35282","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":17},"in_reply_to":"7c7fb600_50e5e892","updated":"2023-01-31 15:18:14.000000000","message":"As above. openstacksdk talks about servers, not instances.","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"19347cc9cb2d3434ad348620333dc2bba0f74950","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"},{"line_number":44,"context_line":"    source_host \u003d resource.Body(\"source_host\")"},{"line_number":45,"context_line":"    #: The dest host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c7fb600_50e5e892","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":17},"in_reply_to":"a751582d_e7937b1c","updated":"2023-01-31 12:05:43.000000000","message":"ditto","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4632c1eb93a52916de04268c50422d9d582d9956","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    #: The instance uuid of this vmove"},{"line_number":40,"context_line":"    instance_uuid \u003d resource.Body(\"instance_uuid\")"},{"line_number":41,"context_line":"    #: The instance name of this vmove"},{"line_number":42,"context_line":"    instance_name \u003d resource.Body(\"instance_name\")"},{"line_number":43,"context_line":"    #: The source host of this vmove"},{"line_number":44,"context_line":"    source_host \u003d resource.Body(\"source_host\")"},{"line_number":45,"context_line":"    #: The dest host of this vmove"}],"source_content_type":"text/x-python","patch_set":4,"id":"962a9434_90447c27","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":17},"in_reply_to":"d6b57643_48e35282","updated":"2023-02-01 09:29:00.000000000","message":"Done","commit_id":"fac9be41cf75fcc48efbc97c279beeb7346dc33d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"16e7a2630cb58b6ee8037b0a23fdbcc362bf97ba","unresolved":true,"context_lines":[{"line_number":18,"context_line":"class VMove(resource.Resource):"},{"line_number":19,"context_line":"    resource_key \u003d \"vmove\""},{"line_number":20,"context_line":"    resources_key \u003d \"vmoves\""},{"line_number":21,"context_line":"    base_path \u003d \"/notifications/{notification_id}/vmoves\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # capabilities"},{"line_number":24,"context_line":"    # 1] GET /v1/notifications/{notification_id}/vmoves"}],"source_content_type":"text/x-python","patch_set":13,"id":"6714838a_733a6b1f","line":21,"range":{"start_line":21,"start_character":33,"end_line":21,"end_character":48},"updated":"2023-07-18 09:44:41.000000000","message":"This needs a corresponding `resource.URI` field. Is this an ID or a UUID?","commit_id":"8fd136c368090e3343f1c268802f60419653a0d6"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"345089345f8abf3eb2573e794219a7866147d45d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"class VMove(resource.Resource):"},{"line_number":19,"context_line":"    resource_key \u003d \"vmove\""},{"line_number":20,"context_line":"    resources_key \u003d \"vmoves\""},{"line_number":21,"context_line":"    base_path \u003d \"/notifications/{notification_id}/vmoves\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # capabilities"},{"line_number":24,"context_line":"    # 1] GET /v1/notifications/{notification_id}/vmoves"}],"source_content_type":"text/x-python","patch_set":13,"id":"d5caeca8_2cb4ba7e","line":21,"range":{"start_line":21,"start_character":33,"end_line":21,"end_character":48},"in_reply_to":"6714838a_733a6b1f","updated":"2023-07-24 12:11:17.000000000","message":"It is a notification uuid in the URI.","commit_id":"8fd136c368090e3343f1c268802f60419653a0d6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"16e7a2630cb58b6ee8037b0a23fdbcc362bf97ba","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    )"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: A ID of representing this vmove"},{"line_number":37,"context_line":"    id \u003d resource.Body(\"id\")"},{"line_number":38,"context_line":"    #: A UUID of representing this vmove"},{"line_number":39,"context_line":"    uuid \u003d resource.Body(\"uuid\")"},{"line_number":40,"context_line":"    #: The notification UUID this vmove belongs to"}],"source_content_type":"text/x-python","patch_set":13,"id":"079dc217_ec8e1c57","line":37,"updated":"2023-07-18 09:44:41.000000000","message":"Out of curiosity, if this field isn\u0027t useful then why is it exposed?","commit_id":"8fd136c368090e3343f1c268802f60419653a0d6"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"345089345f8abf3eb2573e794219a7866147d45d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    )"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: A ID of representing this vmove"},{"line_number":37,"context_line":"    id \u003d resource.Body(\"id\")"},{"line_number":38,"context_line":"    #: A UUID of representing this vmove"},{"line_number":39,"context_line":"    uuid \u003d resource.Body(\"uuid\")"},{"line_number":40,"context_line":"    #: The notification UUID this vmove belongs to"}],"source_content_type":"text/x-python","patch_set":13,"id":"67dd3c03_74ceddf1","line":37,"in_reply_to":"079dc217_ec8e1c57","updated":"2023-07-24 12:11:17.000000000","message":"It is an URI parameter.","commit_id":"8fd136c368090e3343f1c268802f60419653a0d6"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"9074643414d2a52e494ce454142035a6e6fd462c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    )"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: A ID of representing this vmove"},{"line_number":37,"context_line":"    id \u003d resource.Body(\"id\")"},{"line_number":38,"context_line":"    #: A UUID of representing this vmove"},{"line_number":39,"context_line":"    uuid \u003d resource.Body(\"uuid\")"},{"line_number":40,"context_line":"    #: The notification UUID this vmove belongs to"}],"source_content_type":"text/x-python","patch_set":13,"id":"9031b5b6_74af4aca","line":37,"in_reply_to":"67dd3c03_74ceddf1","updated":"2023-08-25 07:14:54.000000000","message":"no, now you have 2 URI ID parameters. This is wrong. notification_id is a URI parameter, while ID is a Body parameter since it is present in the response body. For get operations the resource ID is being used magically without need to be specified this way. Please turn it back to be a Body parameter","commit_id":"8fd136c368090e3343f1c268802f60419653a0d6"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"fa9fe07d13f94f2ce70e89434e2af6450c53b81b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    )"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: A ID of representing this vmove"},{"line_number":37,"context_line":"    id \u003d resource.Body(\"id\")"},{"line_number":38,"context_line":"    #: A UUID of representing this vmove"},{"line_number":39,"context_line":"    uuid \u003d resource.Body(\"uuid\")"},{"line_number":40,"context_line":"    #: The notification UUID this vmove belongs to"}],"source_content_type":"text/x-python","patch_set":13,"id":"43aeea4d_53c49684","line":37,"in_reply_to":"9031b5b6_74af4aca","updated":"2023-08-28 10:05:30.000000000","message":"done","commit_id":"8fd136c368090e3343f1c268802f60419653a0d6"}]}