)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6758f84e335a11e943e9d772a8996c71e31a72be","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-02-21 19:12:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share instances to shared file systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7e1f8bd4218858a8e483a402b3906706840a47a5"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/874046"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"36c9af4b_763c7721","line":8,"updated":"2023-03-03 21:44:50.000000000","message":"Add \n\n Co-Authored-By: Reynaldo Bontje \u003crey.bontje80@gmail.com\u003e","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"92bdab6911f96eecb9ea953489be8ac5a535ac42","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-02-21 19:12:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share instances to shared file systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7e1f8bd4218858a8e483a402b3906706840a47a5"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/874046"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a7e3828d_2b761bd1","line":8,"in_reply_to":"36c9af4b_763c7721","updated":"2023-03-03 22:44:17.000000000","message":"Done","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6758f84e335a11e943e9d772a8996c71e31a72be","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share instances to shared file systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7e1f8bd4218858a8e483a402b3906706840a47a5"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/874046"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b7d06c35_ec8d24f3","line":10,"range":{"start_line":9,"start_character":52,"end_line":10,"end_character":72},"updated":"2023-03-03 21:44:50.000000000","message":"You can drop this now..","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"92bdab6911f96eecb9ea953489be8ac5a535ac42","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share instances to shared file systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7e1f8bd4218858a8e483a402b3906706840a47a5"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/874046"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"03455c7d_3a56075a","line":10,"range":{"start_line":9,"start_character":52,"end_line":10,"end_character":72},"in_reply_to":"b7d06c35_ec8d24f3","updated":"2023-03-03 22:44:17.000000000","message":"Done","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99e1c147c266eef77be6907d77e2fcf86070f8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"609a2a85_5d29dd44","updated":"2023-02-21 20:03:26.000000000","message":"Thanks for the update Rey, as we discussed on the call, the _max_microversion annotation doens\u0027t make much sense in the share_instance.py resource... ","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6758f84e335a11e943e9d772a8996c71e31a72be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3e64c69d_c7694757","updated":"2023-03-03 21:44:50.000000000","message":"This requires minor fixes as commented inline.. please revise this change ","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"28fc30a8d94bfa7fe10ec1cd325e49b0c237b8ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46f509dd_77a60ae4","updated":"2023-02-21 20:07:41.000000000","message":"recheck ","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"156d27865eac896fd0843d8f62e872563bb0e090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72183aad_c7bdc305","updated":"2023-03-03 23:02:22.000000000","message":"LGTM, thanks Reynaldo!","commit_id":"655c4b0ec13415bad70cc41c09ed018468db53e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb3b9f133e3c6d03df28ed17f359fb4dda205d11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"19c48469_1772bf38","updated":"2023-03-27 22:21:03.000000000","message":"Perfect, thank you Rey!","commit_id":"1edfcaa2f6f2a31fb2076c343f55e22572c559f6"}],"openstack/shared_file_system/v2/share_instance.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"28fc30a8d94bfa7fe10ec1cd325e49b0c237b8ff","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"091369a3_b4dc0cab","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"updated":"2023-02-21 20:07:41.000000000","message":"remove this line","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"6fc69d61e81bed179a4aaa9e1c925e68bbfe5b3d","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"64b8024b_0ed1c3ec","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"in_reply_to":"06001cdd_ec1b507f","updated":"2023-03-04 06:30:26.000000000","message":"Alternatively, we could set this to 2.3 and change the response body to use the \u0027os-reset_status\u0027 key. I say we leave it as 2.7.","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"92bdab6911f96eecb9ea953489be8ac5a535ac42","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"b250fc35_ee8535e7","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"in_reply_to":"091369a3_b4dc0cab","updated":"2023-03-03 22:44:17.000000000","message":"Done","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2f3ccf6e88f6b049ffb4b46a958c62d781e4e39e","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"a1b1e08d_a85a3977","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"in_reply_to":"64b8024b_0ed1c3ec","updated":"2023-03-07 01:16:18.000000000","message":"I still think _max_microversion shouldn\u0027t be set here unless the APIs are gone after a particular version. \n\nI feel like our problem is elsewhere; I\u0027m attempting a fix here: https://review.opendev.org/c/openstack/openstacksdk/+/876468\n\nIf that works, we can try that approach.","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"373c68cb94d54da736358c5436a860d8238bdecf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"a6637c8f_9232c3c7","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"in_reply_to":"85d5662a_b7aef77e","updated":"2023-03-27 00:21:51.000000000","message":"Done\n\nThanks for showing me a nice way to handle this.","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"a6eec3fadb3cd8ccbda3a7788afef0fda8594b1f","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"06001cdd_ec1b507f","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"in_reply_to":"949242db_f53792c7","updated":"2023-03-04 06:19:12.000000000","message":"Some more context: https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html#id5","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3389d9fc6eba5c17daccd5e52c18a43591908ded","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"85d5662a_b7aef77e","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"in_reply_to":"a1b1e08d_a85a3977","updated":"2023-03-08 00:33:10.000000000","message":"This approach works and we agreed to proceed with this direction. I\u0027ll abandon https://review.opendev.org/c/openstack/openstacksdk/+/876468; please update this changeset with those changes...","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"2a33d46d4bc44ca0fac46e2461fe5e5c37316aa3","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    #: The share or share instance status."},{"line_number":57,"context_line":"    status \u003d resource.Body(\"status\", type\u003dstr)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # resource APIs were introduced in API microversion 2.3"},{"line_number":60,"context_line":"    # for action methods, the os prefix was removed in microversion 2.7"},{"line_number":61,"context_line":"    _max_microversion \u003d \u00272.7\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _action(self, session, body):"},{"line_number":64,"context_line":"        \"\"\"Perform share instance actions given the message body\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"949242db_f53792c7","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":29},"in_reply_to":"b250fc35_ee8535e7","updated":"2023-03-04 06:06:05.000000000","message":"Tests fail without this. See the code comments for detail. Additionally, I found some very old code from the API for context: https://opendev.org/openstack/manila/src/commit/348fde021f3267ddec7ff77abc4c55fe5a166ffb/manila/api/v2/share_instances.py#L44 \n\nBasically, I\u0027m pretty sure setting this means the max/oldest version of the API this supports is 2.7 (from the\"Liberty\" (circa 2015) release).","commit_id":"6186deee372caca52fd303fe79def11ace639dd3"}]}