)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b44e5feb_df77b71f","updated":"2023-04-13 20:52:32.000000000","message":"Hi Sam; thanks for working on this.. i\u0027ve added comments inline..","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9697d611_0f8a2b47","updated":"2023-04-18 17:22:17.000000000","message":"Thanks for the comments! Those should be resolved.","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"69a1ac86_c4297dfd","updated":"2023-04-17 22:17:52.000000000","message":"Thanks for the updates Sam. more comments inline..","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bcef2ed4ae5ce09d0b1bf518234820cdbc8bfe38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ea612de5_f783215d","updated":"2023-04-23 03:51:27.000000000","message":"Hi Sam, thanks for the updates - a few more minor comments inline. Glad you got the docs issues resolved!","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"30becf42fcb2f39793e8c3963760c128ae16b9af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"92f5147b_8cd277d1","updated":"2023-04-24 22:46:30.000000000","message":"Responses and further comments inline..","commit_id":"601f11806f1ad19541af6fa73298d43f52994390"}],"doc/source/user/proxies/shared_file_system.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":73,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Interact with Share Snapshots supported by the Shared File Systems"},{"line_number":76,"context_line":"service."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":79,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ad13abc6_6dc8b603","side":"PARENT","line":76,"updated":"2023-04-13 20:52:32.000000000","message":"unrelated change; please revert","commit_id":"453087fa96a71e4cf8cc3b7c470173b462a480ad"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":73,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Interact with Share Snapshots supported by the Shared File Systems"},{"line_number":76,"context_line":"service."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":79,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"627f1731_4ac9fd0b","side":"PARENT","line":76,"in_reply_to":"ad13abc6_6dc8b603","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"453087fa96a71e4cf8cc3b7c470173b462a480ad"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":555,"context_line":"        \"\"\""},{"line_number":556,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def share_replica(self, share_replica_id):"},{"line_number":559,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        :param share_replica_id: Id of the share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"17eaec64_36084fc0","line":558,"range":{"start_line":558,"start_character":8,"end_line":558,"end_character":21},"updated":"2023-04-13 20:52:32.000000000","message":"get_share_replica","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        \"\"\""},{"line_number":556,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def share_replica(self, share_replica_id):"},{"line_number":559,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        :param share_replica_id: Id of the share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"067529b4_d8d907ce","line":558,"range":{"start_line":558,"start_character":8,"end_line":558,"end_character":21},"in_reply_to":"17eaec64_36084fc0","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":556,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def share_replica(self, share_replica_id):"},{"line_number":559,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        :param share_replica_id: Id of the share replica"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0fff8ff6_c6d37911","line":559,"range":{"start_line":559,"start_character":16,"end_line":559,"end_character":23},"updated":"2023-04-13 20:52:32.000000000","message":"typo","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def share_replica(self, share_replica_id):"},{"line_number":559,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        :param share_replica_id: Id of the share replica"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"78c40aba_958c193f","line":559,"range":{"start_line":559,"start_character":16,"end_line":559,"end_character":23},"in_reply_to":"0fff8ff6_c6d37911","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":578,"context_line":"        \"\"\""},{"line_number":579,"context_line":"        return self._delete(_share_replica.ShareReplica, share_replica_id)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    def share_replica_reset_status(self, share_replica_id, status):"},{"line_number":582,"context_line":"        \"\"\"Reset status of the share replica"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        :param share_replica_id: Id of the share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"2bae5e81_59b7feb2","line":581,"range":{"start_line":581,"start_character":8,"end_line":581,"end_character":34},"updated":"2023-04-13 20:52:32.000000000","message":"reset_share_replica_status (to be consistent with the implementation for share instances above)","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        \"\"\""},{"line_number":579,"context_line":"        return self._delete(_share_replica.ShareReplica, share_replica_id)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    def share_replica_reset_status(self, share_replica_id, status):"},{"line_number":582,"context_line":"        \"\"\"Reset status of the share replica"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        :param share_replica_id: Id of the share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"1742f1eb_a59ab044","line":581,"range":{"start_line":581,"start_character":8,"end_line":581,"end_character":34},"in_reply_to":"2bae5e81_59b7feb2","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":591,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":592,"context_line":"        share_replica.reset_status(self, status)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def share_replica_reset_replica_state("},{"line_number":595,"context_line":"            self, share_replica_id, replica_state):"},{"line_number":596,"context_line":"        \"\"\"Reset replica_state of the share replica"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ffb2b750_a31d6f30","line":594,"range":{"start_line":594,"start_character":8,"end_line":594,"end_character":41},"updated":"2023-04-13 20:52:32.000000000","message":"reset_share_replica_replica_state","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":592,"context_line":"        share_replica.reset_status(self, status)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def share_replica_reset_replica_state("},{"line_number":595,"context_line":"            self, share_replica_id, replica_state):"},{"line_number":596,"context_line":"        \"\"\"Reset replica_state of the share replica"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"acba4e94_0359120a","line":594,"range":{"start_line":594,"start_character":8,"end_line":594,"end_character":41},"in_reply_to":"ffb2b750_a31d6f30","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":608,"context_line":"    def share_replica_force_delete(self, share_replica_id):"},{"line_number":609,"context_line":"        \"\"\"Force-delete share replica"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        :rtype: ``None``"},{"line_number":614,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"af046e60_9ddb4b48","line":611,"range":{"start_line":611,"start_character":39,"end_line":611,"end_character":43},"updated":"2023-04-13 20:52:32.000000000","message":"typo","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":608,"context_line":"    def share_replica_force_delete(self, share_replica_id):"},{"line_number":609,"context_line":"        \"\"\"Force-delete share replica"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        :rtype: ``None``"},{"line_number":614,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"815d8b1d_b637835c","line":611,"range":{"start_line":611,"start_character":39,"end_line":611,"end_character":43},"in_reply_to":"af046e60_9ddb4b48","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":605,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":606,"context_line":"        share_replica.reset_replica_state(self, replica_state)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def share_replica_force_delete(self, share_replica_id):"},{"line_number":609,"context_line":"        \"\"\"Force-delete share replica"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        :rtype: ``None``"},{"line_number":614,"context_line":"        \"\"\""},{"line_number":615,"context_line":"        share_replica \u003d self._get_resource("},{"line_number":616,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":617,"context_line":"        share_replica.force_delete(self)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def share_replica_promote(self, share_replica_id):"},{"line_number":620,"context_line":"        \"\"\"Promote share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a95c09b_55539412","line":617,"range":{"start_line":608,"start_character":4,"end_line":617,"end_character":40},"updated":"2023-04-13 20:52:32.000000000","message":"why not make \"force\" a parameter to the \"delete_share_replica\" method instead of introducing a separate method..","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":606,"context_line":"        share_replica.reset_replica_state(self, replica_state)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def share_replica_force_delete(self, share_replica_id):"},{"line_number":609,"context_line":"        \"\"\"Force-delete share replica"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        :rtype: ``None``"},{"line_number":614,"context_line":"        \"\"\""},{"line_number":615,"context_line":"        share_replica \u003d self._get_resource("},{"line_number":616,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":617,"context_line":"        share_replica.force_delete(self)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def share_replica_promote(self, share_replica_id):"},{"line_number":620,"context_line":"        \"\"\"Promote share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"4d19eb78_594dcc8a","line":617,"range":{"start_line":608,"start_character":4,"end_line":617,"end_character":40},"in_reply_to":"7a95c09b_55539412","updated":"2023-04-17 20:10:39.000000000","message":"Let me know what you think of the change I made. I\u0027m not sure if it is what you were looking for. Thanks","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":616,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":617,"context_line":"        share_replica.force_delete(self)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def share_replica_promote(self, share_replica_id):"},{"line_number":620,"context_line":"        \"\"\"Promote share replica"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        :param share_replica_id: Id of fthe share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"afcb114d_b9d3eec7","line":619,"range":{"start_line":619,"start_character":8,"end_line":619,"end_character":29},"updated":"2023-04-13 20:52:32.000000000","message":"promote_share_replica","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":616,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":617,"context_line":"        share_replica.force_delete(self)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def share_replica_promote(self, share_replica_id):"},{"line_number":620,"context_line":"        \"\"\"Promote share replica"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        :param share_replica_id: Id of fthe share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"fbb64173_563677cf","line":619,"range":{"start_line":619,"start_character":8,"end_line":619,"end_character":29},"in_reply_to":"afcb114d_b9d3eec7","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":619,"context_line":"    def share_replica_promote(self, share_replica_id):"},{"line_number":620,"context_line":"        \"\"\"Promote share replica"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        :rtype: ``None``"},{"line_number":625,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1bfd6130_48574610","line":622,"range":{"start_line":622,"start_character":39,"end_line":622,"end_character":43},"updated":"2023-04-13 20:52:32.000000000","message":"typo","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    def share_replica_promote(self, share_replica_id):"},{"line_number":620,"context_line":"        \"\"\"Promote share replica"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        :rtype: ``None``"},{"line_number":625,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"348567c4_dcbbe539","line":622,"range":{"start_line":622,"start_character":39,"end_line":622,"end_character":43},"in_reply_to":"1bfd6130_48574610","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":627,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":628,"context_line":"        share_replica.promote(self)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def share_replica_resync(self, share_replica_id):"},{"line_number":631,"context_line":"        \"\"\"Resync share replica"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param share_replica_id: Id of fthe share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"36d23fb0_6282e0f6","line":630,"range":{"start_line":630,"start_character":8,"end_line":630,"end_character":28},"updated":"2023-04-13 20:52:32.000000000","message":"resync_share_replica","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            _share_replica.ShareReplica, share_replica_id)"},{"line_number":628,"context_line":"        share_replica.promote(self)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def share_replica_resync(self, share_replica_id):"},{"line_number":631,"context_line":"        \"\"\"Resync share replica"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param share_replica_id: Id of fthe share replica"}],"source_content_type":"text/x-python","patch_set":5,"id":"8eb9afe1_b402fcaa","line":630,"range":{"start_line":630,"start_character":8,"end_line":630,"end_character":28},"in_reply_to":"36d23fb0_6282e0f6","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":630,"context_line":"    def share_replica_resync(self, share_replica_id):"},{"line_number":631,"context_line":"        \"\"\"Resync share replica"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        :rtype: ``None``"},{"line_number":636,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"c95ffc30_07efc8fc","line":633,"range":{"start_line":633,"start_character":39,"end_line":633,"end_character":43},"updated":"2023-04-13 20:52:32.000000000","message":"typo","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    def share_replica_resync(self, share_replica_id):"},{"line_number":631,"context_line":"        \"\"\"Resync share replica"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        :param share_replica_id: Id of fthe share replica"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        :rtype: ``None``"},{"line_number":636,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"e4bc2398_de3cd32e","line":633,"range":{"start_line":633,"start_character":39,"end_line":633,"end_character":43},"in_reply_to":"c95ffc30_07efc8fc","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":591,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def get_share_replica(self, share_replica_id):"},{"line_number":594,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        :param share_replica_id: Id of the share replica"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"715e8c93_db807edf","line":594,"range":{"start_line":594,"start_character":16,"end_line":594,"end_character":23},"updated":"2023-04-17 22:17:52.000000000","message":"details","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def get_share_replica(self, share_replica_id):"},{"line_number":594,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        :param share_replica_id: Id of the share replica"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fcb6b14_ca9b6726","line":594,"range":{"start_line":594,"start_character":16,"end_line":594,"end_character":23},"in_reply_to":"715e8c93_db807edf","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":603,"context_line":"        return self._get(_share_replica.ShareReplica, share_replica_id)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    def delete_share_replica(self, share_replica_id, ignore_missing\u003dTrue,"},{"line_number":606,"context_line":"                             force_delete\u003dFalse):"},{"line_number":607,"context_line":"        \"\"\"Delete a share replica"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        :param share_replica_id: Id of the share replica"}],"source_content_type":"text/x-python","patch_set":6,"id":"548c7bf1_1e169732","line":606,"range":{"start_line":606,"start_character":29,"end_line":606,"end_character":41},"updated":"2023-04-17 22:17:52.000000000","message":"just call this \"force\"","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        return self._get(_share_replica.ShareReplica, share_replica_id)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    def delete_share_replica(self, share_replica_id, ignore_missing\u003dTrue,"},{"line_number":606,"context_line":"                             force_delete\u003dFalse):"},{"line_number":607,"context_line":"        \"\"\"Delete a share replica"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        :param share_replica_id: Id of the share replica"}],"source_content_type":"text/x-python","patch_set":6,"id":"dabb77f1_520e0332","line":606,"range":{"start_line":606,"start_character":29,"end_line":606,"end_character":41},"in_reply_to":"548c7bf1_1e169732","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":615,"context_line":"        if force_delete:"},{"line_number":616,"context_line":"            share_replica \u003d self._get_resource("},{"line_number":617,"context_line":"                _share_replica.ShareReplica, share_replica_id)"},{"line_number":618,"context_line":"            share_replica.force_delete(self)"},{"line_number":619,"context_line":"            return"},{"line_number":620,"context_line":"        else:"},{"line_number":621,"context_line":"            return self._delete(_share_replica.ShareReplica, share_replica_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c647c1e1_4cae0397","line":618,"range":{"start_line":618,"start_character":0,"end_line":618,"end_character":44},"updated":"2023-04-17 22:17:52.000000000","message":"you\u0027ll need to pass ignore_missing and implement that behavior here too..","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        if force_delete:"},{"line_number":616,"context_line":"            share_replica \u003d self._get_resource("},{"line_number":617,"context_line":"                _share_replica.ShareReplica, share_replica_id)"},{"line_number":618,"context_line":"            share_replica.force_delete(self)"},{"line_number":619,"context_line":"            return"},{"line_number":620,"context_line":"        else:"},{"line_number":621,"context_line":"            return self._delete(_share_replica.ShareReplica, share_replica_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"42c71f3a_77c70fe0","line":618,"range":{"start_line":618,"start_character":0,"end_line":618,"end_character":44},"in_reply_to":"c647c1e1_4cae0397","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bcef2ed4ae5ce09d0b1bf518234820cdbc8bfe38","unresolved":true,"context_lines":[{"line_number":664,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def get_share_replica(self, share_replica_id):"},{"line_number":667,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        :param share_replica_id: Id of the share replica"},{"line_number":670,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"6a2a23f9_fcaa759b","line":667,"range":{"start_line":667,"start_character":16,"end_line":667,"end_character":23},"updated":"2023-04-23 03:51:27.000000000","message":"spelling","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"8bd73a2eace62e4cbe397a2b0d8dd5ca8e91e7b1","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        return self._list(_share_replica.ShareReplica, **attrs)"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def get_share_replica(self, share_replica_id):"},{"line_number":667,"context_line":"        \"\"\"List deatils of a single share replica"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        :param share_replica_id: Id of the share replica"},{"line_number":670,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a9fd4807_e61d6528","line":667,"range":{"start_line":667,"start_character":16,"end_line":667,"end_character":23},"in_reply_to":"6a2a23f9_fcaa759b","updated":"2024-04-22 19:31:21.000000000","message":"Done","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"30becf42fcb2f39793e8c3963760c128ae16b9af","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        \"share_instance\": _share_instance.ShareInstance,"},{"line_number":57,"context_line":"        \"share_export_locations\":"},{"line_number":58,"context_line":"            _share_export_locations.ShareExportLocation,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def availability_zones(self):"},{"line_number":62,"context_line":"        \"\"\"Retrieve shared file system availability zones"}],"source_content_type":"text/x-python","patch_set":11,"id":"957abb52_3a822b23","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":5},"updated":"2023-04-24 22:46:30.000000000","message":"you\u0027ll need to add share replica resource to this list","commit_id":"601f11806f1ad19541af6fa73298d43f52994390"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"8bd73a2eace62e4cbe397a2b0d8dd5ca8e91e7b1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"share_instance\": _share_instance.ShareInstance,"},{"line_number":57,"context_line":"        \"share_export_locations\":"},{"line_number":58,"context_line":"            _share_export_locations.ShareExportLocation,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def availability_zones(self):"},{"line_number":62,"context_line":"        \"\"\"Retrieve shared file system availability zones"}],"source_content_type":"text/x-python","patch_set":11,"id":"895230a9_1ae2cbae","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":5},"in_reply_to":"957abb52_3a822b23","updated":"2024-04-22 19:31:21.000000000","message":"Done","commit_id":"601f11806f1ad19541af6fa73298d43f52994390"}],"openstack/shared_file_system/v2/share_replica.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    share_server_id \u003d resource.Body(\"share_server_id\", type\u003dstr)"},{"line_number":48,"context_line":"    #: The host name of the share replica."},{"line_number":49,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":50,"context_line":"    #: The UUID of the share replica."},{"line_number":51,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":52,"context_line":"    #: The replica state of a share replica."},{"line_number":53,"context_line":"    replica_state \u003d resource.Body(\"replica_state\", type\u003dstr)"},{"line_number":54,"context_line":"    #: The date and time stamp when the resource was created within the"}],"source_content_type":"text/x-python","patch_set":5,"id":"f04724fe_961f3734","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":38},"updated":"2023-04-13 20:52:32.000000000","message":"this is defined in the base Resource class, so no need to duplicate","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    share_server_id \u003d resource.Body(\"share_server_id\", type\u003dstr)"},{"line_number":48,"context_line":"    #: The host name of the share replica."},{"line_number":49,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":50,"context_line":"    #: The UUID of the share replica."},{"line_number":51,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":52,"context_line":"    #: The replica state of a share replica."},{"line_number":53,"context_line":"    replica_state \u003d resource.Body(\"replica_state\", type\u003dstr)"},{"line_number":54,"context_line":"    #: The date and time stamp when the resource was created within the"}],"source_content_type":"text/x-python","patch_set":5,"id":"c7246d32_a4498021","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":38},"in_reply_to":"f04724fe_961f3734","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    #: service’s database."},{"line_number":56,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _max_microversion \u003d \u00272.56\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _action(self, session, body):"},{"line_number":61,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"113ae695_734306b2","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":30},"updated":"2023-04-13 20:52:32.000000000","message":"don\u0027t use a _max_microversion - this API isn\u0027t gone yet..","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    #: service’s database."},{"line_number":56,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _max_microversion \u003d \u00272.56\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _action(self, session, body):"},{"line_number":61,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"6e8118d4_ef298824","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":30},"in_reply_to":"113ae695_734306b2","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _max_microversion \u003d \u00272.56\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _action(self, session, body):"},{"line_number":61,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":62,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":63,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"50fc26ea_95d6551e","line":60,"range":{"start_line":60,"start_character":35,"end_line":60,"end_character":37},"updated":"2023-04-13 20:52:32.000000000","message":"allow specifying a microversion optionally","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _max_microversion \u003d \u00272.56\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _action(self, session, body):"},{"line_number":61,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":62,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":63,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"959f38ea_731cbf66","line":60,"range":{"start_line":60,"start_character":35,"end_line":60,"end_character":37},"in_reply_to":"50fc26ea_95d6551e","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":62,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":63,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"},{"line_number":64,"context_line":"        response \u003d session.post("},{"line_number":65,"context_line":"            url, json\u003dbody, headers\u003dheaders,"},{"line_number":66,"context_line":"            microversion\u003dself._max_microversion)"},{"line_number":67,"context_line":"        exceptions.raise_from_response(response)"},{"line_number":68,"context_line":"        return response"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3e05d0d9_3fe94ad5","line":66,"range":{"start_line":64,"start_character":8,"end_line":66,"end_character":48},"updated":"2023-04-13 20:52:32.000000000","message":"pass the microversion like this:\n\n \n    microversion \u003d microversion or self._get_microversion(session, action\u003d\u0027patch\u0027)\n    response \u003d session.post(\n               url, json\u003dbody, headers\u003dheaders,\n               microversion\u003dmicroversion)","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":62,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":63,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"},{"line_number":64,"context_line":"        response \u003d session.post("},{"line_number":65,"context_line":"            url, json\u003dbody, headers\u003dheaders,"},{"line_number":66,"context_line":"            microversion\u003dself._max_microversion)"},{"line_number":67,"context_line":"        exceptions.raise_from_response(response)"},{"line_number":68,"context_line":"        return response"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ea9f1bfc_670190c3","line":66,"range":{"start_line":64,"start_character":8,"end_line":66,"end_character":48},"in_reply_to":"3e05d0d9_3fe94ad5","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {\u0027replica_state\u0027: replica_state}}"},{"line_number":76,"context_line":"        return self._action(session, body)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def force_delete(self, session):"},{"line_number":79,"context_line":"        \"\"\"Force-delete share replica\"\"\""},{"line_number":80,"context_line":"        body \u003d {\u0027force_delete\u0027: None}"},{"line_number":81,"context_line":"        return self._action(session, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ad0446c9_7333d062","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":36},"updated":"2023-04-17 22:17:52.000000000","message":"allow using \"ignore_missing\" here as well.. \n\ntry..except ResourceNotFound like you do here: https://review.opendev.org/c/openstack/openstacksdk/+/784162/15/openstack/shared_file_system/v2/share_access_rule.py#89","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {\u0027replica_state\u0027: replica_state}}"},{"line_number":76,"context_line":"        return self._action(session, body)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def force_delete(self, session):"},{"line_number":79,"context_line":"        \"\"\"Force-delete share replica\"\"\""},{"line_number":80,"context_line":"        body \u003d {\u0027force_delete\u0027: None}"},{"line_number":81,"context_line":"        return self._action(session, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f024dd5b_c1989997","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":36},"in_reply_to":"ad0446c9_7333d062","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"}],"openstack/tests/functional/shared_file_system/test_share_replica.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        srg \u003d self.user_cloud.shared_file_system.share_replica("},{"line_number":57,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":58,"context_line":"        print(srg)"},{"line_number":59,"context_line":"        self.user_cloud.shared_file_system.delete_share_replica("},{"line_number":60,"context_line":"            self.SHARE_REPLICA_ID"}],"source_content_type":"text/x-python","patch_set":5,"id":"355167af_a0a3e84f","line":57,"range":{"start_line":56,"start_character":8,"end_line":57,"end_character":34},"updated":"2023-04-13 20:52:32.000000000","message":"Can you do list all replicas and delete all non-active replicas instead? (replica_state !\u003d \"active\").. This will be helpful when you decide to have a test to promote the share replica... A promoted replica becomes \"active\" and  the previously \"active\" replica becomes a secondary copy.. So if you try to cleanup the original replica, you\u0027ll get an error.\n\nAlternatively, you can create a new functional test class for Promotion since it defies the regular cleanup rules..","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"450da809907ee5777bb0155560d3e3d6ced45f88","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        srg \u003d self.user_cloud.shared_file_system.share_replica("},{"line_number":57,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":58,"context_line":"        print(srg)"},{"line_number":59,"context_line":"        self.user_cloud.shared_file_system.delete_share_replica("},{"line_number":60,"context_line":"            self.SHARE_REPLICA_ID"}],"source_content_type":"text/x-python","patch_set":5,"id":"71219bcc_9c45cad4","line":57,"range":{"start_line":56,"start_character":8,"end_line":57,"end_character":34},"in_reply_to":"355167af_a0a3e84f","updated":"2023-04-20 19:25:51.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        srg \u003d self.user_cloud.shared_file_system.share_replica("},{"line_number":57,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":58,"context_line":"        print(srg)"},{"line_number":59,"context_line":"        self.user_cloud.shared_file_system.delete_share_replica("},{"line_number":60,"context_line":"            self.SHARE_REPLICA_ID"},{"line_number":61,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"2c94b54e_8f5a2aaa","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":18},"updated":"2023-04-13 20:52:32.000000000","message":"remove print statements","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        srg \u003d self.user_cloud.shared_file_system.share_replica("},{"line_number":57,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":58,"context_line":"        print(srg)"},{"line_number":59,"context_line":"        self.user_cloud.shared_file_system.delete_share_replica("},{"line_number":60,"context_line":"            self.SHARE_REPLICA_ID"},{"line_number":61,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9b375c2d_e89f7bee","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":18},"in_reply_to":"2c94b54e_8f5a2aaa","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        print(self.SHARE.get(\u0027status\u0027))"},{"line_number":65,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":66,"context_line":"            self.SHARE_ID,"},{"line_number":67,"context_line":"            ignore_missing\u003dFalse)"},{"line_number":68,"context_line":"        self.assertIsNone(sot)"},{"line_number":69,"context_line":"        super(ShareReplicaTest, self).tearDown()"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1eacbe9e_cf45aa39","line":67,"range":{"start_line":67,"start_character":12,"end_line":67,"end_character":26},"updated":"2023-04-13 20:52:32.000000000","message":"ignore_missing\u003dTrue?","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        print(self.SHARE.get(\u0027status\u0027))"},{"line_number":65,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":66,"context_line":"            self.SHARE_ID,"},{"line_number":67,"context_line":"            ignore_missing\u003dFalse)"},{"line_number":68,"context_line":"        self.assertIsNone(sot)"},{"line_number":69,"context_line":"        super(ShareReplicaTest, self).tearDown()"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d4e0daf4_0aeb4297","line":67,"range":{"start_line":67,"start_character":12,"end_line":67,"end_character":26},"in_reply_to":"1eacbe9e_cf45aa39","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.assertIsNotNone(srt.id)"},{"line_number":53,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        srg \u003d self.user_cloud.shared_file_system.share_replica("},{"line_number":57,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":58,"context_line":"        print(srg)"},{"line_number":59,"context_line":"        self.user_cloud.shared_file_system.delete_share_replica("},{"line_number":60,"context_line":"            self.SHARE_REPLICA_ID"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":63,"context_line":"            srg, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":64,"context_line":"        print(self.SHARE.get(\u0027status\u0027))"},{"line_number":65,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":66,"context_line":"            self.SHARE_ID,"},{"line_number":67,"context_line":"            ignore_missing\u003dFalse)"},{"line_number":68,"context_line":"        self.assertIsNone(sot)"},{"line_number":69,"context_line":"        super(ShareReplicaTest, self).tearDown()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_get(self):"},{"line_number":72,"context_line":"        sot \u003d self.user_cloud.shared_file_system.share_replica("}],"source_content_type":"text/x-python","patch_set":5,"id":"0cf06c15_a665d2bb","line":69,"range":{"start_line":55,"start_character":0,"end_line":69,"end_character":48},"updated":"2023-04-13 20:52:32.000000000","message":"As i mentioned to you over email.. i like the implementation of an explicit tearDown here because of the logic in manila to disallow deletion of shares if there are replicas.. so its better to be explicit than implicitly allowing \"addCleanup\" to take care of cleanups for us.. \n\nbut, the failure you\u0027re hitting is because you\u0027re not waiting for share deletion to complete.. after line 67, add a waiter on the share to be gone... that way, a deletion attempt that happens because of the addCleanup (https://github.com/openstack/openstacksdk/blob/453087fa96a71e4cf8cc3b7c470173b462a480ad/openstack/tests/functional/shared_file_system/base.py#L30-L32) doesn\u0027t fail the way it currently does","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            self.SHARE_ID,"},{"line_number":67,"context_line":"            ignore_missing\u003dFalse)"},{"line_number":68,"context_line":"        self.assertIsNone(sot)"},{"line_number":69,"context_line":"        super(ShareReplicaTest, self).tearDown()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_get(self):"},{"line_number":72,"context_line":"        sot \u003d self.user_cloud.shared_file_system.share_replica("}],"source_content_type":"text/x-python","patch_set":5,"id":"7b3f6e75_dd268f09","line":69,"range":{"start_line":69,"start_character":9,"end_line":69,"end_character":48},"updated":"2023-04-13 20:52:32.000000000","message":"super().tearDown()","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"0fbb7e8681d2d99231e6699d213ad5524763e909","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.assertIsNotNone(srt.id)"},{"line_number":53,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        srg \u003d self.user_cloud.shared_file_system.share_replica("},{"line_number":57,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":58,"context_line":"        print(srg)"},{"line_number":59,"context_line":"        self.user_cloud.shared_file_system.delete_share_replica("},{"line_number":60,"context_line":"            self.SHARE_REPLICA_ID"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":63,"context_line":"            srg, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":64,"context_line":"        print(self.SHARE.get(\u0027status\u0027))"},{"line_number":65,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":66,"context_line":"            self.SHARE_ID,"},{"line_number":67,"context_line":"            ignore_missing\u003dFalse)"},{"line_number":68,"context_line":"        self.assertIsNone(sot)"},{"line_number":69,"context_line":"        super(ShareReplicaTest, self).tearDown()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_get(self):"},{"line_number":72,"context_line":"        sot \u003d self.user_cloud.shared_file_system.share_replica("}],"source_content_type":"text/x-python","patch_set":5,"id":"03e0bc9b_7cc4f630","line":69,"range":{"start_line":55,"start_character":0,"end_line":69,"end_character":48},"in_reply_to":"0cf06c15_a665d2bb","updated":"2023-04-14 00:34:13.000000000","message":"Thanks Goutham, that worked!","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"998dc14d8b3ed8e70b00eef4b0d90381054deb29","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.SHARE_ID,"},{"line_number":67,"context_line":"            ignore_missing\u003dFalse)"},{"line_number":68,"context_line":"        self.assertIsNone(sot)"},{"line_number":69,"context_line":"        super(ShareReplicaTest, self).tearDown()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_get(self):"},{"line_number":72,"context_line":"        sot \u003d self.user_cloud.shared_file_system.share_replica("}],"source_content_type":"text/x-python","patch_set":5,"id":"2b0a0dad_4c81e2f6","line":69,"range":{"start_line":69,"start_character":9,"end_line":69,"end_character":48},"in_reply_to":"7b3f6e75_dd268f09","updated":"2023-04-17 20:10:39.000000000","message":"Done","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc5a4d6d0f914c5a87ea786d10b80a399cc6ba50","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":74,"context_line":"        self.assertEqual(self.SHARE_REPLICA_ID, sot.id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"77ddcb92_daa864e5","line":76,"updated":"2023-04-13 20:52:32.000000000","message":"are you planning to add more tests for the other methods?","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"49d229b1a3a871f9db3965040a7c44b758e1f52d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":74,"context_line":"        self.assertEqual(self.SHARE_REPLICA_ID, sot.id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"43f18bc8_234dab0c","line":76,"in_reply_to":"77ddcb92_daa864e5","updated":"2023-04-14 00:28:22.000000000","message":"Yes, I just threw this up to see if the same test was failing in my local env vs the zuul env...which it is.","commit_id":"c1b02bb50d55084abf71c72fcfc816ac5872f4a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        my_share \u003d self.create_share("},{"line_number":27,"context_line":"            name\u003dself.SHARE_NAME, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":28,"context_line":"            share_protocol\u003d\u0027NFS\u0027, description\u003dNone)"},{"line_number":29,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":30,"context_line":"            my_share,"},{"line_number":31,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":32,"context_line":"            failures\u003d[\u0027error\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"a9ae1995_5356da16","line":29,"range":{"start_line":29,"start_character":13,"end_line":29,"end_character":27},"updated":"2023-04-17 22:17:52.000000000","message":"user_cloud","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        my_share \u003d self.create_share("},{"line_number":27,"context_line":"            name\u003dself.SHARE_NAME, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":28,"context_line":"            share_protocol\u003d\u0027NFS\u0027, description\u003dNone)"},{"line_number":29,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":30,"context_line":"            my_share,"},{"line_number":31,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":32,"context_line":"            failures\u003d[\u0027error\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf5f5271_2a542dec","line":29,"range":{"start_line":29,"start_character":13,"end_line":29,"end_character":27},"in_reply_to":"a9ae1995_5356da16","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        srt \u003d self.user_cloud.shared_file_system.create_share_replica("},{"line_number":38,"context_line":"            my_share.id)"},{"line_number":39,"context_line":"        self.SHARE_REPLICA \u003d srt"},{"line_number":40,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":41,"context_line":"            srt,"},{"line_number":42,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":43,"context_line":"            failures\u003d[\u0027error\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"069cc653_9bb43cd3","line":40,"range":{"start_line":40,"start_character":13,"end_line":40,"end_character":27},"updated":"2023-04-17 22:17:52.000000000","message":"user_cloud","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        srt \u003d self.user_cloud.shared_file_system.create_share_replica("},{"line_number":38,"context_line":"            my_share.id)"},{"line_number":39,"context_line":"        self.SHARE_REPLICA \u003d srt"},{"line_number":40,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":41,"context_line":"            srt,"},{"line_number":42,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":43,"context_line":"            failures\u003d[\u0027error\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"a8483235_61fd1d4c","line":40,"range":{"start_line":40,"start_character":13,"end_line":40,"end_character":27},"in_reply_to":"069cc653_9bb43cd3","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        srt \u003d self.user_cloud.shared_file_system.create_share_replica("},{"line_number":38,"context_line":"            my_share.id)"},{"line_number":39,"context_line":"        self.SHARE_REPLICA \u003d srt"},{"line_number":40,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":41,"context_line":"            srt,"},{"line_number":42,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":43,"context_line":"            failures\u003d[\u0027error\u0027],"},{"line_number":44,"context_line":"            interval\u003d5,"},{"line_number":45,"context_line":"            wait\u003dself._wait_for_timeout)"},{"line_number":46,"context_line":"        self.assertIsNotNone(srt)"},{"line_number":47,"context_line":"        self.assertIsNotNone(srt.id)"},{"line_number":48,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"c13153ec_0ded99bb","line":45,"range":{"start_line":40,"start_character":8,"end_line":45,"end_character":40},"updated":"2023-04-17 22:17:52.000000000","message":"for correctness, we need to wait for replica_state to become \"in_sync\" (which should be really fast too since the share is empty, and we\u0027re using the dummy driver in the first place to test this and since we\u0027ve some tunings in the CI to make it so)... \n\nThe method \"wait_for_status\" that we\u0027re invoking has a \"attribute\" kwarg that defaults to status: https://opendev.org/openstack/openstacksdk/src/commit/2679719701b398f8509c7e7520d18e0d791c5682/openstack/resource.py#L2279\n\nYou could change the logic in our proxy to accept the \"attribute\" as well and get this waiter to wait for the \"in_sync\" replica_state..","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"450da809907ee5777bb0155560d3e3d6ced45f88","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        srt \u003d self.user_cloud.shared_file_system.create_share_replica("},{"line_number":38,"context_line":"            my_share.id)"},{"line_number":39,"context_line":"        self.SHARE_REPLICA \u003d srt"},{"line_number":40,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":41,"context_line":"            srt,"},{"line_number":42,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":43,"context_line":"            failures\u003d[\u0027error\u0027],"},{"line_number":44,"context_line":"            interval\u003d5,"},{"line_number":45,"context_line":"            wait\u003dself._wait_for_timeout)"},{"line_number":46,"context_line":"        self.assertIsNotNone(srt)"},{"line_number":47,"context_line":"        self.assertIsNotNone(srt.id)"},{"line_number":48,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"bd21cfe4_06a29cf3","line":45,"range":{"start_line":40,"start_character":8,"end_line":45,"end_character":40},"in_reply_to":"c13153ec_0ded99bb","updated":"2023-04-20 19:25:51.000000000","message":"Got this changed. I had to set status\u003d\u0027in_sync\u0027, and attribute\u003d\u0027replica_state\u0027.","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def tearDown(self):"},{"line_number":51,"context_line":"        self.operator_cloud.shared_file_system.delete_share_replica("},{"line_number":52,"context_line":"            self.SHARE_REPLICA_ID,"},{"line_number":53,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":54,"context_line":"            force_delete\u003dTrue"}],"source_content_type":"text/x-python","patch_set":6,"id":"9860c4d0_00c2c929","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":27},"updated":"2023-04-17 22:17:52.000000000","message":"user_cloud","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.SHARE_REPLICA_ID \u003d srt.id"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def tearDown(self):"},{"line_number":51,"context_line":"        self.operator_cloud.shared_file_system.delete_share_replica("},{"line_number":52,"context_line":"            self.SHARE_REPLICA_ID,"},{"line_number":53,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":54,"context_line":"            force_delete\u003dTrue"}],"source_content_type":"text/x-python","patch_set":6,"id":"6fdf48bb_0a82309f","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":27},"in_reply_to":"9860c4d0_00c2c929","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.operator_cloud.shared_file_system.delete_share_replica("},{"line_number":52,"context_line":"            self.SHARE_REPLICA_ID,"},{"line_number":53,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":54,"context_line":"            force_delete\u003dTrue"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":57,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c45d407a_b21d96a9","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":29},"updated":"2023-04-17 22:17:52.000000000","message":"not necessary to force deletion - is the deletion failing without this?","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.operator_cloud.shared_file_system.delete_share_replica("},{"line_number":52,"context_line":"            self.SHARE_REPLICA_ID,"},{"line_number":53,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":54,"context_line":"            force_delete\u003dTrue"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":57,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0bfcdc5c_3b29fa18","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":29},"in_reply_to":"c45d407a_b21d96a9","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":54,"context_line":"            force_delete\u003dTrue"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":57,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":58,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":59,"context_line":"            self.SHARE_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2399c99d_952c0e82","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":27},"updated":"2023-04-17 22:17:52.000000000","message":"user_cloud","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":54,"context_line":"            force_delete\u003dTrue"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":57,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":58,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":59,"context_line":"            self.SHARE_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"afd4af70_3e891863","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":27},"in_reply_to":"2399c99d_952c0e82","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":57,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":58,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":59,"context_line":"            self.SHARE_ID,"},{"line_number":60,"context_line":"            ignore_missing\u003dTrue)"},{"line_number":61,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("}],"source_content_type":"text/x-python","patch_set":6,"id":"c68e88b1_ff178513","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":33},"updated":"2023-04-17 22:17:52.000000000","message":"user_cloud","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":57,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":58,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":59,"context_line":"            self.SHARE_ID,"},{"line_number":60,"context_line":"            ignore_missing\u003dTrue)"},{"line_number":61,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("}],"source_content_type":"text/x-python","patch_set":6,"id":"1755e07b_5dfea8cf","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":33},"in_reply_to":"c68e88b1_ff178513","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":59,"context_line":"            self.SHARE_ID,"},{"line_number":60,"context_line":"            ignore_missing\u003dTrue)"},{"line_number":61,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":62,"context_line":"            self.SHARE, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":63,"context_line":"        self.assertIsNone(sot)"},{"line_number":64,"context_line":"        super().tearDown()"}],"source_content_type":"text/x-python","patch_set":6,"id":"25fde608_ac017603","line":61,"range":{"start_line":61,"start_character":13,"end_line":61,"end_character":27},"updated":"2023-04-17 22:17:52.000000000","message":"user_cloud","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.delete_share("},{"line_number":59,"context_line":"            self.SHARE_ID,"},{"line_number":60,"context_line":"            ignore_missing\u003dTrue)"},{"line_number":61,"context_line":"        self.operator_cloud.shared_file_system.wait_for_delete("},{"line_number":62,"context_line":"            self.SHARE, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":63,"context_line":"        self.assertIsNone(sot)"},{"line_number":64,"context_line":"        super().tearDown()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7561df56_e3f33df3","line":61,"range":{"start_line":61,"start_character":13,"end_line":61,"end_character":27},"in_reply_to":"25fde608_ac017603","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(self.SHARE_REPLICA_ID, sot.id)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_list_share_replicas(self):"},{"line_number":73,"context_line":"        share_replicas \u003d self.operator_cloud.share.share_replicas()"},{"line_number":74,"context_line":"        self.assertGreater(len(list(share_replicas)), 0)"},{"line_number":75,"context_line":"        for share_replica in share_replicas:"},{"line_number":76,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027created_at\u0027, \u0027replica_state\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d22a527_69291203","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":44},"updated":"2023-04-17 22:17:52.000000000","message":"user_cloud","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"a8c8abc47980ffe6b298b509dcc8a127dd7e567e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(self.SHARE_REPLICA_ID, sot.id)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_list_share_replicas(self):"},{"line_number":73,"context_line":"        share_replicas \u003d self.operator_cloud.share.share_replicas()"},{"line_number":74,"context_line":"        self.assertGreater(len(list(share_replicas)), 0)"},{"line_number":75,"context_line":"        for share_replica in share_replicas:"},{"line_number":76,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027created_at\u0027, \u0027replica_state\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ed49ba0_13d7b9bc","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":44},"in_reply_to":"2d22a527_69291203","updated":"2023-04-18 17:22:17.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        self.assertEqual(\u0027error\u0027, sot.replica_state)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_promote_share_replica(self):"},{"line_number":96,"context_line":"        psr \u003d self.user_cloud.shared_file_system.promote_share_replica("},{"line_number":97,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":98,"context_line":"        self.assertIsNone(psr)"},{"line_number":99,"context_line":"        sot \u003d self.user_cloud.shared_file_system.get_share_replica("},{"line_number":100,"context_line":"            self.SHARE_REPLICA_ID)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a2271d06_572a6e7a","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":34},"updated":"2023-04-17 22:17:52.000000000","message":"after initiating this call, you should wait for the replica_state to become \"in_sync\".... and that can be the test, no need for an assert on line 101.. \n\nAlso, at the end of this test, you\u0027ll need to ensure the cleanup is attempted in the right order.. your old secondary replica is now \"promoted\" to be the primary.. so the old \"primary\" replica needs to be deleted first... \n\nif you make your teardown logic agnostic to this by listing the replicas of the share and deleting the non-active replicas, the comment from my last review: https://review.opendev.org/c/openstack/openstacksdk/+/873324/comment/355167af_a0a3e84f/","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"450da809907ee5777bb0155560d3e3d6ced45f88","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.assertEqual(\u0027error\u0027, sot.replica_state)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_promote_share_replica(self):"},{"line_number":96,"context_line":"        psr \u003d self.user_cloud.shared_file_system.promote_share_replica("},{"line_number":97,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":98,"context_line":"        self.assertIsNone(psr)"},{"line_number":99,"context_line":"        sot \u003d self.user_cloud.shared_file_system.get_share_replica("},{"line_number":100,"context_line":"            self.SHARE_REPLICA_ID)"}],"source_content_type":"text/x-python","patch_set":6,"id":"85892ea4_bb48e382","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":34},"in_reply_to":"a2271d06_572a6e7a","updated":"2023-04-20 19:25:51.000000000","message":"Got that changed. Thanks for the explanation.","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a6e27cc34b448d677ce578dbeaf24b3c19ee7c","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        psr \u003d self.operator_cloud.shared_file_system.resync_share_replica("},{"line_number":105,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":106,"context_line":"        self.assertIsNone(psr)"},{"line_number":107,"context_line":"        sot \u003d self.user_cloud.shared_file_system.get_share_replica("},{"line_number":108,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":109,"context_line":"        self.assertEqual(\u0027in_sync\u0027, sot.replica_state)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba02cddf_5a4a7a8f","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":54},"updated":"2023-04-17 22:17:52.000000000","message":"same comment as the promote one above, you could wait for the \"in_sync\" replica state instead of asserting on line 109.. the reasoning here is that the api call is asynchronous","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"450da809907ee5777bb0155560d3e3d6ced45f88","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        psr \u003d self.operator_cloud.shared_file_system.resync_share_replica("},{"line_number":105,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":106,"context_line":"        self.assertIsNone(psr)"},{"line_number":107,"context_line":"        sot \u003d self.user_cloud.shared_file_system.get_share_replica("},{"line_number":108,"context_line":"            self.SHARE_REPLICA_ID)"},{"line_number":109,"context_line":"        self.assertEqual(\u0027in_sync\u0027, sot.replica_state)"}],"source_content_type":"text/x-python","patch_set":6,"id":"60eb143b_95c9a761","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":54},"in_reply_to":"ba02cddf_5a4a7a8f","updated":"2023-04-20 19:25:51.000000000","message":"Done","commit_id":"a408a506a3f431a02b8ceeba5abab9fbd460fe2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bcef2ed4ae5ce09d0b1bf518234820cdbc8bfe38","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                    share_replica,"},{"line_number":58,"context_line":"                    ignore_missing\u003dTrue"},{"line_number":59,"context_line":"                )"},{"line_number":60,"context_line":"        self.user_cloud.shared_file_system.wait_for_delete("},{"line_number":61,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":62,"context_line":"        sot \u003d self.user_cloud.shared_file_system.delete_share("},{"line_number":63,"context_line":"            self.SHARE_ID,"},{"line_number":64,"context_line":"            ignore_missing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"967342d9_96e5c4d4","line":61,"range":{"start_line":60,"start_character":8,"end_line":61,"end_character":72},"updated":"2023-04-23 03:51:27.000000000","message":"put this inside the loop for correctness:\n\n \n    self.user_cloud.shared_file_system.wait_for_delete(\n            share_replica, interval\u003d2, wait\u003dself._wait_for_timeout)","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"8bd73a2eace62e4cbe397a2b0d8dd5ca8e91e7b1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                    share_replica,"},{"line_number":58,"context_line":"                    ignore_missing\u003dTrue"},{"line_number":59,"context_line":"                )"},{"line_number":60,"context_line":"        self.user_cloud.shared_file_system.wait_for_delete("},{"line_number":61,"context_line":"            self.SHARE_REPLICA, interval\u003d2, wait\u003dself._wait_for_timeout)"},{"line_number":62,"context_line":"        sot \u003d self.user_cloud.shared_file_system.delete_share("},{"line_number":63,"context_line":"            self.SHARE_ID,"},{"line_number":64,"context_line":"            ignore_missing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1c5caac9_399daa0b","line":61,"range":{"start_line":60,"start_character":8,"end_line":61,"end_character":72},"in_reply_to":"967342d9_96e5c4d4","updated":"2024-04-22 19:31:21.000000000","message":"Done","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bcef2ed4ae5ce09d0b1bf518234820cdbc8bfe38","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        self.assertIsNone(psr)"},{"line_number":103,"context_line":"        self.user_cloud.shared_file_system.wait_for_status("},{"line_number":104,"context_line":"            self.SHARE_REPLICA,"},{"line_number":105,"context_line":"            status\u003d\u0027in_sync\u0027,"},{"line_number":106,"context_line":"            failures\u003d[\u0027error\u0027],"},{"line_number":107,"context_line":"            interval\u003d5,"},{"line_number":108,"context_line":"            wait\u003dself._wait_for_timeout,"}],"source_content_type":"text/x-python","patch_set":10,"id":"b4846e50_f8efd3e8","line":105,"range":{"start_line":105,"start_character":20,"end_line":105,"end_character":27},"updated":"2023-04-23 03:51:27.000000000","message":"\"active\"\n\nThe replica that you\u0027re promoting becomes \"active\" if the promotion is succesful..","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"30becf42fcb2f39793e8c3963760c128ae16b9af","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        self.assertIsNone(psr)"},{"line_number":103,"context_line":"        self.user_cloud.shared_file_system.wait_for_status("},{"line_number":104,"context_line":"            self.SHARE_REPLICA,"},{"line_number":105,"context_line":"            status\u003d\u0027in_sync\u0027,"},{"line_number":106,"context_line":"            failures\u003d[\u0027error\u0027],"},{"line_number":107,"context_line":"            interval\u003d5,"},{"line_number":108,"context_line":"            wait\u003dself._wait_for_timeout,"}],"source_content_type":"text/x-python","patch_set":10,"id":"f64d77b2_25685bf3","line":105,"range":{"start_line":105,"start_character":20,"end_line":105,"end_character":27},"in_reply_to":"8fca7bd1_0039586a","updated":"2023-04-24 22:46:30.000000000","message":"\u003e But when I have status\u003d\u0027in_sync\u0027, it doesn\u0027t wait forever.\n\nThat\u0027s because the status is already \"in_sync\" when the promotion begins.. \nWe\u0027ll need to debug why the state isn\u0027t going to \"active\".","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"d777441421c14a23ed20314c0d9066fe7e8eba98","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        self.assertIsNone(psr)"},{"line_number":103,"context_line":"        self.user_cloud.shared_file_system.wait_for_status("},{"line_number":104,"context_line":"            self.SHARE_REPLICA,"},{"line_number":105,"context_line":"            status\u003d\u0027in_sync\u0027,"},{"line_number":106,"context_line":"            failures\u003d[\u0027error\u0027],"},{"line_number":107,"context_line":"            interval\u003d5,"},{"line_number":108,"context_line":"            wait\u003dself._wait_for_timeout,"}],"source_content_type":"text/x-python","patch_set":10,"id":"8fca7bd1_0039586a","line":105,"range":{"start_line":105,"start_character":20,"end_line":105,"end_character":27},"in_reply_to":"b4846e50_f8efd3e8","updated":"2023-04-23 18:16:58.000000000","message":"When I have status\u003d\u0027active\u0027, it waits forever and I see this:\n\nStill waiting for resource ShareReplica:5cfaf974-73e2-433e-af3e-ae7a389de25c to reach state active, current state is in_sync\nWaiting 5.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\nWaiting 2.0 seconds\n....\n....\n....\nBut when I have status\u003d\u0027in_sync\u0027, it doesn\u0027t wait forever.","commit_id":"a9b3f7105328f32563ac9bbae464ad1caf3f1c1b"}]}