)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"54f5e60aee4f814341c3f417266fbb0e63b82fe2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     glyphek \u003cchristopher.parks@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-04 14:11:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Adds service resource to shared file system"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce Service class with the list method to"},{"line_number":10,"context_line":"shared file system storage service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"97d0101f_c4789edd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2023-04-18 18:37:29.000000000","message":"Please remove this [WIP] tag","commit_id":"4815a4def9abd3533ff7d87c68475ad505c5db90"},{"author":{"_account_id":35744},"change_message_id":"6fa866da3038a84d8c2feea93c1c85d57d6fcff6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     glyphek \u003cchristopher.parks@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-04 14:11:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Adds service resource to shared file system"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce Service class with the list method to"},{"line_number":10,"context_line":"shared file system storage service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"0d4ced15_5dcb8c48","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"97d0101f_c4789edd","updated":"2023-04-19 19:48:33.000000000","message":"Done","commit_id":"4815a4def9abd3533ff7d87c68475ad505c5db90"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8c8c9559edc87edf2317d25c77bb023e4758159f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2a3fb8f8_e8e04081","updated":"2023-04-24 23:19:43.000000000","message":"Thank you for updating this change. Please see comment inline regarding the functional tests; this one is close!","commit_id":"1e5ef1ac4eeda8b58fc542b0fd227ad217fc1875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3e3bb77b2f8387e872dceb0dd12c3f9894f82c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"117afb2a_767434b1","updated":"2023-04-27 04:56:47.000000000","message":"Thanks, this needs a few more tweaks","commit_id":"8804ed40998354dedac98c1b4ccb3391c755b5a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c84a5cc6f2d6340530beca44e2cc6f1a261b3244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ebe396ed_1e0cd2a0","updated":"2023-04-27 22:16:20.000000000","message":"The service manipulation test is failing. Did you attempt this locally to debug if the filtering you\u0027re doing works?","commit_id":"808f9dc4c3ce7ba1f655dba0da1c41e02be5c6d6"},{"author":{"_account_id":35744},"change_message_id":"135eac66b65853ad12ea2ffc68df9c87324a8a1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c15db377_1cbdf3c7","in_reply_to":"62a8b1de_d3f0a3ad","updated":"2023-04-29 16:01:40.000000000","message":"Done","commit_id":"808f9dc4c3ce7ba1f655dba0da1c41e02be5c6d6"},{"author":{"_account_id":35744},"change_message_id":"520ad3dce6c28d4660d4fb225b6a0ed3479ab7ae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"62a8b1de_d3f0a3ad","in_reply_to":"87d2d883_cf9d580d","updated":"2023-04-28 22:52:18.000000000","message":"Seems like the alias still isn\u0027t working, I\u0027ll look into it.","commit_id":"808f9dc4c3ce7ba1f655dba0da1c41e02be5c6d6"},{"author":{"_account_id":35744},"change_message_id":"ed41f4af16072ce1a43a8e3a040077afd21cfb11","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"87d2d883_cf9d580d","in_reply_to":"ebe396ed_1e0cd2a0","updated":"2023-04-28 17:01:08.000000000","message":"Ack","commit_id":"808f9dc4c3ce7ba1f655dba0da1c41e02be5c6d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2164867d9f7090280e8322317d73fba475fb2483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"8c17b23d_abb84c0c","updated":"2023-05-01 22:09:01.000000000","message":"Thanks for the changes; some more comments inline..","commit_id":"635b971edea7b7830aaad09b6292a6d861b6d055"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f3abc8b6b8449a0c1e5264b76d3ee125c9d23414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"de0482dd_0a269605","updated":"2023-05-02 18:07:44.000000000","message":"Perfect; thank you!","commit_id":"c7bfc2289535057da828b5dea92c1815628bb709"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"712d748c15a8eb884d07994168104c152aed155b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"a2d36022_ab4f2cd8","updated":"2023-07-17 20:32:08.000000000","message":"recheck","commit_id":"d86f88bb73ff556aea001c75655b1866fbaa6564"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"18b47cbc_e0f92155","updated":"2023-09-12 22:06:15.000000000","message":"Hi Ashley, i\u0027ve some more minor comments inline. Can you please take a look?","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"}],"doc/source/user/proxies/shared_file_system.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"54f5e60aee4f814341c3f417266fbb0e63b82fe2","unresolved":true,"context_lines":[{"line_number":117,"context_line":"Shared File System Services"},{"line_number":118,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Interact with Services supported by the Shared File Systems"},{"line_number":121,"context_line":"service."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"}],"source_content_type":"text/x-rst","patch_set":10,"id":"828f825a_5dd694cc","line":120,"range":{"start_line":120,"start_character":14,"end_line":120,"end_character":22},"updated":"2023-04-18 18:37:29.000000000","message":"micro services","commit_id":"4815a4def9abd3533ff7d87c68475ad505c5db90"},{"author":{"_account_id":35744},"change_message_id":"6fa866da3038a84d8c2feea93c1c85d57d6fcff6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"Shared File System Services"},{"line_number":118,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Interact with Services supported by the Shared File Systems"},{"line_number":121,"context_line":"service."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"}],"source_content_type":"text/x-rst","patch_set":10,"id":"4fcb7a0b_12f73f95","line":120,"range":{"start_line":120,"start_character":14,"end_line":120,"end_character":22},"in_reply_to":"828f825a_5dd694cc","updated":"2023-04-19 19:48:33.000000000","message":"Done","commit_id":"4815a4def9abd3533ff7d87c68475ad505c5db90"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2164867d9f7090280e8322317d73fba475fb2483","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        \"share_export_locations\":"},{"line_number":61,"context_line":"            _share_export_locations.ShareExportLocation,"},{"line_number":62,"context_line":"        \"share_access_rule\": _share_access_rule.ShareAccessRule,"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def availability_zones(self):"},{"line_number":66,"context_line":"        \"\"\"Retrieve shared file system availability zones"}],"source_content_type":"text/x-python","patch_set":24,"id":"550a396c_fb912dae","line":63,"updated":"2023-05-01 22:09:01.000000000","message":"You need to add service to this list","commit_id":"635b971edea7b7830aaad09b6292a6d861b6d055"},{"author":{"_account_id":35744},"change_message_id":"13bee199269c5183050ba49312bd31fdbbabafe5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"share_export_locations\":"},{"line_number":61,"context_line":"            _share_export_locations.ShareExportLocation,"},{"line_number":62,"context_line":"        \"share_access_rule\": _share_access_rule.ShareAccessRule,"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def availability_zones(self):"},{"line_number":66,"context_line":"        \"\"\"Retrieve shared file system availability zones"}],"source_content_type":"text/x-python","patch_set":24,"id":"79a1ebb2_76133113","line":63,"in_reply_to":"550a396c_fb912dae","updated":"2023-05-01 22:19:16.000000000","message":"Oops","commit_id":"635b971edea7b7830aaad09b6292a6d861b6d055"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":1074,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":1075,"context_line":"            the services being returned.  Available parameters include:"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"            * project_id: The project ID of the user or service making"},{"line_number":1078,"context_line":"                the request."},{"line_number":1079,"context_line":"            * host: The service host name."},{"line_number":1080,"context_line":"            * binary: The service binary name."},{"line_number":1081,"context_line":"            * zone: The availability zone."}],"source_content_type":"text/x-python","patch_set":29,"id":"fffdf0a3_202f7043","line":1078,"range":{"start_line":1077,"start_character":11,"end_line":1078,"end_character":28},"updated":"2023-09-12 22:06:15.000000000","message":"this isn\u0027t a valid query param.. please drop","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":1075,"context_line":"            the services being returned.  Available parameters include:"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"            * project_id: The project ID of the user or service making"},{"line_number":1078,"context_line":"                the request."},{"line_number":1079,"context_line":"            * host: The service host name."},{"line_number":1080,"context_line":"            * binary: The service binary name."},{"line_number":1081,"context_line":"            * zone: The availability zone."}],"source_content_type":"text/x-python","patch_set":29,"id":"2910a769_cef4dbb9","line":1078,"range":{"start_line":1077,"start_character":11,"end_line":1078,"end_character":28},"in_reply_to":"fffdf0a3_202f7043","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":1089,"context_line":"        \"\"\""},{"line_number":1090,"context_line":"        return self._list(_service.Service, **query)"},{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":"    def disable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1093,"context_line":"        \"\"\"Disable a service"},{"line_number":1094,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1095,"context_line":"            :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":29,"id":"edc53951_229c4c98","line":1092,"range":{"start_line":1092,"start_character":40,"end_line":1092,"end_character":59},"updated":"2023-09-12 22:06:15.000000000","message":"these params aren\u0027t needed; once you get the service, you know the values of these params..","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"        \"\"\""},{"line_number":1090,"context_line":"        return self._list(_service.Service, **query)"},{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":"    def disable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1093,"context_line":"        \"\"\"Disable a service"},{"line_number":1094,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1095,"context_line":"            :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":29,"id":"03ae5d2c_7b112c7b","line":1092,"range":{"start_line":1092,"start_character":40,"end_line":1092,"end_character":59},"in_reply_to":"edc53951_229c4c98","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":1090,"context_line":"        return self._list(_service.Service, **query)"},{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":"    def disable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1093,"context_line":"        \"\"\"Disable a service"},{"line_number":1094,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1095,"context_line":"            :class:`~openstack.shared_file_system.v2."},{"line_number":1096,"context_line":"            service.Service` instance."},{"line_number":1097,"context_line":"        :param str host: The host where service runs."}],"source_content_type":"text/x-python","patch_set":29,"id":"25597b93_88d241fe","line":1094,"range":{"start_line":1093,"start_character":28,"end_line":1094,"end_character":9},"updated":"2023-09-12 22:06:15.000000000","message":"add a blank line above","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":1090,"context_line":"        return self._list(_service.Service, **query)"},{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":"    def disable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1093,"context_line":"        \"\"\"Disable a service"},{"line_number":1094,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1095,"context_line":"            :class:`~openstack.shared_file_system.v2."},{"line_number":1096,"context_line":"            service.Service` instance."},{"line_number":1097,"context_line":"        :param str host: The host where service runs."}],"source_content_type":"text/x-python","patch_set":29,"id":"efc6b369_608d8271","line":1094,"range":{"start_line":1093,"start_character":28,"end_line":1094,"end_character":9},"in_reply_to":"25597b93_88d241fe","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"            service.Service`"},{"line_number":1103,"context_line":"        \"\"\""},{"line_number":1104,"context_line":"        service \u003d self._get_resource(_service.Service, service)"},{"line_number":1105,"context_line":"        return service.disable(self, host, name)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def enable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1108,"context_line":"        \"\"\"Enable a service"}],"source_content_type":"text/x-python","patch_set":29,"id":"169276a1_839135af","line":1105,"range":{"start_line":1105,"start_character":35,"end_line":1105,"end_character":47},"updated":"2023-09-12 22:06:15.000000000","message":"these params aren\u0027t needed; once you get the service, you know the values of these params..","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"            service.Service`"},{"line_number":1103,"context_line":"        \"\"\""},{"line_number":1104,"context_line":"        service \u003d self._get_resource(_service.Service, service)"},{"line_number":1105,"context_line":"        return service.disable(self, host, name)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def enable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1108,"context_line":"        \"\"\"Enable a service"}],"source_content_type":"text/x-python","patch_set":29,"id":"21649785_62349e1c","line":1105,"range":{"start_line":1105,"start_character":35,"end_line":1105,"end_character":47},"in_reply_to":"169276a1_839135af","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":1104,"context_line":"        service \u003d self._get_resource(_service.Service, service)"},{"line_number":1105,"context_line":"        return service.disable(self, host, name)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def enable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1108,"context_line":"        \"\"\"Enable a service"},{"line_number":1109,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1110,"context_line":"            :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":29,"id":"373446fc_0c936eaf","line":1107,"range":{"start_line":1107,"start_character":39,"end_line":1107,"end_character":58},"updated":"2023-09-12 22:06:15.000000000","message":"these params aren\u0027t needed; once you get the service, you know the values of these params..","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"        service \u003d self._get_resource(_service.Service, service)"},{"line_number":1105,"context_line":"        return service.disable(self, host, name)"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def enable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1108,"context_line":"        \"\"\"Enable a service"},{"line_number":1109,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1110,"context_line":"            :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":29,"id":"8aeb02c7_ce4fd989","line":1107,"range":{"start_line":1107,"start_character":39,"end_line":1107,"end_character":58},"in_reply_to":"373446fc_0c936eaf","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def enable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1108,"context_line":"        \"\"\"Enable a service"},{"line_number":1109,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1110,"context_line":"            :class:`~openstack.shared_file_system.v2."},{"line_number":1111,"context_line":"            service.Service` instance."},{"line_number":1112,"context_line":"        :param str host: The host where service runs."}],"source_content_type":"text/x-python","patch_set":29,"id":"fcfaaf5b_eda0241f","line":1109,"range":{"start_line":1109,"start_character":7,"end_line":1109,"end_character":9},"updated":"2023-09-12 22:06:15.000000000","message":"add a blank line above","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def enable_service(self, service, host\u003dNone, name\u003dNone):"},{"line_number":1108,"context_line":"        \"\"\"Enable a service"},{"line_number":1109,"context_line":"        :param service: Either the ID of a service or a"},{"line_number":1110,"context_line":"            :class:`~openstack.shared_file_system.v2."},{"line_number":1111,"context_line":"            service.Service` instance."},{"line_number":1112,"context_line":"        :param str host: The host where service runs."}],"source_content_type":"text/x-python","patch_set":29,"id":"835377e4_0107f696","line":1109,"range":{"start_line":1109,"start_character":7,"end_line":1109,"end_character":9},"in_reply_to":"fcfaaf5b_eda0241f","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":1117,"context_line":"        \"\"\""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        service \u003d self._get_resource(_service.Service, service)"},{"line_number":1120,"context_line":"        return service.enable(self, host, name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"aa71b920_dffbe8c7","line":1120,"range":{"start_line":1120,"start_character":34,"end_line":1120,"end_character":46},"updated":"2023-09-12 22:06:15.000000000","message":"these params aren\u0027t needed; once you get the service, you know the values of these params..","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"        \"\"\""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        service \u003d self._get_resource(_service.Service, service)"},{"line_number":1120,"context_line":"        return service.enable(self, host, name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"71a08de6_e1ca2393","line":1120,"range":{"start_line":1120,"start_character":34,"end_line":1120,"end_character":46},"in_reply_to":"aa71b920_dffbe8c7","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"}],"openstack/shared_file_system/v2/service.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3e3bb77b2f8387e872dceb0dd12c3f9894f82c43","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    #: The service host name."},{"line_number":41,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":42,"context_line":"    #: Service name"},{"line_number":43,"context_line":"    name \u003d resource.Body(\u0027name\u0027, alias\u003d\u0027binary\u0027)"},{"line_number":44,"context_line":"    #: The current state of the service."},{"line_number":45,"context_line":"    state \u003d resource.Body(\"state\", type\u003dstr)"},{"line_number":46,"context_line":"    #: The service status, which is enabled or disabled."}],"source_content_type":"text/x-python","patch_set":16,"id":"c53ddb6e_276d552d","line":43,"range":{"start_line":43,"start_character":26,"end_line":43,"end_character":30},"updated":"2023-04-27 04:56:47.000000000","message":"the body will contain \"binary\" and you want to alias that to \"name\".. so drop this line, and add \n\n       aka\u003d\"name\" \n   \non line 39 instead","commit_id":"8804ed40998354dedac98c1b4ccb3391c755b5a1"},{"author":{"_account_id":35744},"change_message_id":"7469dead3e6484a9cff2fb740bd87552783808b3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    #: The service host name."},{"line_number":41,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":42,"context_line":"    #: Service name"},{"line_number":43,"context_line":"    name \u003d resource.Body(\u0027name\u0027, alias\u003d\u0027binary\u0027)"},{"line_number":44,"context_line":"    #: The current state of the service."},{"line_number":45,"context_line":"    state \u003d resource.Body(\"state\", type\u003dstr)"},{"line_number":46,"context_line":"    #: The service status, which is enabled or disabled."}],"source_content_type":"text/x-python","patch_set":16,"id":"5a046c19_e99931ae","line":43,"range":{"start_line":43,"start_character":26,"end_line":43,"end_character":30},"in_reply_to":"c53ddb6e_276d552d","updated":"2023-04-28 16:59:06.000000000","message":"Done","commit_id":"8804ed40998354dedac98c1b4ccb3391c755b5a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2164867d9f7090280e8322317d73fba475fb2483","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    #: The service host name."},{"line_number":41,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":42,"context_line":"    #: Service name"},{"line_number":43,"context_line":"    name \u003d resource.Body(\u0027name\u0027, alias\u003d\u0027binary\u0027)"},{"line_number":44,"context_line":"    #: The current state of the service."},{"line_number":45,"context_line":"    state \u003d resource.Body(\"state\", type\u003dstr)"},{"line_number":46,"context_line":"    #: The service status, which is enabled or disabled."}],"source_content_type":"text/x-python","patch_set":24,"id":"c6a1950e_7990bc96","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":48},"updated":"2023-05-01 22:09:01.000000000","message":"these annotations \"alias\" and \"aka\" don\u0027t seem to be working.. \n\n\nthe objective here is to set \"name\" as the resource attribute with the value of whatever the server is setting as \"binary\"... \n\nideally, this should work:\n\n  name \u003d resource.Body(\u0027binary\u0027)\n  \nBut I thought setting \"aka\" on line 39 will have the same effect. Something fishy is going on here.","commit_id":"635b971edea7b7830aaad09b6292a6d861b6d055"},{"author":{"_account_id":35744},"change_message_id":"13bee199269c5183050ba49312bd31fdbbabafe5","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    #: The service host name."},{"line_number":41,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":42,"context_line":"    #: Service name"},{"line_number":43,"context_line":"    name \u003d resource.Body(\u0027name\u0027, alias\u003d\u0027binary\u0027)"},{"line_number":44,"context_line":"    #: The current state of the service."},{"line_number":45,"context_line":"    state \u003d resource.Body(\"state\", type\u003dstr)"},{"line_number":46,"context_line":"    #: The service status, which is enabled or disabled."}],"source_content_type":"text/x-python","patch_set":24,"id":"c157baf6_6481e817","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":48},"in_reply_to":"c6a1950e_7990bc96","updated":"2023-05-01 22:19:16.000000000","message":"Ack","commit_id":"635b971edea7b7830aaad09b6292a6d861b6d055"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self._translate_response(response)"},{"line_number":63,"context_line":"        return self"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def enable(self, session, host, binary):"},{"line_number":66,"context_line":"        \"\"\"Enable service.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027host\u0027: host,"}],"source_content_type":"text/x-python","patch_set":29,"id":"905798ec_4e7362ef","line":65,"range":{"start_line":65,"start_character":30,"end_line":65,"end_character":42},"updated":"2023-09-12 22:06:15.000000000","message":"these params aren\u0027t needed; once you get the service, you know the values of these params..","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self._translate_response(response)"},{"line_number":63,"context_line":"        return self"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def enable(self, session, host, binary):"},{"line_number":66,"context_line":"        \"\"\"Enable service.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027host\u0027: host,"}],"source_content_type":"text/x-python","patch_set":29,"id":"72e20579_bb9e017f","line":65,"range":{"start_line":65,"start_character":30,"end_line":65,"end_character":42},"in_reply_to":"905798ec_4e7362ef","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    def enable(self, session, host, binary):"},{"line_number":66,"context_line":"        \"\"\"Enable service.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027host\u0027: host,"},{"line_number":69,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"25708e4e_86fd08b2","line":68,"range":{"start_line":68,"start_character":20,"end_line":68,"end_character":24},"updated":"2023-09-12 22:06:15.000000000","message":"self.host","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def enable(self, session, host, binary):"},{"line_number":66,"context_line":"        \"\"\"Enable service.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027host\u0027: host,"},{"line_number":69,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"8cefefc1_75209783","line":68,"range":{"start_line":68,"start_character":20,"end_line":68,"end_character":24},"in_reply_to":"25708e4e_86fd08b2","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        \"\"\"Enable service.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027host\u0027: host,"},{"line_number":69,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return self._action(session, \u0027enable\u0027, body)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5fe3ea09_43004e9a","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":28},"updated":"2023-09-12 22:06:15.000000000","message":"self.binary","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \"\"\"Enable service.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027host\u0027: host,"},{"line_number":69,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return self._action(session, \u0027enable\u0027, body)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a8059e2_c70b74df","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":28},"in_reply_to":"5fe3ea09_43004e9a","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return self._action(session, \u0027enable\u0027, body)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def disable(self, session, host, binary):"},{"line_number":75,"context_line":"        \"\"\"Disable service.\"\"\""},{"line_number":76,"context_line":"        body \u003d {"},{"line_number":77,"context_line":"            \u0027host\u0027: host,"}],"source_content_type":"text/x-python","patch_set":29,"id":"00f9ccb1_255bcabe","line":74,"range":{"start_line":74,"start_character":31,"end_line":74,"end_character":43},"updated":"2023-09-12 22:06:15.000000000","message":"these params aren\u0027t needed; once you get the service, you know the values of these params..","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return self._action(session, \u0027enable\u0027, body)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def disable(self, session, host, binary):"},{"line_number":75,"context_line":"        \"\"\"Disable service.\"\"\""},{"line_number":76,"context_line":"        body \u003d {"},{"line_number":77,"context_line":"            \u0027host\u0027: host,"}],"source_content_type":"text/x-python","patch_set":29,"id":"34bbe54d_f21e64c0","line":74,"range":{"start_line":74,"start_character":31,"end_line":74,"end_character":43},"in_reply_to":"00f9ccb1_255bcabe","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":74,"context_line":"    def disable(self, session, host, binary):"},{"line_number":75,"context_line":"        \"\"\"Disable service.\"\"\""},{"line_number":76,"context_line":"        body \u003d {"},{"line_number":77,"context_line":"            \u0027host\u0027: host,"},{"line_number":78,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"4af58c90_32959f4f","line":77,"range":{"start_line":77,"start_character":20,"end_line":77,"end_character":24},"updated":"2023-09-12 22:06:15.000000000","message":"self.host","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def disable(self, session, host, binary):"},{"line_number":75,"context_line":"        \"\"\"Disable service.\"\"\""},{"line_number":76,"context_line":"        body \u003d {"},{"line_number":77,"context_line":"            \u0027host\u0027: host,"},{"line_number":78,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"e7b82a54_511fa988","line":77,"range":{"start_line":77,"start_character":20,"end_line":77,"end_character":24},"in_reply_to":"4af58c90_32959f4f","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c72d066f732b190165571388a8d33735b3ba866","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        \"\"\"Disable service.\"\"\""},{"line_number":76,"context_line":"        body \u003d {"},{"line_number":77,"context_line":"            \u0027host\u0027: host,"},{"line_number":78,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        return self._action(session, \u0027disable\u0027, body)"}],"source_content_type":"text/x-python","patch_set":29,"id":"97d8ddcd_3988ea8d","line":78,"range":{"start_line":78,"start_character":22,"end_line":78,"end_character":28},"updated":"2023-09-12 22:06:15.000000000","message":"self.binary","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5e06c41614872075b1e335558a86fd2b854d23e5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"\"\"Disable service.\"\"\""},{"line_number":76,"context_line":"        body \u003d {"},{"line_number":77,"context_line":"            \u0027host\u0027: host,"},{"line_number":78,"context_line":"            \u0027binary\u0027: binary,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        return self._action(session, \u0027disable\u0027, body)"}],"source_content_type":"text/x-python","patch_set":29,"id":"66184aea_0434ebea","line":78,"range":{"start_line":78,"start_character":22,"end_line":78,"end_character":28},"in_reply_to":"97d8ddcd_3988ea8d","updated":"2024-04-22 19:03:39.000000000","message":"Done","commit_id":"a34a36bb10877afa3d49dd62436bdb0cd2c40a83"}],"openstack/tests/functional/shared_file_system/test_service.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8c8c9559edc87edf2317d25c77bb023e4758159f","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ServiceTest(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_service(self):"},{"line_number":19,"context_line":"        services \u003d self.operator_cloud.shared_file_system.services()"},{"line_number":20,"context_line":"        self.assertIsNotNone(services)"},{"line_number":21,"context_line":"        for service in services:"}],"source_content_type":"text/x-python","patch_set":14,"id":"57fde15b_611991b5","line":18,"updated":"2023-04-24 23:19:43.000000000","message":"The problem i have with tests like these is that we can\u0027t really tell if they\u0027ve done their job. \n\nWe know the proxy call on Line 19 will return a generator, and the generator isn\u0027t going to be \"None\" ever (the SDK would raise an exception and bail if there was a problem executing the API call)... \n\nWe don\u0027t want to lose the goodness of the generator either... so how about we test how many services were there based on our loop?\n\n    num_services \u003d 0\n    for service in services:\n            num_services +\u003d 1\n            for attribute in (\u0027id\u0027, \u0027host\u0027, \u0027updated_at\u0027):\n                self.assertTrue(hasattr(service, attribute))\n                \n    self.assertGreater(0, num_services)","commit_id":"1e5ef1ac4eeda8b58fc542b0fd227ad217fc1875"},{"author":{"_account_id":35744},"change_message_id":"e926a72be9b2759a3fa29949d5befeb6db7695f5","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ServiceTest(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_service(self):"},{"line_number":19,"context_line":"        services \u003d self.operator_cloud.shared_file_system.services()"},{"line_number":20,"context_line":"        self.assertIsNotNone(services)"},{"line_number":21,"context_line":"        for service in services:"}],"source_content_type":"text/x-python","patch_set":14,"id":"dcb1930b_bda2afd6","line":18,"in_reply_to":"57fde15b_611991b5","updated":"2023-04-27 03:46:19.000000000","message":"Done","commit_id":"1e5ef1ac4eeda8b58fc542b0fd227ad217fc1875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8c8c9559edc87edf2317d25c77bb023e4758159f","unresolved":true,"context_lines":[{"line_number":23,"context_line":"                self.assertTrue(hasattr(service, attribute))"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_disable_enable(self):"},{"line_number":26,"context_line":"        for srv in self.operator_cloud.shared_file_system.services():"},{"line_number":27,"context_line":"            if srv.name \u003d\u003d \u0027manila-data\u0027:"},{"line_number":28,"context_line":"                self.operator_cloud.shared_file_system.disable_service("},{"line_number":29,"context_line":"                    srv, srv.host, srv.name)"},{"line_number":30,"context_line":"                self.operator_cloud.shared_file_system.enable_service("},{"line_number":31,"context_line":"                    srv, srv.host, srv.name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"e10edb43_1def00f2","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":44},"updated":"2023-04-24 23:19:43.000000000","message":"same concern as above:\n\n    services_modified \u003d 0\n    for srv in self.operator_cloud.shared_file_system.services():\n            if srv.name \u003d\u003d \u0027manila-data\u0027:\n                self.operator_cloud.shared_file_system.disable_service(\n                    srv, srv.host, srv.name)\n                self.operator_cloud.shared_file_system.enable_service(\n                    srv, srv.host, srv.name)\n                services_modified +\u003d 1\n    self.assertGreater(0, services_modified)","commit_id":"1e5ef1ac4eeda8b58fc542b0fd227ad217fc1875"},{"author":{"_account_id":35744},"change_message_id":"e926a72be9b2759a3fa29949d5befeb6db7695f5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                self.assertTrue(hasattr(service, attribute))"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_disable_enable(self):"},{"line_number":26,"context_line":"        for srv in self.operator_cloud.shared_file_system.services():"},{"line_number":27,"context_line":"            if srv.name \u003d\u003d \u0027manila-data\u0027:"},{"line_number":28,"context_line":"                self.operator_cloud.shared_file_system.disable_service("},{"line_number":29,"context_line":"                    srv, srv.host, srv.name)"},{"line_number":30,"context_line":"                self.operator_cloud.shared_file_system.enable_service("},{"line_number":31,"context_line":"                    srv, srv.host, srv.name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"543693fd_3cadec1c","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":44},"in_reply_to":"e10edb43_1def00f2","updated":"2023-04-27 03:46:19.000000000","message":"Done","commit_id":"1e5ef1ac4eeda8b58fc542b0fd227ad217fc1875"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3e3bb77b2f8387e872dceb0dd12c3f9894f82c43","unresolved":true,"context_lines":[{"line_number":23,"context_line":"            num_services +\u003d 1"},{"line_number":24,"context_line":"            for attribute in (\u0027id\u0027, \u0027host\u0027, \u0027updated_at\u0027):"},{"line_number":25,"context_line":"                self.assertTrue(hasattr(service, attribute))"},{"line_number":26,"context_line":"        self.assertGreater(0, num_services)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_disable_enable(self):"},{"line_number":29,"context_line":"        services_modified \u003d 0"}],"source_content_type":"text/x-python","patch_set":16,"id":"257c0f4b_35168cf0","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":43},"updated":"2023-04-27 04:56:47.000000000","message":"the order of assert is incorrect here.. \n\n    self.assertGreater(num_services, 0)","commit_id":"8804ed40998354dedac98c1b4ccb3391c755b5a1"},{"author":{"_account_id":35744},"change_message_id":"7469dead3e6484a9cff2fb740bd87552783808b3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            num_services +\u003d 1"},{"line_number":24,"context_line":"            for attribute in (\u0027id\u0027, \u0027host\u0027, \u0027updated_at\u0027):"},{"line_number":25,"context_line":"                self.assertTrue(hasattr(service, attribute))"},{"line_number":26,"context_line":"        self.assertGreater(0, num_services)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_disable_enable(self):"},{"line_number":29,"context_line":"        services_modified \u003d 0"}],"source_content_type":"text/x-python","patch_set":16,"id":"b97f9b17_4646749a","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":43},"in_reply_to":"257c0f4b_35168cf0","updated":"2023-04-28 16:59:06.000000000","message":"Done","commit_id":"8804ed40998354dedac98c1b4ccb3391c755b5a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3e3bb77b2f8387e872dceb0dd12c3f9894f82c43","unresolved":true,"context_lines":[{"line_number":34,"context_line":"                self.operator_cloud.shared_file_system.enable_service("},{"line_number":35,"context_line":"                    srv, srv.host, srv.name)"},{"line_number":36,"context_line":"                services_modified +\u003d 1"},{"line_number":37,"context_line":"        self.assertGreater(0, services_modified)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ef9262db_f29c6d8e","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":48},"updated":"2023-04-27 04:56:47.000000000","message":"same comment as above, but this test seems to be failing to modify any service... that\u0027s because \"name\" doesn\u0027t map to anything.. see my comment in service.py\n\n AssertionError: 0 not greater than 5","commit_id":"8804ed40998354dedac98c1b4ccb3391c755b5a1"},{"author":{"_account_id":35744},"change_message_id":"7469dead3e6484a9cff2fb740bd87552783808b3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                self.operator_cloud.shared_file_system.enable_service("},{"line_number":35,"context_line":"                    srv, srv.host, srv.name)"},{"line_number":36,"context_line":"                services_modified +\u003d 1"},{"line_number":37,"context_line":"        self.assertGreater(0, services_modified)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5049f552_61e527c6","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":48},"in_reply_to":"ef9262db_f29c6d8e","updated":"2023-04-28 16:59:06.000000000","message":"Done","commit_id":"8804ed40998354dedac98c1b4ccb3391c755b5a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2164867d9f7090280e8322317d73fba475fb2483","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_disable_enable(self):"},{"line_number":29,"context_line":"        services_modified \u003d 0"},{"line_number":30,"context_line":"        for srv in self.operator_cloud.shared_file_system.services():"},{"line_number":31,"context_line":"            if srv.name \u003d\u003d \u0027manila-data\u0027:"},{"line_number":32,"context_line":"                self.operator_cloud.shared_file_system.disable_service("},{"line_number":33,"context_line":"                    srv, srv.host, srv.name)"},{"line_number":34,"context_line":"                self.operator_cloud.shared_file_system.enable_service("}],"source_content_type":"text/x-python","patch_set":24,"id":"4605891a_1570d55a","line":31,"range":{"start_line":30,"start_character":8,"end_line":31,"end_character":41},"updated":"2023-05-01 22:09:01.000000000","message":"While this is okay, i like the previous approach of exercising the name query directly.. using that way will test that queries and the specific query mapping (\"name\" is actually \"binary\") is working. \n\nI tested your patch on my system, and that works fine:\n\n\n\n    \u003e\u003e\u003e list(ds.share.services(name\u003d\u0027manila-data\u0027))\n    [openstack.shared_file_system.v2.service.Service(id\u003d3, binary\u003dmanila-data, host\u003dzorilla-antelope, zone\u003dnova, status\u003denabled, state\u003dup, updated_at\u003d2023-05-01T20:12:11.073006, location\u003dMunch({\u0027cloud\u0027: \u0027devstack-admin\u0027, \u0027region_name\u0027: \u0027RegionOne\u0027, \u0027zone\u0027: \u0027nova\u0027, \u0027project\u0027: Munch({\u0027id\u0027: \u0027850db2ecbdee4b7cbae2ce0073cdcfde\u0027, \u0027name\u0027: \u0027admin\u0027, \u0027domain_id\u0027: \u0027default\u0027, \u0027domain_name\u0027: None})}))]\n    \n    \u003e\u003e\u003e list(ds.share.services(name\u003d\u0027manila-data\u0027)) \u003d\u003d \n    list(ds.share.services(binary\u003d\u0027manila-data\u0027))\n    True","commit_id":"635b971edea7b7830aaad09b6292a6d861b6d055"},{"author":{"_account_id":35744},"change_message_id":"13bee199269c5183050ba49312bd31fdbbabafe5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_disable_enable(self):"},{"line_number":29,"context_line":"        services_modified \u003d 0"},{"line_number":30,"context_line":"        for srv in self.operator_cloud.shared_file_system.services():"},{"line_number":31,"context_line":"            if srv.name \u003d\u003d \u0027manila-data\u0027:"},{"line_number":32,"context_line":"                self.operator_cloud.shared_file_system.disable_service("},{"line_number":33,"context_line":"                    srv, srv.host, srv.name)"},{"line_number":34,"context_line":"                self.operator_cloud.shared_file_system.enable_service("}],"source_content_type":"text/x-python","patch_set":24,"id":"a5be44fd_46cfe93e","line":31,"range":{"start_line":30,"start_character":8,"end_line":31,"end_character":41},"in_reply_to":"4605891a_1570d55a","updated":"2023-05-01 22:19:16.000000000","message":"My bad, I made that change and must have accidentally reverted it.","commit_id":"635b971edea7b7830aaad09b6292a6d861b6d055"}]}