)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"79906acca7dbe9eb081fe052742b5b8d68b309d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ca6644e3_7005da13","updated":"2023-03-24 09:50:17.000000000","message":"Good work, few issues need to be resolved though","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"33f086cd8e00ae22290126109452ecabfb385379","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18cea759_3947ee84","updated":"2023-02-28 03:44:51.000000000","message":"LGTM from the Designate side","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ba0c0c7b41383b83ca049c90eb4c67c401b21948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fdd6767f_49865ed9","updated":"2023-10-11 17:34:43.000000000","message":"Fix proposed here: https://review.opendev.org/c/openstack/openstacksdk/+/897995","commit_id":"a7456043289e833fc459fec7144bf1f0c1ddddc0"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3157d0ec1b685f6a9ddca7b313f0577e7f43b7e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9bd7bbfd_b2032cbe","updated":"2023-10-11 14:20:04.000000000","message":"Hi i reported https://bugs.launchpad.net/neutron/+bug/2039066 as functional jobs(with openstacksdk master) running before stable/2023.1 are failing since this patch.\nIs it fine to not use openstacksdk master in those jobs before stable/2023.1 or something else needs to be done?","commit_id":"a7456043289e833fc459fec7144bf1f0c1ddddc0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"96bc0e527762556312be80e1e03f87797880c036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c92a9ee5_e0ae428f","updated":"2023-03-31 22:42:02.000000000","message":"LGTM from the Designate side","commit_id":"a7456043289e833fc459fec7144bf1f0c1ddddc0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14f3e980b2d7d170b670988193fd51691bae5c42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b006c90d_efafb6a6","updated":"2023-04-21 16:26:32.000000000","message":"Looks like all of Artem\u0027s comments were address. LGTM","commit_id":"a7456043289e833fc459fec7144bf1f0c1ddddc0"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fbd814882b774957de7e96b5dc0dce438e70015f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ef881493_59a464d2","in_reply_to":"9bd7bbfd_b2032cbe","updated":"2023-10-11 14:52:37.000000000","message":"ugh oh, that sucks. There is a tendency of not using master sdk in stable branches in the services themselves (for testing OSC and sdk itself it should be fine).\n- The best approach would be of course to add feature detection, but that will likely not going to happen. Maybe we can improve the test by skipping if we get 405 back\n- alternative is to skip those tests on older branches. I have no idea right now how to do this.\n\nLet\u0027s see whether https://review.opendev.org/c/openstack/openstacksdk/+/897958 can help","commit_id":"a7456043289e833fc459fec7144bf1f0c1ddddc0"}],"openstack/dns/v2/zone.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"79906acca7dbe9eb081fe052742b5b8d68b309d4","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":82,"context_line":"    #: Whether the zone is shared with other projects"},{"line_number":83,"context_line":"    #: *Type: bool*"},{"line_number":84,"context_line":"    shared \u003d resource.Body(\u0027shared\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Headers for DELETE requests"},{"line_number":87,"context_line":"    #: If true, delete any existing zone shares along with the zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"c10562fc_f03cb442","line":84,"updated":"2023-03-24 09:50:17.000000000","message":"in SDK there is a convention, that all bool properties are prefixed with \"is_\" to clearly visualize attribute type.","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a512ce9c4d5fc063a918e54e05c42dfd658bbe4c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":82,"context_line":"    #: Whether the zone is shared with other projects"},{"line_number":83,"context_line":"    #: *Type: bool*"},{"line_number":84,"context_line":"    shared \u003d resource.Body(\u0027shared\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Headers for DELETE requests"},{"line_number":87,"context_line":"    #: If true, delete any existing zone shares along with the zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"efce651b_6ebe333c","line":84,"in_reply_to":"3ef3b3af_c17e99c0","updated":"2023-04-11 14:38:18.000000000","message":"Done","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"22a4834a5ba228fd33fb22f3bb87c7ac37e09ebb","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":82,"context_line":"    #: Whether the zone is shared with other projects"},{"line_number":83,"context_line":"    #: *Type: bool*"},{"line_number":84,"context_line":"    shared \u003d resource.Body(\u0027shared\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Headers for DELETE requests"},{"line_number":87,"context_line":"    #: If true, delete any existing zone shares along with the zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ef3b3af_c17e99c0","line":84,"in_reply_to":"c10562fc_f03cb442","updated":"2023-03-31 19:40:38.000000000","message":"Yep, I remember that now. It\u0027s been a while since I have worked on SDK. sigh\nThanks for catching this!","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"}],"openstack/tests/functional/dns/v2/test_zone_share.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"79906acca7dbe9eb081fe052742b5b8d68b309d4","unresolved":true,"context_lines":[{"line_number":24,"context_line":"        if not self.user_cloud:"},{"line_number":25,"context_line":"            self.skipTest(\"The demo cloud is required for this test\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        self.conn \u003d connection.from_config(cloud_name\u003dbase.TEST_CLOUD_NAME)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        # Note: zone deletion is not an immediate operation, so each time"},{"line_number":30,"context_line":"        # chose a new zone name for a test"}],"source_content_type":"text/x-python","patch_set":1,"id":"60be78b7_f0b66a8a","line":27,"updated":"2023-03-24 09:50:17.000000000","message":"you do not need this. self.user_cloud is already a connection to cloud with regular user privileges. Please use it instead","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a53aa849bfd3f822a27f0bac7553c9f8cf10e41f","unresolved":true,"context_lines":[{"line_number":24,"context_line":"        if not self.user_cloud:"},{"line_number":25,"context_line":"            self.skipTest(\"The demo cloud is required for this test\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        self.conn \u003d connection.from_config(cloud_name\u003dbase.TEST_CLOUD_NAME)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        # Note: zone deletion is not an immediate operation, so each time"},{"line_number":30,"context_line":"        # chose a new zone name for a test"}],"source_content_type":"text/x-python","patch_set":1,"id":"616554ef_6f2a6b36","line":27,"in_reply_to":"60be78b7_f0b66a8a","updated":"2023-03-31 20:07:44.000000000","message":"Actually, this test is using two different projects, so I can\u0027t use self.user_cloud, but I see that there is self.operator_cloud, which is actually what I need here.","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a512ce9c4d5fc063a918e54e05c42dfd658bbe4c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        if not self.user_cloud:"},{"line_number":25,"context_line":"            self.skipTest(\"The demo cloud is required for this test\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        self.conn \u003d connection.from_config(cloud_name\u003dbase.TEST_CLOUD_NAME)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        # Note: zone deletion is not an immediate operation, so each time"},{"line_number":30,"context_line":"        # chose a new zone name for a test"}],"source_content_type":"text/x-python","patch_set":1,"id":"026edb41_995369d9","line":27,"in_reply_to":"616554ef_6f2a6b36","updated":"2023-04-11 14:38:18.000000000","message":"Done","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"}],"openstack/tests/unit/dns/v2/test_zone.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"79906acca7dbe9eb081fe052742b5b8d68b309d4","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        self.assertEqual(EXAMPLE[\u0027type\u0027], sot.type)"},{"line_number":78,"context_line":"        self.assertEqual(EXAMPLE[\u0027name\u0027], sot.name)"},{"line_number":79,"context_line":"        self.assertEqual(EXAMPLE[\u0027status\u0027], sot.status)"},{"line_number":80,"context_line":"        self.assertEqual(EXAMPLE[\u0027shared\u0027], sot.shared)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_abandon(self):"},{"line_number":83,"context_line":"        sot \u003d zone.Zone(**EXAMPLE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1cae23a4_3c63d6a5","line":80,"updated":"2023-03-24 09:50:17.000000000","message":"here you would compare with sot.is_shared","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a512ce9c4d5fc063a918e54e05c42dfd658bbe4c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.assertEqual(EXAMPLE[\u0027type\u0027], sot.type)"},{"line_number":78,"context_line":"        self.assertEqual(EXAMPLE[\u0027name\u0027], sot.name)"},{"line_number":79,"context_line":"        self.assertEqual(EXAMPLE[\u0027status\u0027], sot.status)"},{"line_number":80,"context_line":"        self.assertEqual(EXAMPLE[\u0027shared\u0027], sot.shared)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_abandon(self):"},{"line_number":83,"context_line":"        sot \u003d zone.Zone(**EXAMPLE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dabff1e1_ef034c79","line":80,"in_reply_to":"1cae23a4_3c63d6a5","updated":"2023-04-11 14:38:18.000000000","message":"Done","commit_id":"7bb712a48d415dacbee5dac47ec8a1c3e995445b"}]}