)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"a9c41b68b1cdb438f8501138c35f410030199801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29b2d737_00712198","updated":"2023-03-10 08:48:55.000000000","message":"Please add also here entry into docs, otherwise fine","commit_id":"acc1db1555fd1f3769334a4065af0b8bf7a1bb39"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"b879f9af31f96708f5fc186739fd89a2fca1c4f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34900577_49c0972e","in_reply_to":"29b2d737_00712198","updated":"2023-03-13 06:17:37.000000000","message":"Ack, will add the docmentation in a separate patch","commit_id":"acc1db1555fd1f3769334a4065af0b8bf7a1bb39"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e747209f16934ff265241d35d153097a8fdbb229","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec89d38a_e1f88549","in_reply_to":"34900577_49c0972e","updated":"2023-03-20 11:46:40.000000000","message":"If you can do this here, we can merge this","commit_id":"acc1db1555fd1f3769334a4065af0b8bf7a1bb39"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"57406b6ba2c8106d112fb948231f9588688b0e6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ab019c3_de57db10","in_reply_to":"ec89d38a_e1f88549","updated":"2023-03-20 13:22:35.000000000","message":"Done","commit_id":"acc1db1555fd1f3769334a4065af0b8bf7a1bb39"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5ee2aae0e5a76b417ca4103bfb206540f705120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9338430e_49c6b380","updated":"2023-03-20 18:24:16.000000000","message":"One further comment inline","commit_id":"3882d0a79b5e67cd55c378b41424a6167c5f1d5b"}],"openstack/image/v2/cache.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5ee2aae0e5a76b417ca4103bfb206540f705120","unresolved":true,"context_lines":[{"line_number":33,"context_line":"                                  list_type\u003dCachedImage)"},{"line_number":34,"context_line":"    queued_images \u003d resource.Body(\u0027queued_images\u0027, type\u003dlist)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def clear(self, session, target\u003d\u0027both\u0027):"},{"line_number":37,"context_line":"        \"\"\"Clears the cache."},{"line_number":38,"context_line":"        :param session: The session to use for making this request"},{"line_number":39,"context_line":"        :param target: Specify which target you want to clear"}],"source_content_type":"text/x-python","patch_set":3,"id":"d74fe24d_e87f400e","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":42},"updated":"2023-03-20 18:24:16.000000000","message":"Rather than doing this, couldn\u0027t we default to None and only allow None, \u0027cache\u0027 or \u0027queue\u0027?","commit_id":"3882d0a79b5e67cd55c378b41424a6167c5f1d5b"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"8464540a7085ff242b37a09ed8d827d00506116f","unresolved":true,"context_lines":[{"line_number":33,"context_line":"                                  list_type\u003dCachedImage)"},{"line_number":34,"context_line":"    queued_images \u003d resource.Body(\u0027queued_images\u0027, type\u003dlist)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def clear(self, session, target\u003d\u0027both\u0027):"},{"line_number":37,"context_line":"        \"\"\"Clears the cache."},{"line_number":38,"context_line":"        :param session: The session to use for making this request"},{"line_number":39,"context_line":"        :param target: Specify which target you want to clear"}],"source_content_type":"text/x-python","patch_set":3,"id":"b1616f28_e0a395e0","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":42},"in_reply_to":"d74fe24d_e87f400e","updated":"2023-03-21 05:56:04.000000000","message":"None will imply it does not delete anything, hence we are using \u0027both\u0027 as default","commit_id":"3882d0a79b5e67cd55c378b41424a6167c5f1d5b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7fa17a2e20e9fd128fc79cc42907da6082cd814e","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        :returns: The server response"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        headers \u003d {}"},{"line_number":62,"context_line":"        if target !\u003d \"both\":"},{"line_number":63,"context_line":"            headers \u003d {\u0027x-image-cache-clear-target\u0027: target}"},{"line_number":64,"context_line":"        response \u003d session.delete(self.base_path, headers\u003dheaders)"},{"line_number":65,"context_line":"        exceptions.raise_from_response(response)"},{"line_number":66,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":4,"id":"c927130a_13ef0643","line":63,"range":{"start_line":62,"start_character":8,"end_line":63,"end_character":60},"updated":"2024-03-15 07:12:01.000000000","message":"I\u0027m failing to understand the purpose of this string \u0027both\u0027\nIf we just use None as default (as Stephen said), this logic could be simplified\n\n    def clear(self, session, target\u003dNone):\n    ...\n        if target:\n            headers \u003d {\u0027x-image-cache-clear-target\u0027: target}","commit_id":"a9614648c6a705bf85a6cf8d134b3125304b318b"}]}