)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"70854563263095b2f85b77150ba83fa493a476b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99ccbb44_d40de6ba","updated":"2023-03-29 05:33:40.000000000","message":"I\u0027m a bit worried about the amount of existing code being touched here and I wonder if that could be reduced.\n\nDoes your use case really require selection of specific resources or might skipping per service be good enough? The latter would be possible by just adding an early return everywhere.\n\nAlso this will need a release note and possibly some documentation.","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"79820b1e90f8a056bca5273802e285d63824e24b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d761ae80_c5244e46","in_reply_to":"99ccbb44_d40de6ba","updated":"2023-03-30 14:37:03.000000000","message":"Indeed a lot of code without required changes is touched due to indentation. However, our use case for this feature is specifically to be able to skip resources on a resource level, not just per service (e. g. keep backups, but cleanup volumes and snapshots).","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"b652f35e3c99068126a7f1031e20f50add3e1a2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3aa932fa_c1e9a32f","updated":"2023-03-31 14:22:02.000000000","message":"recheck","commit_id":"1d5a26000ec3171f461131a6fbd0fc3cc2213cf8"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"784e7ac8e0e9ae1cde57cd9f7d26afde064e9389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4fa81e65_a3602a4a","updated":"2023-04-12 12:32:48.000000000","message":"recheck","commit_id":"b7429ee75beeb656aeeeb2c5caf1912c889f0ec8"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"ac1ba4d00995f6c59561772419650d23aacc0159","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e8b2d5e5_4d95fc3d","updated":"2023-04-12 10:51:34.000000000","message":"recheck","commit_id":"b7429ee75beeb656aeeeb2c5caf1912c889f0ec8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"845e5423ed477fe0fd54d94edcc44412d9a026e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3874a0bf_86a3dcc2","updated":"2023-05-17 09:05:31.000000000","message":"Just fixed the pep8 issue (by rebasing and running \u0027pre-commit run -a\u0027)","commit_id":"039bd6dcba050302a12b9f2f61189b14a3416d21"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"08b3ca8e953600dec5afdbe6e5b20c12b98e7a1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"60a7fae2_f005af50","updated":"2023-06-12 12:57:53.000000000","message":"Has this a chance to get merged soon?","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"3390072ce72015d7c4454c58fbc080f50815ba5e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3cf8e9d7_ee1eb231","updated":"2023-07-14 12:36:58.000000000","message":"Could you kindly take another look at this feature?\nWould be nice to have this.","commit_id":"068cc997d570b1bcc28075517639c4c76bf5787a"}],"openstack/block_storage/v3/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":1644,"context_line":"        # required to limit amount of iterations we do (currently pick 10).  In"},{"line_number":1645,"context_line":"        # dry_run all those iterations are doing not what we want, therefore"},{"line_number":1646,"context_line":"        # only iterate in a real cleanup mode."},{"line_number":1647,"context_line":"        if not self.should_skip_resource_cleanup(\"backup\", skip_resources):"},{"line_number":1648,"context_line":"            if dry_run:"},{"line_number":1649,"context_line":"                # Just iterate and evaluate backups in dry_run mode"},{"line_number":1650,"context_line":"                for obj in self.backups(details\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"091695e1_86c536c9","line":1647,"updated":"2023-06-14 23:04:58.000000000","message":"1) backup should be block_storage.backup\n2) let\u0027s do `self.should_skip_resource_cleanup(\"backup\", skip_resources): then return` instead to not to have additional indentation","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"449c5410df4cd6bc5770f4a3c8295dc0fbcdf7b8","unresolved":true,"context_lines":[{"line_number":1644,"context_line":"        # required to limit amount of iterations we do (currently pick 10).  In"},{"line_number":1645,"context_line":"        # dry_run all those iterations are doing not what we want, therefore"},{"line_number":1646,"context_line":"        # only iterate in a real cleanup mode."},{"line_number":1647,"context_line":"        if not self.should_skip_resource_cleanup(\"backup\", skip_resources):"},{"line_number":1648,"context_line":"            if dry_run:"},{"line_number":1649,"context_line":"                # Just iterate and evaluate backups in dry_run mode"},{"line_number":1650,"context_line":"                for obj in self.backups(details\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"4145c385_0e72659b","line":1647,"in_reply_to":"091695e1_86c536c9","updated":"2023-06-15 13:02:12.000000000","message":"1) The service type is currently read in the should_skip_resource_cleanup method in proxy.py (from self.service_type) so that proxies do not need to re-specify their own type again when calling this method, but only the resource type. Are there issues with the current implementation?\n\n2) This would imply to also skip resource cleanup of snapshots and volumes when the user just wants to skip backups. I think this would not be the expected result.","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"}],"openstack/cloud/openstackcloud.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":855,"context_line":"        status_queue\u003dNone,"},{"line_number":856,"context_line":"        filters\u003dNone,"},{"line_number":857,"context_line":"        resource_evaluation_fn\u003dNone,"},{"line_number":858,"context_line":"        skip_resources\u003d[],"},{"line_number":859,"context_line":"    ):"},{"line_number":860,"context_line":"        \"\"\"Cleanup the project resources."},{"line_number":861,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"0a7b4688_bf4920b9","line":858,"updated":"2023-06-14 23:04:58.000000000","message":"1) can you please add a docstring on the new parameter\n2) please do not have an empty list as default (read https://nikos7am.com/posts/mutable-default-arguments/ for explanation)","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"449c5410df4cd6bc5770f4a3c8295dc0fbcdf7b8","unresolved":false,"context_lines":[{"line_number":855,"context_line":"        status_queue\u003dNone,"},{"line_number":856,"context_line":"        filters\u003dNone,"},{"line_number":857,"context_line":"        resource_evaluation_fn\u003dNone,"},{"line_number":858,"context_line":"        skip_resources\u003d[],"},{"line_number":859,"context_line":"    ):"},{"line_number":860,"context_line":"        \"\"\"Cleanup the project resources."},{"line_number":861,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"832d54e0_6a710a11","line":858,"in_reply_to":"0a7b4688_bf4920b9","updated":"2023-06-15 13:02:12.000000000","message":"Ack","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"}],"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"70854563263095b2f85b77150ba83fa493a476b9","unresolved":true,"context_lines":[{"line_number":2420,"context_line":"                         filters\u003dNone, resource_evaluation_fn\u003dNone,"},{"line_number":2421,"context_line":"                         skip_resources\u003dNone):"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"        if not self.should_skip_resource_cleanup(\"server\", skip_resources):"},{"line_number":2424,"context_line":"            servers \u003d []"},{"line_number":2425,"context_line":"            for obj in self.servers():"},{"line_number":2426,"context_line":"                need_delete \u003d self._service_cleanup_del_res("}],"source_content_type":"text/x-python","patch_set":1,"id":"be314ba8_20c4832f","line":2423,"range":{"start_line":2423,"start_character":8,"end_line":2423,"end_character":75},"updated":"2023-03-29 05:33:40.000000000","message":"If you make this\n\n  if self.should_skip_resource_cleanup(\"server\", skip_resources):\n      return\n    \nyou can avoid reindenting the remainder of the code.","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"5c225620d83bff83a0dba9c3eb979d37d041d3a6","unresolved":false,"context_lines":[{"line_number":2420,"context_line":"                         filters\u003dNone, resource_evaluation_fn\u003dNone,"},{"line_number":2421,"context_line":"                         skip_resources\u003dNone):"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"        if not self.should_skip_resource_cleanup(\"server\", skip_resources):"},{"line_number":2424,"context_line":"            servers \u003d []"},{"line_number":2425,"context_line":"            for obj in self.servers():"},{"line_number":2426,"context_line":"                need_delete \u003d self._service_cleanup_del_res("}],"source_content_type":"text/x-python","patch_set":1,"id":"9392fe5f_8932bdd1","line":2423,"range":{"start_line":2423,"start_character":8,"end_line":2423,"end_character":75},"in_reply_to":"7eb8ab40_82ca387e","updated":"2023-03-30 14:56:10.000000000","message":"Done","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"79820b1e90f8a056bca5273802e285d63824e24b","unresolved":true,"context_lines":[{"line_number":2420,"context_line":"                         filters\u003dNone, resource_evaluation_fn\u003dNone,"},{"line_number":2421,"context_line":"                         skip_resources\u003dNone):"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"        if not self.should_skip_resource_cleanup(\"server\", skip_resources):"},{"line_number":2424,"context_line":"            servers \u003d []"},{"line_number":2425,"context_line":"            for obj in self.servers():"},{"line_number":2426,"context_line":"                need_delete \u003d self._service_cleanup_del_res("}],"source_content_type":"text/x-python","patch_set":1,"id":"7eb8ab40_82ca387e","line":2423,"range":{"start_line":2423,"start_character":8,"end_line":2423,"end_character":75},"in_reply_to":"be314ba8_20c4832f","updated":"2023-03-30 14:37:03.000000000","message":"In the current state, yes. But when another Nova resource is added to project cleanup, this would also need indentation, that\u0027s why I added it this way (and also to be consistent with the other files).\n\nOf course, an early return can be used here until more skippable resources are added. I will edit it to have less code change right now.","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":2531,"context_line":"        resource_evaluation_fn\u003dNone,"},{"line_number":2532,"context_line":"        skip_resources\u003dNone,"},{"line_number":2533,"context_line":"    ):"},{"line_number":2534,"context_line":"        if self.should_skip_resource_cleanup(\"server\", skip_resources):"},{"line_number":2535,"context_line":"            return"},{"line_number":2536,"context_line":""},{"line_number":2537,"context_line":"        servers \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"ed0a95b8_7cb2b316","line":2534,"updated":"2023-06-14 23:04:58.000000000","message":"\"compute.server\" instead of \"server\"","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"}],"openstack/dns/v2/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":669,"context_line":"        resource_evaluation_fn\u003dNone,"},{"line_number":670,"context_line":"        skip_resources\u003dNone,"},{"line_number":671,"context_line":"    ):"},{"line_number":672,"context_line":"        if not self.should_skip_resource_cleanup(\"zone\", skip_resources):"},{"line_number":673,"context_line":"            # Delete all zones"},{"line_number":674,"context_line":"            for obj in self.zones():"},{"line_number":675,"context_line":"                self._service_cleanup_del_res("}],"source_content_type":"text/x-python","patch_set":9,"id":"0a4033de_c39ff4dc","line":672,"updated":"2023-06-14 23:04:58.000000000","message":"\"dns.zone\" instead of \"zone\"","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":683,"context_line":"                )"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        if not self.should_skip_resource_cleanup("},{"line_number":686,"context_line":"            \"floating_ip\", skip_resources"},{"line_number":687,"context_line":"        ):"},{"line_number":688,"context_line":"            # Unset all floatingIPs"},{"line_number":689,"context_line":"            # NOTE: FloatingIPs are not cleaned when filters are set"}],"source_content_type":"text/x-python","patch_set":9,"id":"3c12fe59_babc733a","line":686,"updated":"2023-06-14 23:04:58.000000000","message":"\"dns.floating_ip\" - otherwise also network.floating_ip is going to be respected as well","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"}],"openstack/network/v2/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":6217,"context_line":"        project_id \u003d self.get_project_id()"},{"line_number":6218,"context_line":""},{"line_number":6219,"context_line":"        if not self.should_skip_resource_cleanup("},{"line_number":6220,"context_line":"            \"floating_ip\", skip_resources"},{"line_number":6221,"context_line":"        ):"},{"line_number":6222,"context_line":"            # Delete floating_ips in the project if no filters defined OR all"},{"line_number":6223,"context_line":"            # filters are matching and port_id is empty"}],"source_content_type":"text/x-python","patch_set":9,"id":"8c330faa_76ee7ab7","line":6220,"updated":"2023-06-14 23:04:58.000000000","message":"network.floating_ip","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":6233,"context_line":"                )"},{"line_number":6234,"context_line":""},{"line_number":6235,"context_line":"        if not self.should_skip_resource_cleanup("},{"line_number":6236,"context_line":"            \"security_group\", skip_resources"},{"line_number":6237,"context_line":"        ):"},{"line_number":6238,"context_line":"            # Delete (try to delete) all security groups in the project"},{"line_number":6239,"context_line":"            # Let\u0027s hope we can\u0027t drop SG in use"}],"source_content_type":"text/x-python","patch_set":9,"id":"9335701c_ec9e09c2","line":6236,"updated":"2023-06-14 23:04:58.000000000","message":"network.security_group","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":6250,"context_line":"                    )"},{"line_number":6251,"context_line":""},{"line_number":6252,"context_line":"        if ("},{"line_number":6253,"context_line":"            not self.should_skip_resource_cleanup(\"network\", skip_resources)"},{"line_number":6254,"context_line":"            and not self.should_skip_resource_cleanup(\"port\", skip_resources)"},{"line_number":6255,"context_line":"            and not self.should_skip_resource_cleanup(\"subnet\", skip_resources)"},{"line_number":6256,"context_line":"        ):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fbcd5db9_50e4f52a","line":6253,"updated":"2023-06-14 23:04:58.000000000","message":"\"network.\" prefix here as well","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":6370,"context_line":"                \"excluded, but at least one should be kept\""},{"line_number":6371,"context_line":"            )"},{"line_number":6372,"context_line":""},{"line_number":6373,"context_line":"        if not self.should_skip_resource_cleanup(\"router\", skip_resources):"},{"line_number":6374,"context_line":"            # It might happen, that we have routers not attached to anything"},{"line_number":6375,"context_line":"            for obj in self.routers():"},{"line_number":6376,"context_line":"                ports \u003d list(self.ports(device_id\u003dobj.id))"}],"source_content_type":"text/x-python","patch_set":9,"id":"6e5ae34f_b3aecedc","line":6373,"updated":"2023-06-14 23:04:58.000000000","message":"network.router","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"}],"openstack/object_store/v1/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":1132,"context_line":"        resource_evaluation_fn\u003dNone,"},{"line_number":1133,"context_line":"        skip_resources\u003dNone,"},{"line_number":1134,"context_line":"    ):"},{"line_number":1135,"context_line":"        if self.should_skip_resource_cleanup(\"container\", skip_resources):"},{"line_number":1136,"context_line":"            return"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        is_bulk_delete_supported \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"f00213d3_d1f9702b","line":1135,"updated":"2023-06-14 23:04:58.000000000","message":"object_store.container","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":1133,"context_line":"        skip_resources\u003dNone,"},{"line_number":1134,"context_line":"    ):"},{"line_number":1135,"context_line":"        if self.should_skip_resource_cleanup(\"container\", skip_resources):"},{"line_number":1136,"context_line":"            return"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        is_bulk_delete_supported \u003d False"},{"line_number":1139,"context_line":"        bulk_delete_max_per_request \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"1c3c7373_3c8b8eab","line":1136,"updated":"2023-06-14 23:04:58.000000000","message":"I have a fear somebody would try to set skip deleting objects and with this check will not get the expected result","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"449c5410df4cd6bc5770f4a3c8295dc0fbcdf7b8","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"        skip_resources\u003dNone,"},{"line_number":1134,"context_line":"    ):"},{"line_number":1135,"context_line":"        if self.should_skip_resource_cleanup(\"container\", skip_resources):"},{"line_number":1136,"context_line":"            return"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        is_bulk_delete_supported \u003d False"},{"line_number":1139,"context_line":"        bulk_delete_max_per_request \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"13db8e62_427a09b4","line":1136,"in_reply_to":"1c3c7373_3c8b8eab","updated":"2023-06-15 13:02:12.000000000","message":"Right, I will add object_store.object as well.","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"}],"openstack/orchestration/v1/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e6048be4a1a86365fc6901e4c6d690137236aee7","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        resource_evaluation_fn\u003dNone,"},{"line_number":552,"context_line":"        skip_resources\u003dNone,"},{"line_number":553,"context_line":"    ):"},{"line_number":554,"context_line":"        if self.should_skip_resource_cleanup(\"stack\", skip_resources):"},{"line_number":555,"context_line":"            return"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        stacks \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"606f93b7_86d5aa12","line":554,"updated":"2023-06-14 23:04:58.000000000","message":"orchestration.stack","commit_id":"a2e5d165525da271e2edd98b06700fbf4735cb31"}],"openstack/proxy.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"70854563263095b2f85b77150ba83fa493a476b9","unresolved":true,"context_lines":[{"line_number":821,"context_line":"                           \"in project cleanup\")"},{"line_number":822,"context_line":"            return True"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        self.log.debug(f\"Including resource {resource_name} \""},{"line_number":825,"context_line":"                       \"in project cleanup\")"},{"line_number":826,"context_line":"        return False"},{"line_number":827,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9d15c6ba_0fa37784","line":824,"updated":"2023-03-29 05:33:40.000000000","message":"I\u0027m not sure if the debug logging isn\u0027t too verbose. Maybe at least omit it for this second case?","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"5c225620d83bff83a0dba9c3eb979d37d041d3a6","unresolved":false,"context_lines":[{"line_number":821,"context_line":"                           \"in project cleanup\")"},{"line_number":822,"context_line":"            return True"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        self.log.debug(f\"Including resource {resource_name} \""},{"line_number":825,"context_line":"                       \"in project cleanup\")"},{"line_number":826,"context_line":"        return False"},{"line_number":827,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2f2e70ba_a71b3b47","line":824,"in_reply_to":"3ea8d84a_22f3c001","updated":"2023-03-30 14:56:10.000000000","message":"Done","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"79820b1e90f8a056bca5273802e285d63824e24b","unresolved":true,"context_lines":[{"line_number":821,"context_line":"                           \"in project cleanup\")"},{"line_number":822,"context_line":"            return True"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        self.log.debug(f\"Including resource {resource_name} \""},{"line_number":825,"context_line":"                       \"in project cleanup\")"},{"line_number":826,"context_line":"        return False"},{"line_number":827,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ea8d84a_22f3c001","line":824,"in_reply_to":"9d15c6ba_0fa37784","updated":"2023-03-30 14:37:03.000000000","message":"Right, this log can probably be removed.","commit_id":"4a60c9f54efd5b8aa843ad5a64faaa2fad3bd850"}]}