)]}'
{"id":"openstack%2Fopenstacksdk~881033","triplet_id":"openstack%2Fopenstacksdk~master~Idd2dd85e2fee364348328b5f25096f565cd47241","project":"openstack/openstacksdk","branch":"master","topic":"story/2009127","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-05-16 10:33:31.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},"27900":{"account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"last_update":"2023-05-16 12:09:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idd2dd85e2fee364348328b5f25096f565cd47241","subject":"image: Don\u0027t envelope properties","status":"MERGED","created":"2023-04-20 17:23:11.000000000","updated":"2023-05-16 12:10:33.000000000","submitted":"2023-05-16 12:09:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"881033-story/2009127","meta_rev_id":"b7fea3394166672524c842023a08916251e74370","_number":881033,"virtual_id_number":881033,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-16 12:09:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2023-04-21 18:30:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2023-05-16 10:33:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"reviewers":{"REVIEWER":[{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-20 18:52:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-21 16:34:29.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2023-04-21 18:30:53.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"}],"messages":[{"id":"141b842acb74743c6a526fc6c45760e092ddaba6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-04-20 17:23:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b7a9982bb51d6d52c300e6857dd55e38d5db3ec3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-20 18:52:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ee4c78d859ce46a4992eb63a195728f3\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/6e1d6cc0a74a48e6af9a947a78618036 : SUCCESS in 1h 07m 16s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/1879d09d8bac4e68b3f94c33dd72d63d : SUCCESS in 35m 25s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/74a9f3e728be4c5eb4b27583e731dcdd : SUCCESS in 2m 59s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0b1612410cfe4ae6b1efb2d6a8b79f0b : SUCCESS in 3m 55s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/12bdc48ec64243d9bfd65b0a44e1aab8 : SUCCESS in 3m 33s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/2947242f76224f568ae1bc1791cd442f : SUCCESS in 55m 58s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/4ee89cc2ca1548cf81402442e96142fd : SUCCESS in 3m 08s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/6105328412704e82969060c658c0f3dd : SUCCESS in 4m 24s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/f190dc18084f413587e24d975dc848b0 : SUCCESS in 4m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/84c9edc356354f70a94e15f5674c3923 : SUCCESS in 7m 26s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/fedc7c84a06d438dbd54d739ce544b7a : SUCCESS in 1h 10m 10s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/8fdae82aef6d48b1b9607485593d93bf : SUCCESS in 14m 19s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/3680bab49daf4109ab8b89ec161d1faa : SUCCESS in 41m 30s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/45c2bcca654c49feb0cd09dad1a77ec2 : SUCCESS in 1h 02m 26s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/842bc28e525845748dc26e6c2c71a078 : SUCCESS in 1h 21m 56s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/f530ff43d988445f92dedd3f8f66f79a : SUCCESS in 55m 41s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/bb0293d92a064232aa748bfd7a353484 : SUCCESS in 52m 25s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/597a3f0c1d674ffda340cef110b8d282 : SUCCESS in 35m 15s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/d85be7cfc7aa47ff996342c217f04836 : SUCCESS in 34m 48s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/0845f673018f4154acc4b7355bcd308b : SUCCESS in 39m 17s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/d4fd6616d3f040f9bdbcedbba02a5483 : SUCCESS in 1h 09m 19s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/2b59e1dc3a4544e5aee992a15ca82871 : SUCCESS in 1h 06m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4fc5e7220c3067753d966287c9e1e4c0b4f32ee1","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2023-04-21 18:30:53.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d62ed77abbd379da0e1d3acbf23e36a1325735b4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-05-16 10:33:31.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"56a619887a9666b465489aa45a113023bcaaf3da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-16 10:34:32.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1cb50dcc90d0c1b727c52d0e3474f179d1bc6172","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-16 12:09:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ed9275d5484d4fe89bdc82be474c771b\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dbdf121ee16a43a792260c31803b2227 : SUCCESS in 4m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/36fcba83aa4040139035187ca828c737 : SUCCESS in 4m 21s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/54a397b7eb054a97b5da6040b49b9b41 : SUCCESS in 3m 59s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/4f65bc5e8a164b53ac325e4ba2746ba0 : SUCCESS in 4m 03s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/8d33f73cbe96431380b316e74ff2bbca : SUCCESS in 54m 40s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/0569b082788d48eb9a9bcab6bec9bfff : SUCCESS in 4m 09s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/a038d8c02aea4c36ba4c60df6a47964b : SUCCESS in 4m 14s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/c064e2d6d1a34f22a07a2c7e03eee20b : SUCCESS in 5m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f1e0ca87065f424795c39a3bf04ba00f : SUCCESS in 8m 06s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/c6228cab80824314a757e059fbbed558 : SUCCESS in 46m 56s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/ad8948ca89a84a2faaddca3ebe002465 : SUCCESS in 19m 30s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/56bd3de5591f43a1a34bc08bcb9a06a3 : FAILURE in 20m 18s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/2452c55425ab45118e57f3a93f798e11 : SUCCESS in 55m 37s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/2140295c0198426080b3f11136c093a9 : SUCCESS in 1h 34m 33s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/e37edd2079944c978a347dc29a25a22a : SUCCESS in 50m 29s","accounts_in_message":[],"_revision_number":1},{"id":"f33aa52f92bc1cf6139ab1ba3d58a7ef59530ffa","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-16 12:09:15.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"b7fea3394166672524c842023a08916251e74370","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-16 12:10:33.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d1bbd8bf520041c8b549062ffe3d0734\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77c934c42e42480ab8ce1df5cfb27bd6 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9153d6704ba648136cf0f67e1ccdf4cbb7a417c7","revisions":{"9153d6704ba648136cf0f67e1ccdf4cbb7a417c7":{"kind":"REWORK","_number":1,"created":"2023-04-20 17:23:11.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/33/881033/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/33/881033/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/33/881033/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/33/881033/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/33/881033/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/33/881033/1"}}},"commit":{"parents":[{"commit":"79d1743d2a58bb8d6d4efe622f9ad47ffa7aaffc","subject":"Merge \"Add share instances to shared file systems\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/79d1743d2a58bb8d6d4efe622f9ad47ffa7aaffc"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-04-20 14:49:26.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-04-20 17:16:40.000000000","tz":60},"subject":"image: Don\u0027t envelope properties","message":"image: Don\u0027t envelope properties\n\nThe Glance v2 API is weird, in that it allows and places arbitrary\nproperties in the root envelope of requests and responses respectively\nrather than under a \u0027properties\u0027 or \u0027metadata\u0027 key like other services.\nWe were using a properties key temporarily as an envelope so we can\nformat these extra properties specifically. However, we were forgetting\nto remove this envelope when creating an bare image without uploading\ndata. Correct this.\n\nChange-Id: Idd2dd85e2fee364348328b5f25096f565cd47241\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nStory: 2009127\nTask: 43041\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/9153d6704ba648136cf0f67e1ccdf4cbb7a417c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/9153d6704ba648136cf0f67e1ccdf4cbb7a417c7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
