)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e2a3f99b86ba6077c8b95894f49836a4fed65c6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49239949_208f7750","updated":"2023-05-02 14:16:44.000000000","message":"one question inline but overall this makes sense","commit_id":"dec8fe236590635a53efd11848d291288afbf7e3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e02b729eda9e7ee0568938f7e8dc535ae26b65f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c77b383_7a7f1651","updated":"2023-05-02 13:38:41.000000000","message":"thanks for this.","commit_id":"dec8fe236590635a53efd11848d291288afbf7e3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa4f9fb802048daa3dbea9758a0a7218bb62f6c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b4b9a71_4e06246b","updated":"2023-05-16 08:59:15.000000000","message":"Simple rebase. Approving.","commit_id":"2ce0bdbdf388771514c7ab2830310312e3e6a9e7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b06564b872b8b01ee985ca6b32714bc36b0dfb1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b3d16228_fd2d1cd3","updated":"2025-01-09 20:36:22.000000000","message":"just did another rebase, but it seems some more testing fixes are needed","commit_id":"864bb444328c15d4f05ca6d313e6e66b73fa75e5"}],"openstack/compute/v2/keypair.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e2a3f99b86ba6077c8b95894f49836a4fed65c6a","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    allow_delete \u003d True"},{"line_number":29,"context_line":"    allow_list \u003d True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    _max_microversion \u003d \u00272.92\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Properties"},{"line_number":34,"context_line":"    #: The date and time when the resource was created."}],"source_content_type":"text/x-python","patch_set":1,"id":"e9a59f57_2e746545","line":31,"updated":"2023-05-02 14:16:44.000000000","message":"i assum this is used by some mechanisum in the base class since its \"_private\"\nand not used in this file.\n\nmy guess is this refers to the max microveriosn that modifed the behavior fo this api rather then the max that can be used with this api correct.","commit_id":"dec8fe236590635a53efd11848d291288afbf7e3"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b194ca98810adea9f2cc455b1ffb97bf331f7468","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    allow_delete \u003d True"},{"line_number":29,"context_line":"    allow_list \u003d True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    _max_microversion \u003d \u00272.92\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Properties"},{"line_number":34,"context_line":"    #: The date and time when the resource was created."}],"source_content_type":"text/x-python","patch_set":1,"id":"2fd2bcf7_c32b3200","line":31,"in_reply_to":"2df4a5ac_9a044479","updated":"2023-05-02 14:49:01.000000000","message":"\u003e Ideally we should have a \u0027_min_microversion\u0027 attribute to mark an absolute minimum version but no one has implemented that yet.\n\nI am on it in some form","commit_id":"dec8fe236590635a53efd11848d291288afbf7e3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb590fce0a6c801c02ff6f05ce4674eb772d4afe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    allow_delete \u003d True"},{"line_number":29,"context_line":"    allow_list \u003d True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    _max_microversion \u003d \u00272.92\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Properties"},{"line_number":34,"context_line":"    #: The date and time when the resource was created."}],"source_content_type":"text/x-python","patch_set":1,"id":"2df4a5ac_9a044479","line":31,"in_reply_to":"e9a59f57_2e746545","updated":"2023-05-02 14:46:54.000000000","message":"Yeahhhhh, this is poorly named. This is the microversion that we will attempt to use by default when making calls to this resource\u0027s endpoint (i.e. \u0027/os-keypairs\u0027). This applies unless the user explicitly provides an API version (e.g. via \u0027--os-compute-api-version\u0027 when using OSC).\n\nWe generally use this attribute to indicate the most recent microversion affecting this API that we\u0027ve implemented support for. For example, if API 2.4 changed resource Foo\u0027s representation and Foo._max_microversion \u003d\u003d 2.3, that would imply we had some work to do to support API microversion 2.4. If this microversion is not supported, we will downgrade until we find one that is supported and the expectation is that we\u0027ll have added logic to handle that downgrade (again, assuming the user didn\u0027t override us).\n\nIdeally we should have a \u0027_min_microversion\u0027 attribute to mark an absolute minimum version but no one has implemented that yet.","commit_id":"dec8fe236590635a53efd11848d291288afbf7e3"}]}