)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80d20c902fef440205645b051e6fba184d4a27cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84e716da_773c1abc","updated":"2023-05-25 19:45:58.000000000","message":"This is a good fix, I ran into the issue a couple of times myself. I don\u0027t understand the patch, but verified locally that it does what the commit message promises.","commit_id":"68ecfaccaeadaeb7bd1b2df27d3f71b76e0799e6"}],"openstack/tests/unit/base.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80d20c902fef440205645b051e6fba184d4a27cf","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Isolate openstack.config from test environment"},{"line_number":108,"context_line":"        self.os_cloud_fixture \u003d self.useFixture("},{"line_number":109,"context_line":"            fixtures.EnvironmentVariable(\u0027OS_CLOUD\u0027),"},{"line_number":110,"context_line":"        )"},{"line_number":111,"context_line":"        config \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":112,"context_line":"        cloud_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":1,"id":"12c9e762_70b41dad","line":109,"updated":"2023-05-25 19:45:58.000000000","message":"Just to soothe my curious mind, could explain how this works? This var doesn\u0027t seem to get referenced anywhere.","commit_id":"68ecfaccaeadaeb7bd1b2df27d3f71b76e0799e6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"850e420cbe2043c29f9c9f5a8222fc2e6a2436d8","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Isolate openstack.config from test environment"},{"line_number":108,"context_line":"        self.os_cloud_fixture \u003d self.useFixture("},{"line_number":109,"context_line":"            fixtures.EnvironmentVariable(\u0027OS_CLOUD\u0027),"},{"line_number":110,"context_line":"        )"},{"line_number":111,"context_line":"        config \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":112,"context_line":"        cloud_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":1,"id":"6f4af59b_a33731a2","line":109,"in_reply_to":"12c9e762_70b41dad","updated":"2023-05-26 08:50:42.000000000","message":"Sure. I\u0027m using the `EnvironmentVariable` fixture from `fixtures`, which you can find here [1]. All that this does is either set or delete the environment variable (depending on whether you provide a new value or not) during test set up and then restore it during test tear down. Very dumb, but it does the trick.\n\n[1] https://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/environ.py","commit_id":"68ecfaccaeadaeb7bd1b2df27d3f71b76e0799e6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a57fdb92cfa2e28a1f1013289d076c69fadcb5f","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Isolate openstack.config from test environment"},{"line_number":108,"context_line":"        self.os_cloud_fixture \u003d self.useFixture("},{"line_number":109,"context_line":"            fixtures.EnvironmentVariable(\u0027OS_CLOUD\u0027),"},{"line_number":110,"context_line":"        )"},{"line_number":111,"context_line":"        config \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":112,"context_line":"        cloud_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":1,"id":"729e900e_629d5911","line":109,"in_reply_to":"6f4af59b_a33731a2","updated":"2023-05-26 08:53:38.000000000","message":"I don\u0027t actually need to assign the fixture to anything though. Sometime you\u0027d want to do that so you can inspect something that the fixture capture (for example, the `output` attribute of the `FakeLogger` fixture [1]), but we don\u0027t need to do this here. It was done this way because we\u0027re setting `OS_CLOUD` in some places in the tests and I thought that in those I\u0027d want to modify this fixture rather than provide a new one. I couldn\u0027t figure out how to do that so I left it and never cleaned this up. It\u0027s harmless though.\n\n[1] https://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/logger.py","commit_id":"68ecfaccaeadaeb7bd1b2df27d3f71b76e0799e6"}]}
