)]}'
{"id":"openstack%2Fopenstacksdk~884390","triplet_id":"openstack%2Fopenstacksdk~master~Id8756f679ec5130779d61d454455c9c25afe8baa","project":"openstack/openstacksdk","branch":"master","topic":"story/2010627","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-07-28 10:21:51.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},"18816":{"account":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"last_update":"2023-05-26 12:56:33.000000000","reason":"\u003cGERRIT_ACCOUNT_18816\u003e replied on the change","reason_account":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"}}},"hashtags":[],"change_id":"Id8756f679ec5130779d61d454455c9c25afe8baa","subject":"cloud: Ignore invalid filters","status":"MERGED","created":"2023-05-25 12:04:04.000000000","updated":"2023-07-28 13:53:25.000000000","submitted":"2023-07-28 13:52:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"884390-story/2010627","meta_rev_id":"4decb88f2360af35402d59491a5e7f5f18b7fc0b","_number":884390,"virtual_id_number":884390,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-07-28 13:52:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-07-28 10:21:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2023-05-26 12:56:33.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-07-28 10:21:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-25 13:43:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-26 09:01:03.000000000","updated_by":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"reviewer":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"state":"CC"},{"updated":"2023-05-26 12:56:33.000000000","updated_by":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"reviewer":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"state":"REVIEWER"}],"messages":[{"id":"ec91cc0199b686eccf65314692cf29c96d177508","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-05-25 12:04:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"82d93a5eff55cbc0647ecc7cb53079ee995c8fa5","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-05-25 12:07:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"db3abd1cbaa9e17ce208380a525fbf231bae3379","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-25 13:43:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/b8e18ea93b7a432c94feef3b96cfd2df\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/858c102906ac49f5bc31a5f1b58a200a : SUCCESS in 47m 37s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/33da8c0ecc9e4292bb526dd2fd63a1d3 : SUCCESS in 40m 38s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fb03e026f9d74e68a916528ffca53fab : SUCCESS in 4m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c42f09657abe416cbaa4b450bb69afb7 : SUCCESS in 3m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1c23effce563470f973246f4a6ef3595 : SUCCESS in 3m 22s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/e86856c5b2094c97ad14ee95128f704e : SUCCESS in 3m 49s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/0c82d31844704add9de8d120175523bd : FAILURE in 52m 29s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/ee7c2167a1b14b8d80c9e5c36c3a0601 : SUCCESS in 3m 08s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/97d0a818b5884e6e9ab0ab1762e33444 : SUCCESS in 4m 23s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/8727c164aa41446989ebc756f0339e01 : SUCCESS in 4m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b47832ce854c4e5a933a25a240820587 : SUCCESS in 7m 12s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/0f81890bdd8648dfb704af250207bdd8 : SUCCESS in 36m 22s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/6275401f48da424699b60bf90b8008a1 : SUCCESS in 11m 02s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/d4dfefa80a62413eb3087d9c3f85b6f3 : FAILURE in 21m 09s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/6b0b203519ef47e190cb863d66740e00 : FAILURE in 58m 43s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/4ac15db153ec426783b7c6d27fe20a0e : FAILURE in 1h 16m 27s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/5ec2bbd0dfd14378b39544904f193b59 : FAILURE in 51m 46s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/5ce72fd1fd6b4ea5b13888ae398ce5aa : FAILURE in 54m 45s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/0d42fc2cde484d99b5657b4cf996b45c : SUCCESS in 34m 18s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/f6ba4a1a942a4a99b461c98e9e1abaf8 : SUCCESS in 32m 34s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/beab1e4010784a01acc25277bd04a67e : SUCCESS in 41m 10s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/8b1b8fa9322647ad8450c83219ef18ce : SUCCESS in 1h 10m 52s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/9ba82901f529422099fac3f269a948c3 : SUCCESS in 1h 14m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"73a2c705e6d953757d3219b1b7698a829dedeccd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-05-25 16:35:50.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"0d5b5b018067acf9ede53166f8dba811e6638cf1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-25 17:54:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/848dc637f5c248c8b209e398d707dbe0\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/4a4fd4c2120e47a59979f2008c065080 : SUCCESS in 57m 23s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/58f23141c1b445758466fbc5630100d9 : SUCCESS in 35m 21s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/464a825f01b84a79a9968d1b8983c441 : SUCCESS in 5m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/83449459f4fc494d8e106f45d58c258f : SUCCESS in 4m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/34972dfaecbb49d583c39ed6bada6bab : SUCCESS in 3m 31s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/0ad24092488b4655a9d6e9ff54df0fd8 : SUCCESS in 4m 07s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/668c01864eff443ba7a7c4da053a22b1 : SUCCESS in 1h 06m 44s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/e5c9acd4ed9f4b95adaf86c5e9ec27f3 : SUCCESS in 4m 12s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/9796fa2624b049598dd4a7fd9f26ed3b : SUCCESS in 5m 09s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/65ebf53f190544dabca879a9f322823e : SUCCESS in 4m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3370f48e2b744379ac9277e84cf48d9e : SUCCESS in 6m 39s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/59d1b72d5dea4d2990137711efad8c71 : SUCCESS in 1h 12m 56s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/4c0f2c30958c40458841f8d5fe22c235 : SUCCESS in 13m 27s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/72b2ec6358e44a11aaf5ca59fbbcc865 : FAILURE in 17m 41s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/74f8afbb8d2a4e8eab409dbe7774299b : SUCCESS in 1h 01m 53s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/489af4b496304a1fb7ee01390397b324 : SUCCESS in 1h 14m 01s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/19bfabb5881e4e4aaaaa90bdf94fcd63 : SUCCESS in 1h 00m 29s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/67a6fe9fea934b9da45337d7e1a7ac36 : SUCCESS in 45m 38s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/86f312aa7dc7451fa7170851f58fd712 : SUCCESS in 35m 15s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/d393c06b4e0844d5a8a8faef1cd9532c : SUCCESS in 36m 27s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/2eff931768aa435fabab73eefb386114 : SUCCESS in 40m 57s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/56701f40e2c34ca4953d08035585c477 : SUCCESS in 1h 02m 10s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/60796c16014e43d8af55fad04cb9f2a7 : SUCCESS in 1h 10m 41s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c33c082a0cbfe792db695105b279613195daecb5","author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"date":"2023-05-26 09:01:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7511a9469b66ff5afa7dc5e3061f051d00207dee","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-05-26 12:52:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e3572b38ece50fb8aa50064aab3d3c1e088f214d","author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"date":"2023-05-26 12:56:33.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d62ed86c63b7c629e92a3c8d7f3b9667589fb35e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-07-28 10:21:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ba8ac3843d39e9d536e83938c5e0d2bba7541d36","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-28 10:22:52.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0848ff93f97b174f101ecfa0c3202b6355f87442","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-28 13:52:16.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ad95c4b3bc3d42a4a971b74cc6121b14\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3acc4ff62be94525be77dabe395aed40 : SUCCESS in 4m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4b155332f52a4a91ac1a33b262626b9a : SUCCESS in 4m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/04bf8047162c40c491072c3535170ca2 : SUCCESS in 3m 55s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/72f2bcc0c9e3444fbb78ce5b54f1fcba : SUCCESS in 3m 48s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/6be319566b994768bc0f9e230bfbd071 : SUCCESS in 52m 24s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/b9213d79f43041df8a7ab73d8b8563d4 : SUCCESS in 4m 24s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/62494750fc644572943093c53b4b44d0 : SUCCESS in 5m 33s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/c09245846c304b95a3d7bfdfcb3fe4f2 : SUCCESS in 5m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6df2282ce77e4c61bfda4733b370d49e : SUCCESS in 6m 21s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7339dc1ac3b0489ca3f4dcd0f33ab0bc : SUCCESS in 1h 12m 15s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/404083445257498abdeaffe6feb1006a : SUCCESS in 15m 39s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/f4d37df78f0b4c8ea6c0402d1d65b3be : SUCCESS in 44m 06s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f6b7cd66e8d94c368eb422f6b6544d0b : SUCCESS in 59m 32s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/a3c8d24ba22a415db7571e0b85a52a39 : SUCCESS in 1h 13m 11s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/e471bf9358f143a28a7c773c661811d7 : SUCCESS in 1h 51m 20s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/a9a36e82af4444a2a380fd97fb63f83a : SUCCESS in 1h 03m 05s","accounts_in_message":[],"_revision_number":2},{"id":"038f1868e6571d61ab56b83065e0328c0ff9320d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-28 13:52:16.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"4decb88f2360af35402d59491a5e7f5f18b7fc0b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-28 13:53:25.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/71ce4e5f62004ed9887b0e017c5705ad\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/273995f8d6174182b627e19711d7b962 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"661efb7cedf702545dc6e2b99395dfcc1e5873ad","revisions":{"80185c4d2cc633b40a75a9a71f6098cba3124e34":{"kind":"REWORK","_number":1,"created":"2023-05-25 12:04:04.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/90/884390/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/90/884390/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/1"}}},"commit":{"parents":[{"commit":"dc52fd4978424ae9f55b3a602572dce6a291407b","subject":"cloud: Filter FIPs by valid filters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/dc52fd4978424ae9f55b3a602572dce6a291407b"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-05-25 10:14:20.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-05-25 12:02:15.000000000","tz":60},"subject":"cloud: Ignore invalid filters","message":"cloud: Ignore invalid filters\n\nThe \u0027openstack.cloud._utils._filter_list\u0027 function accepts a list of\nfilters. These filters are key-value pairs where the key indicates the\nattribute of the resources that we wish to filter on, and the value is\neither a simple value or another key-value pair to allow us to filter on\nnested attributes (turtles all the way down 🐢🌍).\n\nWe were using \u0027.get(key, None)\u0027 to retrieve the attribute from the\nresource, meaning we inadvertently allowed for filters on attributes\nthat did not exist. If the attribute was not found, we treated this as a\nmismatch. This is certainly not what was intended and it\u0027s not\nnecessary: because the cloud layer is now using the proxy layer rather\nthan raw REST requests, and the proxy layer in-turn uses resources, we\ncan ensure that a valid attribute will always be present even if it\nunset. As such, the current logic is incorrect and has allowed at least\none bug to slip into our codebase.\n\nCorrect this issue by checking for the presence of a resource attribute\nmatching the key. If an attribute doesn\u0027t match, we now raise a warning\nand exception, as one would have expected.\n\nChange-Id: Id8756f679ec5130779d61d454455c9c25afe8baa\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nStory: 2010627\nTask: 48095\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/80185c4d2cc633b40a75a9a71f6098cba3124e34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/80185c4d2cc633b40a75a9a71f6098cba3124e34"}]},"branch":"refs/heads/master"},"661efb7cedf702545dc6e2b99395dfcc1e5873ad":{"kind":"REWORK","_number":2,"created":"2023-05-25 16:35:50.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/90/884390/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/90/884390/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/90/884390/2"}}},"commit":{"parents":[{"commit":"dc52fd4978424ae9f55b3a602572dce6a291407b","subject":"cloud: Filter FIPs by valid filters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/dc52fd4978424ae9f55b3a602572dce6a291407b"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-05-25 10:14:20.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-05-25 16:35:31.000000000","tz":60},"subject":"cloud: Ignore invalid filters","message":"cloud: Ignore invalid filters\n\nThe \u0027openstack.cloud._utils._filter_list\u0027 function accepts a list of\nfilters. These filters are key-value pairs where the key indicates the\nattribute of the resources that we wish to filter on, and the value is\neither a simple value or another key-value pair to allow us to filter on\nnested attributes (turtles all the way down 🐢🌍).\n\nWe were using \u0027.get(key, None)\u0027 to retrieve the attribute from the\nresource, meaning we inadvertently allowed for filters on attributes\nthat did not exist. If the attribute was not found, we treated this as a\nmismatch. This is certainly not what was intended and it\u0027s not\nnecessary: because the cloud layer is now using the proxy layer rather\nthan raw REST requests, and the proxy layer in-turn uses resources, we\ncan ensure that a valid attribute will always be present even if it\nunset. As such, the current logic is incorrect and has allowed at least\none bug to slip into our codebase.\n\nCorrect this issue by checking for the presence of a resource attribute\nmatching the key. If an attribute doesn\u0027t match, we now raise a warning\nand exception, as one would have expected.\n\nChange-Id: Id8756f679ec5130779d61d454455c9c25afe8baa\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nStory: 2010627\nTask: 48095\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/661efb7cedf702545dc6e2b99395dfcc1e5873ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/661efb7cedf702545dc6e2b99395dfcc1e5873ad"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}