)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5ffc12af4db44d31a63ee2f01c98583ffc00bfec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9c8b2f58_dbbc1349","updated":"2023-05-31 08:22:43.000000000","message":"This could also do with functional and unit tests, of course, plus a release note.","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5d3a58775a2b5cca9a8e8bb425f4966a9246925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f3333fb_2fd503e3","in_reply_to":"9c8b2f58_dbbc1349","updated":"2023-06-02 19:23:58.000000000","message":"Done","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5d3a58775a2b5cca9a8e8bb425f4966a9246925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6e6d54b_925316ed","updated":"2023-06-02 19:23:58.000000000","message":"Thanks Stephen, that was the input i was looking for for my initial work on SDK :).\nI intentionally didn\u0027t include UTs and functional tests initially just to get input on the approach which was not 100% correct.\nThis PS should be good now.","commit_id":"e31228a28eb4d3bf8eba6ccf792efd6516891372"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"baa783d61171fba00f131f06757c9552c27bf9b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afe8d64c_f5407442","updated":"2023-06-09 17:57:30.000000000","message":"can we please fix docs here? Otherwise change is good.\n\n- add sphinx comments to resource properties\n- add proxy method under service docs\n- add new resource under service resource docs","commit_id":"e31228a28eb4d3bf8eba6ccf792efd6516891372"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e46b357b110cf0c2015e3997dd2048a18a75508b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52030d47_86445742","in_reply_to":"afe8d64c_f5407442","updated":"2023-06-14 06:27:10.000000000","message":"Done","commit_id":"e31228a28eb4d3bf8eba6ccf792efd6516891372"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e46b357b110cf0c2015e3997dd2048a18a75508b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"432d0974_521850dd","updated":"2023-06-14 06:27:10.000000000","message":"Thanks Artem, added the relevant docs.","commit_id":"7a04473a085a9cbf9238c9f679068485fcc5aa09"}],"openstack/block_storage/v3/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aef21d820dfc874b4d4202b0df2c3af7ecca06ba","unresolved":true,"context_lines":[{"line_number":1761,"context_line":"            instance."},{"line_number":1762,"context_line":"        \"\"\""},{"line_number":1763,"context_line":"        res \u003d self._get(_summary.Summary, requires_id\u003dFalse)"},{"line_number":1764,"context_line":"        return res.summary(self, all_projects)"}],"source_content_type":"text/x-python","patch_set":1,"id":"69672fb6_4ec03458","line":1764,"updated":"2023-05-31 08:22:26.000000000","message":"You\u0027ll note this file is grouped by \"category\" or resource. Can you move this up to a new section above \"UTILS\"?","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5d3a58775a2b5cca9a8e8bb425f4966a9246925","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"            instance."},{"line_number":1762,"context_line":"        \"\"\""},{"line_number":1763,"context_line":"        res \u003d self._get(_summary.Summary, requires_id\u003dFalse)"},{"line_number":1764,"context_line":"        return res.summary(self, all_projects)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7185081f_98ed4b36","line":1764,"in_reply_to":"69672fb6_4ec03458","updated":"2023-06-02 19:23:58.000000000","message":"Done","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"}],"openstack/block_storage/v3/block_storage_summary.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aef21d820dfc874b4d4202b0df2c3af7ecca06ba","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Summary(resource.Resource):"},{"line_number":19,"context_line":"    resource_key \u003d \"summary\""},{"line_number":20,"context_line":"    resources_key \u003d \"summary\""},{"line_number":21,"context_line":"    base_path \u003d \"/volumes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"84b5a75f_9956928a","line":20,"updated":"2023-05-31 08:22:26.000000000","message":"You don\u0027t need to define this unless `allow_list \u003d True`","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5d3a58775a2b5cca9a8e8bb425f4966a9246925","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Summary(resource.Resource):"},{"line_number":19,"context_line":"    resource_key \u003d \"summary\""},{"line_number":20,"context_line":"    resources_key \u003d \"summary\""},{"line_number":21,"context_line":"    base_path \u003d \"/volumes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"862bd815_054f1875","line":20,"in_reply_to":"84b5a75f_9956928a","updated":"2023-06-02 19:23:58.000000000","message":"Done","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aef21d820dfc874b4d4202b0df2c3af7ecca06ba","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        microversion \u003d self._get_microversion(session, action\u003d\u0027fetch\u0027)"},{"line_number":42,"context_line":"        resp \u003d session.get(url, microversion\u003dmicroversion)"},{"line_number":43,"context_line":"        exceptions.raise_from_response(resp)"},{"line_number":44,"context_line":"        return resp.json()"}],"source_content_type":"text/x-python","patch_set":1,"id":"15b662e3_79660899","line":44,"updated":"2023-05-31 08:22:26.000000000","message":"You shouldn\u0027t need to implement this. Instead, you can use rely on either the `fetch` or `list` methods. To decide which of them to use, look at whether the response returned by the API is a single object or a list of objects. From the [API ref](https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dget-volumes-summary-detail#get-volumes-summary) it seems it\u0027s the former, in which case you can simply use `fetch`.\n\nYou may wish to override the default value of the `requires_id` argument to `fetch` though. I don\u0027t think there\u0027s a way to do this on the class, unfortunately.\n\n    def fetch(\n        session,\n        requires_id\u003dFalse,\n        base_path\u003dNone,\n        error_message\u003dNone,\n        skip_cache\u003dFalse,\n        *,\n        resource_response_key\u003dNone,\n        microversion\u003dNone,\n        **params,\n    ):\n        super(\n            ...\n        )","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5d3a58775a2b5cca9a8e8bb425f4966a9246925","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        microversion \u003d self._get_microversion(session, action\u003d\u0027fetch\u0027)"},{"line_number":42,"context_line":"        resp \u003d session.get(url, microversion\u003dmicroversion)"},{"line_number":43,"context_line":"        exceptions.raise_from_response(resp)"},{"line_number":44,"context_line":"        return resp.json()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ef41522_e01da13b","line":44,"in_reply_to":"15b662e3_79660899","updated":"2023-06-02 19:23:58.000000000","message":"Done","commit_id":"74b513fdbf5bad424a642e0a82d8afa588c24d88"}]}
