)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6c8a611b_fcc62dc1","updated":"2023-06-30 01:40:05.000000000","message":"Hi Anvi, \n\nThanks for submitting this change. It looks great for the most part; i really appreciate the effort you\u0027ve put into the testing and documentation. I have a few comments inline, with some change suggestions. Please take a look!","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33640a841fdff8218336a3b34adc294b55c8fb29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a4124315_4d1cfc48","updated":"2023-07-24 18:11:56.000000000","message":"Hi Anvi, \n\nThank you for making the changes; i\u0027ve a few more minor comments/suggestions inline; after these are made, i think this is good to close!","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"102c46bf7055bd80fe277123d24e33fa6d0cd743","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6411da37_427dbeb2","updated":"2023-07-25 17:29:44.000000000","message":"Anvi, a change merged elsewhere, and another one is in the queue to merge: https://review.opendev.org/c/openstack/openstacksdk/+/879686\n\nThese changes modify some of the same files you\u0027re modifying in this change. So, could you please rebase and resolve any merge conflicts with your patch?","commit_id":"6cf9c0fe5000ed8733c1e42dbce65055bffd1641"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dc39feb91de4c0dc4d3d0c7c19600f0ccca6e3cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"75f39900_7b71a002","updated":"2023-07-29 01:24:10.000000000","message":"recheck\n\nGood job Anvi. Thank you for adding this SDK functionality!","commit_id":"6ef2af39d5cec38db3dca075aa874c5e6f40d6a8"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"0521a60075c63fb1fab1517e37a52be7ecf36095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fd821977_ca7d1310","updated":"2023-07-28 19:30:00.000000000","message":"recheck\nFailure in networking job not related to the changes in the shared file systems code","commit_id":"6ef2af39d5cec38db3dca075aa874c5e6f40d6a8"}],"examples/shared_file_system/share_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33640a841fdff8218336a3b34adc294b55c8fb29","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    print(\"List All Share Metadata:\")"},{"line_number":22,"context_line":"    for meta_key in metadata:"},{"line_number":23,"context_line":"        print(metadata[meta_key])"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def get_share_metadata_item(conn, share_id, key):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bcb0eefa_51f8f704","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":33},"updated":"2023-07-24 18:11:56.000000000","message":"you\u0027d likely want both key and value:\n\n print(f\"{meta_key}\u003d{metadata[meta_key]}\")","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"605651f1ef90f1b5609c722c5a3eb49190837ff8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    print(\"List All Share Metadata:\")"},{"line_number":22,"context_line":"    for meta_key in metadata:"},{"line_number":23,"context_line":"        print(metadata[meta_key])"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def get_share_metadata_item(conn, share_id, key):"}],"source_content_type":"text/x-python","patch_set":8,"id":"94a14e4e_3b0daf08","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":33},"in_reply_to":"bcb0eefa_51f8f704","updated":"2023-07-25 04:53:46.000000000","message":"Done","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        :param share_id: The ID of the share"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        :returns: A :class:`~openstack.shared_file_system.v2.share.Share` with the"},{"line_number":725,"context_line":"            share\u0027s metadata."},{"line_number":726,"context_line":"        :rtype:"},{"line_number":727,"context_line":"            :class:`~openstack.shared_file_system.v2.share.Share`"},{"line_number":728,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"f40313cb_3b05a824","line":725,"range":{"start_line":724,"start_character":74,"end_line":725,"end_character":29},"updated":"2023-06-30 01:40:05.000000000","message":"please wrap to 79 characters...","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        :param share_id: The ID of the share"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        :returns: A :class:`~openstack.shared_file_system.v2.share.Share` with the"},{"line_number":725,"context_line":"            share\u0027s metadata."},{"line_number":726,"context_line":"        :rtype:"},{"line_number":727,"context_line":"            :class:`~openstack.shared_file_system.v2.share.Share`"},{"line_number":728,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ad78d93e_e1b54201","line":725,"range":{"start_line":724,"start_character":74,"end_line":725,"end_character":29},"in_reply_to":"f40313cb_3b05a824","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":730,"context_line":"        return share.fetch_metadata(self)"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    def get_share_metadata_item(self, share_id, key):"},{"line_number":733,"context_line":"        \"\"\"Retrieves a specific metadata item from a share’s metadata by its key."},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        :param share_id: The ID of the share"},{"line_number":736,"context_line":"        :param key: The key of the share metadata"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        :returns: A :class:`~openstack.shared_file_system.v2.share.Share` with the"},{"line_number":739,"context_line":"            share\u0027s metadata."},{"line_number":740,"context_line":"        :rtype:"},{"line_number":741,"context_line":"            :class:`~openstack.shared_file_system.v2.share.Share`"}],"source_content_type":"text/x-python","patch_set":7,"id":"a8a303cf_c1f2385c","line":738,"range":{"start_line":733,"start_character":73,"end_line":738,"end_character":82},"updated":"2023-06-30 01:40:05.000000000","message":"same comment as above; and for the docstrings below","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        return share.fetch_metadata(self)"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    def get_share_metadata_item(self, share_id, key):"},{"line_number":733,"context_line":"        \"\"\"Retrieves a specific metadata item from a share’s metadata by its key."},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        :param share_id: The ID of the share"},{"line_number":736,"context_line":"        :param key: The key of the share metadata"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        :returns: A :class:`~openstack.shared_file_system.v2.share.Share` with the"},{"line_number":739,"context_line":"            share\u0027s metadata."},{"line_number":740,"context_line":"        :rtype:"},{"line_number":741,"context_line":"            :class:`~openstack.shared_file_system.v2.share.Share`"}],"source_content_type":"text/x-python","patch_set":7,"id":"4464cac3_e57fa8a8","line":738,"range":{"start_line":733,"start_character":73,"end_line":738,"end_character":82},"in_reply_to":"a8a303cf_c1f2385c","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33640a841fdff8218336a3b34adc294b55c8fb29","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            try:"},{"line_number":788,"context_line":"                share.delete_metadata_item(self, key)"},{"line_number":789,"context_line":"            except exceptions.NotFoundException:"},{"line_number":790,"context_line":"                self._connection.log.info(\"Key %s not found.\", key)"},{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3b7541f7_455d51d4","line":790,"updated":"2023-07-24 18:11:56.000000000","message":"s/info/error","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"c4442416a316456f47e9f5452bd0593266253196","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            try:"},{"line_number":788,"context_line":"                share.delete_metadata_item(self, key)"},{"line_number":789,"context_line":"            except exceptions.NotFoundException:"},{"line_number":790,"context_line":"                self._connection.log.info(\"Key %s not found.\", key)"},{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"8ac16c6a_09d853d9","line":790,"in_reply_to":"3b7541f7_455d51d4","updated":"2023-07-24 21:44:05.000000000","message":"I\u0027m not sure what you mean by this. How should I be handling the exception?","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2b90af5270c28618707545b0c1fc9f5c49ef839a","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            try:"},{"line_number":788,"context_line":"                share.delete_metadata_item(self, key)"},{"line_number":789,"context_line":"            except exceptions.NotFoundException:"},{"line_number":790,"context_line":"                self._connection.log.info(\"Key %s not found.\", key)"},{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"e8e1cfd4_8f5adc04","line":790,"in_reply_to":"8ac16c6a_09d853d9","updated":"2023-07-24 22:36:37.000000000","message":"It\u0027s actually a good question, imho the SDK should surface the error.. logging would be helpful, and be sufficient if we were deliberately ignoring the errors... but, we should bubble up the error in case we are aren\u0027t, or are unsure.. \n\nA thought that\u0027s coming from a parallel patch in review (https://review.opendev.org/c/openstack/openstacksdk/+/889328) is that we need to support a way to ignore errors that pertain to \"missing\" items. doing that will harden the method such that it can be called multiple times, and won\u0027t fail if a key has been deleted because of a prior call.\n\nThe thing to be careful about here is that this method is handling multiple keys, maybe we could try something like this?\n\n\n    def delete_share_metadata(self, share_id, keys, ignore_missing\u003dTrue):\n        \"\"\"Deletes a single metadata item on a share, idetified by its key.\n\n        :param share_id: The ID of the share\n        :param keys: The list of share metadata keys to be deleted\n\n        :returns: None\n        :rtype: None\n        \"\"\"\n        share \u003d self._get_resource(_share.Share, share_id)\n        keys_failed_to_delete \u003d []\n        for key in keys:\n            try:\n                share.delete_metadata_item(self, key)\n            except exceptions.NotFoundException:\n                if not ignore_missing:\n                    self._connection.log.error(\"Key %s not found.\", key)\n                    keys_failed_to_delete.append(key)\n            except exceptions.ForbiddenException:\n                self._connection.log.error(\"Key %s cannot be deleted.\", key)\n                keys_failed_to_delete.append(key)\n            except exceptions.SDKException:\n                self._connection.log.error(\"Failed to delete key %s.\", key)\n                keys_failed_to_delete.append(key)\n        if keys_failed_to_delete:\n           raise raise exceptions.SDKException(\n            \u0027Some keys failed to be deleted %s\u0027 % keys_failed_to_delete\n        )","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"83bc6a96a9352fb6232277b03dd6eea2c37dfd44","unresolved":false,"context_lines":[{"line_number":787,"context_line":"            try:"},{"line_number":788,"context_line":"                share.delete_metadata_item(self, key)"},{"line_number":789,"context_line":"            except exceptions.NotFoundException:"},{"line_number":790,"context_line":"                self._connection.log.info(\"Key %s not found.\", key)"},{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"24eae106_e95a3ed8","line":790,"in_reply_to":"e8e1cfd4_8f5adc04","updated":"2023-07-25 04:51:54.000000000","message":"Ah, I see. Went ahead and made these changes.","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33640a841fdff8218336a3b34adc294b55c8fb29","unresolved":true,"context_lines":[{"line_number":789,"context_line":"            except exceptions.NotFoundException:"},{"line_number":790,"context_line":"                self._connection.log.info(\"Key %s not found.\", key)"},{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"},{"line_number":794,"context_line":"                self._connection.log.info(\"Failed to delete key %s.\", key)"}],"source_content_type":"text/x-python","patch_set":8,"id":"42d5252a_e4dffd60","line":792,"range":{"start_line":792,"start_character":37,"end_line":792,"end_character":41},"updated":"2023-07-24 18:11:56.000000000","message":"same here","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"605651f1ef90f1b5609c722c5a3eb49190837ff8","unresolved":false,"context_lines":[{"line_number":789,"context_line":"            except exceptions.NotFoundException:"},{"line_number":790,"context_line":"                self._connection.log.info(\"Key %s not found.\", key)"},{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"},{"line_number":794,"context_line":"                self._connection.log.info(\"Failed to delete key %s.\", key)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7819ef70_9badd27c","line":792,"range":{"start_line":792,"start_character":37,"end_line":792,"end_character":41},"in_reply_to":"42d5252a_e4dffd60","updated":"2023-07-25 04:53:46.000000000","message":"Done","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33640a841fdff8218336a3b34adc294b55c8fb29","unresolved":true,"context_lines":[{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"},{"line_number":794,"context_line":"                self._connection.log.info(\"Failed to delete key %s.\", key)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e613af84_5769fa6b","line":794,"range":{"start_line":794,"start_character":37,"end_line":794,"end_character":41},"updated":"2023-07-24 18:11:56.000000000","message":"and here","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"605651f1ef90f1b5609c722c5a3eb49190837ff8","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            except exceptions.ForbiddenException:"},{"line_number":792,"context_line":"                self._connection.log.info(\"Key %s cannot be deleted.\", key)"},{"line_number":793,"context_line":"            except exceptions.SDKException:"},{"line_number":794,"context_line":"                self._connection.log.info(\"Failed to delete key %s.\", key)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c27eaf88_9300ae09","line":794,"range":{"start_line":794,"start_character":37,"end_line":794,"end_character":41},"in_reply_to":"e613af84_5769fa6b","updated":"2023-07-25 04:53:46.000000000","message":"Done","commit_id":"412864f87ef47b3016fa5ef7536682a37266636e"}],"openstack/tests/functional/shared_file_system/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        super(BaseSharedFileSystemTest, self).setUp()"},{"line_number":22,"context_line":"        self.require_service("},{"line_number":23,"context_line":"            \u0027shared-file-system\u0027, min_microversion\u003dself.min_microversion"},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":"        self._set_operator_cloud(shared_file_system_api_version\u003d\u00272.78\u0027)"},{"line_number":26,"context_line":"        self._set_user_cloud(shared_file_system_api_version\u003d\u00272.78\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_share(self, **kwargs):"},{"line_number":29,"context_line":"        share \u003d self.user_cloud.share.create_share(**kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1745908a_ba05e4a0","line":26,"range":{"start_line":24,"start_character":9,"end_line":26,"end_character":67},"updated":"2023-06-30 01:40:05.000000000","message":"do you really need this change?\n\nall share metadata items are available with version 2.63.. \n\nWe have a functional test failing because there is an RBAC policy that restricts using \"force\" when performing a share extension.. we need to fix the functional test; so maybe lets bump the version in a separate change?\n\nhttps://af210370ee7c4e700e5c-94bdf753088c3a25476df71e05562111.ssl.cf2.rackcdn.com/886123/7/check/openstacksdk-functional-devstack-manila/56bca11/testr_results.html","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        super(BaseSharedFileSystemTest, self).setUp()"},{"line_number":22,"context_line":"        self.require_service("},{"line_number":23,"context_line":"            \u0027shared-file-system\u0027, min_microversion\u003dself.min_microversion"},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":"        self._set_operator_cloud(shared_file_system_api_version\u003d\u00272.78\u0027)"},{"line_number":26,"context_line":"        self._set_user_cloud(shared_file_system_api_version\u003d\u00272.78\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_share(self, **kwargs):"},{"line_number":29,"context_line":"        share \u003d self.user_cloud.share.create_share(**kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f6f69d04_d88b9f15","line":26,"range":{"start_line":24,"start_character":9,"end_line":26,"end_character":67},"in_reply_to":"1745908a_ba05e4a0","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"}],"openstack/tests/functional/shared_file_system/test_share_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        self.assertIsNotNone(my_share)"},{"line_number":31,"context_line":"        self.assertIsNotNone(my_share.id)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def tearDown(self):"},{"line_number":34,"context_line":"        super().tearDown()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_create(self):"},{"line_number":37,"context_line":"        meta \u003d {\"foo\": \"bar\"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"e3b9f6c0_da97aa72","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":26},"updated":"2023-06-30 01:40:05.000000000","message":"no need to redefine this if there\u0027s nothing to implement","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.assertIsNotNone(my_share)"},{"line_number":31,"context_line":"        self.assertIsNotNone(my_share.id)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def tearDown(self):"},{"line_number":34,"context_line":"        super().tearDown()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_create(self):"},{"line_number":37,"context_line":"        meta \u003d {\"foo\": \"bar\"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fd472bf_330a0cdb","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":26},"in_reply_to":"e3b9f6c0_da97aa72","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    def test_create(self):"},{"line_number":37,"context_line":"        meta \u003d {\"foo\": \"bar\"}"},{"line_number":38,"context_line":"        created_share \u003d ("},{"line_number":39,"context_line":"            self.operator_cloud.shared_file_system.create_share_metadata("},{"line_number":40,"context_line":"                self.SHARE_ID, **meta"},{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"a2d98d1c_b0824406","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":31},"updated":"2023-06-30 01:40:05.000000000","message":"Here and in all the tests below, there\u0027s no need to use \"operator_cloud\"; these metadata actions are feasible with even a regular user, so use the \"user_cloud\" connection object instead","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def test_create(self):"},{"line_number":37,"context_line":"        meta \u003d {\"foo\": \"bar\"}"},{"line_number":38,"context_line":"        created_share \u003d ("},{"line_number":39,"context_line":"            self.operator_cloud.shared_file_system.create_share_metadata("},{"line_number":40,"context_line":"                self.SHARE_ID, **meta"},{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"38399bfe_60378a86","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":31},"in_reply_to":"a2d98d1c_b0824406","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        assert isinstance(created_share, _share.Share)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_item(self):"},{"line_number":46,"context_line":"        meta \u003d {\"foo\": \"bar\"}"},{"line_number":47,"context_line":"        created_share \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"5e48f6bf_f0be89ca","line":44,"updated":"2023-06-30 01:40:05.000000000","message":"maybe also assert that created_share[\u0027metadata\u0027] is equal to {\u0027foo\u0027, \u0027bar\u0027}?","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        assert isinstance(created_share, _share.Share)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_item(self):"},{"line_number":46,"context_line":"        meta \u003d {\"foo\": \"bar\"}"},{"line_number":47,"context_line":"        created_share \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"e5b72a0c_53407aee","line":44,"in_reply_to":"5e48f6bf_f0be89ca","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        new_meta \u003d {\"newFoo\": \"newBar\"}"},{"line_number":86,"context_line":"        empty_meta \u003d {}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        updated_share \u003d ("},{"line_number":89,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("},{"line_number":90,"context_line":"                created_share, new_meta"},{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        self.assertEqual(updated_share[\u0027metadata\u0027], new_meta)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        deleted_share \u003d ("},{"line_number":96,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("}],"source_content_type":"text/x-python","patch_set":7,"id":"88ea45c7_8c080c77","line":93,"range":{"start_line":88,"start_character":0,"end_line":93,"end_character":61},"updated":"2023-06-30 01:40:05.000000000","message":"while this is correct; can i suggest an improvement to tighten the assert?\n\n updated_metadata \u003d (\n       self.user_cloud.shared_file_system.update_share_metadata(\n                created_share, new_meta\n            )[\u0027metadata\u0027]\n        )\n self.assertEqual(updated_metadata, new_meta)\n \n full_metadata \u003d (\n        self.user_cloud.shared_file_system.get_share_metadata(\n            created_share\n       )[\u0027metadata\u0027]\n )\n self.assertEqual({\u0027foo\u0027: \u0027bar\u0027, {newFoo\u0027: \u0027newBar\u0027}, full_metadata)","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"6b4689d2911f192da9b3be42dcc1b7c78791e934","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        new_meta \u003d {\"newFoo\": \"newBar\"}"},{"line_number":86,"context_line":"        empty_meta \u003d {}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        updated_share \u003d ("},{"line_number":89,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("},{"line_number":90,"context_line":"                created_share, new_meta"},{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        self.assertEqual(updated_share[\u0027metadata\u0027], new_meta)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        deleted_share \u003d ("},{"line_number":96,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("}],"source_content_type":"text/x-python","patch_set":7,"id":"c8dd49c4_43297435","line":93,"range":{"start_line":88,"start_character":0,"end_line":93,"end_character":61},"in_reply_to":"88ea45c7_8c080c77","updated":"2023-06-30 19:07:19.000000000","message":"Not sure I completely understand the last assertion. Shouldn\u0027t full_metadata be equal to {\u0027newFoo\u0027:\u0027newBar\u0027}?","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3b96a48c261cd8dc8331f78801a0e7b689bc989","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        new_meta \u003d {\"newFoo\": \"newBar\"}"},{"line_number":86,"context_line":"        empty_meta \u003d {}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        updated_share \u003d ("},{"line_number":89,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("},{"line_number":90,"context_line":"                created_share, new_meta"},{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        self.assertEqual(updated_share[\u0027metadata\u0027], new_meta)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        deleted_share \u003d ("},{"line_number":96,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("}],"source_content_type":"text/x-python","patch_set":7,"id":"db3805bb_6dafb536","line":93,"range":{"start_line":88,"start_character":0,"end_line":93,"end_character":61},"in_reply_to":"c8dd49c4_43297435","updated":"2023-07-05 16:41:27.000000000","message":"you\u0027re not using \"replace\u003dTrue\"; so the metadata should be appended","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        new_meta \u003d {\"newFoo\": \"newBar\"}"},{"line_number":86,"context_line":"        empty_meta \u003d {}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        updated_share \u003d ("},{"line_number":89,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("},{"line_number":90,"context_line":"                created_share, new_meta"},{"line_number":91,"context_line":"            )"},{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        self.assertEqual(updated_share[\u0027metadata\u0027], new_meta)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        deleted_share \u003d ("},{"line_number":96,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("}],"source_content_type":"text/x-python","patch_set":7,"id":"a6d84e9f_cfc84236","line":93,"range":{"start_line":88,"start_character":0,"end_line":93,"end_character":61},"in_reply_to":"db3805bb_6dafb536","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f21ebfb6d75ea74579e3c655afd175470b9308b","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        self.assertEqual(updated_share[\u0027metadata\u0027], new_meta)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        deleted_share \u003d ("},{"line_number":96,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("},{"line_number":97,"context_line":"                updated_share, empty_meta"},{"line_number":98,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":7,"id":"bcdc1f38_6cddda50","line":95,"updated":"2023-06-30 01:40:05.000000000","message":"maybe call this \"share_with_deleted_metadata\"?","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"bd7ca524ef80435967a870d00572aace36d39da4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        self.assertEqual(updated_share[\u0027metadata\u0027], new_meta)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        deleted_share \u003d ("},{"line_number":96,"context_line":"            self.operator_cloud.shared_file_system.update_share_metadata("},{"line_number":97,"context_line":"                updated_share, empty_meta"},{"line_number":98,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":7,"id":"569c7cbb_f0dbc4b7","line":95,"in_reply_to":"bcdc1f38_6cddda50","updated":"2023-07-12 03:14:17.000000000","message":"Done","commit_id":"f47bf4bfb22088b7d6ff5627ac244a509d13ff1e"}]}