)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"b7d0be1cc1b1815bb8947f2a593ee14b5ff40989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5b53442_cbd52642","updated":"2023-06-28 06:23:39.000000000","message":"This follows the discussion in https://github.com/openstack/openstacksdk/commit/3cb5bc98573e8eb7d3487121b7b59ebd535035c5","commit_id":"a2e17a7e3e5574c5c6aa1114c953a0712c6b42cf"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"d102bc42636cdf89c501c96a1990a02ef1ce502e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b7d899b_e425cdd3","updated":"2023-06-28 07:58:10.000000000","message":"I think the reason py38 failed for not related reason\n```\n{1} openstack.tests.unit.test_stats.TestStats.test_servers_no_detail [1.057683s] ... FAILED\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n\n      File \"/home/zuul/src/opendev.org/openstack/openstacksdk/openstack/tests/unit/test_stats.py\", line 292, in test_servers_no_detail\n    self.assert_reported_stat(\n\n      File \"/home/zuul/src/opendev.org/openstack/openstacksdk/openstack/tests/unit/test_stats.py\", line 163, in assert_reported_stat\n    raise Exception(\"Key %s not found in reported stats\" % key)\n\n    Exception: Key openstack.api.compute.GET.servers.200 not found in reported stats\n\n\nCaptured statsd_content:\n~~~~~~~~~~~~~~~~~~~~~~~~\n    [b\u0027openstack.api.compute.GET.servers.200:1.000000|ms\\nopenstack.api.compute.\u0027\n b\u0027GET.servers.200:1|c\\nopenstack.api.compute.GET.servers.attempted:1|c\u0027]\n\n```","commit_id":"10f6395ffb765401afe917099d2a83b2652f4f44"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"1483aba458ed3a92cc82982b76759e0c9ff4dec8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f1f1bfb_6b710f44","updated":"2023-06-28 09:17:04.000000000","message":"I\u0027ve come across the issue as well and applying this patch resolved the problem","commit_id":"10f6395ffb765401afe917099d2a83b2652f4f44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6a41723ea71a994ff520d2bb43975341da9d1fa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a2ccdb21_ae0e2a6d","updated":"2023-06-28 13:07:30.000000000","message":"That won\u0027t work if we are still using the annotations in \"supports_version\". Instead of that, if this project is still supporting py36, we should partially revert the change that introduced this import.","commit_id":"10f6395ffb765401afe917099d2a83b2652f4f44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d9dfed766e32b4642c6947641d57ee5f9e6c3ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0bfac395_e0c069e4","updated":"2023-06-28 14:11:47.000000000","message":"Also, as a follow-up, we clearly need to add tests for Python 3.6 *or* explicitly remove support. I\u0027d be in favour of the latter long-term (next few months) but we don\u0027t need to do it today.","commit_id":"e4368bcce2d19b1d56c918ed4871876164876428"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"9f671ea6c582a6fb7550f2d92485f163a4f34e3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c95c30ed_7643f300","updated":"2023-06-28 17:46:47.000000000","message":"shame on  me to have missed previously microversion changes. Remember to never review from mobile","commit_id":"2da00af16014e16d447e28940742e381a0c9c1a6"}],"openstack/utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7e60122f74620f2d7e8fc43452d4a593344f3bb2","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        return keys"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def supports_version(adapter, version, raise_exception\u003dFalse):"},{"line_number":102,"context_line":"    \"\"\"Determine if the given adapter supports the given version."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    Checks the version asserted by the service and ensures this matches the"}],"source_content_type":"text/x-python","patch_set":4,"id":"c6887f93_451c5f8c","line":101,"updated":"2023-06-28 14:09:21.000000000","message":"You don\u0027t need to drop the annotations, just the import. We\u0027re not actually relying on postponed evaluation yet.","commit_id":"e4368bcce2d19b1d56c918ed4871876164876428"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"102158810da4ee1723939da8e151ac75abfdb060","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return keys"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def supports_version(adapter, version, raise_exception\u003dFalse):"},{"line_number":102,"context_line":"    \"\"\"Determine if the given adapter supports the given version."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    Checks the version asserted by the service and ensures this matches the"}],"source_content_type":"text/x-python","patch_set":4,"id":"64c55cb9_0747288c","line":101,"in_reply_to":"c6887f93_451c5f8c","updated":"2023-06-28 14:21:19.000000000","message":"Done","commit_id":"e4368bcce2d19b1d56c918ed4871876164876428"}]}
