)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f2820ef42afa783101d3f511fbb1d2818d59b93d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9e6dcb4e_182c4e49","updated":"2023-07-07 11:46:52.000000000","message":"@stephenfin,","commit_id":"d7c448ecb60a1a3b4f8b654c49b1b268c66d2e10"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"05a46fb834a4ee87a31fb972ad60728619913175","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"646d62ba_7a0b59a0","updated":"2024-02-18 16:37:03.000000000","message":"recheck","commit_id":"8c988b7e627ef802c019979c26fd5cac24871473"}],"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a76d04002171566a7ea44fac9ffd531065be591a","unresolved":true,"context_lines":[{"line_number":2194,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":2195,"context_line":"        return self._list("},{"line_number":2196,"context_line":"            _server_migration.ServerMigration,"},{"line_number":2197,"context_line":"            server_uuid\u003dserver_id,"},{"line_number":2198,"context_line":"        )"},{"line_number":2199,"context_line":""},{"line_number":2200,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Migrations \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b2685f3_08dd69f8","line":2197,"updated":"2023-07-06 16:12:30.000000000","message":"Good spot. However, I think the correct thing to do here is to fix `ServerMigration.base_path` and the `server_id` attribute?","commit_id":"d7c448ecb60a1a3b4f8b654c49b1b268c66d2e10"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c60393d1b3a94d65ba66bd2f8ec19b71ac148e18","unresolved":false,"context_lines":[{"line_number":2194,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":2195,"context_line":"        return self._list("},{"line_number":2196,"context_line":"            _server_migration.ServerMigration,"},{"line_number":2197,"context_line":"            server_uuid\u003dserver_id,"},{"line_number":2198,"context_line":"        )"},{"line_number":2199,"context_line":""},{"line_number":2200,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Migrations \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8c330a6_3e6c8137","line":2197,"in_reply_to":"2f0ae94f_463af09a","updated":"2024-02-15 21:03:35.000000000","message":"Done","commit_id":"d7c448ecb60a1a3b4f8b654c49b1b268c66d2e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f2001badafca109157150d2be5e14cfa859fc5f","unresolved":true,"context_lines":[{"line_number":2194,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":2195,"context_line":"        return self._list("},{"line_number":2196,"context_line":"            _server_migration.ServerMigration,"},{"line_number":2197,"context_line":"            server_uuid\u003dserver_id,"},{"line_number":2198,"context_line":"        )"},{"line_number":2199,"context_line":""},{"line_number":2200,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Migrations \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f0ae94f_463af09a","line":2197,"in_reply_to":"5ffc0f6a_0d894909","updated":"2023-07-10 08:54:25.000000000","message":"tbh, I doubt that anyone is relying on the resource object directly. Virtually every user of SDK that I\u0027m aware of uses the proxy or cloud APIs. I think there\u0027s no issue changing this, though we can include a release note if you are concerned.","commit_id":"d7c448ecb60a1a3b4f8b654c49b1b268c66d2e10"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f2820ef42afa783101d3f511fbb1d2818d59b93d","unresolved":true,"context_lines":[{"line_number":2194,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":2195,"context_line":"        return self._list("},{"line_number":2196,"context_line":"            _server_migration.ServerMigration,"},{"line_number":2197,"context_line":"            server_uuid\u003dserver_id,"},{"line_number":2198,"context_line":"        )"},{"line_number":2199,"context_line":""},{"line_number":2200,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Migrations \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ffc0f6a_0d894909","line":2197,"in_reply_to":"7b2685f3_08dd69f8","updated":"2023-07-07 11:46:52.000000000","message":"probably, but I\u0027m not sure what would break if we change it there.\n\nThis value of \u0027base_path\u0027 is a kind of a part of \u0027public api\u0027 of the ServerMigration object, some might be using it already, and I don\u0027t think we can support both at the same time.\n\nContrary, what we name attribute we pass here is internal implementation detail.","commit_id":"d7c448ecb60a1a3b4f8b654c49b1b268c66d2e10"}]}