)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"54638a6bcd30455efb0e936f5391b2f7dae531cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf823a06_16c4c4f6","updated":"2023-07-19 08:43:31.000000000","message":"Hello, this patch works for me but I\u0027m unsure I set the proper version.\nPlease let me know in comments if you would rather something different.","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"734ea2b35ad20f5104387693b8575ef152980971","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff0c3285_29e6b8ad","updated":"2023-07-19 12:19:31.000000000","message":"Thank you for the change, Rene! The versioning in openstacksdk is a bit puzzling, so I left some questions. Maybe Stephen can shed some light on this :)","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"006b5e0d227ab837ed18c977c8cf679883fd027f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45fb81eb_93e5aafd","updated":"2023-07-19 16:21:54.000000000","message":"A minor change suggested inline, but doesn\u0027t change the functionality of this patch. Thanks Rene!","commit_id":"3d45785cb079141b6a974842f2db3183c4bff2a1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4de017f506360170b137a4cc64679c55bcc76db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"696d8d2c_5e2d709b","updated":"2023-07-19 13:23:34.000000000","message":"LGTM. Thanks for the changes, Rene!","commit_id":"3d45785cb079141b6a974842f2db3183c4bff2a1"}],"openstack/shared_file_system/v2/share_export_locations.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"734ea2b35ad20f5104387693b8575ef152980971","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    allow_delete \u003d False"},{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.63\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc5283e5_327c8544","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":30},"updated":"2023-07-19 12:19:31.000000000","message":"This _max_microversion is not the latest version in Manila, but I\u0027m unsure of what we are expected to set here... 2.63 refers to some changes in security services [1]. Have you tested without the 2.63 api version set?\n\nIn case we need to set _max_microversion to the most recent version where we had changes in the export location APIs would be 2.47 [2].\n\nAnyways, I saw most example using _max_microversion as \"the last time the API response/behavior has changed\", i.e: [3] [4], so that\u0027s what make me scratch my head on whether we should use the latest version of the service, or the latest version the APIs had significant changes/version bumps.\n\n[1] https://github.com/openstack/manila/blob/master/manila/api/openstack/api_version_request.py#L167C26-L167C26\n[2] https://github.com/openstack/manila/blob/master/manila/api/openstack/api_version_request.py#L123\n[3] https://github.com/openstack/openstacksdk/blob/b93ea39ea5c1edff4b59ad0940992b5e4a8c695a/openstack/compute/v2/server_action.py#L17C1-L17C1\n[4] https://github.com/openstack/openstacksdk/blob/b93ea39ea5c1edff4b59ad0940992b5e4a8c695a/openstack/compute/v2/volume_attachment.py#L51C1-L51C1","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"49077e418e7bffacd2815e709ab50d9504b005e8","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    allow_delete \u003d False"},{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.63\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5c47158_88a1c7ef","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":30},"in_reply_to":"37e0b299_48219689","updated":"2023-07-19 12:48:05.000000000","message":"I have just changed to 2.47 as proposed by Carlos","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"971d27df699912ea1ece83d0dfc595db1c9a4d39","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    allow_delete \u003d False"},{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.63\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"37e0b299_48219689","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":30},"in_reply_to":"cc5283e5_327c8544","updated":"2023-07-19 12:24:49.000000000","message":"\u003e Anyways, I saw most example using _max_microversion as \"the last time the API response/behavior has changed\", i.e: [3] [4], so that\u0027s what make me scratch my head on whether we should use the latest version of the service, or the latest version the APIs had significant changes/version bumps.\n\nAh, yes, that\u0027s the intended purpose of this attribute. I had wrongfully assumed that René had used this version. If not, we should update to the version where we most recently had changes, as you suggest.","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25296c905e679fa4635a701cd9e2740f7a7e06f4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    allow_delete \u003d False"},{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.63\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"1201e845_68a7e0c9","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":30},"in_reply_to":"f5c47158_88a1c7ef","updated":"2023-07-19 15:13:01.000000000","message":"Done","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c68fb672802c882482d1a2d46c2d43a57ebfc55","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.63\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"},{"line_number":34,"context_line":"    # The share ID, part of the URI for export locations"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ef9635d_04e94c3f","line":31,"updated":"2023-07-19 11:49:33.000000000","message":"This doesn\u0027t do anything currently, but it\u0027s no harm to have it for a future when we do support it.","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"49077e418e7bffacd2815e709ab50d9504b005e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.63\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"},{"line_number":34,"context_line":"    # The share ID, part of the URI for export locations"}],"source_content_type":"text/x-python","patch_set":1,"id":"5cf7ed46_cff718a0","line":31,"in_reply_to":"4ef9635d_04e94c3f","updated":"2023-07-19 12:48:05.000000000","message":"Ack","commit_id":"2abf7b2da7944069216cc490b2e52557dae04e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"006b5e0d227ab837ed18c977c8cf679883fd027f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    allow_delete \u003d False"},{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.47\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":2,"id":"67865ef7_3c50a019","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":30},"updated":"2023-07-19 16:21:54.000000000","message":"_max_microversion is a way to negotiate with the server when the connection doesn\u0027t  have a default microversion configured.. it will cause the version used eventually to be the minimum between the version specified here and the version supported by the driver. \n\n\nalso this is the behavior:\n\n  \n\n     +-------------------+----------------+---------------+\n     | _max_microversion | server_version | what\u0027s picked |\n     +-------------------+----------------+---------------+\n     |              2.47 |            2.6 |           2.6 |\n     |              2.47 |           2.79 |          2.47 |\n     |              2.47 |           2.47 |          2.47 |\n     +-------------------+----------------+---------------+\n\n\nin case of the first scenario, adding this property doesn\u0027t really help. The server will respond with  HTTPNotFound, because this API was introduced in version 2.9, but, the server doesn\u0027t have 2.9 and the version used by the SDK is 2.6 (the minimum of the maximums)\n\nquite confusing :/ \n\nI think we need to introduce a _min_microversion and improve user experience instead.. but that\u0027s not the concern of this specific patch.","commit_id":"3d45785cb079141b6a974842f2db3183c4bff2a1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"49597adc3420b9a65e811f45353df67747f05867","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    allow_delete \u003d False"},{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.47\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":2,"id":"3d9fa9a9_75e5795d","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":30},"in_reply_to":"67865ef7_3c50a019","updated":"2023-07-20 11:07:39.000000000","message":"Ack, yeah, @gtema is working on some extensive changes to the `Resource` object [at the moment](https://review.opendev.org/c/openstack/openstacksdk/+/884909/). This is potentially one to add to that list.","commit_id":"3d45785cb079141b6a974842f2db3183c4bff2a1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"006b5e0d227ab837ed18c977c8cf679883fd027f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _max_microversion \u003d \u00272.47\u0027"},{"line_number":31,"context_line":"    _min_microversion \u003d \u00272.9\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #: Properties"},{"line_number":34,"context_line":"    # The share ID, part of the URI for export locations"}],"source_content_type":"text/x-python","patch_set":2,"id":"a8e3ed19_6ed4fd4b","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":29},"updated":"2023-07-19 16:21:54.000000000","message":"Since this doesn\u0027t work yet, i think we should drop this or convert it to a doc string so it doesn\u0027t confuse the next person looking at this :)","commit_id":"3d45785cb079141b6a974842f2db3183c4bff2a1"}]}