)]}'
{".vscode/settings.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a220489e6004775abe01d22b1ef10d03c695d2d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52b1ef1c_ec9df11f","updated":"2023-07-28 22:23:29.000000000","message":"please remove this file; \n\n\nlocally, you can set your gitignore to ignore anything in a \".vscode\" directory:\n\nhttps://www.flother.is/til/global-gitignore/","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"5d95e0e2a734bf35ab69d90f02685d4f5812bd76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e575a970_fac6a603","in_reply_to":"08b50198_511840ff","updated":"2023-08-03 04:27:15.000000000","message":"Done","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"f55d9e83eb517667d1ab9865674a0f673d390366","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08b50198_511840ff","in_reply_to":"3179637c_4b709e01","updated":"2023-08-02 18:43:35.000000000","message":"That worked. Thanks!","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de473308dd2f184351d300d48bf5f7fcca52f2b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c4336c97_9ef76a21","in_reply_to":"3d6aba34_2007218b","updated":"2023-07-31 15:20:21.000000000","message":"you could place the file in the repo\u0027s \".gitignore\"; or, i would suggest creating a global gitignore file for yourself.. \n\nas the doc suggests, create this file: \"~/.gitignore\" \nthis puts a \".gitignore\" in your home directory.. \n\nthen you can configure git globally to ignore whatever glob patterns of files/directories are specified in that gitignore file: \n\n```\ngit config --global core.excludesfile ~/.gitignore\n```","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"e9b87b0f8ac30cedabac54205f7f7ff36967ad19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d6aba34_2007218b","in_reply_to":"52b1ef1c_ec9df11f","updated":"2023-07-29 05:20:46.000000000","message":"Is there a specific place I can set this? The source linked suggests having it in the repo\u0027s top-level .gitignore.","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"cfb50b15454cdcea48fde7bd6a9f4ae6012fabb6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e149cb21_e527407f","in_reply_to":"c4336c97_9ef76a21","updated":"2023-08-02 04:08:52.000000000","message":"When I tried this and then committed, I get the following message, which makes me think the file has been properly deleted:\n\n5 files changed, 180 insertions(+), 1 deletion(-)\n create mode 100644 .vscode/settings.json\n \n However, when I push my change for review, I still see the file.","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c707297b821b37e957d997233955c9f3c7f7eeca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3179637c_4b709e01","in_reply_to":"e149cb21_e527407f","updated":"2023-08-02 04:30:30.000000000","message":"try:\n\n```\ngit rm .vscode/settings.json\n```","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"}],"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00f888a5705796ea2801511011be94f91305b795","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Anvi Joshi \u003canviajoshi@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-02 18:42:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for managing and unmanaging shares in the shared file systems service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I95b72434a8a44f737f5ee9a44b6ecbf8f4162a7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d8b91eff_8e5e2a7e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":81},"updated":"2023-08-02 21:21:57.000000000","message":"please keep the commit message title line under 50 characters. you can provide more detail in the body of the commit message..\n\n \nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nMaybe something like:\n\n```\nSupport manage/unmanage shares with manila\n```\n\nwill suffice and provide the same meaning","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"5d95e0e2a734bf35ab69d90f02685d4f5812bd76","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anvi Joshi \u003canviajoshi@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-02 18:42:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for managing and unmanaging shares in the shared file systems service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I95b72434a8a44f737f5ee9a44b6ecbf8f4162a7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"6466eb75_8f1ed06b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":81},"in_reply_to":"d8b91eff_8e5e2a7e","updated":"2023-08-03 04:27:15.000000000","message":"Done","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00f888a5705796ea2801511011be94f91305b795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c9c19e61_2e8af122","updated":"2023-08-02 21:21:57.000000000","message":"Hi Anvi; \n\nthis is great; we\u0027re having some instability in the CI at the moment... meanwhile could you see some minor comments inline?\n\nThanks!","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7cbcfd6efffaaa881bf21ec94b186d845a7c106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3d11e9df_fae7bb1a","updated":"2023-08-03 04:47:09.000000000","message":"Also please add a release note!","commit_id":"b457d91740759394827edf23e18e964d5331a327"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"f75d072cab0aa44ee6e5a7992eabe93c00ecabc3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b0449d79_25e609fb","updated":"2023-08-03 04:30:31.000000000","message":"Hi, thank you for the initial comments! I have made the corresponding changes in the current patch. In terms of documentation, does the format look any different from share metadata? If so, which files should I create/modify?","commit_id":"b457d91740759394827edf23e18e964d5331a327"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"573e969ec5e449d08bfc9dcd7649e7d9ca596956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c6f52b64_922be6a9","in_reply_to":"2a7d4271_81306075","updated":"2023-08-04 03:25:38.000000000","message":"Done","commit_id":"b457d91740759394827edf23e18e964d5331a327"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"814a8a1904267cea8e9923c23ab23ed82085071a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2a7d4271_81306075","in_reply_to":"b0449d79_25e609fb","updated":"2023-08-03 04:46:50.000000000","message":"Thanks for the question; \n\nyou could add manage and unmanage examples in the user docs to this file: https://github.com/openstack/openstacksdk/blob/master/doc/source/user/guides/shared_file_system.rst \n\nMake sure the docstrings that you\u0027ve added in the proxy methods show up in the proxy doc; you\u0027d need to add \"manage_share\" and \"unmanage_share\" to the list of members here: https://github.com/openstack/openstacksdk/blob/master/doc/source/user/proxies/shared_file_system.rst#shared-file-system-shares\n\n\nThe methods you\u0027ve added in the share.py resource file should automatically get covered in the doc file that exists: https://github.com/openstack/openstacksdk/blob/master/doc/source/user/resources/shared_file_system/v2/share.rst\n\n\nI\u0027d just make sure that the output in \"tox -e docs\" looks correct. When you execute \"tox -e docs\", you will see a \"html\" folder created that is a rendered documentation website - a local copy of https://docs.openstack.org/openstacksdk/latest/. You can launch the index.html file with your browser and look at the content of this locally.\n\nSphinx - our RST to HTML rendering software does not tolerate indentation issues well, so pay attention to indents inside docstrings by verifying how the output looks locally (or in the CI results here).","commit_id":"b457d91740759394827edf23e18e964d5331a327"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3ee465070914c1636454fd14aaa7dc0f14a5607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3e5256c0_126be791","updated":"2023-08-04 18:18:21.000000000","message":"The docs job is failing because of this error:\n\n2023-08-04 03:47:19.725857 | ubuntu-jammy | /home/zuul/src/opendev.org/openstack/openstacksdk/openstack/shared_file_system/v2/share.py:docstring of openstack.shared_file_system.v2.share.Share.manage:13: WARNING: Bullet list ends without a blank line; unexpected unindent.","commit_id":"5a452dfc1c6c7b001a09683db7bb05e97d8de66b"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"197db97375a62d6abd16732ac609f890db85c309","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dc42e278_0e32eeb4","in_reply_to":"3e5256c0_126be791","updated":"2023-08-05 18:00:49.000000000","message":"Thanks, should be fixed now.","commit_id":"5a452dfc1c6c7b001a09683db7bb05e97d8de66b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d519facf5998716d89f4615e4e5112c5c875859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"24dc8295_8579c52d","updated":"2023-08-08 20:36:50.000000000","message":"Anvi, could you please update your \"master\" branch and rebase this change? \n\n```\n $ git fetch origin\n $ git review -d 888940\n $ git rebase -i origin/master\n```\n\nresolve all merge conflicts, use \"git rebase --continue\" and \"git review\" to update this change.","commit_id":"045320d7abef91266d6d92ea359868211a11a087"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"084c85093d7c37cc15550011ffa6ef6e7082d775","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"86f04bbf_8af74195","updated":"2023-08-07 17:51:43.000000000","message":"LGTM; Thank you Anvi!","commit_id":"045320d7abef91266d6d92ea359868211a11a087"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de398647ff673b985b6305bc03eeaa74c9686715","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e2b4c99a_819b9b4a","updated":"2023-08-09 04:40:19.000000000","message":"Thank you; LGTM","commit_id":"7b5356f32de2a0cd9bde411c008ec612df5c0f99"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a220489e6004775abe01d22b1ef10d03c695d2d","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def manage_share(self, protocol, export_path, service_host, **params):"},{"line_number":185,"context_line":"        \"\"\"Manage a share."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        :param str protocol: The shared file systems protocol of this share."},{"line_number":188,"context_line":"        :param str export_path: The export path formatted according to the protocol."},{"line_number":189,"context_line":"        :param str service_host: The manage-share service host."},{"line_number":190,"context_line":"        :param dict params: A dict providing the details of a share to be"},{"line_number":191,"context_line":"                            managed."},{"line_number":192,"context_line":"        :param kwargs params: Optional parameters to be sent. Available parameters include:"},{"line_number":193,"context_line":"            * name: The user defined name of the resource."},{"line_number":194,"context_line":"            * share_type: The name or ID of the share type to be used to create the resource."},{"line_number":195,"context_line":"            * driver_options: A set of one or more key and value pairs, as a dictionary of strings, that describe driver options."},{"line_number":196,"context_line":"            * is_public: The level of visibility for the share."},{"line_number":197,"context_line":"            * description: The user defiend description of the resource."},{"line_number":198,"context_line":"            * share_server_id: The UUID of the share server."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :returns: The share that was managed."}],"source_content_type":"text/x-python","patch_set":3,"id":"bff7af1f_efb3cc14","line":197,"range":{"start_line":186,"start_character":0,"end_line":197,"end_character":72},"updated":"2023-07-28 22:23:29.000000000","message":"please wrap long lines to 79 characters or less","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"e9b87b0f8ac30cedabac54205f7f7ff36967ad19","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def manage_share(self, protocol, export_path, service_host, **params):"},{"line_number":185,"context_line":"        \"\"\"Manage a share."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        :param str protocol: The shared file systems protocol of this share."},{"line_number":188,"context_line":"        :param str export_path: The export path formatted according to the protocol."},{"line_number":189,"context_line":"        :param str service_host: The manage-share service host."},{"line_number":190,"context_line":"        :param dict params: A dict providing the details of a share to be"},{"line_number":191,"context_line":"                            managed."},{"line_number":192,"context_line":"        :param kwargs params: Optional parameters to be sent. Available parameters include:"},{"line_number":193,"context_line":"            * name: The user defined name of the resource."},{"line_number":194,"context_line":"            * share_type: The name or ID of the share type to be used to create the resource."},{"line_number":195,"context_line":"            * driver_options: A set of one or more key and value pairs, as a dictionary of strings, that describe driver options."},{"line_number":196,"context_line":"            * is_public: The level of visibility for the share."},{"line_number":197,"context_line":"            * description: The user defiend description of the resource."},{"line_number":198,"context_line":"            * share_server_id: The UUID of the share server."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :returns: The share that was managed."}],"source_content_type":"text/x-python","patch_set":3,"id":"911986a4_7a10dd74","line":197,"range":{"start_line":186,"start_character":0,"end_line":197,"end_character":72},"in_reply_to":"bff7af1f_efb3cc14","updated":"2023-07-29 05:20:46.000000000","message":"Done","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"}],"openstack/shared_file_system/v2/share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a220489e6004775abe01d22b1ef10d03c695d2d","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        body \u003d {\"revert\": {\"snapshot_id\": snapshot_id}}"},{"line_number":161,"context_line":"        self._action(session, body)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def manage_share("},{"line_number":164,"context_line":"        self, session, protocol, export_path, service_host, **params"},{"line_number":165,"context_line":"    ):"},{"line_number":166,"context_line":"        \"\"\"Manage a share."}],"source_content_type":"text/x-python","patch_set":3,"id":"fc85ebd0_59336535","line":163,"range":{"start_line":163,"start_character":8,"end_line":163,"end_character":20},"updated":"2023-07-28 22:23:29.000000000","message":"\"share\" here is redundant, suggest calling this method \"manage\"","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"e9b87b0f8ac30cedabac54205f7f7ff36967ad19","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        body \u003d {\"revert\": {\"snapshot_id\": snapshot_id}}"},{"line_number":161,"context_line":"        self._action(session, body)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def manage_share("},{"line_number":164,"context_line":"        self, session, protocol, export_path, service_host, **params"},{"line_number":165,"context_line":"    ):"},{"line_number":166,"context_line":"        \"\"\"Manage a share."}],"source_content_type":"text/x-python","patch_set":3,"id":"45d1312d_da61d4eb","line":163,"range":{"start_line":163,"start_character":8,"end_line":163,"end_character":20},"in_reply_to":"fc85ebd0_59336535","updated":"2023-07-29 05:20:46.000000000","message":"Done","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a220489e6004775abe01d22b1ef10d03c695d2d","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        self._translate_response(resp)"},{"line_number":200,"context_line":"        return self"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def unmanage_share(self, session):"},{"line_number":203,"context_line":"        \"\"\"Unmanage a share."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        :param session: A session object used for sending request."}],"source_content_type":"text/x-python","patch_set":3,"id":"b664b1c3_0a1e8ca8","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":22},"updated":"2023-07-28 22:23:29.000000000","message":"just \"unmanage\"","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"e9b87b0f8ac30cedabac54205f7f7ff36967ad19","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        self._translate_response(resp)"},{"line_number":200,"context_line":"        return self"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def unmanage_share(self, session):"},{"line_number":203,"context_line":"        \"\"\"Unmanage a share."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        :param session: A session object used for sending request."}],"source_content_type":"text/x-python","patch_set":3,"id":"b6b1d18a_4faaf5b0","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":22},"in_reply_to":"b664b1c3_0a1e8ca8","updated":"2023-07-29 05:20:46.000000000","message":"Done","commit_id":"84cdca62ec36eedcb9a541227c1af4ca9c9e203d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00f888a5705796ea2801511011be94f91305b795","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Manage a share."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        :param session: A session object used for sending request."},{"line_number":167,"context_line":"        :param str protocol: The shared file systems protocol of this share."},{"line_number":168,"context_line":"        :param str export_path: The export path formatted according to the protocol."},{"line_number":169,"context_line":"        :param str service_host: The manage-share service host."},{"line_number":170,"context_line":"        :param dict params: A dict providing the details of a share to be"},{"line_number":171,"context_line":"                            managed."},{"line_number":172,"context_line":"        :param kwargs params: Optional parameters to be sent. Available parameters include:"},{"line_number":173,"context_line":"            * name: The user defined name of the resource."},{"line_number":174,"context_line":"            * share_type: The name or ID of the share type to be used to create the resource."},{"line_number":175,"context_line":"            * driver_options: A set of one or more key and value pairs, as a dictionary of strings, that describe driver options."},{"line_number":176,"context_line":"            * is_public: The level of visibility for the share."},{"line_number":177,"context_line":"            * description: The user defiend description of the resource."},{"line_number":178,"context_line":"            * share_server_id: The UUID of the share server."}],"source_content_type":"text/x-python","patch_set":6,"id":"36705954_d41d32b8","line":175,"range":{"start_line":167,"start_character":76,"end_line":175,"end_character":129},"updated":"2023-08-02 21:21:57.000000000","message":"wrap these long lines at 79 characters or lesser","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"5d95e0e2a734bf35ab69d90f02685d4f5812bd76","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Manage a share."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        :param session: A session object used for sending request."},{"line_number":167,"context_line":"        :param str protocol: The shared file systems protocol of this share."},{"line_number":168,"context_line":"        :param str export_path: The export path formatted according to the protocol."},{"line_number":169,"context_line":"        :param str service_host: The manage-share service host."},{"line_number":170,"context_line":"        :param dict params: A dict providing the details of a share to be"},{"line_number":171,"context_line":"                            managed."},{"line_number":172,"context_line":"        :param kwargs params: Optional parameters to be sent. Available parameters include:"},{"line_number":173,"context_line":"            * name: The user defined name of the resource."},{"line_number":174,"context_line":"            * share_type: The name or ID of the share type to be used to create the resource."},{"line_number":175,"context_line":"            * driver_options: A set of one or more key and value pairs, as a dictionary of strings, that describe driver options."},{"line_number":176,"context_line":"            * is_public: The level of visibility for the share."},{"line_number":177,"context_line":"            * description: The user defiend description of the resource."},{"line_number":178,"context_line":"            * share_server_id: The UUID of the share server."}],"source_content_type":"text/x-python","patch_set":6,"id":"ff1f126e_91c27f38","line":175,"range":{"start_line":167,"start_character":76,"end_line":175,"end_character":129},"in_reply_to":"36705954_d41d32b8","updated":"2023-08-03 04:27:15.000000000","message":"Done","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"}],"openstack/tests/functional/shared_file_system/test_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00f888a5705796ea2801511011be94f91305b795","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        self.export_id \u003d exports[0][1]"},{"line_number":182,"context_line":"        self.export_path \u003d exports[0][0]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self.share_instances \u003d self.operator_cloud.share.share_instances("},{"line_number":185,"context_line":"            export_location_id\u003dself.export_id"},{"line_number":186,"context_line":"        )"},{"line_number":187,"context_line":"        hosts \u003d [instance[\u0027host\u0027] for instance in self.share_instances]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.share_host \u003d hosts[0]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_manage_and_unmanage_share(self):"},{"line_number":192,"context_line":"        self.operator_cloud.share.unmanage_share(self.SHARE_ID)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a9e712a_a6f6f1bc","line":189,"range":{"start_line":184,"start_character":0,"end_line":189,"end_character":34},"updated":"2023-08-02 21:21:57.000000000","message":"a straightforward way to get the host; get the share using the operator_cloud connection:\n\n```\n self.share_host \u003d self.operator_cloud.get_share(self.SHARE_ID)[\u0027host\u0027]\n \n```","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"5d95e0e2a734bf35ab69d90f02685d4f5812bd76","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.export_id \u003d exports[0][1]"},{"line_number":182,"context_line":"        self.export_path \u003d exports[0][0]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self.share_instances \u003d self.operator_cloud.share.share_instances("},{"line_number":185,"context_line":"            export_location_id\u003dself.export_id"},{"line_number":186,"context_line":"        )"},{"line_number":187,"context_line":"        hosts \u003d [instance[\u0027host\u0027] for instance in self.share_instances]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.share_host \u003d hosts[0]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_manage_and_unmanage_share(self):"},{"line_number":192,"context_line":"        self.operator_cloud.share.unmanage_share(self.SHARE_ID)"}],"source_content_type":"text/x-python","patch_set":6,"id":"30fae284_6e13ddaf","line":189,"range":{"start_line":184,"start_character":0,"end_line":189,"end_character":34},"in_reply_to":"3a9e712a_a6f6f1bc","updated":"2023-08-03 04:27:15.000000000","message":"Done","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00f888a5705796ea2801511011be94f91305b795","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"26fb7f23_4851433a","line":235,"range":{"start_line":229,"start_character":8,"end_line":235,"end_character":0},"updated":"2023-08-02 21:21:57.000000000","message":"same as above; only make sure to get the share after it\u0027s \"available\" using the operator_cloud connection, you\u0027ll see the \"host\" field","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"},{"author":{"_account_id":36056,"name":"Anvi Joshi","display_name":"Anvi Joshi","email":"anviajoshi@gmail.com","username":"anvijoshi"},"change_message_id":"5d95e0e2a734bf35ab69d90f02685d4f5812bd76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b479ca28_431bab2f","line":235,"range":{"start_line":229,"start_character":8,"end_line":235,"end_character":0},"in_reply_to":"26fb7f23_4851433a","updated":"2023-08-03 04:27:15.000000000","message":"Done","commit_id":"0bc80e2e486d243c87dd82fdf959dcddd0746a5b"}]}
