)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"cb237b2e3c91435522c1f1348cd7777bea28231c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9e152480_82060fb1","updated":"2023-07-24 15:51:35.000000000","message":"Hello, I\u0027m not sure that\u0027s the proper way to handle this.\n\nPlease let me know what you think about it.","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b37112d2db7c831662e2b0e412c12b136fe0baad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a241dba_d759f493","updated":"2023-07-24 20:55:30.000000000","message":"Thank you for fixing this up; please see comments inline","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"55411e63b48ac4c5b2478eac2d1cd85302b1f7d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b989a7f7_4b894975","in_reply_to":"9e152480_82060fb1","updated":"2023-07-25 08:34:45.000000000","message":"Done","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2ce47868a001da92a1f55d72f55a84bd6ce5f582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edd8d46e_2de24880","updated":"2023-07-25 10:18:28.000000000","message":"LGTM, thanks René","commit_id":"213311010c5de6de5d9147aca8efdf7a1a1d9706"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c51b79d8b0caf5f136728fe3bc9126a6791bf959","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0074049f_f607749c","updated":"2023-07-26 10:38:50.000000000","message":"LGTM, thanks René! The change is now in merge conflict, could you please rebase it?","commit_id":"213311010c5de6de5d9147aca8efdf7a1a1d9706"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ac810b26c490d2e3bef04624f5409e72c06022c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8df7990a_5f390633","updated":"2023-07-25 17:26:13.000000000","message":"Thank you Rene!","commit_id":"213311010c5de6de5d9147aca8efdf7a1a1d9706"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"8b5de17bbc538c8c3abd5a92a6b2b2cf4fa55318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd6c9abb_cc490dfc","in_reply_to":"0074049f_f607749c","updated":"2023-07-26 12:47:06.000000000","message":"Rebase done.","commit_id":"213311010c5de6de5d9147aca8efdf7a1a1d9706"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"1ca49204653028e0de580777ab11dfbb974925fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30162bb7_23b3a0fb","in_reply_to":"8df7990a_5f390633","updated":"2023-07-26 09:45:49.000000000","message":"You are welcome.","commit_id":"213311010c5de6de5d9147aca8efdf7a1a1d9706"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01076732b1a44dfe4b3d6df668c65d75ce97824b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca2e04ce_cb350012","updated":"2023-07-28 17:13:19.000000000","message":"FYI, this has broken the \u0027openstacksdk-functional-devstack-manila\u0027 job. Looks like one test needs an update here","commit_id":"c0758f146273d915aebe632e4953c6d0f54d3cf3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"95834b4f9eb0e5fe02729a4b200320a644ced429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"069e3392_736eb3ba","in_reply_to":"ca2e04ce_cb350012","updated":"2023-07-29 00:10:34.000000000","message":"UGH! thanks for noticing. I glossed over the failure when reviewing this. Fix is here: https://review.opendev.org/c/openstack/openstacksdk/+/889997","commit_id":"c0758f146273d915aebe632e4953c6d0f54d3cf3"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b37112d2db7c831662e2b0e412c12b136fe0baad","unresolved":true,"context_lines":[{"line_number":704,"context_line":"            _share_access_rule.ShareAccessRule, base_path\u003dbase_path, **attrs"},{"line_number":705,"context_line":"        )"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"    def delete_access_rule(self, access_id, share_id):"},{"line_number":708,"context_line":"        \"\"\"Deletes an access rule"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        :param access_id: The id of the access rule to get"}],"source_content_type":"text/x-python","patch_set":1,"id":"214bc5f4_86c17a8b","line":707,"updated":"2023-07-24 20:55:30.000000000","message":"all delete methods must implement the \"ignore_missing\" behavior for consistency.. so i suggest we keep that behavior. Adding the return statement on line 717 is fine.","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"55411e63b48ac4c5b2478eac2d1cd85302b1f7d3","unresolved":false,"context_lines":[{"line_number":704,"context_line":"            _share_access_rule.ShareAccessRule, base_path\u003dbase_path, **attrs"},{"line_number":705,"context_line":"        )"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"    def delete_access_rule(self, access_id, share_id):"},{"line_number":708,"context_line":"        \"\"\"Deletes an access rule"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        :param access_id: The id of the access rule to get"}],"source_content_type":"text/x-python","patch_set":1,"id":"c3e860c0_dff8fe0e","line":707,"in_reply_to":"214bc5f4_86c17a8b","updated":"2023-07-25 08:34:45.000000000","message":"Done","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"}],"openstack/shared_file_system/v2/share_access_rule.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b37112d2db7c831662e2b0e412c12b136fe0baad","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        if microversion is None:"},{"line_number":62,"context_line":"            microversion \u003d self._get_microversion(session, action\u003daction)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        return session.post("},{"line_number":65,"context_line":"            url, json\u003dbody, headers\u003dheaders, microversion\u003dmicroversion"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create(self, session, **kwargs):"},{"line_number":69,"context_line":"        return super().create("}],"source_content_type":"text/x-python","patch_set":1,"id":"cf86656f_364ce066","line":66,"range":{"start_line":64,"start_character":9,"end_line":66,"end_character":9},"updated":"2023-07-24 20:55:30.000000000","message":"+1","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"55411e63b48ac4c5b2478eac2d1cd85302b1f7d3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if microversion is None:"},{"line_number":62,"context_line":"            microversion \u003d self._get_microversion(session, action\u003daction)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        return session.post("},{"line_number":65,"context_line":"            url, json\u003dbody, headers\u003dheaders, microversion\u003dmicroversion"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create(self, session, **kwargs):"},{"line_number":69,"context_line":"        return super().create("}],"source_content_type":"text/x-python","patch_set":1,"id":"13ce35c4_98326e68","line":66,"range":{"start_line":64,"start_character":9,"end_line":66,"end_character":9},"in_reply_to":"cf86656f_364ce066","updated":"2023-07-25 08:34:45.000000000","message":"Ack","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b37112d2db7c831662e2b0e412c12b136fe0baad","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def delete(self, session, share_id):"},{"line_number":77,"context_line":"        body \u003d {\u0027deny_access\u0027: {\u0027access_id\u0027: self.id}}"},{"line_number":78,"context_line":"        url \u003d utils.urljoin(\u0027/shares\u0027, share_id, \u0027action\u0027)"},{"line_number":79,"context_line":"        # If something goes really wrong, we will have an exception"},{"line_number":80,"context_line":"        # (keystoneauth1.exceptions.base.ClientException),"},{"line_number":81,"context_line":"        # otherwise return the HTTP response so users can deal with it"},{"line_number":82,"context_line":"        # or simply check if we have a HTTP 202 for successful completion."},{"line_number":83,"context_line":"        response \u003d self._action(session, body, url)"},{"line_number":84,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":1,"id":"0dcb197c_b6aaa77e","line":83,"range":{"start_line":78,"start_character":58,"end_line":83,"end_character":51},"updated":"2023-07-24 20:55:30.000000000","message":"i was able to reproduce the bug; the method is silently failing _any_ errors because it isn\u0027t parsing the response that\u0027s coming back. \n\n\nwe still need \"ignore_missing\" functionality. I suggest rewriting this like:\n\n     \n\n         def delete(self, session, share_id, ignore_missing\u003dTrue):\n             body \u003d {\u0027deny_access\u0027: {\u0027access_id\u0027: self.id}}\n             url \u003d utils.urljoin(\u0027/shares\u0027, share_id, \u0027action\u0027)\n    +        response \u003d self._action(session, body, url)\n             try:\n    -              response \u003d self._action(session, body, url)\n    +              self._translate_response(response)\n             except exceptions.ResourceNotFound:\n                 if not ignore_missing:\n                     raise\n             return response","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"55411e63b48ac4c5b2478eac2d1cd85302b1f7d3","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def delete(self, session, share_id):"},{"line_number":77,"context_line":"        body \u003d {\u0027deny_access\u0027: {\u0027access_id\u0027: self.id}}"},{"line_number":78,"context_line":"        url \u003d utils.urljoin(\u0027/shares\u0027, share_id, \u0027action\u0027)"},{"line_number":79,"context_line":"        # If something goes really wrong, we will have an exception"},{"line_number":80,"context_line":"        # (keystoneauth1.exceptions.base.ClientException),"},{"line_number":81,"context_line":"        # otherwise return the HTTP response so users can deal with it"},{"line_number":82,"context_line":"        # or simply check if we have a HTTP 202 for successful completion."},{"line_number":83,"context_line":"        response \u003d self._action(session, body, url)"},{"line_number":84,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d89c1ea_c1d2f76c","line":83,"range":{"start_line":78,"start_character":58,"end_line":83,"end_character":51},"in_reply_to":"0dcb197c_b6aaa77e","updated":"2023-07-25 08:34:45.000000000","message":"Done","commit_id":"e29b0bcdb9554b67bbbdd3f10adc6657547a2990"}]}