)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f146644_59dd60fe","updated":"2023-08-01 20:27:28.000000000","message":"Thanks Carlos; some comments inline.. could you please also add a release note in your next patch?","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7ecdf8c2_dfca2578","updated":"2023-08-02 11:42:42.000000000","message":"Thank you for the comments and suggestions, Goutham and Rene!\nForgot to remove the WIP from the commit, but I\u0027m not taking this as WIP anymore","commit_id":"525d5e0126e8ff2d2844a7278fab52c404fc8952"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"30f139d5_09519501","updated":"2023-09-14 17:56:32.000000000","message":"Thanks for the review, Goutham. Please take a look at the latest PS","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9cc018c15066e0ad529c833a8eb5e8b631bf16ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4e7cc25b_620ac471","updated":"2023-09-06 11:41:12.000000000","message":"Thanks for the review, Stephen! Please take another look","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"18d3c3c7_dda0043e","updated":"2023-09-11 23:15:30.000000000","message":"thanks for working on this, Carlos - please see a few minor comments inline","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f3525f47f543cb1f86d92ed7acfe5d0009c1657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b2d44cba_671cb5fc","updated":"2024-01-31 16:38:23.000000000","message":"A couple of doc/testing comments; but this looks good for now; and the rest can be addressed in a follow up change.. Thanks Carlos!","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"641498da_2982b269","updated":"2024-02-14 13:20:55.000000000","message":"Looks pretty complete. Some comments inline. Hopefully they\u0027re easily addressed!","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"fe92156a2ba1a50b2753dce1e8141c69bbb34e99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"07722e62_a075a056","updated":"2024-02-14 13:04:48.000000000","message":"This patch sounds good to me.\nThere are just 2 doc points to fix but it could be done afterwards.","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a4ce2bdc37923b0c801498f1924a62e1a45b3a2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1fa24bbd_bd3dd12c","updated":"2024-02-14 21:24:40.000000000","message":"Didn\u0027t run all functional tests locally, so there might be one or two things to fix... I\u0027ll check on the CI results","commit_id":"83c53c4d3836a4172622ca6004286d2a4ef555d2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9baaff32_b0cca2fe","updated":"2024-02-14 21:23:58.000000000","message":"Thank you for the reviews, please check the changes inline.","commit_id":"83c53c4d3836a4172622ca6004286d2a4ef555d2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f43bd545ce0c7b6566874b7bba0623e69f6f5c10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"61ae51a9_24e7ad6e","updated":"2024-02-15 00:05:31.000000000","message":"It looks like functional tests on this repo are broken; all of the functional test jobs are running unit tests instead of devstack/functional tests.. e.g.: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f53/889519/12/check/openstacksdk-functional-devstack-manila/f5346b6/testr_results.html","commit_id":"0082c376319d4ff804a5f8966a285486209e65ea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1d2f315d308cbfa30dbc2decc9cf8e4f7b890697","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0f214362_e8293bff","updated":"2024-02-15 14:18:51.000000000","message":"whoops","commit_id":"0082c376319d4ff804a5f8966a285486209e65ea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9dfd040634718ebd863e53aaed0e0b38c011e97f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0ddfd1cb_e584e348","in_reply_to":"61ae51a9_24e7ad6e","updated":"2024-02-15 14:18:42.000000000","message":"Indeed. This is a tox 4 issue. See [my bug report](https://github.com/tox-dev/tox/issues/3219).","commit_id":"0082c376319d4ff804a5f8966a285486209e65ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d4d5191254aa600d0a2a14c17b56b4149b815a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8cb55e15_349d585c","updated":"2024-02-16 01:52:21.000000000","message":"failing some functional tests: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_92c/889519/13/check/openstacksdk-functional-devstack-manila/92cb60f/testr_results.html","commit_id":"9c99416b67831188098c12fe77a029e37dd5f91e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a1e5fc55a8a3b889afbc5d4446ed7f028028bdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1681ac90_ef25c73a","updated":"2024-02-16 20:21:47.000000000","message":"couple of functional tests are still failing. could you please fix them?","commit_id":"e793210b6992335a1b05a1761eb119fac680504c"}],"doc/source/user/proxies/shared_file_system.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Create, list, update and delete locks for resources. When a resource is"},{"line_number":174,"context_line":"locked, it means that it can be deleted only by services, admins or"},{"line_number":175,"context_line":"the own user that created the lock."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":178,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"86d7f62e_4bbe8274","line":175,"range":{"start_line":175,"start_character":4,"end_line":175,"end_character":7},"updated":"2023-08-01 20:27:28.000000000","message":"nit:s/own//","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Create, list, update and delete locks for resources. When a resource is"},{"line_number":174,"context_line":"locked, it means that it can be deleted only by services, admins or"},{"line_number":175,"context_line":"the own user that created the lock."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":178,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cb3c93b2_23b1edaf","line":175,"range":{"start_line":175,"start_character":4,"end_line":175,"end_character":7},"in_reply_to":"86d7f62e_4bbe8274","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f3525f47f543cb1f86d92ed7acfe5d0009c1657","unresolved":true,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Create, View, and Delete access rules for shares from the"},{"line_number":136,"context_line":"Shared File Systems service. Access rules can also have their deletion"},{"line_number":137,"context_line":"and visibility restricted during the creation. A lock reason can also be"},{"line_number":138,"context_line":"specified. The deletion restriction can be removed during the access removal."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"}],"source_content_type":"text/x-rst","patch_set":10,"id":"23afeb55_ac5251d1","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":36},"updated":"2024-01-31 16:38:23.000000000","message":"nit: remove or replace with \"their\"","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Create, View, and Delete access rules for shares from the"},{"line_number":136,"context_line":"Shared File Systems service. Access rules can also have their deletion"},{"line_number":137,"context_line":"and visibility restricted during the creation. A lock reason can also be"},{"line_number":138,"context_line":"specified. The deletion restriction can be removed during the access removal."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"}],"source_content_type":"text/x-rst","patch_set":10,"id":"59ea0a6a_031e314c","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":36},"in_reply_to":"23afeb55_ac5251d1","updated":"2024-02-14 13:20:55.000000000","message":"I\u0027d remove","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Create, View, and Delete access rules for shares from the"},{"line_number":136,"context_line":"Shared File Systems service. Access rules can also have their deletion"},{"line_number":137,"context_line":"and visibility restricted during the creation. A lock reason can also be"},{"line_number":138,"context_line":"specified. The deletion restriction can be removed during the access removal."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba170c1b_63b2bd51","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":36},"in_reply_to":"59ea0a6a_031e314c","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"fe92156a2ba1a50b2753dce1e8141c69bbb34e99","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Create, View, and Delete access rules for shares from the"},{"line_number":136,"context_line":"Shared File Systems service. Access rules can also have their deletion"},{"line_number":137,"context_line":"and visibility restricted during the creation. A lock reason can also be"},{"line_number":138,"context_line":"specified. The deletion restriction can be removed during the access removal."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":141,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"79721b84_ad1a1fa9","line":138,"range":{"start_line":137,"start_character":47,"end_line":138,"end_character":9},"updated":"2024-02-14 13:04:48.000000000","message":"thx !","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"}],"openstack/proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":589,"context_line":"        :returns: The result of the ``create``"},{"line_number":590,"context_line":"        :rtype: :class:`~openstack.resource.Resource`"},{"line_number":591,"context_line":"        \"\"\""},{"line_number":592,"context_line":"        conflicting_params \u003d attrs.get(\u0027conflicting_params\u0027, {})"},{"line_number":593,"context_line":"        if conflicting_params:"},{"line_number":594,"context_line":"            for k, v in conflicting_params.items():"},{"line_number":595,"context_line":"                attrs[k] \u003d v"}],"source_content_type":"text/x-python","patch_set":4,"id":"8c0757ed_d522a7b8","line":592,"range":{"start_line":592,"start_character":40,"end_line":592,"end_character":58},"updated":"2023-08-01 20:27:28.000000000","message":"this looks like a good approach to avoid conflicts with \"resource_type\" and \"base_path\" here; maybe call this \"__conflicting_attrs\"? so that we can further reduce the possibility of an API using that key","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        :returns: The result of the ``create``"},{"line_number":590,"context_line":"        :rtype: :class:`~openstack.resource.Resource`"},{"line_number":591,"context_line":"        \"\"\""},{"line_number":592,"context_line":"        conflicting_params \u003d attrs.get(\u0027conflicting_params\u0027, {})"},{"line_number":593,"context_line":"        if conflicting_params:"},{"line_number":594,"context_line":"            for k, v in conflicting_params.items():"},{"line_number":595,"context_line":"                attrs[k] \u003d v"}],"source_content_type":"text/x-python","patch_set":4,"id":"40c64b8c_a566da8e","line":592,"range":{"start_line":592,"start_character":40,"end_line":592,"end_character":58},"in_reply_to":"8c0757ed_d522a7b8","updated":"2023-08-02 11:42:42.000000000","message":"sure thing :)","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6db2107313fac42c887161d4b8ec1ac19f217193","unresolved":true,"context_lines":[{"line_number":587,"context_line":"        if conflicting_attrs:"},{"line_number":588,"context_line":"            for k, v in conflicting_attrs.items():"},{"line_number":589,"context_line":"                attrs[k] \u003d v"},{"line_number":590,"context_line":"            attrs.pop(\u0027__conflicting_attrs\u0027)"},{"line_number":591,"context_line":"        conn \u003d self._get_connection()"},{"line_number":592,"context_line":"        res \u003d resource_type.new(connection\u003dconn, **attrs)"},{"line_number":593,"context_line":"        return res.create(self, base_path\u003dbase_path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"01816e4a_3e035983","line":590,"updated":"2023-09-05 17:05:01.000000000","message":"What\u0027s going on here? Can you add a comment explaining what we\u0027re doing?","commit_id":"9a388cd069af275bcf2ab6948680ace607adab70"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac902adc5db39d10c72e1f4919e9efd6dc0973b","unresolved":true,"context_lines":[{"line_number":587,"context_line":"        if conflicting_attrs:"},{"line_number":588,"context_line":"            for k, v in conflicting_attrs.items():"},{"line_number":589,"context_line":"                attrs[k] \u003d v"},{"line_number":590,"context_line":"            attrs.pop(\u0027__conflicting_attrs\u0027)"},{"line_number":591,"context_line":"        conn \u003d self._get_connection()"},{"line_number":592,"context_line":"        res \u003d resource_type.new(connection\u003dconn, **attrs)"},{"line_number":593,"context_line":"        return res.create(self, base_path\u003dbase_path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ad42afe6_cab74a47","line":590,"in_reply_to":"01816e4a_3e035983","updated":"2023-09-05 17:23:05.000000000","message":"Sure thing, Stephen... I\u0027ll add a comment, but it\u0027s basically:\n\nSome context:\n- Manila resource locks are meant to be generic (currently we support shares and access rules, but in the future we might other stuff)\n- To specify what kind of resource you\u0027re attempting to lock, you need to tell Manila what is the resource type by specifying one parameter in the request body: `resource_type`\n\nNow what\u0027s happening:\n- This method (_create) already receives a parameter called resource_type [1], which in this case would be _resource_locks.ResourceLock\n- The resource lock create method will get the specified parameters as kwargs and just send them to the _create method. When we receive resource_type as one of the kwargs in the _create method [2], it fails, as there are two parameters named resource_type.\n- In order to avoid that, we are populating the __conficting_attrs with parameters that already exist in the method\u0027s signature and could make it fail.\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/889519/7/openstack/proxy.py#566\n[2] https://review.opendev.org/c/openstack/openstacksdk/+/889519/7/openstack/shared_file_system/v2/_proxy.py#1172","commit_id":"9a388cd069af275bcf2ab6948680ace607adab70"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9cc018c15066e0ad529c833a8eb5e8b631bf16ce","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        if conflicting_attrs:"},{"line_number":588,"context_line":"            for k, v in conflicting_attrs.items():"},{"line_number":589,"context_line":"                attrs[k] \u003d v"},{"line_number":590,"context_line":"            attrs.pop(\u0027__conflicting_attrs\u0027)"},{"line_number":591,"context_line":"        conn \u003d self._get_connection()"},{"line_number":592,"context_line":"        res \u003d resource_type.new(connection\u003dconn, **attrs)"},{"line_number":593,"context_line":"        return res.create(self, base_path\u003dbase_path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b7fbc394_6a0a95b8","line":590,"in_reply_to":"ad42afe6_cab74a47","updated":"2023-09-06 11:41:12.000000000","message":"Done","commit_id":"9a388cd069af275bcf2ab6948680ace607adab70"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"adf259378f11913dc85ab21ef0f02da62586e4e0","unresolved":true,"context_lines":[{"line_number":878,"context_line":"            _resource_locks.ResourceLock,"},{"line_number":879,"context_line":"            lock_id,"},{"line_number":880,"context_line":"            ignore_missing\u003dignore_missing,"},{"line_number":881,"context_line":"        )"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def create_resource_lock(self, **attrs):"},{"line_number":884,"context_line":"        \"\"\"Locks a resource."}],"source_content_type":"text/x-python","patch_set":3,"id":"40596ab6_3fa0ebcb","line":881,"updated":"2023-07-28 14:26:12.000000000","message":"I think it will be good to return the HTTP response like we did with access_rules.\nSo users could check if we have a 202.","commit_id":"9623eeb809deae25fb1cd83f549696c7ba97b8ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":878,"context_line":"            _resource_locks.ResourceLock,"},{"line_number":879,"context_line":"            lock_id,"},{"line_number":880,"context_line":"            ignore_missing\u003dignore_missing,"},{"line_number":881,"context_line":"        )"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def create_resource_lock(self, **attrs):"},{"line_number":884,"context_line":"        \"\"\"Locks a resource."}],"source_content_type":"text/x-python","patch_set":3,"id":"e7e2d6c2_a6158419","line":881,"in_reply_to":"40596ab6_3fa0ebcb","updated":"2023-08-01 20:27:28.000000000","message":"+1","commit_id":"9623eeb809deae25fb1cd83f549696c7ba97b8ff"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            _resource_locks.ResourceLock,"},{"line_number":879,"context_line":"            lock_id,"},{"line_number":880,"context_line":"            ignore_missing\u003dignore_missing,"},{"line_number":881,"context_line":"        )"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def create_resource_lock(self, **attrs):"},{"line_number":884,"context_line":"        \"\"\"Locks a resource."}],"source_content_type":"text/x-python","patch_set":3,"id":"d4a850cd_a4d1c717","line":881,"in_reply_to":"40596ab6_3fa0ebcb","updated":"2023-08-02 11:42:42.000000000","message":"Ack","commit_id":"9623eeb809deae25fb1cd83f549696c7ba97b8ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":951,"context_line":"            ignore_missing\u003dignore_missing,"},{"line_number":952,"context_line":"        )"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"    def get_all_resource_locks(self, **query):"},{"line_number":955,"context_line":"        \"\"\"Lists all resource locks groups."},{"line_number":956,"context_line":""},{"line_number":957,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":4,"id":"05960548_de689635","line":954,"range":{"start_line":954,"start_character":8,"end_line":954,"end_character":30},"updated":"2023-08-01 20:27:28.000000000","message":"name this: \"resource_locks\"","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":951,"context_line":"            ignore_missing\u003dignore_missing,"},{"line_number":952,"context_line":"        )"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"    def get_all_resource_locks(self, **query):"},{"line_number":955,"context_line":"        \"\"\"Lists all resource locks groups."},{"line_number":956,"context_line":""},{"line_number":957,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":4,"id":"66227d41_68d6e38d","line":954,"range":{"start_line":954,"start_character":8,"end_line":954,"end_character":30},"in_reply_to":"05960548_de689635","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":957,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":958,"context_line":"            the share groups being returned.  Available parameters include:"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"}],"source_content_type":"text/x-python","patch_set":4,"id":"96ae7539_20fd8877","line":960,"range":{"start_line":960,"start_character":48,"end_line":960,"end_character":64},"updated":"2023-08-01 20:27:28.000000000","message":"user that the lock is created for.","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":957,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":958,"context_line":"            the share groups being returned.  Available parameters include:"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"}],"source_content_type":"text/x-python","patch_set":4,"id":"eb6b220c_54f7a140","line":960,"range":{"start_line":960,"start_character":48,"end_line":960,"end_character":64},"in_reply_to":"96ae7539_20fd8877","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":958,"context_line":"            the share groups being returned.  Available parameters include:"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"},{"line_number":964,"context_line":"                group listing."}],"source_content_type":"text/x-python","patch_set":4,"id":"8d44d39a_10608518","line":961,"range":{"start_line":961,"start_character":14,"end_line":961,"end_character":25},"updated":"2023-08-01 20:27:28.000000000","message":"\"all_projects\"","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":958,"context_line":"            the share groups being returned.  Available parameters include:"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"},{"line_number":964,"context_line":"                group listing."}],"source_content_type":"text/x-python","patch_set":4,"id":"670d0870_81f27067","line":961,"range":{"start_line":961,"start_character":14,"end_line":961,"end_character":25},"in_reply_to":"8d44d39a_10608518","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"},{"line_number":964,"context_line":"                group listing."},{"line_number":965,"context_line":"            * sort_key: The key to sort a list of shares."}],"source_content_type":"text/x-python","patch_set":4,"id":"e4176b5e_b418f8b6","line":962,"range":{"start_line":962,"start_character":43,"end_line":962,"end_character":63},"updated":"2023-08-01 20:27:28.000000000","message":"resource locks","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"},{"line_number":964,"context_line":"                group listing."},{"line_number":965,"context_line":"            * sort_key: The key to sort a list of shares."}],"source_content_type":"text/x-python","patch_set":4,"id":"e3f109bd_3fce07f3","line":962,"range":{"start_line":962,"start_character":43,"end_line":962,"end_character":63},"in_reply_to":"e4176b5e_b418f8b6","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"},{"line_number":964,"context_line":"                group listing."},{"line_number":965,"context_line":"            * sort_key: The key to sort a list of shares."},{"line_number":966,"context_line":"            * sort_dir: The direction to sort a list of shares"},{"line_number":967,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"86b5f58b_e9852ad0","line":964,"range":{"start_line":963,"start_character":58,"end_line":964,"end_character":21},"updated":"2023-08-01 20:27:28.000000000","message":"resource lock","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":960,"context_line":"            * project_id: The project ID of the user or service."},{"line_number":961,"context_line":"            * all_tenants: list locks from all projects (Admin Only)"},{"line_number":962,"context_line":"            * limit: The maximum number of share groups members to return."},{"line_number":963,"context_line":"            * offset: The offset to define start point of share or share"},{"line_number":964,"context_line":"                group listing."},{"line_number":965,"context_line":"            * sort_key: The key to sort a list of shares."},{"line_number":966,"context_line":"            * sort_dir: The direction to sort a list of shares"},{"line_number":967,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e31e1d07_3ce0d4ff","line":964,"range":{"start_line":963,"start_character":58,"end_line":964,"end_character":21},"in_reply_to":"86b5f58b_e9852ad0","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":964,"context_line":"                group listing."},{"line_number":965,"context_line":"            * sort_key: The key to sort a list of shares."},{"line_number":966,"context_line":"            * sort_dir: The direction to sort a list of shares"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        :returns: A generator of manila resource locks"},{"line_number":969,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":970,"context_line":"            resource_locks.ResourceLock`"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f36c58a_c87c7140","line":967,"updated":"2023-08-01 20:27:28.000000000","message":"there are some other possible query opts, it\u0027d be good to document these as well:\n\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_db3/887115/9/check/build-openstack-api-ref/db3a5f0/docs/?expanded\u003dlist-resource-locks-detail#id788","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                group listing."},{"line_number":965,"context_line":"            * sort_key: The key to sort a list of shares."},{"line_number":966,"context_line":"            * sort_dir: The direction to sort a list of shares"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        :returns: A generator of manila resource locks"},{"line_number":969,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":970,"context_line":"            resource_locks.ResourceLock`"}],"source_content_type":"text/x-python","patch_set":4,"id":"16dc25aa_c765f2de","line":967,"in_reply_to":"3f36c58a_c87c7140","updated":"2023-08-02 11:42:42.000000000","message":"thanks for the link. Done :)","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":972,"context_line":"        return self._list(_resource_locks.ResourceLock, **query)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    def get_resource_lock(self, lock_id):"},{"line_number":975,"context_line":"        \"\"\"List details of an access rule."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        :param lock_id: The id of the lock to get"},{"line_number":978,"context_line":"        :returns: Details of the identified resource lock."}],"source_content_type":"text/x-python","patch_set":4,"id":"44aea195_c933d0c9","line":975,"range":{"start_line":975,"start_character":27,"end_line":975,"end_character":41},"updated":"2023-08-01 20:27:28.000000000","message":"\"Show details of a resource lock.\"","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":972,"context_line":"        return self._list(_resource_locks.ResourceLock, **query)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    def get_resource_lock(self, lock_id):"},{"line_number":975,"context_line":"        \"\"\"List details of an access rule."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        :param lock_id: The id of the lock to get"},{"line_number":978,"context_line":"        :returns: Details of the identified resource lock."}],"source_content_type":"text/x-python","patch_set":4,"id":"b05f4300_917fabf2","line":975,"range":{"start_line":975,"start_character":27,"end_line":975,"end_character":41},"in_reply_to":"44aea195_c933d0c9","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":982,"context_line":"        return self._get(_resource_locks.ResourceLock, lock_id)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    def update_resource_lock(self, lock_id, **updates):"},{"line_number":985,"context_line":"        \"\"\"Updates details of a single share network."},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        :param lock_id: The ID of the resource lock to update"},{"line_number":988,"context_line":"        :pram dict attrs: The attributes to update on the resource lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"0d55eadc_5ae98899","line":985,"range":{"start_line":985,"start_character":31,"end_line":985,"end_character":52},"updated":"2023-08-01 20:27:28.000000000","message":"resource lock","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":982,"context_line":"        return self._get(_resource_locks.ResourceLock, lock_id)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    def update_resource_lock(self, lock_id, **updates):"},{"line_number":985,"context_line":"        \"\"\"Updates details of a single share network."},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        :param lock_id: The ID of the resource lock to update"},{"line_number":988,"context_line":"        :pram dict attrs: The attributes to update on the resource lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"44c1ffb9_d8f26183","line":985,"range":{"start_line":985,"start_character":31,"end_line":985,"end_character":52},"in_reply_to":"0d55eadc_5ae98899","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":1011,"context_line":"        :returns: Details of the lock"},{"line_number":1012,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":1013,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":1014,"context_line":"            resource_locks.ResourceLock`, comprised of the properties"},{"line_number":1015,"context_line":"            on the ResourceLock class."},{"line_number":1016,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":1017,"context_line":"            resource_locks.ResourceLock`"},{"line_number":1018,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5c977407_d6c4637a","line":1015,"range":{"start_line":1014,"start_character":42,"end_line":1015,"end_character":37},"updated":"2023-08-01 20:27:28.000000000","message":"maybe specify what params are required and which ones are optional: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_db3/887115/9/check/build-openstack-api-ref/db3a5f0/docs/?expanded\u003dcreate-a-resource-lock-detail#id781","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        :returns: Details of the lock"},{"line_number":1012,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":1013,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":1014,"context_line":"            resource_locks.ResourceLock`, comprised of the properties"},{"line_number":1015,"context_line":"            on the ResourceLock class."},{"line_number":1016,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":1017,"context_line":"            resource_locks.ResourceLock`"},{"line_number":1018,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"c6c341c1_087afec7","line":1015,"range":{"start_line":1014,"start_character":42,"end_line":1015,"end_character":37},"in_reply_to":"5c977407_d6c4637a","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6db2107313fac42c887161d4b8ec1ac19f217193","unresolved":true,"context_lines":[{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        :param access_id: The id of the access rule to get"},{"line_number":857,"context_line":"        :param share_id: The ID of the share"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        :rtype: ``requests.models.Response`` HTTP response from internal"},{"line_number":860,"context_line":"            requests client"},{"line_number":861,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"95c851b0_c589c51b","line":858,"updated":"2023-09-05 17:05:01.000000000","message":"Need a `:param:` string","commit_id":"9a388cd069af275bcf2ab6948680ace607adab70"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac902adc5db39d10c72e1f4919e9efd6dc0973b","unresolved":true,"context_lines":[{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        :param access_id: The id of the access rule to get"},{"line_number":857,"context_line":"        :param share_id: The ID of the share"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        :rtype: ``requests.models.Response`` HTTP response from internal"},{"line_number":860,"context_line":"            requests client"},{"line_number":861,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"f5055f3f_c25cfd1d","line":858,"in_reply_to":"95c851b0_c589c51b","updated":"2023-09-05 17:23:05.000000000","message":"Ack","commit_id":"9a388cd069af275bcf2ab6948680ace607adab70"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9cc018c15066e0ad529c833a8eb5e8b631bf16ce","unresolved":false,"context_lines":[{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        :param access_id: The id of the access rule to get"},{"line_number":857,"context_line":"        :param share_id: The ID of the share"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        :rtype: ``requests.models.Response`` HTTP response from internal"},{"line_number":860,"context_line":"            requests client"},{"line_number":861,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"13d36468_9f59dc0f","line":858,"in_reply_to":"f5055f3f_c25cfd1d","updated":"2023-09-06 11:41:12.000000000","message":"Done","commit_id":"9a388cd069af275bcf2ab6948680ace607adab70"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":839,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":840,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":841,"context_line":"            share_access_rules.ShareAccessRules`, comprised of the"},{"line_number":842,"context_line":"            properties on the ShareAccessRules class."},{"line_number":843,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":844,"context_line":"            share_access_rules.ShareAccessRules`"},{"line_number":845,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"e5206bc1_e3caa8b8","line":842,"updated":"2023-09-11 23:15:30.000000000","message":"probably expand this with a bullet list of acceptable attrs including the new ones: https://docs.openstack.org/api-ref/shared-file-system/index.html#id112","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":839,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":840,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":841,"context_line":"            share_access_rules.ShareAccessRules`, comprised of the"},{"line_number":842,"context_line":"            properties on the ShareAccessRules class."},{"line_number":843,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":844,"context_line":"            share_access_rules.ShareAccessRules`"},{"line_number":845,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"f6e3a7be_59deb766","line":842,"in_reply_to":"e5206bc1_e3caa8b8","updated":"2023-09-14 17:56:32.000000000","message":"Done","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":1077,"context_line":"            )"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def resource_locks(self, **query):"},{"line_number":1080,"context_line":"        \"\"\"Lists all resource locks groups."},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":1083,"context_line":"            the share groups being returned.  Available parameters include:"}],"source_content_type":"text/x-python","patch_set":8,"id":"8bbfbb11_1e60e8e2","line":1080,"range":{"start_line":1080,"start_character":36,"end_line":1080,"end_character":42},"updated":"2023-09-11 23:15:30.000000000","message":"remove","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"            )"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def resource_locks(self, **query):"},{"line_number":1080,"context_line":"        \"\"\"Lists all resource locks groups."},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":1083,"context_line":"            the share groups being returned.  Available parameters include:"}],"source_content_type":"text/x-python","patch_set":8,"id":"95375071_d7238d28","line":1080,"range":{"start_line":1080,"start_character":36,"end_line":1080,"end_character":42},"in_reply_to":"8bbfbb11_1e60e8e2","updated":"2023-09-14 17:56:32.000000000","message":"Done","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        \"\"\"Lists all resource locks groups."},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":1083,"context_line":"            the share groups being returned.  Available parameters include:"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"            * project_id: The project ID of the user that the lock is"},{"line_number":1086,"context_line":"                created for."}],"source_content_type":"text/x-python","patch_set":8,"id":"753e8a4d_09c95596","line":1083,"range":{"start_line":1083,"start_character":16,"end_line":1083,"end_character":28},"updated":"2023-09-11 23:15:30.000000000","message":"resource locks","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"        \"\"\"Lists all resource locks groups."},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":1083,"context_line":"            the share groups being returned.  Available parameters include:"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"            * project_id: The project ID of the user that the lock is"},{"line_number":1086,"context_line":"                created for."}],"source_content_type":"text/x-python","patch_set":8,"id":"a9e7f9f2_fe9f4693","line":1083,"range":{"start_line":1083,"start_character":16,"end_line":1083,"end_character":28},"in_reply_to":"753e8a4d_09c95596","updated":"2023-09-14 17:56:32.000000000","message":"Done","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":1100,"context_line":"            * created_before: Search for the list of resources that were"},{"line_number":1101,"context_line":"                created prior to the specified date. The date is in"},{"line_number":1102,"context_line":"                ‘yyyy-mm-dd’ format."},{"line_number":1103,"context_line":"            * limit: The maximum number of resource locks members to return."},{"line_number":1104,"context_line":"            * offset: The offset to define start point of resource lock"},{"line_number":1105,"context_line":"                listing."},{"line_number":1106,"context_line":"            * sort_key: The key to sort a list of shares."}],"source_content_type":"text/x-python","patch_set":8,"id":"c1832e40_a174fd57","line":1103,"range":{"start_line":1103,"start_character":58,"end_line":1103,"end_character":65},"updated":"2023-09-11 23:15:30.000000000","message":"remove","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"            * created_before: Search for the list of resources that were"},{"line_number":1101,"context_line":"                created prior to the specified date. The date is in"},{"line_number":1102,"context_line":"                ‘yyyy-mm-dd’ format."},{"line_number":1103,"context_line":"            * limit: The maximum number of resource locks members to return."},{"line_number":1104,"context_line":"            * offset: The offset to define start point of resource lock"},{"line_number":1105,"context_line":"                listing."},{"line_number":1106,"context_line":"            * sort_key: The key to sort a list of shares."}],"source_content_type":"text/x-python","patch_set":8,"id":"6eeb88eb_a772b26d","line":1103,"range":{"start_line":1103,"start_character":58,"end_line":1103,"end_character":65},"in_reply_to":"c1832e40_a174fd57","updated":"2023-09-14 17:56:32.000000000","message":"Done","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":1163,"context_line":"            * ``resource_action``: action to be locked (delete, show)."},{"line_number":1164,"context_line":"            * ``lock_reason``: reason why you\u0027re locking the resource"},{"line_number":1165,"context_line":"                (Optional)."},{"line_number":1166,"context_line":"            * ``service_token``: when provided in the header of the"},{"line_number":1167,"context_line":"                request, only services will be able to manipulate the"},{"line_number":1168,"context_line":"                lock (Optional)."},{"line_number":1169,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":1170,"context_line":"            resource_locks.ResourceLock`"},{"line_number":1171,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5b5a0693_e3767c8a","line":1168,"range":{"start_line":1166,"start_character":12,"end_line":1168,"end_character":32},"updated":"2023-09-11 23:15:30.000000000","message":"what code handles this?\n\n\"service\" users will use keystoneauth\u0027s `ServiceTokenAuthWrapper` class to instantiate a user client.. such a client can be used to instantiate an openstack connection object to use the methods in this proxy.. so there\u0027s no need to set any headers through this method.. \n\nhere\u0027s where service token headers are populated in the ServiceTokenAuthWrapper:\n https://github.com/openstack/keystoneauth/blob/e6f3999c6f2f846e3dda505343166ab8c8346c2a/keystoneauth1/service_token.py#L27-L33","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"            * ``resource_action``: action to be locked (delete, show)."},{"line_number":1164,"context_line":"            * ``lock_reason``: reason why you\u0027re locking the resource"},{"line_number":1165,"context_line":"                (Optional)."},{"line_number":1166,"context_line":"            * ``service_token``: when provided in the header of the"},{"line_number":1167,"context_line":"                request, only services will be able to manipulate the"},{"line_number":1168,"context_line":"                lock (Optional)."},{"line_number":1169,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":1170,"context_line":"            resource_locks.ResourceLock`"},{"line_number":1171,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"461f55e4_abf4a9fe","line":1168,"range":{"start_line":1166,"start_character":12,"end_line":1168,"end_character":32},"in_reply_to":"5b5a0693_e3767c8a","updated":"2023-09-14 17:56:32.000000000","message":"Ack, I\u0027ll drop this fromt he docstring then. Thanks","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f3525f47f543cb1f86d92ed7acfe5d0009c1657","unresolved":true,"context_lines":[{"line_number":841,"context_line":"            share_access_rules.ShareAccessRules`, comprised of the"},{"line_number":842,"context_line":"            properties on the ShareAccessRules class. It is possible to lock"},{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":10,"id":"6d9ee2f8_e456fd54","line":844,"range":{"start_line":844,"start_character":37,"end_line":844,"end_character":56},"updated":"2024-01-31 16:38:23.000000000","message":"lock_visibility","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"fe92156a2ba1a50b2753dce1e8141c69bbb34e99","unresolved":true,"context_lines":[{"line_number":841,"context_line":"            share_access_rules.ShareAccessRules`, comprised of the"},{"line_number":842,"context_line":"            properties on the ShareAccessRules class. It is possible to lock"},{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":10,"id":"be6db541_fc1cf2fc","line":844,"range":{"start_line":844,"start_character":37,"end_line":844,"end_character":56},"in_reply_to":"6d9ee2f8_e456fd54","updated":"2024-02-14 13:04:48.000000000","message":"++","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":841,"context_line":"            share_access_rules.ShareAccessRules`, comprised of the"},{"line_number":842,"context_line":"            properties on the ShareAccessRules class. It is possible to lock"},{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":10,"id":"13de26d3_0209ec98","line":844,"range":{"start_line":844,"start_character":37,"end_line":844,"end_character":56},"in_reply_to":"be6db541_fc1cf2fc","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f3525f47f543cb1f86d92ed7acfe5d0009c1657","unresolved":true,"context_lines":[{"line_number":842,"context_line":"            properties on the ShareAccessRules class. It is possible to lock"},{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":848,"context_line":"            share_access_rules.ShareAccessRules`"}],"source_content_type":"text/x-python","patch_set":10,"id":"c7b722bb_613f2105","line":845,"range":{"start_line":845,"start_character":13,"end_line":845,"end_character":30},"updated":"2024-01-31 16:38:23.000000000","message":"lock_deletion","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":842,"context_line":"            properties on the ShareAccessRules class. It is possible to lock"},{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":848,"context_line":"            share_access_rules.ShareAccessRules`"}],"source_content_type":"text/x-python","patch_set":10,"id":"50f09fee_bb8936e5","line":845,"range":{"start_line":845,"start_character":13,"end_line":845,"end_character":30},"in_reply_to":"c1049b1f_594f9390","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"fe92156a2ba1a50b2753dce1e8141c69bbb34e99","unresolved":true,"context_lines":[{"line_number":842,"context_line":"            properties on the ShareAccessRules class. It is possible to lock"},{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":848,"context_line":"            share_access_rules.ShareAccessRules`"}],"source_content_type":"text/x-python","patch_set":10,"id":"c1049b1f_594f9390","line":845,"range":{"start_line":845,"start_character":13,"end_line":845,"end_character":30},"in_reply_to":"c7b722bb_613f2105","updated":"2024-02-14 13:04:48.000000000","message":"++","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":848,"context_line":"            share_access_rules.ShareAccessRules`"},{"line_number":849,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5eb99f90_45ef5240","line":846,"updated":"2024-02-14 13:20:55.000000000","message":"I think this is too much detail to go into here. This is documentation for the Manila API IMO. I\u0027d drop this docstring update.","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":843,"context_line":"            the visibility and the deletion of the access rule during the"},{"line_number":844,"context_line":"            creation, by specifying `restrict_visibility` and"},{"line_number":845,"context_line":"            `restrict_deletion` attributes in the attrs. A `lock_reason` can"},{"line_number":846,"context_line":"            also be provided."},{"line_number":847,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":848,"context_line":"            share_access_rules.ShareAccessRules`"},{"line_number":849,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"b2af0bce_3b49f62d","line":846,"in_reply_to":"5eb99f90_45ef5240","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":853,"context_line":"        )"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def delete_access_rule("},{"line_number":856,"context_line":"        self, access_id, share_id, ignore_missing\u003dTrue, unrestrict\u003dFalse"},{"line_number":857,"context_line":"    ):"},{"line_number":858,"context_line":"        \"\"\"Deletes an access rule"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0aca90cb_279fd2e4","line":856,"updated":"2024-02-14 13:20:55.000000000","message":"can we make this a kwarg-only argument?\n\n```\ndef delete_access_rule(\n    self, access_id, share_id, ignore_missing\u003dTrue, *, unrestrict\u003dFalse\n):\n```\n\nwe don\u0027t expect people to call this as an arg/want to discourage that (hard to read)","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        )"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def delete_access_rule("},{"line_number":856,"context_line":"        self, access_id, share_id, ignore_missing\u003dTrue, unrestrict\u003dFalse"},{"line_number":857,"context_line":"    ):"},{"line_number":858,"context_line":"        \"\"\"Deletes an access rule"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fd1d142a_6e9a2f56","line":856,"in_reply_to":"0aca90cb_279fd2e4","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":1119,"context_line":"        \"\"\""},{"line_number":1120,"context_line":"        return self._list(_resource_locks.ResourceLock, **query)"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def get_resource_lock(self, lock_id):"},{"line_number":1123,"context_line":"        \"\"\"Show details of a resource lock."},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        :param lock_id: The id of the lock to get"}],"source_content_type":"text/x-python","patch_set":10,"id":"b20a4c2e_bf5cd194","line":1122,"range":{"start_line":1122,"start_character":32,"end_line":1122,"end_character":39},"updated":"2024-02-14 13:20:55.000000000","message":"In most other proxy APIs, we would call this `resource_lock` since we allow passing both an ID an a `ResourceLock` object. e.g. for `get_server` from the compute proxy:\n\n```\n:param server: The value can be the ID of a server or a\n    :class:`~openstack.compute.v2.server.Server` instance.\n```\n\nI know we\u0027re not doing this here, but we should. Could you rename these are update the docstrings. We need to address the rest of these but that\u0027s a follow-up, naturally.","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"        \"\"\""},{"line_number":1120,"context_line":"        return self._list(_resource_locks.ResourceLock, **query)"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def get_resource_lock(self, lock_id):"},{"line_number":1123,"context_line":"        \"\"\"Show details of a resource lock."},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        :param lock_id: The id of the lock to get"}],"source_content_type":"text/x-python","patch_set":10,"id":"857fc0cb_a4d98f2b","line":1122,"range":{"start_line":1122,"start_character":32,"end_line":1122,"end_character":39},"in_reply_to":"b20a4c2e_bf5cd194","updated":"2024-02-14 21:23:58.000000000","message":"Sure :)","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":1129,"context_line":"        \"\"\""},{"line_number":1130,"context_line":"        return self._get(_resource_locks.ResourceLock, lock_id)"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def update_resource_lock(self, lock_id, **updates):"},{"line_number":1133,"context_line":"        \"\"\"Updates details of a single resource lock."},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        :param lock_id: The ID of the resource lock to update"}],"source_content_type":"text/x-python","patch_set":10,"id":"798be66a_8fa2e42b","line":1132,"range":{"start_line":1132,"start_character":46,"end_line":1132,"end_character":53},"updated":"2024-02-14 13:20:55.000000000","message":"We typically call this `**attrs`, which is what your docstring calls it. Can you update?","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        \"\"\""},{"line_number":1130,"context_line":"        return self._get(_resource_locks.ResourceLock, lock_id)"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def update_resource_lock(self, lock_id, **updates):"},{"line_number":1133,"context_line":"        \"\"\"Updates details of a single resource lock."},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        :param lock_id: The ID of the resource lock to update"}],"source_content_type":"text/x-python","patch_set":10,"id":"44ee9cbf_29cc0cf9","line":1132,"range":{"start_line":1132,"start_character":46,"end_line":1132,"end_character":53},"in_reply_to":"798be66a_8fa2e42b","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":1156,"context_line":"    def create_resource_lock(self, **attrs):"},{"line_number":1157,"context_line":"        \"\"\"Locks a resource."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        :returns: Details of the lock"},{"line_number":1160,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":1161,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":1162,"context_line":"            resource_locks.ResourceLock`, comprised of the properties"}],"source_content_type":"text/x-python","patch_set":10,"id":"2d9480f1_d52f5005","line":1159,"updated":"2024-02-14 13:20:55.000000000","message":"This should go _after_ the param docs","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"    def create_resource_lock(self, **attrs):"},{"line_number":1157,"context_line":"        \"\"\"Locks a resource."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        :returns: Details of the lock"},{"line_number":1160,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":1161,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":1162,"context_line":"            resource_locks.ResourceLock`, comprised of the properties"}],"source_content_type":"text/x-python","patch_set":10,"id":"fbe984dc_e6b0e320","line":1159,"in_reply_to":"2d9480f1_d52f5005","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":1171,"context_line":"            resource_locks.ResourceLock`"},{"line_number":1172,"context_line":"        \"\"\""},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        if attrs.get(\u0027resource_type\u0027):"},{"line_number":1175,"context_line":"            attrs[\u0027__conflicting_attrs\u0027] \u003d {"},{"line_number":1176,"context_line":"                \u0027resource_type\u0027: attrs.get(\u0027resource_type\u0027)"},{"line_number":1177,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":10,"id":"fbadc59e_a3f0b377","line":1174,"updated":"2024-02-14 13:20:55.000000000","message":"Can you leave comment here explaining what you\u0027re doing (for future us)?","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"            resource_locks.ResourceLock`"},{"line_number":1172,"context_line":"        \"\"\""},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        if attrs.get(\u0027resource_type\u0027):"},{"line_number":1175,"context_line":"            attrs[\u0027__conflicting_attrs\u0027] \u003d {"},{"line_number":1176,"context_line":"                \u0027resource_type\u0027: attrs.get(\u0027resource_type\u0027)"},{"line_number":1177,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":10,"id":"fcf63092_b363542f","line":1174,"in_reply_to":"fbadc59e_a3f0b377","updated":"2024-02-14 21:23:58.000000000","message":"Sure 😄","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"}],"openstack/shared_file_system/v2/resource_locks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \"created_since\","},{"line_number":32,"context_line":"        \"created_before\","},{"line_number":33,"context_line":"        \"limit\","},{"line_number":34,"context_line":"        \"offset\","},{"line_number":35,"context_line":"        all_projects\u003d\"all_tenants\","},{"line_number":36,"context_line":"    )"},{"line_number":37,"context_line":"    _max_microversion \u003d \u00272.80\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d9539aa_2b2728c4","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":17},"updated":"2023-08-01 20:27:28.000000000","message":"there are others as well: \n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_db3/887115/9/check/build-openstack-api-ref/db3a5f0/docs/?expanded\u003dlist-resource-locks-detail#id788","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"created_since\","},{"line_number":32,"context_line":"        \"created_before\","},{"line_number":33,"context_line":"        \"limit\","},{"line_number":34,"context_line":"        \"offset\","},{"line_number":35,"context_line":"        all_projects\u003d\"all_tenants\","},{"line_number":36,"context_line":"    )"},{"line_number":37,"context_line":"    _max_microversion \u003d \u00272.80\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"21796821_55c4e744","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":17},"in_reply_to":"7d9539aa_2b2728c4","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        \"created_before\","},{"line_number":33,"context_line":"        \"limit\","},{"line_number":34,"context_line":"        \"offset\","},{"line_number":35,"context_line":"        all_projects\u003d\"all_tenants\","},{"line_number":36,"context_line":"    )"},{"line_number":37,"context_line":"    _max_microversion \u003d \u00272.80\u0027"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dd8784d1_682e14bb","line":35,"range":{"start_line":35,"start_character":9,"end_line":35,"end_character":35},"updated":"2023-08-01 20:27:28.000000000","message":"lets not support \"all_tenants\" for this new SDK; you can drop the mapping; we usually try to provide compatibility the other way around; i.e., SDK users can only use \"all_projects\" and our SDK methods translate that to \"all_tenants\" for APIs that don\u0027t support \"all_projects\"","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"created_before\","},{"line_number":33,"context_line":"        \"limit\","},{"line_number":34,"context_line":"        \"offset\","},{"line_number":35,"context_line":"        all_projects\u003d\"all_tenants\","},{"line_number":36,"context_line":"    )"},{"line_number":37,"context_line":"    _max_microversion \u003d \u00272.80\u0027"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bd5354c5_16f62043","line":35,"range":{"start_line":35,"start_character":9,"end_line":35,"end_character":35},"in_reply_to":"dd8784d1_682e14bb","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    #: service’s database."},{"line_number":42,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"},{"line_number":43,"context_line":"    #: The date and time stamp when the resource was last modified within the"},{"line_number":44,"context_line":"    #: service’s database."},{"line_number":45,"context_line":"    updated_at \u003d resource.Body(\"updated_at\", type\u003dstr)"},{"line_number":46,"context_line":"    #: The ID of the user that owns the lock"},{"line_number":47,"context_line":"    user_id \u003d resource.Body(\"user_id\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae60576_147450a7","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":26},"updated":"2023-08-01 20:27:28.000000000","message":"you\u0027re missing \"lock_context\"","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    #: service’s database."},{"line_number":42,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"},{"line_number":43,"context_line":"    #: The date and time stamp when the resource was last modified within the"},{"line_number":44,"context_line":"    #: service’s database."},{"line_number":45,"context_line":"    updated_at \u003d resource.Body(\"updated_at\", type\u003dstr)"},{"line_number":46,"context_line":"    #: The ID of the user that owns the lock"},{"line_number":47,"context_line":"    user_id \u003d resource.Body(\"user_id\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8212e8a8_5a33eeda","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":26},"in_reply_to":"1ae60576_147450a7","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        \"with_count\","},{"line_number":46,"context_line":"        \"all_projects\","},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"    _max_microversion \u003d \u00272.81\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    #: Properties"},{"line_number":51,"context_line":"    #: The date and time stamp when the resource was created within the"}],"source_content_type":"text/x-python","patch_set":8,"id":"e49f188b_838857b4","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":30},"updated":"2023-09-11 23:15:30.000000000","message":"please add a comment here that the resource was introduced in this microversion; so this is really the min microversion necessary; but openstacksdk doesn\u0027t provide a mechanism to specify a minimum version..","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"with_count\","},{"line_number":46,"context_line":"        \"all_projects\","},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"    _max_microversion \u003d \u00272.81\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    #: Properties"},{"line_number":51,"context_line":"    #: The date and time stamp when the resource was created within the"}],"source_content_type":"text/x-python","patch_set":8,"id":"02f5afbb_2e9c08d8","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":30},"in_reply_to":"e49f188b_838857b4","updated":"2023-09-14 17:56:32.000000000","message":"Done","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"}],"openstack/shared_file_system/v2/share_access_rule.py":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"11baf5dda54583a01081235cca7eb72f55aa7754","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    _query_mapping \u003d resource.QueryParameters(\"share_id\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Restricted access rules became available in 2.80"},{"line_number":34,"context_line":"    _max_microversion \u003d \u00272.80\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: Properties"},{"line_number":37,"context_line":"    #: The access credential of the entity granted share access."}],"source_content_type":"text/x-python","patch_set":4,"id":"757a9c38_c6dfb836","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":30},"updated":"2023-08-02 09:27:47.000000000","message":"I think it is 2.81","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    _query_mapping \u003d resource.QueryParameters(\"share_id\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Restricted access rules became available in 2.80"},{"line_number":34,"context_line":"    _max_microversion \u003d \u00272.80\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: Properties"},{"line_number":37,"context_line":"    #: The access credential of the entity granted share access."}],"source_content_type":"text/x-python","patch_set":4,"id":"c7b54c42_698c962d","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":30},"in_reply_to":"757a9c38_c6dfb836","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    #: The date and time stamp when the resource was last updated within"},{"line_number":58,"context_line":"    #: the service’s database."},{"line_number":59,"context_line":"    updated_at \u003d resource.Body(\"updated_at\", type\u003dstr)"},{"line_number":60,"context_line":"    #: Whether the visibility of some sensible fields is restricted or not"},{"line_number":61,"context_line":"    restrict_visibility \u003d resource.Body(\"restrict_visibility\", type\u003dbool)"},{"line_number":62,"context_line":"    #: Whether the deletion of the access rule should be restricted or not"},{"line_number":63,"context_line":"    restrict_deletion \u003d resource.Body(\"restrict_deletion\", type\u003dbool)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9e8d9d22_1a4e7ce0","line":60,"range":{"start_line":60,"start_character":38,"end_line":60,"end_character":46},"updated":"2023-08-01 20:27:28.000000000","message":"s/sensible/sensitive","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    #: The date and time stamp when the resource was last updated within"},{"line_number":58,"context_line":"    #: the service’s database."},{"line_number":59,"context_line":"    updated_at \u003d resource.Body(\"updated_at\", type\u003dstr)"},{"line_number":60,"context_line":"    #: Whether the visibility of some sensible fields is restricted or not"},{"line_number":61,"context_line":"    restrict_visibility \u003d resource.Body(\"restrict_visibility\", type\u003dbool)"},{"line_number":62,"context_line":"    #: Whether the deletion of the access rule should be restricted or not"},{"line_number":63,"context_line":"    restrict_deletion \u003d resource.Body(\"restrict_deletion\", type\u003dbool)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df861c48_38164d2f","line":60,"range":{"start_line":60,"start_character":38,"end_line":60,"end_character":46},"in_reply_to":"9e8d9d22_1a4e7ce0","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"9716f959e0cbec7e1bdbf9f07b17ab73cc09d53e","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    _query_mapping \u003d resource.QueryParameters(\"share_id\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Restricted access rules became available in 2.80"},{"line_number":34,"context_line":"    _max_microversion \u003d \u00272.81\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"125e0a9d_ecbd3207","line":33,"range":{"start_line":33,"start_character":50,"end_line":33,"end_character":54},"updated":"2023-08-02 12:27:36.000000000","message":"I think you missed the comment as well. s/2.80/2.81/","commit_id":"525d5e0126e8ff2d2844a7278fab52c404fc8952"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"481e870baead4a8b5e00900fab7e752298ea0147","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    _query_mapping \u003d resource.QueryParameters(\"share_id\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Restricted access rules became available in 2.80"},{"line_number":34,"context_line":"    _max_microversion \u003d \u00272.81\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"cc6b265d_64a092e2","line":33,"range":{"start_line":33,"start_character":50,"end_line":33,"end_character":54},"in_reply_to":"125e0a9d_ecbd3207","updated":"2023-08-02 12:28:26.000000000","message":"ah, true! :) thanks","commit_id":"525d5e0126e8ff2d2844a7278fab52c404fc8952"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c7d7200a66a84486844b5b29adac42712e5592e5","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    _query_mapping \u003d resource.QueryParameters(\"share_id\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Restricted access rules became available in 2.80"},{"line_number":34,"context_line":"    _max_microversion \u003d \u00272.81\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    #: Properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"a680d48f_91e062aa","line":33,"range":{"start_line":33,"start_character":50,"end_line":33,"end_character":54},"in_reply_to":"cc6b265d_64a092e2","updated":"2023-08-03 19:47:05.000000000","message":"Done","commit_id":"525d5e0126e8ff2d2844a7278fab52c404fc8952"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            **kwargs"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def delete(self, session, share_id, ignore_missing\u003dTrue, unrestrict\u003dFalse):"},{"line_number":86,"context_line":"        body \u003d {\"deny_access\": {\"access_id\": self.id}}"},{"line_number":87,"context_line":"        if unrestrict:"},{"line_number":88,"context_line":"            body[\u0027deny_access\u0027][\u0027unrestrict\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":10,"id":"314533e9_25a0e162","line":85,"range":{"start_line":85,"start_character":59,"end_line":85,"end_character":77},"updated":"2024-02-14 13:20:55.000000000","message":"Can you make this a kwarg-only argument here also?","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            **kwargs"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def delete(self, session, share_id, ignore_missing\u003dTrue, unrestrict\u003dFalse):"},{"line_number":86,"context_line":"        body \u003d {\"deny_access\": {\"access_id\": self.id}}"},{"line_number":87,"context_line":"        if unrestrict:"},{"line_number":88,"context_line":"            body[\u0027deny_access\u0027][\u0027unrestrict\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":10,"id":"725a6b17_84f2de27","line":85,"range":{"start_line":85,"start_character":59,"end_line":85,"end_character":77},"in_reply_to":"314533e9_25a0e162","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"}],"openstack/tests/functional/shared_file_system/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8c65295f079e5a0cd936dddc0e3af0a4796249e0","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        self.require_service("},{"line_number":23,"context_line":"            \u0027shared-file-system\u0027, min_microversion\u003dself.min_microversion"},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":"        self._set_operator_cloud(shared_file_system_api_version\u003d\u00272.63\u0027)"},{"line_number":26,"context_line":"        self._set_user_cloud(shared_file_system_api_version\u003d\u00272.63\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_share(self, **kwargs):"},{"line_number":29,"context_line":"        share \u003d self.user_cloud.share.create_share(**kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc38857b_c6b251cb","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":67},"updated":"2023-08-01 20:27:59.000000000","message":"You\u0027ll have to adjust these to get access to newer features in the tests","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        self.require_service("},{"line_number":23,"context_line":"            \u0027shared-file-system\u0027, min_microversion\u003dself.min_microversion"},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":"        self._set_operator_cloud(shared_file_system_api_version\u003d\u00272.63\u0027)"},{"line_number":26,"context_line":"        self._set_user_cloud(shared_file_system_api_version\u003d\u00272.63\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_share(self, **kwargs):"},{"line_number":29,"context_line":"        share \u003d self.user_cloud.share.create_share(**kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3da5710f_69031785","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":67},"in_reply_to":"fc38857b_c6b251cb","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    def create_resource_lock(self, **kwargs):"},{"line_number":80,"context_line":"        resource_lock \u003d self.user_cloud.share.create_resource_lock(**kwargs)"},{"line_number":81,"context_line":"        self.addCleanup("},{"line_number":82,"context_line":"            self.conn.share.delete_resource_lock,"},{"line_number":83,"context_line":"            resource_lock.id,"},{"line_number":84,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":85,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"1be6069f_8737ebd6","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":21},"updated":"2023-08-01 20:27:28.000000000","message":"self.user_cloud\n\n\nwe should\u0027ve used \"user_cloud\" with the above methods as well..","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def create_resource_lock(self, **kwargs):"},{"line_number":80,"context_line":"        resource_lock \u003d self.user_cloud.share.create_resource_lock(**kwargs)"},{"line_number":81,"context_line":"        self.addCleanup("},{"line_number":82,"context_line":"            self.conn.share.delete_resource_lock,"},{"line_number":83,"context_line":"            resource_lock.id,"},{"line_number":84,"context_line":"            ignore_missing\u003dTrue,"},{"line_number":85,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"0b45c56b_3434d084","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":21},"in_reply_to":"1be6069f_8737ebd6","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ff3ea3ed528f7b0a04a938bc7ddb8200cba13d4","unresolved":true,"context_lines":[{"line_number":23,"context_line":"            \u0027shared-file-system\u0027, min_microversion\u003dself.min_microversion"},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":"        self._set_operator_cloud(shared_file_system_api_version\u003d\u00272.82\u0027)"},{"line_number":26,"context_line":"        self._set_user_cloud(shared_file_system_api_version\u003d\u00272.82\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_share(self, **kwargs):"},{"line_number":29,"context_line":"        share \u003d self.user_cloud.share.create_share(**kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4e16b9e1_ce2846b6","line":26,"updated":"2024-02-14 13:20:55.000000000","message":"This prevents us running against older clouds. I wonder if we could do API version checks in the test instead? Nice to have though since I don\u0027t think we do this elsewhere...","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":true,"context_lines":[{"line_number":23,"context_line":"            \u0027shared-file-system\u0027, min_microversion\u003dself.min_microversion"},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":"        self._set_operator_cloud(shared_file_system_api_version\u003d\u00272.82\u0027)"},{"line_number":26,"context_line":"        self._set_user_cloud(shared_file_system_api_version\u003d\u00272.82\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_share(self, **kwargs):"},{"line_number":29,"context_line":"        share \u003d self.user_cloud.share.create_share(**kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"78adfe90_c7af80cb","line":26,"in_reply_to":"4e16b9e1_ce2846b6","updated":"2024-02-14 21:23:58.000000000","message":"will take a look :)","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"}],"openstack/tests/functional/shared_file_system/test_resource_lock.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a2b67692_1aed789a","updated":"2023-08-01 20:27:28.000000000","message":"it\u0027d be nice to add a restricted access rule as well, and verify that locks are created as expected","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c86a9b79_11f5802a","in_reply_to":"a2b67692_1aed789a","updated":"2023-08-02 11:42:42.000000000","message":"Ack. I\u0027m still yet to test that side of the implementation with Manila, but I will do soon and add the tests.","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.assertIsNotNone(share)"},{"line_number":37,"context_line":"        self.assertIsNotNone(share.id)"},{"line_number":38,"context_line":"        self.SHARE_ID \u003d share.id"},{"line_number":39,"context_line":"        lock \u003d self.user_cloud.shared_file_system.create_resource_lock("},{"line_number":40,"context_line":"            resource_action\u003d\u0027delete\u0027,"},{"line_number":41,"context_line":"            resource_type\u003d\u0027share\u0027,"},{"line_number":42,"context_line":"            resource_id\u003dself.SHARE_ID,"},{"line_number":43,"context_line":"            lock_reason\u003d\u0027openstacksdk testing\u0027,"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        self.LOCK_ID \u003d lock.id"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_get(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7146948f_1f273e57","line":44,"range":{"start_line":39,"start_character":8,"end_line":44,"end_character":9},"updated":"2023-08-01 20:27:28.000000000","message":"maybe use the method you introduced in the base.py module?","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.assertIsNotNone(share)"},{"line_number":37,"context_line":"        self.assertIsNotNone(share.id)"},{"line_number":38,"context_line":"        self.SHARE_ID \u003d share.id"},{"line_number":39,"context_line":"        lock \u003d self.user_cloud.shared_file_system.create_resource_lock("},{"line_number":40,"context_line":"            resource_action\u003d\u0027delete\u0027,"},{"line_number":41,"context_line":"            resource_type\u003d\u0027share\u0027,"},{"line_number":42,"context_line":"            resource_id\u003dself.SHARE_ID,"},{"line_number":43,"context_line":"            lock_reason\u003d\u0027openstacksdk testing\u0027,"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        self.LOCK_ID \u003d lock.id"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_get(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2e187070_e1e427ca","line":44,"range":{"start_line":39,"start_character":8,"end_line":44,"end_character":9},"in_reply_to":"7146948f_1f273e57","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7ae0f2337e95c6e18775fa828ece4961baa3322","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        lock_attrs \u003d ("},{"line_number":58,"context_line":"            \u0027id\u0027,"},{"line_number":59,"context_line":"            \u0027lock_reason\u0027,"},{"line_number":60,"context_line":"            \u0027resource_type\u0027,"},{"line_number":61,"context_line":"            \u0027resource_action\u0027,"},{"line_number":62,"context_line":"            \u0027created_at\u0027,"},{"line_number":63,"context_line":"            \u0027updated_at\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"12857d8e_e965b0c5","line":60,"range":{"start_line":60,"start_character":27,"end_line":60,"end_character":28},"updated":"2023-08-01 20:27:28.000000000","message":"+ \"lock_context\"","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"11bcb8ac2f6366d3f779a0deeed35e25378dcac5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        lock_attrs \u003d ("},{"line_number":58,"context_line":"            \u0027id\u0027,"},{"line_number":59,"context_line":"            \u0027lock_reason\u0027,"},{"line_number":60,"context_line":"            \u0027resource_type\u0027,"},{"line_number":61,"context_line":"            \u0027resource_action\u0027,"},{"line_number":62,"context_line":"            \u0027created_at\u0027,"},{"line_number":63,"context_line":"            \u0027updated_at\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"64711935_69bbc709","line":60,"range":{"start_line":60,"start_character":27,"end_line":60,"end_character":28},"in_reply_to":"12857d8e_e965b0c5","updated":"2023-08-02 11:42:42.000000000","message":"Done","commit_id":"1b965f815a8aac511315c82783b3941b5fc99b6a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f3525f47f543cb1f86d92ed7acfe5d0009c1657","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9ed7c2ce_c0e9d6c3","line":69,"updated":"2024-01-31 16:38:23.000000000","message":"It\u0027d be nice to edit existing access rule tests as well and add locks, and test the unrestrict workflow..","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"804c0179_cb3062d7","line":69,"in_reply_to":"9ed7c2ce_c0e9d6c3","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a1e5fc55a8a3b889afbc5d4446ed7f028028bdd","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        self.user_cloud.shared_file_system.wait_for_status("},{"line_number":44,"context_line":"            access_rule,"},{"line_number":45,"context_line":"            status\u003d\u0027active\u0027,"},{"line_number":46,"context_line":"            failures\u003d[\u0027error\u0027],"},{"line_number":47,"context_line":"            interval\u003d5,"},{"line_number":48,"context_line":"            wait\u003dself._wait_for_timeout,"}],"source_content_type":"text/x-python","patch_set":15,"id":"8d9c494e_0b5e1beb","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":28},"updated":"2024-02-16 20:21:47.000000000","message":"we need to support setting \"attribute\" here [1] before invoking [2] the status attribute on an access rule is \"state\".\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/c0e20c54898393e821f5bf6cf7a7169ee7eaac6f/openstack/shared_file_system/v2/_proxy.py#L356-L357\n[2] https://opendev.org/openstack/openstacksdk/src/commit/c0e20c54898393e821f5bf6cf7a7169ee7eaac6f/openstack/resource.py#L2394","commit_id":"e793210b6992335a1b05a1761eb119fac680504c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f1629680e532bfd42a1c3c9ca7b129d0a2e12fbe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        self.user_cloud.shared_file_system.wait_for_status("},{"line_number":44,"context_line":"            access_rule,"},{"line_number":45,"context_line":"            status\u003d\u0027active\u0027,"},{"line_number":46,"context_line":"            failures\u003d[\u0027error\u0027],"},{"line_number":47,"context_line":"            interval\u003d5,"},{"line_number":48,"context_line":"            wait\u003dself._wait_for_timeout,"}],"source_content_type":"text/x-python","patch_set":15,"id":"279b0ae8_7a5f4e33","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":28},"in_reply_to":"8d9c494e_0b5e1beb","updated":"2024-02-19 15:59:25.000000000","message":"ah, true... Pretty much ignored the state attribute thingy...","commit_id":"e793210b6992335a1b05a1761eb119fac680504c"}],"openstack/tests/functional/shared_file_system/test_share_access_rule.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a1e5fc55a8a3b889afbc5d4446ed7f028028bdd","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            self.SHARE_ID,"},{"line_number":82,"context_line":"            access_level\u003d\"rw\","},{"line_number":83,"context_line":"            access_type\u003d\"ip\","},{"line_number":84,"context_line":"            access_to\u003d\"10.0.0.0/0\","},{"line_number":85,"context_line":"            lock_deletion\u003dTrue,"},{"line_number":86,"context_line":"            lock_visibility\u003dTrue,"},{"line_number":87,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba42082d_8963d471","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":33},"updated":"2024-02-16 20:21:47.000000000","message":"i\u0027d suggest using a \"non-routable\" IP reserved for doc/testing: https://datatracker.ietf.org/doc/html/rfc5737#section-3\n\nexample: 203.0.113.10\n\nthe API prevents subnet mask to be 0 unless the IP address is 0.0.0.0\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_563/889519/15/check/openstacksdk-functional-devstack-manila/563e49b/testr_results.html","commit_id":"e793210b6992335a1b05a1761eb119fac680504c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f1629680e532bfd42a1c3c9ca7b129d0a2e12fbe","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            self.SHARE_ID,"},{"line_number":82,"context_line":"            access_level\u003d\"rw\","},{"line_number":83,"context_line":"            access_type\u003d\"ip\","},{"line_number":84,"context_line":"            access_to\u003d\"10.0.0.0/0\","},{"line_number":85,"context_line":"            lock_deletion\u003dTrue,"},{"line_number":86,"context_line":"            lock_visibility\u003dTrue,"},{"line_number":87,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"b1125ef0_1a33740c","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":33},"in_reply_to":"ba42082d_8963d471","updated":"2024-02-19 15:59:25.000000000","message":"Done","commit_id":"e793210b6992335a1b05a1761eb119fac680504c"}],"releasenotes/notes/add-shared-file-system-locks-support-4859ca93f93a1056.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support to manipulate resource locks from the share file system"},{"line_number":5,"context_line":"    service."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Add support to restrict the visibility and deletion of the shared file"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"85bbb4d9_56d2a1f0","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2023-09-11 23:15:30.000000000","message":"nit: Added","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support to manipulate resource locks from the share file system"},{"line_number":5,"context_line":"    service."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Add support to restrict the visibility and deletion of the shared file"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b3267c74_58b77823","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"85bbb4d9_56d2a1f0","updated":"2023-09-14 17:56:32.000000000","message":"Done","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e46f5405e38605d689fc19cf8135cf784c0ef39c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Add support to manipulate resource locks from the share file system"},{"line_number":5,"context_line":"    service."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Add support to restrict the visibility and deletion of the shared file"},{"line_number":8,"context_line":"    system share access rules."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df3fa105_f097d06f","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":7},"updated":"2023-09-11 23:15:30.000000000","message":"nit: Added","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c0fee18b59476c747390230d89e40dd6c275c521","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add support to manipulate resource locks from the share file system"},{"line_number":5,"context_line":"    service."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Add support to restrict the visibility and deletion of the shared file"},{"line_number":8,"context_line":"    system share access rules."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a3df7f0_4fa950a0","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":7},"in_reply_to":"df3fa105_f097d06f","updated":"2023-09-14 17:56:32.000000000","message":"Done","commit_id":"fd76ac643b5d2fa713dc936838a79e728c3ba671"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f3525f47f543cb1f86d92ed7acfe5d0009c1657","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to manipulate resource locks from the share file system"},{"line_number":5,"context_line":"    service."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Added support to restrict the visibility and deletion of the shared file"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"94a31766_3f94b270","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":61},"updated":"2024-01-31 16:38:23.000000000","message":"shared","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3001eb6703d6780b5eafc8480d6c9afc31c3f3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to manipulate resource locks from the share file system"},{"line_number":5,"context_line":"    service."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Added support to restrict the visibility and deletion of the shared file"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ac329cec_6a94aed5","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":61},"in_reply_to":"94a31766_3f94b270","updated":"2024-02-14 21:23:58.000000000","message":"Done","commit_id":"51c7a1e75cd58f5766da8d8c58516f3db0edbd02"}]}