)]}'
{"id":"openstack%2Fopenstacksdk~890781","triplet_id":"openstack%2Fopenstacksdk~master~Id02a495353e1bfef3785248e48dec7344ef8f5af","project":"openstack/openstacksdk","branch":"master","topic":"fix_leak","attention_set":{},"removed_from_attention_set":{"29074":{"account":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"last_update":"2023-08-09 10:53:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id02a495353e1bfef3785248e48dec7344ef8f5af","subject":"fix memory leak of Connections","status":"MERGED","created":"2023-08-08 11:08:01.000000000","updated":"2023-08-09 10:55:38.000000000","submitted":"2023-08-09 10:53:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"890781-fix_leak","meta_rev_id":"559e63ebcfbe35eef14d6be66a2bb8a40379772d","_number":890781,"virtual_id_number":890781,"owner":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-08-09 10:53:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":2,"date":"2023-08-08 11:35:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-08-09 09:00:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-08-09 09:00:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-08 11:33:32.000000000","updated_by":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"CC"},{"updated":"2023-08-08 11:35:59.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2023-08-08 13:12:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-08-09 09:00:39.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"804cac74ce9fbea4c4c703fcce2a549b3e01e840","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"date":"2023-08-08 11:08:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"610af06824941e582594252cfb3b1ed7f85c0056","author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"date":"2023-08-08 11:33:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dfe85486dc3eefe7316c4f7aac6bb747f243946d","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2023-08-08 11:35:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4c0b2d0798b76e366236016c615225858c9d4028","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-08 13:12:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9eda345ef9534e7190aa727aaae52f01\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/da77364a610e41e7b5054f7659c5f130 : SUCCESS in 59m 04s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/66322fe7ec3d48ae891663fb5e285e9e : SUCCESS in 41m 32s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/44b528abdea14932b0b056148541cdb4 : SUCCESS in 4m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/55e0834cc3954962b1678b9bc4372c22 : SUCCESS in 4m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/afada0d776dc4b16ad43dd702c94f527 : SUCCESS in 3m 48s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a690a537c3174262bb5705c85b1e1319 : SUCCESS in 3m 36s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/63a051ddbf1340589c919c8221af1a5f : SUCCESS in 1h 09m 07s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/921536396f434bfbb449c473254c4bdf : SUCCESS in 3m 12s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/297cf96ddadd42b2b0a9511cbe159b1e : SUCCESS in 4m 20s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/feee271b88cc4a3faf62a42577b2ce94 : SUCCESS in 4m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d8a300347f704a0a9b874671031e1afd : SUCCESS in 7m 33s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/cb7f1db1fd3a4f29b47b00f5646aa99c : SUCCESS in 1h 58m 11s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/38e5e0bf31bc42f6a25ec0685d9ac215 : SUCCESS in 15m 00s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/714486834e1847cd9939dbd3b0e50570 : SUCCESS in 1h 24m 58s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f14137e6007c45d7a6bdd916b0976636 : SUCCESS in 48m 11s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/fca2d2e228da4e0688da46bba1340815 : SUCCESS in 1h 24m 38s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/492947f5aed44df19c184d15e86e571f : SUCCESS in 1h 33m 35s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/6cbf55d25b7142ccbb54d9cfd30382ee : SUCCESS in 55m 19s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/7dfb6bbbe496490b927f93abbba82379 : SUCCESS in 45m 24s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/db63b0f43326427092a3ae8ddfe52c30 : SUCCESS in 26m 01s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/92184cac2d314a10a8ccfea9585c394d : SUCCESS in 35m 11s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/35657ac027a24181ac710aa75d9890ca : SUCCESS in 29m 02s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/cfb3393d23704012b1200e3823b95a2b : SUCCESS in 1h 10m 30s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/6175ebad6eeb4949b86f596320b48711 : SUCCESS in 1h 18m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fd137e87395ff5fd4eec563488396cfd23c1312b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-08-09 09:00:39.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7715cb45fe1a8a935d15d8666caf7e070dc82c4e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-09 09:01:26.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"afcf61dd455eaca1c87c697848750ad704756356","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-09 10:53:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3b740689e017489780dd37325110ac3d\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/30c5f9a2060343bd94e9d49895d97256 : SUCCESS in 3m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/24fc970bb28f4ed586810d1cba9913f3 : SUCCESS in 3m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c5681d076b0a48ed9ec7dd8c2a026be4 : SUCCESS in 4m 26s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a8f49007fa3049029b0fe65a6c0e5718 : SUCCESS in 3m 52s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/8ef59fdf22484a49bc57f76c563ee9c9 : SUCCESS in 59m 57s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/96b2d77641fb48479cd7a98b4bdf15fa : SUCCESS in 3m 11s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/c9121a4d8ff94291842b9ee8c7fc2632 : SUCCESS in 4m 43s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/96536ac1e75a43c99d774f24e2415772 : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ed2c6f6d1d343b5bfe4b454ceb2efb0 : SUCCESS in 6m 43s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/5781c95ff3704b5bb8cfcfb3fdd40ea7 : SUCCESS in 57m 29s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/12adbe4d5c2e4bc293b284b293cdc893 : SUCCESS in 12m 19s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/b75d7caf4f6d4d7d9c54c9b6e3e6e072 : SUCCESS in 40m 36s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4fd3feaaca8047429028da74d751314f : SUCCESS in 57m 30s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/62fb708f2da546b6942d68bef227aa70 : SUCCESS in 1h 11m 21s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/c3308b82d56746bca2764b8a02be8824 : SUCCESS in 1h 18m 54s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/ec7839ff8b31446e8c66497e352ff157 : SUCCESS in 52m 45s","accounts_in_message":[],"_revision_number":1},{"id":"763d73827ff77e229fa137dec83ec47668b28da4","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-09 10:53:23.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"559e63ebcfbe35eef14d6be66a2bb8a40379772d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-09 10:55:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/15deb913b7754511ba3e19fb99d3d6b1\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d3b14a13c9054af3a31078e37301bd37 : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8f9aa3b7e2abf60e427bd73ceb44b2322154874f","revisions":{"8f9aa3b7e2abf60e427bd73ceb44b2322154874f":{"kind":"REWORK","_number":1,"created":"2023-08-08 11:08:01.000000000","uploader":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"ref":"refs/changes/81/890781/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/81/890781/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/81/890781/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/81/890781/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/81/890781/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/81/890781/1"}}},"commit":{"parents":[{"commit":"8742c06490ec41e6b9a0bfc9f57e132944717f25","subject":"Merge \"Implemented methods for share metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/8742c06490ec41e6b9a0bfc9f57e132944717f25"}]}],"author":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2023-08-08 10:04:36.000000000","tz":120},"committer":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2023-08-08 10:04:36.000000000","tz":120},"subject":"fix memory leak of Connections","message":"fix memory leak of Connections\n\nduring `__init__` of a `Connection` we register an `atexit` handler to\ncall the `close` method when the python interpreter exits. This should\nensure that connections are closed reliably.\n\nHowever when a connection is closed earlier (e.g. by using the context\nmanager of `Connection`) `close` is already called. However the `atexit`\nhandler is not unregistered.\nThis prevents python garbage collector from actually collecting the\n`Connection` since there is still an active reference to it.\n\nTo fix this we unregister the `atexit` handler if `close` is called.\n\nChange-Id: Id02a495353e1bfef3785248e48dec7344ef8f5af\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/8f9aa3b7e2abf60e427bd73ceb44b2322154874f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/8f9aa3b7e2abf60e427bd73ceb44b2322154874f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
