)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af598f3570d2a4f87ce731570d09284113616a8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78cce769_91df3f69","updated":"2023-09-05 09:23:36.000000000","message":"Also, you need to add docs for `StackEvent` in the `doc/source/user/resources/orchestration/v1/` directory.","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":35933,"name":"Baek Seung Ju","display_name":"Becker","email":"halucinor0@gmail.com","username":"halucinor","status":"developer"},"change_message_id":"0557dddae9d94dd4a3e791147786cc08b072d409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"409c29df_9f459e32","updated":"2023-08-31 14:51:40.000000000","message":"LGTM, But I have a suggestion.","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6462b37107612a8c64c77d9e3df7816e62deb799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0de7887f_af7d0949","updated":"2023-09-05 09:22:45.000000000","message":"Looks pretty good. Some small nits but nothing that couldn\u0027t be fixed up quickly.\n\nI note we have a method `get_events` in `openstack/orchestration/util/event_utils.py` that could probably do with being updated to use this real resource. Could you update this in a follow-up patch?","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"a2e1810df3d5473e251038dbc321e68dd35b0e4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4debfb43_4c3c1bb9","in_reply_to":"0de7887f_af7d0949","updated":"2023-09-07 02:13:44.000000000","message":"Thanks for your review! :) If what you\u0027re talking about is modifying the content of the `get_events` method or replacing it with `stack_events` where it\u0027s used, would you mind if I reflect that in my next review?","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"a2e1810df3d5473e251038dbc321e68dd35b0e4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"759ffa6b_566fd1d3","in_reply_to":"409c29df_9f459e32","updated":"2023-09-07 02:13:44.000000000","message":"Thanks for your review, I have reflected it in Patchset 9 :)","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"a2e1810df3d5473e251038dbc321e68dd35b0e4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6e401128_c5e15e53","in_reply_to":"78cce769_91df3f69","updated":"2023-09-07 02:13:44.000000000","message":"Done! 😊","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"503094dc338e0eeeadb1f3bea90e134f71ea2870","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c446a384_5f0d948c","updated":"2023-11-14 12:11:08.000000000","message":"Can you push a follow-up to rework the stack event-related logic in `openstack/orchestration/util/event_utils.py` if you get a chance?","commit_id":"3f57d7897214df6c53f37a6b95739e6683143d06"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9969634ec7d0248557bb8adb3b06c952f963bc55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"476f2326_3fc7caeb","updated":"2023-11-14 16:28:06.000000000","message":"Looks like this needs a rebase now. Will +2 again when that\u0027s done","commit_id":"3f57d7897214df6c53f37a6b95739e6683143d06"}],"openstack/orchestration/v1/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6462b37107612a8c64c77d9e3df7816e62deb799","unresolved":true,"context_lines":[{"line_number":572,"context_line":"        for stack in stacks:"},{"line_number":573,"context_line":"            self.wait_for_delete(stack)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def get_stack_events(self, stack, resource_name\u003dNone, **attr):"},{"line_number":576,"context_line":"        \"\"\"Get a stack events"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        :param stack: The value can be the ID of a stack or an instance of"}],"source_content_type":"text/x-python","patch_set":6,"id":"c464e67b_a0391d47","line":575,"range":{"start_line":575,"start_character":8,"end_line":575,"end_character":24},"updated":"2023-09-05 09:22:45.000000000","message":"should this just be `stack_events` since it returns a list of `StackEvent` objects?","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"cb5bc90cc08c6343ee4a52d264313be015224be8","unresolved":true,"context_lines":[{"line_number":572,"context_line":"        for stack in stacks:"},{"line_number":573,"context_line":"            self.wait_for_delete(stack)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def get_stack_events(self, stack, resource_name\u003dNone, **attr):"},{"line_number":576,"context_line":"        \"\"\"Get a stack events"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        :param stack: The value can be the ID of a stack or an instance of"}],"source_content_type":"text/x-python","patch_set":6,"id":"c1dc19f8_f249e641","line":575,"range":{"start_line":575,"start_character":8,"end_line":575,"end_character":24},"in_reply_to":"8cd085fc_6438f161","updated":"2023-09-07 02:23:57.000000000","message":"I fixed the fixes related to StackEvent and also renamed the file to stack_event.py :)","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"b4aabb88643309c301f22fea098431390e71d91f","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        for stack in stacks:"},{"line_number":573,"context_line":"            self.wait_for_delete(stack)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def get_stack_events(self, stack, resource_name\u003dNone, **attr):"},{"line_number":576,"context_line":"        \"\"\"Get a stack events"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        :param stack: The value can be the ID of a stack or an instance of"}],"source_content_type":"text/x-python","patch_set":6,"id":"e5ca16d9_dd225bf5","line":575,"range":{"start_line":575,"start_character":8,"end_line":575,"end_character":24},"in_reply_to":"c1dc19f8_f249e641","updated":"2023-09-18 05:59:34.000000000","message":"Done","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"a2e1810df3d5473e251038dbc321e68dd35b0e4a","unresolved":true,"context_lines":[{"line_number":572,"context_line":"        for stack in stacks:"},{"line_number":573,"context_line":"            self.wait_for_delete(stack)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def get_stack_events(self, stack, resource_name\u003dNone, **attr):"},{"line_number":576,"context_line":"        \"\"\"Get a stack events"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        :param stack: The value can be the ID of a stack or an instance of"}],"source_content_type":"text/x-python","patch_set":6,"id":"8cd085fc_6438f161","line":575,"range":{"start_line":575,"start_character":8,"end_line":575,"end_character":24},"in_reply_to":"c464e67b_a0391d47","updated":"2023-09-07 02:13:44.000000000","message":"I looked at the names of the other methods that used `_list` and you\u0027re right, I fixed it!","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"}],"openstack/orchestration/v1/stack_events.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6462b37107612a8c64c77d9e3df7816e62deb799","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack import resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class StackEvents(resource.Resource):"},{"line_number":17,"context_line":"    base_path \u003d \u0027/stacks/%(stack_name)s/%(stack_id)s/events\u0027"},{"line_number":18,"context_line":"    resources_key \u003d \u0027events\u0027"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9bc98dc9_f88a1a4c","line":16,"updated":"2023-09-05 09:22:45.000000000","message":"Use singular names, even if you can\u0027t fetch an individual resource by ID","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"b4aabb88643309c301f22fea098431390e71d91f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from openstack import resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class StackEvents(resource.Resource):"},{"line_number":17,"context_line":"    base_path \u003d \u0027/stacks/%(stack_name)s/%(stack_id)s/events\u0027"},{"line_number":18,"context_line":"    resources_key \u003d \u0027events\u0027"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5be4863d_a14d8da5","line":16,"in_reply_to":"9510e912_385a0857","updated":"2023-09-18 05:59:34.000000000","message":"Done","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"a2e1810df3d5473e251038dbc321e68dd35b0e4a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack import resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class StackEvents(resource.Resource):"},{"line_number":17,"context_line":"    base_path \u003d \u0027/stacks/%(stack_name)s/%(stack_id)s/events\u0027"},{"line_number":18,"context_line":"    resources_key \u003d \u0027events\u0027"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9510e912_385a0857","line":16,"in_reply_to":"9bc98dc9_f88a1a4c","updated":"2023-09-07 02:13:44.000000000","message":"Done","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":35933,"name":"Baek Seung Ju","display_name":"Becker","email":"halucinor0@gmail.com","username":"halucinor","status":"developer"},"change_message_id":"0557dddae9d94dd4a3e791147786cc08b072d409","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    allow_delete \u003d False"},{"line_number":25,"context_line":"    allow_commit \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    _query_mapping \u003d resource.QueryParameters(\u0027nested_depth\u0027, \u0027sort_dir\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Properties"},{"line_number":30,"context_line":"    #: The date and time when the event was created"}],"source_content_type":"text/x-python","patch_set":6,"id":"973d95b1_cefbde72","line":27,"updated":"2023-08-31 14:51:40.000000000","message":"`suggestion`\n\nList stack events API support more query param like below\n- resource_action\n- resource_status\n- resource_name\n- resource_type\n- sort_keys\n- sort_dir\n- nested_depth\n\nHow about make `_query_mapping` support those request parameters?\n\n```\n_query_mapping \u003d resource.Queryparameters(\n        \"resource_action\",\n        \"resource_status\",\n        \"resource_name\",\n        \"resource_type\",\n        \"nested_depth\",\n        \"sort_key\",\n        \"sort_dir\",\n)\n```","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"b4aabb88643309c301f22fea098431390e71d91f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    allow_delete \u003d False"},{"line_number":25,"context_line":"    allow_commit \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    _query_mapping \u003d resource.QueryParameters(\u0027nested_depth\u0027, \u0027sort_dir\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Properties"},{"line_number":30,"context_line":"    #: The date and time when the event was created"}],"source_content_type":"text/x-python","patch_set":6,"id":"ecb07222_4bb3b3a6","line":27,"in_reply_to":"3e665699_f5ddc19d","updated":"2023-09-18 05:59:34.000000000","message":"Done","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6462b37107612a8c64c77d9e3df7816e62deb799","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    allow_delete \u003d False"},{"line_number":25,"context_line":"    allow_commit \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    _query_mapping \u003d resource.QueryParameters(\u0027nested_depth\u0027, \u0027sort_dir\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Properties"},{"line_number":30,"context_line":"    #: The date and time when the event was created"}],"source_content_type":"text/x-python","patch_set":6,"id":"dad9ad11_3599fdf3","line":27,"in_reply_to":"973d95b1_cefbde72","updated":"2023-09-05 09:22:45.000000000","message":"+1","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"a2e1810df3d5473e251038dbc321e68dd35b0e4a","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    allow_delete \u003d False"},{"line_number":25,"context_line":"    allow_commit \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    _query_mapping \u003d resource.QueryParameters(\u0027nested_depth\u0027, \u0027sort_dir\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Properties"},{"line_number":30,"context_line":"    #: The date and time when the event was created"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e665699_f5ddc19d","line":27,"in_reply_to":"dad9ad11_3599fdf3","updated":"2023-09-07 02:13:44.000000000","message":"Done","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6462b37107612a8c64c77d9e3df7816e62deb799","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    # Properties"},{"line_number":30,"context_line":"    #: The date and time when the event was created"},{"line_number":31,"context_line":"    event_time \u003d resource.Body(\u0027event_time\u0027)"},{"line_number":32,"context_line":"    #: The ID of the evnet object"},{"line_number":33,"context_line":"    id \u003d resource.Body(\u0027id\u0027)"},{"line_number":34,"context_line":"    #: A list of dictionaries containing links relevant to the stack."},{"line_number":35,"context_line":"    links \u003d resource.Body(\u0027links\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b3340d38_e9c65f9a","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":26},"updated":"2023-09-05 09:22:45.000000000","message":"nit: `event`","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"b4aabb88643309c301f22fea098431390e71d91f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # Properties"},{"line_number":30,"context_line":"    #: The date and time when the event was created"},{"line_number":31,"context_line":"    event_time \u003d resource.Body(\u0027event_time\u0027)"},{"line_number":32,"context_line":"    #: The ID of the evnet object"},{"line_number":33,"context_line":"    id \u003d resource.Body(\u0027id\u0027)"},{"line_number":34,"context_line":"    #: A list of dictionaries containing links relevant to the stack."},{"line_number":35,"context_line":"    links \u003d resource.Body(\u0027links\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"84e58343_ce20d67b","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":26},"in_reply_to":"86994ca0_ff5d6515","updated":"2023-09-18 05:59:34.000000000","message":"Done","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"},{"author":{"_account_id":36157,"name":"SongSuheon","display_name":"ssheon0812","email":"ssheon0812@naver.com","username":"ssheon0812"},"change_message_id":"a2e1810df3d5473e251038dbc321e68dd35b0e4a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    # Properties"},{"line_number":30,"context_line":"    #: The date and time when the event was created"},{"line_number":31,"context_line":"    event_time \u003d resource.Body(\u0027event_time\u0027)"},{"line_number":32,"context_line":"    #: The ID of the evnet object"},{"line_number":33,"context_line":"    id \u003d resource.Body(\u0027id\u0027)"},{"line_number":34,"context_line":"    #: A list of dictionaries containing links relevant to the stack."},{"line_number":35,"context_line":"    links \u003d resource.Body(\u0027links\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"86994ca0_ff5d6515","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":26},"in_reply_to":"b3340d38_e9c65f9a","updated":"2023-09-07 02:13:44.000000000","message":"Done","commit_id":"1953d85a0baad687a6a7fee0d6b72e77fa49724d"}]}