)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c449946de7062157a10b17fc621705a513fd0563","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3cfcf10_b50f16b3","updated":"2023-09-01 09:44:02.000000000","message":"It\u0027s worth noting also that this will change behaviour for users using `clouds.yaml`. Given the following configuration:\n\n```yaml\nclouds:\n  foo:\n    username: foo\n    password: bar\n    auth:\n      username: abc\n      password: xyz\n    # ...\n```\n\n\nCurrently, we would prefer the configuration in `clouds.foo.auth`. With this change, we will prefer the configuration in `clouds.foo`. At least, that\u0027s how I\u0027m reading the code (have no verified myself yet). Perhaps you can add a check for this also? I\u0027d like to avoid changing _this_ behavior, but I don\u0027t know how you can do that without keeping track of the source of the configuration value.\n\nPerhaps as an alternative, we can start moving certain options that are known to be auth values into the `auth` section? i.e. if we read `OS_USERNAME` we save that in `cloud[\u0027auth\u0027]` instead of `cloud`? I haven\u0027t looked into how this is done but it would have the advantage of avoiding this other change in behaviour and also mean we\u0027re generating \"correct\" cloud objects in our own code (vs objects that need transformation by this backwards compatibility handling code). wdyt?","commit_id":"debafe89dd31ccffd350fbe921b7cc2293895632"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b3bbd0a603b3e5ac64e73a47737a9819b6387f88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"94c21fc6_b5f494fd","updated":"2023-09-01 09:38:17.000000000","message":"Looks pretty good. Can you please add a release note and a note to the documentation in `doc/source/user/config/configuration.rst`? We could also do with a unit tests to verify this behavior and prevent regressions.","commit_id":"debafe89dd31ccffd350fbe921b7cc2293895632"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"1360a2e51225c6603dfd7ab2aa985e843634f789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcf1f999_0d03efea","in_reply_to":"e3cfcf10_b50f16b3","updated":"2023-09-01 23:52:54.000000000","message":"You\u0027re right that this order will be changed but I don\u0027t think I\u0027m motivated to rearrange code elsewhere to resolve the issue. Specifying the same setting both inside and outside the \u0027auth\u0027 setting in clouds.yaml seems like clearly undefined behavior so I don\u0027t feel too bad changing it.\n\nUpcoming patch documents the behavior as you currently describe it. I\u0027m open to digging deeper into the redundant settings question if you feel strongly!","commit_id":"debafe89dd31ccffd350fbe921b7cc2293895632"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68a906c1_665642a6","updated":"2023-09-27 08:58:33.000000000","message":"Lots of doc nits. Fix and tests are fine.","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1602461_128fa6bc","updated":"2023-10-01 18:59:39.000000000","message":"Thank you for the close review! I clearly have not written a lot of .rst, hopefully I caught all the literals.","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1aaaf850980ac6ae210a416f5f4e1d5a4182dfab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc1d9f07_986be0ac","updated":"2023-10-02 14:46:48.000000000","message":"Failures are real but trivial to resolve. I would recommend installing and enabling pre-commit to catch things like this in the future, fwiw.","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"773564aa19d848935a231a9602d4723c16db144d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa483352_583edc70","updated":"2023-10-03 15:16:29.000000000","message":"just cleaning up open comments","commit_id":"1ceb9972eb460090fc8cc8524d9f036f562cb552"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"f14bdd7f13c2f1f72f615b095a9f53fa06ff90f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45e5b07f_acac3f40","updated":"2023-10-16 14:54:51.000000000","message":"thanks y\u0027all","commit_id":"1ceb9972eb460090fc8cc8524d9f036f562cb552"}],"doc/source/user/config/configuration.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":400,"context_line":"------------------"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"Some settings are redundant, e.g. \u0027project-name\u0027 and \u0027project-id\u0027 both specify"},{"line_number":403,"context_line":"the project. In a conflict between redundant settings, the -name or _NAME"},{"line_number":404,"context_line":"setting will be used."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"Some environment vars or commandline flags can override the settings from"}],"source_content_type":"text/x-rst","patch_set":2,"id":"99790995_fcce3553","line":403,"range":{"start_line":403,"start_character":59,"end_line":403,"end_character":64},"updated":"2023-09-27 08:58:33.000000000","message":"nit: `literal`. Also, you probably want to indicate what the different suffixes refer to and call out the `clouds.yaml` equivalent.\n\n```\n``_name`` ``clouds.yaml`` option (or equivalent ``-name`` CLI option and ``_NAME`` environment variable) will be used.\n```","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":400,"context_line":"------------------"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"Some settings are redundant, e.g. \u0027project-name\u0027 and \u0027project-id\u0027 both specify"},{"line_number":403,"context_line":"the project. In a conflict between redundant settings, the -name or _NAME"},{"line_number":404,"context_line":"setting will be used."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"Some environment vars or commandline flags can override the settings from"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7c5e6fa3_5b4cde49","line":403,"range":{"start_line":403,"start_character":59,"end_line":403,"end_character":64},"in_reply_to":"99790995_fcce3553","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":403,"context_line":"the project. In a conflict between redundant settings, the -name or _NAME"},{"line_number":404,"context_line":"setting will be used."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"Some environment vars or commandline flags can override the settings from"},{"line_number":407,"context_line":"clouds.yaml. These are:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":" --domain_id (OS_DOMAIN_ID)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"576bdc9c_d2b96fe7","line":406,"range":{"start_line":406,"start_character":17,"end_line":406,"end_character":21},"updated":"2023-09-27 08:58:33.000000000","message":"nit: variables","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":403,"context_line":"the project. In a conflict between redundant settings, the -name or _NAME"},{"line_number":404,"context_line":"setting will be used."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"Some environment vars or commandline flags can override the settings from"},{"line_number":407,"context_line":"clouds.yaml. These are:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":" --domain_id (OS_DOMAIN_ID)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f7afc82_f6d4c851","line":406,"range":{"start_line":406,"start_character":17,"end_line":406,"end_character":21},"in_reply_to":"576bdc9c_d2b96fe7","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":406,"context_line":"Some environment vars or commandline flags can override the settings from"},{"line_number":407,"context_line":"clouds.yaml. These are:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":" --domain_id (OS_DOMAIN_ID)"},{"line_number":410,"context_line":" --domain_name (OS_DOMAIN_NAME)"},{"line_number":411,"context_line":" --user_domain_id (OS_USER_DOMAIN_ID)"},{"line_number":412,"context_line":" --user_domain_name (OS_USER_DOMAIN_NAME)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cae5a397_b186bc05","line":409,"range":{"start_line":409,"start_character":3,"end_line":409,"end_character":12},"updated":"2023-09-27 08:58:33.000000000","message":"I think these should all use dashes rather than underscores.\n\nAlso, nit: could you format this is a bullet list and the symbols as `literals` (use double backticks in reST), e.g.\n\n```\n- ``--domain-id`` (``OS_DOMAIN_ID``)\n- ...\n```","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":406,"context_line":"Some environment vars or commandline flags can override the settings from"},{"line_number":407,"context_line":"clouds.yaml. These are:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":" --domain_id (OS_DOMAIN_ID)"},{"line_number":410,"context_line":" --domain_name (OS_DOMAIN_NAME)"},{"line_number":411,"context_line":" --user_domain_id (OS_USER_DOMAIN_ID)"},{"line_number":412,"context_line":" --user_domain_name (OS_USER_DOMAIN_NAME)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5121f4d8_bec1ef98","line":409,"range":{"start_line":409,"start_character":3,"end_line":409,"end_character":12},"in_reply_to":"cae5a397_b186bc05","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":418,"context_line":" --tenant_id (OS_TENANT_ID) (deprecated in favor of --project_id)"},{"line_number":419,"context_line":" --tenant_name (OS_TENANT_NAME) (deprecated in favor of --project_name)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Similarly, if one of the above settings is specified in clouds.yaml as part of"},{"line_number":422,"context_line":"the \u0027auth\u0027 section as well as the main section, the \u0027auth\u0027 settings will be"},{"line_number":423,"context_line":"overridden. For example in this config section, note that project is specified"},{"line_number":424,"context_line":"multiple times:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b8b10de5_a2e9edc9","line":421,"range":{"start_line":421,"start_character":56,"end_line":421,"end_character":67},"updated":"2023-09-27 08:58:33.000000000","message":"nit: `literal`","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":418,"context_line":" --tenant_id (OS_TENANT_ID) (deprecated in favor of --project_id)"},{"line_number":419,"context_line":" --tenant_name (OS_TENANT_NAME) (deprecated in favor of --project_name)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Similarly, if one of the above settings is specified in clouds.yaml as part of"},{"line_number":422,"context_line":"the \u0027auth\u0027 section as well as the main section, the \u0027auth\u0027 settings will be"},{"line_number":423,"context_line":"overridden. For example in this config section, note that project is specified"},{"line_number":424,"context_line":"multiple times:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"679194f5_4edb820d","line":421,"range":{"start_line":421,"start_character":56,"end_line":421,"end_character":67},"in_reply_to":"b8b10de5_a2e9edc9","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":419,"context_line":" --tenant_name (OS_TENANT_NAME) (deprecated in favor of --project_name)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Similarly, if one of the above settings is specified in clouds.yaml as part of"},{"line_number":422,"context_line":"the \u0027auth\u0027 section as well as the main section, the \u0027auth\u0027 settings will be"},{"line_number":423,"context_line":"overridden. For example in this config section, note that project is specified"},{"line_number":424,"context_line":"multiple times:"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6ed3b7f9_cf10a6be","line":422,"range":{"start_line":422,"start_character":5,"end_line":422,"end_character":9},"updated":"2023-09-27 08:58:33.000000000","message":"nit: `literal`","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":419,"context_line":" --tenant_name (OS_TENANT_NAME) (deprecated in favor of --project_name)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Similarly, if one of the above settings is specified in clouds.yaml as part of"},{"line_number":422,"context_line":"the \u0027auth\u0027 section as well as the main section, the \u0027auth\u0027 settings will be"},{"line_number":423,"context_line":"overridden. For example in this config section, note that project is specified"},{"line_number":424,"context_line":"multiple times:"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e72340be_95872c69","line":422,"range":{"start_line":422,"start_character":53,"end_line":422,"end_character":57},"updated":"2023-09-27 08:58:33.000000000","message":"nit: `literal`","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":419,"context_line":" --tenant_name (OS_TENANT_NAME) (deprecated in favor of --project_name)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Similarly, if one of the above settings is specified in clouds.yaml as part of"},{"line_number":422,"context_line":"the \u0027auth\u0027 section as well as the main section, the \u0027auth\u0027 settings will be"},{"line_number":423,"context_line":"overridden. For example in this config section, note that project is specified"},{"line_number":424,"context_line":"multiple times:"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d594a24c_a779f783","line":422,"range":{"start_line":422,"start_character":5,"end_line":422,"end_character":9},"in_reply_to":"6ed3b7f9_cf10a6be","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":419,"context_line":" --tenant_name (OS_TENANT_NAME) (deprecated in favor of --project_name)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Similarly, if one of the above settings is specified in clouds.yaml as part of"},{"line_number":422,"context_line":"the \u0027auth\u0027 section as well as the main section, the \u0027auth\u0027 settings will be"},{"line_number":423,"context_line":"overridden. For example in this config section, note that project is specified"},{"line_number":424,"context_line":"multiple times:"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"806ed92b_a3c14902","line":422,"range":{"start_line":422,"start_character":53,"end_line":422,"end_character":57},"in_reply_to":"e72340be_95872c69","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":437,"context_line":"      project_name: myfavoriteproject"},{"line_number":438,"context_line":"      project_id: 2acf9403-25e8-479e-a3c6-d67540c424a4"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"In the above example, the project_ids will be ignored in favor of the"},{"line_number":441,"context_line":"project_names, and the higher-level project will be chosen over the"},{"line_number":442,"context_line":"auth-specified project. So the actual project used will be \u0027myfavoriteproject\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3d92b4_86b3adfd","line":440,"range":{"start_line":440,"start_character":26,"end_line":440,"end_character":37},"updated":"2023-09-27 08:58:33.000000000","message":"nit:\n\n```\nthe ``project_id`` configuration values\n```\n\n?","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":437,"context_line":"      project_name: myfavoriteproject"},{"line_number":438,"context_line":"      project_id: 2acf9403-25e8-479e-a3c6-d67540c424a4"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"In the above example, the project_ids will be ignored in favor of the"},{"line_number":441,"context_line":"project_names, and the higher-level project will be chosen over the"},{"line_number":442,"context_line":"auth-specified project. So the actual project used will be \u0027myfavoriteproject\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"199ad731_685fe9a1","line":440,"range":{"start_line":440,"start_character":26,"end_line":440,"end_character":37},"in_reply_to":"df3d92b4_86b3adfd","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":438,"context_line":"      project_id: 2acf9403-25e8-479e-a3c6-d67540c424a4"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"In the above example, the project_ids will be ignored in favor of the"},{"line_number":441,"context_line":"project_names, and the higher-level project will be chosen over the"},{"line_number":442,"context_line":"auth-specified project. So the actual project used will be \u0027myfavoriteproject\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"964591a1_e97edf8b","line":441,"range":{"start_line":441,"start_character":0,"end_line":441,"end_character":13},"updated":"2023-09-27 08:58:33.000000000","message":"nit:\n\n```\nthe ``project_name`` configuration values\n```","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":438,"context_line":"      project_id: 2acf9403-25e8-479e-a3c6-d67540c424a4"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"In the above example, the project_ids will be ignored in favor of the"},{"line_number":441,"context_line":"project_names, and the higher-level project will be chosen over the"},{"line_number":442,"context_line":"auth-specified project. So the actual project used will be \u0027myfavoriteproject\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"af399345_8282ed23","line":441,"range":{"start_line":441,"start_character":0,"end_line":441,"end_character":13},"in_reply_to":"964591a1_e97edf8b","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"In the above example, the project_ids will be ignored in favor of the"},{"line_number":441,"context_line":"project_names, and the higher-level project will be chosen over the"},{"line_number":442,"context_line":"auth-specified project. So the actual project used will be \u0027myfavoriteproject\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1358afb0_265bf418","line":442,"range":{"start_line":442,"start_character":60,"end_line":442,"end_character":77},"updated":"2023-09-27 08:58:33.000000000","message":"nit: `literal`","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"In the above example, the project_ids will be ignored in favor of the"},{"line_number":441,"context_line":"project_names, and the higher-level project will be chosen over the"},{"line_number":442,"context_line":"auth-specified project. So the actual project used will be \u0027myfavoriteproject\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"d59ed732_b78f6a7a","line":442,"range":{"start_line":442,"start_character":60,"end_line":442,"end_character":77},"in_reply_to":"1358afb0_265bf418","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"}],"openstack/config/loader.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":776,"context_line":"        for target_key, possible_values in mappings.items():"},{"line_number":777,"context_line":"            target \u003d None"},{"line_number":778,"context_line":"            for key in possible_values:"},{"line_number":779,"context_line":"                if key in cloud[\u0027auth\u0027]:"},{"line_number":780,"context_line":"                    target \u003d str(cloud[\u0027auth\u0027][key])"},{"line_number":781,"context_line":"                    del cloud[\u0027auth\u0027][key]"},{"line_number":782,"context_line":"                if key in cloud:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f41e8362_42021a92","line":779,"updated":"2023-09-27 08:58:33.000000000","message":"Can you add a comment here about why we do things in this order?","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        for target_key, possible_values in mappings.items():"},{"line_number":777,"context_line":"            target \u003d None"},{"line_number":778,"context_line":"            for key in possible_values:"},{"line_number":779,"context_line":"                if key in cloud[\u0027auth\u0027]:"},{"line_number":780,"context_line":"                    target \u003d str(cloud[\u0027auth\u0027][key])"},{"line_number":781,"context_line":"                    del cloud[\u0027auth\u0027][key]"},{"line_number":782,"context_line":"                if key in cloud:"}],"source_content_type":"text/x-python","patch_set":2,"id":"cebb6215_52f487a5","line":779,"in_reply_to":"f41e8362_42021a92","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"}],"releasenotes/notes/story-2010784-21d23043155497f5.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    In previous releases, these credentials could not be usefully defined"},{"line_number":8,"context_line":"    within \u0027clouds.yaml\u0027 because clouds.yaml supports only specifying a single"},{"line_number":9,"context_line":"    domain and project for auth purposes. This project or domain could not"},{"line_number":10,"context_line":"    be overridden on the commandline."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    When some config settings are specified multiple times, the order of precendence"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8a008516_171922db","line":10,"updated":"2023-09-27 08:58:33.000000000","message":"Preludes can only be specified once per-release. You don\u0027t want to use that. This feels like an \"upgrade\" release note since it\u0027s a change in behaviour following an upgrade.","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    In previous releases, these credentials could not be usefully defined"},{"line_number":8,"context_line":"    within \u0027clouds.yaml\u0027 because clouds.yaml supports only specifying a single"},{"line_number":9,"context_line":"    domain and project for auth purposes. This project or domain could not"},{"line_number":10,"context_line":"    be overridden on the commandline."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    When some config settings are specified multiple times, the order of precendence"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6a05186c_87e6f36b","line":10,"in_reply_to":"8a008516_171922db","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32fe97ef875bb2c8ef9846a58df3089753eee694","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    precedence over that specified within the auth section."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Affected settings are:"},{"line_number":20,"context_line":"      domain_id"},{"line_number":21,"context_line":"      domain_name"},{"line_number":22,"context_line":"      user_domain_id"},{"line_number":23,"context_line":"      user_domain_name"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f3a9bc3_ef1c4985","line":20,"updated":"2023-09-27 08:58:33.000000000","message":"This isn\u0027t valid rST (or rather, it\u0027s not rendering what you think it is). You need an empty line before a bullet list. Also, you need bullet points. As things stand, I think this is a quotation and all tokens will be wrapped onto one line.\n\n```\nAffected settings are:\n\n- ``domain_name``\n- ...\n```","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"05fa6f07ccde3a305b59a233f0bfd7925e30ebb4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    precedence over that specified within the auth section."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Affected settings are:"},{"line_number":20,"context_line":"      domain_id"},{"line_number":21,"context_line":"      domain_name"},{"line_number":22,"context_line":"      user_domain_id"},{"line_number":23,"context_line":"      user_domain_name"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2de57442_bc0cda44","line":20,"in_reply_to":"7f3a9bc3_ef1c4985","updated":"2023-10-01 18:59:39.000000000","message":"Done","commit_id":"5c224983015bca5041885049aeaec6e06635a543"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1aaaf850980ac6ae210a416f5f4e1d5a4182dfab","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    or domain-wide."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In previous releases, these credentials could not be usefully defined"},{"line_number":9,"context_line":"    within \u0027clouds.yaml\u0027 because clouds.yaml supports only specifying a single"},{"line_number":10,"context_line":"    domain and project for auth purposes. This project or domain could not"},{"line_number":11,"context_line":"    be overridden on the commandline."},{"line_number":12,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"38652a4f_23eb070e","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":24},"updated":"2023-10-02 14:46:48.000000000","message":"nit:\n\n```\n``clouds.yaml``\n```\n\nelsewhere too","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f600b0cf232a05a01b48fb62aadcf4372150b06c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    or domain-wide."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In previous releases, these credentials could not be usefully defined"},{"line_number":9,"context_line":"    within \u0027clouds.yaml\u0027 because clouds.yaml supports only specifying a single"},{"line_number":10,"context_line":"    domain and project for auth purposes. This project or domain could not"},{"line_number":11,"context_line":"    be overridden on the commandline."},{"line_number":12,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1616f062_caea3923","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":24},"in_reply_to":"38652a4f_23eb070e","updated":"2023-10-03 09:30:15.000000000","message":"Done","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"773564aa19d848935a231a9602d4723c16db144d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    or domain-wide."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In previous releases, these credentials could not be usefully defined"},{"line_number":9,"context_line":"    within \u0027clouds.yaml\u0027 because clouds.yaml supports only specifying a single"},{"line_number":10,"context_line":"    domain and project for auth purposes. This project or domain could not"},{"line_number":11,"context_line":"    be overridden on the commandline."},{"line_number":12,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2a7c4fcb_ef55f37a","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":24},"in_reply_to":"38652a4f_23eb070e","updated":"2023-10-03 15:16:29.000000000","message":"Done","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1aaaf850980ac6ae210a416f5f4e1d5a4182dfab","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    be overridden on the commandline."},{"line_number":12,"context_line":"fixes:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    When some config settings are specified multiple times, the order of precendence"},{"line_number":15,"context_line":"    has been changed to prefer command-line or env settings over those found in"},{"line_number":16,"context_line":"    clouds.yaml. The same reordering has been done when a setting is specified"},{"line_number":17,"context_line":"    multiple times within clouds.yaml; now a higher-level setting will take"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8c8066b4_c2581999","line":14,"updated":"2023-10-02 14:46:48.000000000","message":"This is too long, which is why pep8 checks are failing. You need to wrap at \u003c\u003d 79 characters.","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f600b0cf232a05a01b48fb62aadcf4372150b06c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    be overridden on the commandline."},{"line_number":12,"context_line":"fixes:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    When some config settings are specified multiple times, the order of precendence"},{"line_number":15,"context_line":"    has been changed to prefer command-line or env settings over those found in"},{"line_number":16,"context_line":"    clouds.yaml. The same reordering has been done when a setting is specified"},{"line_number":17,"context_line":"    multiple times within clouds.yaml; now a higher-level setting will take"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"babd05cf_52705b0d","line":14,"in_reply_to":"8c8066b4_c2581999","updated":"2023-10-03 09:30:15.000000000","message":"Done","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"773564aa19d848935a231a9602d4723c16db144d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    be overridden on the commandline."},{"line_number":12,"context_line":"fixes:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    When some config settings are specified multiple times, the order of precendence"},{"line_number":15,"context_line":"    has been changed to prefer command-line or env settings over those found in"},{"line_number":16,"context_line":"    clouds.yaml. The same reordering has been done when a setting is specified"},{"line_number":17,"context_line":"    multiple times within clouds.yaml; now a higher-level setting will take"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d3626ed4_7d7e37e7","line":14,"in_reply_to":"8c8066b4_c2581999","updated":"2023-10-03 15:16:29.000000000","message":"Done","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1aaaf850980ac6ae210a416f5f4e1d5a4182dfab","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    Affected settings are:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"-       ``domain_id``"},{"line_number":23,"context_line":"-       ``domain_name``"},{"line_number":24,"context_line":"-       ``user_domain_id``"},{"line_number":25,"context_line":"-       ``user_domain_name``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a549c92f_d724a232","line":22,"updated":"2023-10-02 14:46:48.000000000","message":"Whoops. These are too far outdented.","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"773564aa19d848935a231a9602d4723c16db144d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    Affected settings are:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"-       ``domain_id``"},{"line_number":23,"context_line":"-       ``domain_name``"},{"line_number":24,"context_line":"-       ``user_domain_id``"},{"line_number":25,"context_line":"-       ``user_domain_name``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a2272708_1b229bd3","line":22,"in_reply_to":"a1bdd7a1_643fb4dd","updated":"2023-10-03 15:16:29.000000000","message":"done","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f600b0cf232a05a01b48fb62aadcf4372150b06c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    Affected settings are:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"-       ``domain_id``"},{"line_number":23,"context_line":"-       ``domain_name``"},{"line_number":24,"context_line":"-       ``user_domain_id``"},{"line_number":25,"context_line":"-       ``user_domain_name``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a1bdd7a1_643fb4dd","line":22,"in_reply_to":"a549c92f_d724a232","updated":"2023-10-03 09:30:15.000000000","message":"Done","commit_id":"606d0d4598cbd7bcd4ff5411d658dcb2a44afb53"}]}