)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5f654579539a5e48249ee507289e54b60d711ec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4f9c12c_6d29f79c","updated":"2023-10-06 11:17:09.000000000","message":"Again, is there anything totally unique about glance tags to warrant now using the tag mixin like everyone else?","commit_id":"02a8bedf25e2016bb65ddcb78ed9cad5196a5a39"}],"openstack/image/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4af0884d9aa82d7a1450e40f19c565a156cb5f6","unresolved":true,"context_lines":[{"line_number":1312,"context_line":"        )"},{"line_number":1313,"context_line":""},{"line_number":1314,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d METADEF TAGS \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1315,"context_line":"    def get_metadef_tag(self, namespace, tag_name):"},{"line_number":1316,"context_line":"        \"\"\"Get a single metadef object"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"        :param namespace: The value can be either the name of a metadef"}],"source_content_type":"text/x-python","patch_set":5,"id":"6e4445cf_059443c5","line":1315,"updated":"2024-01-26 15:27:17.000000000","message":"As noted in https://review.opendev.org/c/openstack/openstacksdk/+/896903, do we need this proxy method? Do we expect people to do this? It feels like a bit of a useless method. The user could simply do `get_metadef_namespace` and look at the tags attribute, right?","commit_id":"c4b7194724126ba8297bbddba18f9b18a526f77c"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"fffba9259dab73b6c9957818256cb137ee286a33","unresolved":true,"context_lines":[{"line_number":1312,"context_line":"        )"},{"line_number":1313,"context_line":""},{"line_number":1314,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d METADEF TAGS \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1315,"context_line":"    def get_metadef_tag(self, namespace, tag_name):"},{"line_number":1316,"context_line":"        \"\"\"Get a single metadef object"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"        :param namespace: The value can be either the name of a metadef"}],"source_content_type":"text/x-python","patch_set":5,"id":"5c23b94e_a6cd97c6","line":1315,"in_reply_to":"6e4445cf_059443c5","updated":"2024-01-30 10:44:45.000000000","message":"Agreed with dropping of the proxy_method","commit_id":"c4b7194724126ba8297bbddba18f9b18a526f77c"}],"openstack/image/v2/metadef_namespace.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4af0884d9aa82d7a1450e40f19c565a156cb5f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e1741791_85c0933a","line":89,"updated":"2024-01-26 15:27:17.000000000","message":"This is already defined in `TagMixin`. Why are you providing your own implementation?","commit_id":"c4b7194724126ba8297bbddba18f9b18a526f77c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"44ce272c2af21bc287701aa28257800734524d6f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7c13742d_fd6c1f79","line":89,"in_reply_to":"7fecd969_855066a9","updated":"2024-01-30 10:58:26.000000000","message":"Okay. So the way the tag mixin appears to work is that you can call `fetch_tags`, and then if you want to get an individual tag you simply check the value of `namespace.tags` (which is a list of tags).\n\nGiven this, does this method do much? Do we need it? How would you envision an end-user using this in a meaningful manner?","commit_id":"c4b7194724126ba8297bbddba18f9b18a526f77c"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"fffba9259dab73b6c9957818256cb137ee286a33","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7fecd969_855066a9","line":89,"in_reply_to":"e1741791_85c0933a","updated":"2024-01-30 10:44:45.000000000","message":"The check_tag method in TagMixin checks if the tag exists or not, but does not return details of the tag.\n\nI think we can rename it as get_tag_detail or get_tag.","commit_id":"c4b7194724126ba8297bbddba18f9b18a526f77c"}]}