)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c269aa608487f68c789f6f112d3b9d6d62850d09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73e8bc53_64cecca3","updated":"2024-01-16 09:45:23.000000000","message":"recheck docs job failure","commit_id":"73905496683ee75b3c8511b8d148b9844649ff7a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ed9539d1134d7902615970313d46962239419cc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9158694_4785f352","updated":"2023-11-21 05:01:26.000000000","message":"recheck for fresh logs","commit_id":"73905496683ee75b3c8511b8d148b9844649ff7a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"294c28567d72e4425c9a73346d7953b474820dc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f0d9262_ea22c85f","updated":"2023-10-11 19:28:36.000000000","message":"recheck the docs failure looks unrelated\n\n2023-10-11 09:04:53.535429 | ubuntu-jammy | docs: 49346 C exit 1 (36.86 seconds) /home/zuul/src/opendev.org/openstack/openstacksdk\u003e sphinx-build -W --keep-going -b html -j auto doc/source/ doc/build/html pid\u003d8096 [tox/execute/api.py:279]\n2023-10-11 09:04:53.537049 | ubuntu-jammy | .pkg: 49348 W _exit\u003e python /home/zuul/.local/tox/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ [tox/tox_env/api.py:427]\n2023-10-11 09:04:53.538712 | ubuntu-jammy | Backend: run command _exit with args {}\n2023-10-11 09:04:53.540009 | ubuntu-jammy | Backend: Wrote response {\u0027return\u0027: 0} to /tmp/pep517__exit-fuqtgwss.json\n2023-10-11 09:04:53.540066 | ubuntu-jammy | .pkg: 49351 I exit None (0.00 seconds) /home/zuul/src/opendev.org/openstack/openstacksdk\u003e python /home/zuul/.local/tox/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ pid\u003d6347 [tox/execute/api.py:279]\n2023-10-11 09:04:53.592588 | ubuntu-jammy | .pkg: 49403 D delete package /home/zuul/src/opendev.org/openstack/openstacksdk/.tox/.tmp/package/2/openstacksdk-1.6.0.dev49.tar.gz [tox/tox_env/python/virtual_env/package/pyproject.py:206]\n2023-10-11 09:04:53.594330 | ubuntu-jammy |   docs: FAIL code 1 (49.04\u003dsetup[12.19]+cmd[36.86] seconds)\n2023-10-11 09:04:53.642842 | ubuntu-jammy |   evaluation failed :( (49.19 seconds)\n2023-10-11 09:04:54.221733 | ubuntu-jammy | ERROR","commit_id":"73905496683ee75b3c8511b8d148b9844649ff7a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"41a8bc5de82335faf2d605db173cf39f925b57f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f68d218f_ed5f1522","updated":"2024-01-31 09:41:21.000000000","message":"Hi Artem, please find the reply inline","commit_id":"fdeb9c5b299534dec839e7bf2058f7b8b566a479"}],"openstack/block_storage/v3/volume.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4b7c979a9530838d04a22b2e2b581f077a407ea4","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    #: The name of the associated volume type."},{"line_number":108,"context_line":"    volume_type \u003d resource.Body(\"volume_type\")"},{"line_number":109,"context_line":"    #: Remove any snapshots along with the volume. Default\u003dFalse."},{"line_number":110,"context_line":"    cascade \u003d resource.Body(\"cascade\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    _max_microversion \u003d \"3.60\""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"69505d4c_6ea9f387","line":110,"updated":"2024-01-30 08:06:49.000000000","message":"this is not the REST resource attribute, isn\u0027t it? If so it should not appear as a resource field just to address cascade delete","commit_id":"fdeb9c5b299534dec839e7bf2058f7b8b566a479"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"41a8bc5de82335faf2d605db173cf39f925b57f2","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    #: The name of the associated volume type."},{"line_number":108,"context_line":"    volume_type \u003d resource.Body(\"volume_type\")"},{"line_number":109,"context_line":"    #: Remove any snapshots along with the volume. Default\u003dFalse."},{"line_number":110,"context_line":"    cascade \u003d resource.Body(\"cascade\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    _max_microversion \u003d \"3.60\""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"84e3fa33_87c4f89f","line":110,"in_reply_to":"69505d4c_6ea9f387","updated":"2024-01-31 09:41:21.000000000","message":"it is a REST request parameter for volume delete, see the request section here https://docs.openstack.org/api-ref/block-storage/v3/#delete-a-volume","commit_id":"fdeb9c5b299534dec839e7bf2058f7b8b566a479"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"a8ec7104e02c7781a94709162a45fe33dcd5aa5c","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    #: The name of the associated volume type."},{"line_number":108,"context_line":"    volume_type \u003d resource.Body(\"volume_type\")"},{"line_number":109,"context_line":"    #: Remove any snapshots along with the volume. Default\u003dFalse."},{"line_number":110,"context_line":"    cascade \u003d resource.Body(\"cascade\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    _max_microversion \u003d \"3.60\""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bb6d35fb_0f5ce5c3","line":110,"in_reply_to":"84e3fa33_87c4f89f","updated":"2024-01-31 09:44:29.000000000","message":"sure, but this is not an attribute of the volume. On the resource we only have attributes that are representing resource fields (like in the DB table). All special request attributes (only required for 1-2 apis) are just passed as additional function parameters and are not persisted on the resource","commit_id":"fdeb9c5b299534dec839e7bf2058f7b8b566a479"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0a03d7a57969a962fb51a062352d0830b5948915","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    #: The name of the associated volume type."},{"line_number":108,"context_line":"    volume_type \u003d resource.Body(\"volume_type\")"},{"line_number":109,"context_line":"    #: Remove any snapshots along with the volume. Default\u003dFalse."},{"line_number":110,"context_line":"    cascade \u003d resource.Body(\"cascade\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    _max_microversion \u003d \"3.60\""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"066b3eb6_fe50ada0","line":110,"in_reply_to":"bb6d35fb_0f5ce5c3","updated":"2024-02-05 21:05:59.000000000","message":"so you mean we only keep response parameters here? got it.\nI\u0027m running into another problem now since I\u0027m overriding the resource\u0027s delete method, here[1] we only preserve the kwargs that are part of resource definition and ignore other kwargs.\n\none possibility is to define custom delete method (delete_volume) and call it directly from the _proxy file but that will lead to duplication of the delete method code from the resource file. Is there a simpler way to pass kwargs in the current workflow?\n\n[1] https://github.com/openstack/openstacksdk/blob/6077e6c2ba3a461b79c3d90b16f8d3b39b8ee8c5/openstack/proxy.py#L568","commit_id":"fdeb9c5b299534dec839e7bf2058f7b8b566a479"}]}