)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d191c73a10b732735d1d0044a222e5feb26b8fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3179c24_603e27eb","updated":"2023-10-12 05:02:50.000000000","message":"Thanks Michael, also need to handle https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/dns/v2/test_zone.py#L74","commit_id":"cd63b2d05f853eb3147046f097c3ce022caad42f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ea51040c35cfe517768243f232d9e2ad8834fe2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8da97914_738a406c","updated":"2023-10-13 04:36:03.000000000","message":"ohkk https://review.opendev.org/c/openstack/neutron/+/897472 triggered missing tables issue","commit_id":"5bab9de98b57da2fa5fd8433868017ae895a81f7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"694bb148f378c8ad6ad3da6da39be23da475bef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae06d45a_e9d52313","updated":"2023-10-12 15:11:38.000000000","message":"recheck\nPOST_FAILURE\nI think this looks good, so adding my vote.","commit_id":"5bab9de98b57da2fa5fd8433868017ae895a81f7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5b14674d225c530fa7f3c33c70c99b05b1f4668e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"547c847c_6450245f","updated":"2023-10-12 22:39:19.000000000","message":"recheck\nunrelated neutron error: \"Table \u0027neutron.cisco_csr_identifier_map\u0027 doesn\u0027t exist\"","commit_id":"5bab9de98b57da2fa5fd8433868017ae895a81f7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1cecf6b3266be7d6fb647603338a3708fdeaa781","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e0e5f7e6_c1130725","updated":"2023-10-12 12:30:20.000000000","message":"recheck POST_FAILURES","commit_id":"5bab9de98b57da2fa5fd8433868017ae895a81f7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c4b2c07d2d0aef1bbc81974e340c98f2a89f8f5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd8ce08e_4343160d","updated":"2023-10-12 10:27:07.000000000","message":"recheck stable/yoga version green openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/fbda6da3ae2344c0861f503695a0b0cb : SUCCESS in 1h 23m 27s","commit_id":"5bab9de98b57da2fa5fd8433868017ae895a81f7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b5aed264e84df92b47f2a4ca217fbee9d4225407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e1445548_8d3ac263","updated":"2023-10-13 05:50:02.000000000","message":"recheck depends-on updated","commit_id":"3a3f6f15d12e6057cb3afd26a6bfe9574ff92927"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"025029fa0cb77d4fa63abbcaea6866356b73295a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d632d2c8_4bd0448c","updated":"2023-10-13 17:03:01.000000000","message":"latest PS works fine too","commit_id":"111951424ab84b683333233b9ab440376a1c4dbf"}],"openstack/tests/functional/dns/base.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"94ef3fa1c50b6995c58c10e6f2a618321c081736","unresolved":true,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def is_version_supported(api_version, version):"},{"line_number":15,"context_line":"    \"\"\"Check if a version is supported by the API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    :param api_version: Reference endpoint API version."}],"source_content_type":"text/x-python","patch_set":3,"id":"3b3c0602_0c79678a","line":14,"updated":"2023-10-12 07:31:01.000000000","message":"actually we have this method already: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/utils.py#L135 I suggest use this instead","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ddbcd2b189798b51c451eadcb2d1394b877161a9","unresolved":true,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def is_version_supported(api_version, version):"},{"line_number":15,"context_line":"    \"\"\"Check if a version is supported by the API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    :param api_version: Reference endpoint API version."}],"source_content_type":"text/x-python","patch_set":3,"id":"777edea6_b1b90f83","line":14,"in_reply_to":"3b3c0602_0c79678a","updated":"2023-10-12 08:05:18.000000000","message":"hmm but that looks took about microversions, will let Michael to check that","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8f586a6e305aa22ad540d1d241a737a2ca724ae8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def is_version_supported(api_version, version):"},{"line_number":15,"context_line":"    \"\"\"Check if a version is supported by the API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    :param api_version: Reference endpoint API version."}],"source_content_type":"text/x-python","patch_set":3,"id":"ef4fd4d8_beeab5b2","line":14,"in_reply_to":"777edea6_b1b90f83","updated":"2023-10-12 14:59:57.000000000","message":"Yes, I looked at that method and it is not appropriate for non-microversioned APIs.","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"2a5e2fc73984ff01f7c5dc006879a7e91230335a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def is_version_supported(api_version, version):"},{"line_number":15,"context_line":"    \"\"\"Check if a version is supported by the API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    :param api_version: Reference endpoint API version."}],"source_content_type":"text/x-python","patch_set":3,"id":"ac59aeec_5a50d972","line":14,"in_reply_to":"ef4fd4d8_beeab5b2","updated":"2023-10-12 15:03:20.000000000","message":"right, wrong pointer - `supports_version` is there as well","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"}],"openstack/tests/functional/dns/v2/test_zone.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"94ef3fa1c50b6995c58c10e6f2a618321c081736","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # Make sure the API under test has shared zones support"},{"line_number":34,"context_line":"        endpoint_data \u003d self.conn.session.get_endpoint_data(service_type\u003d\u0027dns\u0027)"},{"line_number":35,"context_line":"        if not dns_base.is_version_supported(endpoint_data.api_version, \u00272.1\u0027):"},{"line_number":36,"context_line":"            self.skipTest("},{"line_number":37,"context_line":"                \u0027Designate API version does not support shared zones.\u0027"},{"line_number":38,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"048f921b_10402f89","line":35,"updated":"2023-10-12 07:31:01.000000000","message":"but this way we are not going to run even simple zone tests (not share) on 2.0. Let\u0027s better skip only tests with shares","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ddbcd2b189798b51c451eadcb2d1394b877161a9","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # Make sure the API under test has shared zones support"},{"line_number":34,"context_line":"        endpoint_data \u003d self.conn.session.get_endpoint_data(service_type\u003d\u0027dns\u0027)"},{"line_number":35,"context_line":"        if not dns_base.is_version_supported(endpoint_data.api_version, \u00272.1\u0027):"},{"line_number":36,"context_line":"            self.skipTest("},{"line_number":37,"context_line":"                \u0027Designate API version does not support shared zones.\u0027"},{"line_number":38,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"e2acff3b_f71f2f4a","line":35,"in_reply_to":"048f921b_10402f89","updated":"2023-10-12 08:05:18.000000000","message":"yes right, my bad will push.","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a3070bf00042ca6ccf884a0ebc8f18ce689a87c6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # Make sure the API under test has shared zones support"},{"line_number":34,"context_line":"        endpoint_data \u003d self.conn.session.get_endpoint_data(service_type\u003d\u0027dns\u0027)"},{"line_number":35,"context_line":"        if not dns_base.is_version_supported(endpoint_data.api_version, \u00272.1\u0027):"},{"line_number":36,"context_line":"            self.skipTest("},{"line_number":37,"context_line":"                \u0027Designate API version does not support shared zones.\u0027"},{"line_number":38,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"035d3ca5_16c5d8d1","line":35,"in_reply_to":"066a4ce1_80964399","updated":"2023-10-13 17:03:21.000000000","message":"Done","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8f586a6e305aa22ad540d1d241a737a2ca724ae8","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # Make sure the API under test has shared zones support"},{"line_number":34,"context_line":"        endpoint_data \u003d self.conn.session.get_endpoint_data(service_type\u003d\u0027dns\u0027)"},{"line_number":35,"context_line":"        if not dns_base.is_version_supported(endpoint_data.api_version, \u00272.1\u0027):"},{"line_number":36,"context_line":"            self.skipTest("},{"line_number":37,"context_line":"                \u0027Designate API version does not support shared zones.\u0027"},{"line_number":38,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"066a4ce1_80964399","line":35,"in_reply_to":"e2acff3b_f71f2f4a","updated":"2023-10-12 14:59:57.000000000","message":"Yes, this is incorrect. It should not skip all of the zone tests.","commit_id":"4f42dcd95a9d0596d70a3530f9afa772f030413e"}]}