)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36481,"name":"Mario Minners","email":"mario@minne.rs","username":"mminners"},"change_message_id":"53a8725defce3983b9f7fc58b19bcbd02f36248e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3115a8ae_fedf95dd","updated":"2023-11-10 17:10:44.000000000","message":"Hi,\n\nSorry I had to add someone manually. The Zuul marks this patch to my turn even on succesful testing. Or did I overlook something?","commit_id":"337bc1e51faf32096e7629b7de3c60fb399e209d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94064edacc60ffbf762058fa41c7cc609ed0ac91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ae869d3_b2a52e3b","updated":"2024-04-26 11:36:35.000000000","message":"This looks pretty good but it\u0027s missing a release note (you use [`reno`](https://pypi.org/project/reno/) for that) and tests. I also have some comments around how we expose this that would be good to address.","commit_id":"337bc1e51faf32096e7629b7de3c60fb399e209d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94064edacc60ffbf762058fa41c7cc609ed0ac91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"088466ee_afa90434","in_reply_to":"3115a8ae_fedf95dd","updated":"2024-04-26 11:36:35.000000000","message":"Nope, we just missed this unfortunately 😞","commit_id":"337bc1e51faf32096e7629b7de3c60fb399e209d"}],"openstack/cloud/_compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94064edacc60ffbf762058fa41c7cc609ed0ac91","unresolved":true,"context_lines":[{"line_number":1720,"context_line":"            _qs.QuotaSet(project_id\u003dproj.id), **kwargs"},{"line_number":1721,"context_line":"        )"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"    def get_compute_quotas(self, name_or_id, usage\u003dFalse):"},{"line_number":1724,"context_line":"        \"\"\"Get quota for a project"},{"line_number":1725,"context_line":""},{"line_number":1726,"context_line":"        :param name_or_id: project name or id"}],"source_content_type":"text/x-python","patch_set":5,"id":"c1a9a35b_c004f2e2","line":1723,"updated":"2024-04-26 11:36:35.000000000","message":"I realise that you\u0027re trying to abstract the difference here and/or work with the existing parameters, but Cinder and Nova just work differently: where Cinder expects a `usage` query string parameter, Nova requires you to use a different endpoint. Passing a `usage` argument here is incorrect since that doesn\u0027t exist. We should instead pass a `details` parameter that will get passed down to the proxy API (which will in-turn set a `base_path` argument for the result `fetch` call).\n\nI would *not* add a `usage` argument here and instead pass a `details\u003dTrue` parameter to the `get_quota_set` call below.","commit_id":"337bc1e51faf32096e7629b7de3c60fb399e209d"}],"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94064edacc60ffbf762058fa41c7cc609ed0ac91","unresolved":true,"context_lines":[{"line_number":2346,"context_line":""},{"line_number":2347,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Quota sets \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2348,"context_line":""},{"line_number":2349,"context_line":"    def get_quota_set(self, project, usage\u003dFalse, **query):"},{"line_number":2350,"context_line":"        \"\"\"Show QuotaSet information for the project"},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"        :param project: ID or instance of"}],"source_content_type":"text/x-python","patch_set":5,"id":"592fda48_83f0e0c9","line":2349,"range":{"start_line":2349,"start_character":37,"end_line":2349,"end_character":48},"updated":"2024-04-26 11:36:35.000000000","message":"So `usage` doesn\u0027t actually exist. We should deprecate this and replace it with a `details` parameter instead. If that parameter is provided, we will set a new `base_path` argument like you\u0027ve done. The `usage` argument should be ignored. Alternatively we can preserve `usage` but make clear it\u0027s an alias for the new `details` parameter.","commit_id":"337bc1e51faf32096e7629b7de3c60fb399e209d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94064edacc60ffbf762058fa41c7cc609ed0ac91","unresolved":true,"context_lines":[{"line_number":2366,"context_line":"            None,"},{"line_number":2367,"context_line":"            project_id\u003dproject.id,"},{"line_number":2368,"context_line":"        )"},{"line_number":2369,"context_line":"        if usage:"},{"line_number":2370,"context_line":"            # NOTE: The API endpoint for compute quota usage differs from those for"},{"line_number":2371,"context_line":"            # network and volume services. So we should override the base_path from"},{"line_number":2372,"context_line":"            # class:QuotaSet here so that we can fill the response with usage"},{"line_number":2373,"context_line":"            # and reservation data."},{"line_number":2374,"context_line":"            base_path \u003d \u0027/os-quota-sets/%(project_id)s/detail\u0027"},{"line_number":2375,"context_line":"            return res.fetch(self, base_path\u003dbase_path, usage\u003dusage, **query)"},{"line_number":2376,"context_line":"        else:"},{"line_number":2377,"context_line":"            return res.fetch(self, usage\u003dusage, **query)"},{"line_number":2378,"context_line":""},{"line_number":2379,"context_line":"    def get_quota_set_defaults(self, project):"},{"line_number":2380,"context_line":"        \"\"\"Show QuotaSet defaults for the project"}],"source_content_type":"text/x-python","patch_set":5,"id":"75447933_c0ea6688","line":2377,"range":{"start_line":2369,"start_character":0,"end_line":2377,"end_character":56},"updated":"2024-04-26 11:36:35.000000000","message":"nit:\n\n```\nbase_path \u003d \u0027/os-quota-sets/%(project_id)s/detail\u0027 if details else None\nreturn res.fetch(self, base_path\u003dbase_path, **query)\n```","commit_id":"337bc1e51faf32096e7629b7de3c60fb399e209d"}]}