)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1da79435e49038eb204407c9966af01922c01577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b47d0920_4a261347","updated":"2023-11-07 04:11:14.000000000","message":"cinderclient equivalent:\nhttps://opendev.org/openstack/python-cinderclient/src/branch/master/cinderclient/v3/volumes_base.py#L328\n\nThe motivation for this change is ironic replacing cinderclient with openstacksdk, and the response from this request needs to be stored:\nhttps://opendev.org/openstack/ironic/src/branch/master/ironic/common/cinder.py#L321","commit_id":"40ce831671d87bf04096064acb26a36aa6015d2e"}],"openstack/block_storage/v3/_proxy.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5cf31c6e3f6c0f8b7b1b500e794f62ed7172316","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from openstack.block_storage.v3 import resource_filter as _resource_filter"},{"line_number":28,"context_line":"from openstack.block_storage.v3 import service as _service"},{"line_number":29,"context_line":"from openstack.block_storage.v3 import snapshot as _snapshot"},{"line_number":30,"context_line":"from openstack.block_storage.v3 import stats as _stats"},{"line_number":31,"context_line":"from openstack.block_storage.v3 import transfer as _transfer"},{"line_number":32,"context_line":"from openstack.block_storage.v3 import type as _type"},{"line_number":33,"context_line":"from openstack.block_storage.v3 import volume as _volume"},{"line_number":34,"context_line":"from openstack import exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa188e59_db41e026","side":"PARENT","line":31,"range":{"start_line":30,"start_character":54,"end_line":31,"end_character":60},"updated":"2023-11-07 16:37:10.000000000","message":"Removal of volume transfer support is not described in the commit message. Is it intentional ?","commit_id":"911cf7ddb196fd9d5c6d7ba1149957735ef304c0"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c8d06e996698fe8abf8e93c28385536dd5209dc8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from openstack.block_storage.v3 import resource_filter as _resource_filter"},{"line_number":28,"context_line":"from openstack.block_storage.v3 import service as _service"},{"line_number":29,"context_line":"from openstack.block_storage.v3 import snapshot as _snapshot"},{"line_number":30,"context_line":"from openstack.block_storage.v3 import stats as _stats"},{"line_number":31,"context_line":"from openstack.block_storage.v3 import transfer as _transfer"},{"line_number":32,"context_line":"from openstack.block_storage.v3 import type as _type"},{"line_number":33,"context_line":"from openstack.block_storage.v3 import volume as _volume"},{"line_number":34,"context_line":"from openstack import exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"8da5652e_ff515ce4","side":"PARENT","line":31,"range":{"start_line":30,"start_character":54,"end_line":31,"end_character":60},"in_reply_to":"4012d932_1f277c1d","updated":"2023-11-07 19:39:49.000000000","message":"Done","commit_id":"911cf7ddb196fd9d5c6d7ba1149957735ef304c0"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae01ff0caedd96125eab6e639e5dca96c8917492","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from openstack.block_storage.v3 import resource_filter as _resource_filter"},{"line_number":28,"context_line":"from openstack.block_storage.v3 import service as _service"},{"line_number":29,"context_line":"from openstack.block_storage.v3 import snapshot as _snapshot"},{"line_number":30,"context_line":"from openstack.block_storage.v3 import stats as _stats"},{"line_number":31,"context_line":"from openstack.block_storage.v3 import transfer as _transfer"},{"line_number":32,"context_line":"from openstack.block_storage.v3 import type as _type"},{"line_number":33,"context_line":"from openstack.block_storage.v3 import volume as _volume"},{"line_number":34,"context_line":"from openstack import exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"4012d932_1f277c1d","side":"PARENT","line":31,"range":{"start_line":30,"start_character":54,"end_line":31,"end_character":60},"in_reply_to":"aa188e59_db41e026","updated":"2023-11-07 19:26:25.000000000","message":"Oh this was not intentional, I must have made an error while rebasing","commit_id":"911cf7ddb196fd9d5c6d7ba1149957735ef304c0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9899049b30bb05c194d4f5d6e09d4ef6abba9b3f","unresolved":true,"context_lines":[{"line_number":948,"context_line":"            :class:`~openstack.block_storage.v3.volume.Volume` instance."},{"line_number":949,"context_line":"        :param dict connector: The connector object."},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        :returns: Dictionary containing the modified connector object\"\"\""},{"line_number":952,"context_line":"        volume \u003d self._get_resource(_volume.Volume, volume)"},{"line_number":953,"context_line":"        return volume.init_attachment(self, connector)"},{"line_number":954,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fab1dbf9_0e732b3f","line":951,"range":{"start_line":951,"start_character":18,"end_line":951,"end_character":69},"updated":"2023-11-09 02:43:08.000000000","message":"I\u0027m wondering if returning a VolumeAttachment object instead of a dict makes better sense. However I have to dig into the current sdk code to explain how to do but so someone more familir with sdk may have a better idea (about the idea as well as its implementation)","commit_id":"a03396d3479a4341d0143f3e72729a06eb45ea53"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"93d3bd1406004cd00fc245256f737d46be02ad8a","unresolved":true,"context_lines":[{"line_number":948,"context_line":"            :class:`~openstack.block_storage.v3.volume.Volume` instance."},{"line_number":949,"context_line":"        :param dict connector: The connector object."},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        :returns: Dictionary containing the modified connector object\"\"\""},{"line_number":952,"context_line":"        volume \u003d self._get_resource(_volume.Volume, volume)"},{"line_number":953,"context_line":"        return volume.init_attachment(self, connector)"},{"line_number":954,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f5e78111_6ddc786a","line":951,"range":{"start_line":951,"start_character":18,"end_line":951,"end_character":69},"in_reply_to":"baabcb33_95f89bdb","updated":"2023-11-24 08:44:10.000000000","message":"Re-reading the cinder code I noticed it returns connection info, not volume attachment so we can\u0027t use a volume attachment here.\n\nI still think we can create a generic object because cinder formats connection info using the single utility (_parse_connection_options) but I think it\u0027s ok to return a dict because the connection info object is not yet implemented.","commit_id":"a03396d3479a4341d0143f3e72729a06eb45ea53"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"39191263a0318fb55e05ebff617768d68673cae7","unresolved":true,"context_lines":[{"line_number":948,"context_line":"            :class:`~openstack.block_storage.v3.volume.Volume` instance."},{"line_number":949,"context_line":"        :param dict connector: The connector object."},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        :returns: Dictionary containing the modified connector object\"\"\""},{"line_number":952,"context_line":"        volume \u003d self._get_resource(_volume.Volume, volume)"},{"line_number":953,"context_line":"        return volume.init_attachment(self, connector)"},{"line_number":954,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baabcb33_95f89bdb","line":951,"range":{"start_line":951,"start_character":18,"end_line":951,"end_character":69},"in_reply_to":"fab1dbf9_0e732b3f","updated":"2023-11-23 21:58:11.000000000","message":"I\u0027m thinking not, because the cinder API leaves the return value of this call undefined. I believe this is because storage drivers can (and do) add arbitrary driver-specific values beyond what VolumeAttachment defines","commit_id":"a03396d3479a4341d0143f3e72729a06eb45ea53"}]}