)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc974c6a88beec652139ee9e103e8d7d50a474ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d2c9311_ad1cea80","updated":"2024-01-29 12:57:53.000000000","message":"Identical comments to https://review.opendev.org/c/openstack/openstacksdk/+/901671/","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"66ce123f7116e46c56c3d07280125ef936e35147","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8054103b_2c83693f","updated":"2023-12-05 12:55:59.000000000","message":"recheck","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"90abf8a233e74764fa960b72a344f96149d8acc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1f4365c_a13c8f7b","updated":"2023-12-07 13:43:33.000000000","message":"recheck","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"59875934e35517f0aa17ba8966a01a2aa9325cc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9952550_76c72518","updated":"2024-01-16 12:53:12.000000000","message":"recheck","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1c2b7892d0c12e7b9a02a42b161a7b6a592c1692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"944d6e25_bc872d06","updated":"2024-02-21 09:39:24.000000000","message":"looks good","commit_id":"434adf775c9c2a62876b5bd1d33b9a36164b4f17"}],"openstack/image/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc974c6a88beec652139ee9e103e8d7d50a474ff","unresolved":true,"context_lines":[{"line_number":1524,"context_line":"            **query,"},{"line_number":1525,"context_line":"        )"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"    def delete_all_metadef_properties(self, namespace):"},{"line_number":1528,"context_line":"        \"\"\"Delete all metadata definitions property inside a specific namespace."},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"        :param namespace: The value can be either the name of a metadef"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bad141d_6822c43e","line":1527,"range":{"start_line":1527,"start_character":44,"end_line":1527,"end_character":53},"updated":"2024-01-29 12:57:53.000000000","message":"This is called `metadef_namespace` in the other metadef property methods. Should we do the same here?","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"329e03b2e305c95a206de3b79db021e86fc90b61","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            **query,"},{"line_number":1525,"context_line":"        )"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"    def delete_all_metadef_properties(self, namespace):"},{"line_number":1528,"context_line":"        \"\"\"Delete all metadata definitions property inside a specific namespace."},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"        :param namespace: The value can be either the name of a metadef"}],"source_content_type":"text/x-python","patch_set":1,"id":"dda26933_b4186693","line":1527,"range":{"start_line":1527,"start_character":44,"end_line":1527,"end_character":53},"in_reply_to":"4bad141d_6822c43e","updated":"2024-02-10 18:51:05.000000000","message":"Acknowledged","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"}],"openstack/image/v2/metadef_property.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc974c6a88beec652139ee9e103e8d7d50a474ff","unresolved":true,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return None"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def delete_all(self, session, namespace_name):"},{"line_number":182,"context_line":"        \"\"\"Delete all properties in a namespace."},{"line_number":183,"context_line":"        :param session: The session to use for making this request"},{"line_number":184,"context_line":"        :param namespace_name: The name of the namespace to delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"d229924c_d34a9df0","line":181,"range":{"start_line":181,"start_character":34,"end_line":181,"end_character":48},"updated":"2024-01-29 12:57:53.000000000","message":"Can we called this `namespace` instead?","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc974c6a88beec652139ee9e103e8d7d50a474ff","unresolved":true,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return None"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def delete_all(self, session, namespace_name):"},{"line_number":182,"context_line":"        \"\"\"Delete all properties in a namespace."},{"line_number":183,"context_line":"        :param session: The session to use for making this request"},{"line_number":184,"context_line":"        :param namespace_name: The name of the namespace to delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"09b78cd9_365ef2d9","line":181,"updated":"2024-01-29 12:57:53.000000000","message":"This feels like it should be a class method? Also, it feels like something that should be a part of the `MetadefNamespace` resource rather than the `MetadefObject` resource?","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"329e03b2e305c95a206de3b79db021e86fc90b61","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return None"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def delete_all(self, session, namespace_name):"},{"line_number":182,"context_line":"        \"\"\"Delete all properties in a namespace."},{"line_number":183,"context_line":"        :param session: The session to use for making this request"},{"line_number":184,"context_line":"        :param namespace_name: The name of the namespace to delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"6dfc6afd_5a74dc61","line":181,"in_reply_to":"09b78cd9_365ef2d9","updated":"2024-02-10 18:51:05.000000000","message":"Acknowledged","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"329e03b2e305c95a206de3b79db021e86fc90b61","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return None"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def delete_all(self, session, namespace_name):"},{"line_number":182,"context_line":"        \"\"\"Delete all properties in a namespace."},{"line_number":183,"context_line":"        :param session: The session to use for making this request"},{"line_number":184,"context_line":"        :param namespace_name: The name of the namespace to delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"cff0c81e_91b96c61","line":181,"range":{"start_line":181,"start_character":34,"end_line":181,"end_character":48},"in_reply_to":"d229924c_d34a9df0","updated":"2024-02-10 18:51:05.000000000","message":"Done","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc974c6a88beec652139ee9e103e8d7d50a474ff","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        :returns: The server response"},{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        if not self.allow_delete:"},{"line_number":189,"context_line":"            raise exceptions.MethodNotSupported(self, \"delete\")"},{"line_number":190,"context_line":"        request \u003d self._prepare_request(requires_id\u003dFalse)"},{"line_number":191,"context_line":"        session \u003d self._get_session(session)"},{"line_number":192,"context_line":"        response \u003d session.delete(request.url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4dfd5cf6_2b3e459e","line":189,"updated":"2024-01-29 12:57:53.000000000","message":"This isn\u0027t necessary when you\u0027re providing a custom implementation. Obviously it\u0027s allowed 😉","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"329e03b2e305c95a206de3b79db021e86fc90b61","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        :returns: The server response"},{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        if not self.allow_delete:"},{"line_number":189,"context_line":"            raise exceptions.MethodNotSupported(self, \"delete\")"},{"line_number":190,"context_line":"        request \u003d self._prepare_request(requires_id\u003dFalse)"},{"line_number":191,"context_line":"        session \u003d self._get_session(session)"},{"line_number":192,"context_line":"        response \u003d session.delete(request.url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb9c6c2c_d624ef1c","line":189,"in_reply_to":"4dfd5cf6_2b3e459e","updated":"2024-02-10 18:51:05.000000000","message":"Done","commit_id":"aee470daa289661afcbb6611ad27d598c0490afe"}]}
