)]}'
{"id":"openstack%2Fopenstacksdk~904302","triplet_id":"openstack%2Fopenstacksdk~master~I51843a5f94ae0210ab42b0b83f869a9d18955206","project":"openstack/openstacksdk","branch":"master","topic":"changeset_815728","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-12-25 11:36:18.000000000","reason":"Reviewer/Cc was removed"},"9373":{"account":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"last_update":"2024-02-12 10:46:45.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I51843a5f94ae0210ab42b0b83f869a9d18955206","subject":"compute: Allow deleting of other users\u0027 keypairs","status":"ABANDONED","created":"2023-12-22 21:40:31.000000000","updated":"2024-02-12 10:46:45.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cc68dcb20d2ad2aa1fcc91ddc24a3018d0a6c3ff","_number":904302,"virtual_id_number":904302,"owner":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-12-25 13:36:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-22 21:40:31.000000000","updated_by":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2023-12-22 23:46:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-25 11:36:18.000000000","updated_by":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"CC"}],"messages":[{"id":"cd5ba97b22c84677211d15ff489d8a8ec6c35de8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2023-12-22 21:40:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9b4921dde8d8f2780549ca8087d8db3d8638dc1","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2023-12-22 21:41:06.000000000","message":"Topic changeset_815728 removed","accounts_in_message":[],"_revision_number":1},{"id":"e7a535194b315e5a08014c57ec948eaeb07badca","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2023-12-22 21:41:08.000000000","message":"Topic set to story/2009000","accounts_in_message":[],"_revision_number":1},{"id":"98feed738839cfd68012111162bf9c75d2012c41","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-22 23:46:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/da1ee2718f1b460399a15ae651352a65\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/228baf290db9479ea0f9642057270f23 : SUCCESS in 38m 44s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/aeac2810d93b4445bbf17467e2cbd9d6 : FAILURE in 2m 41s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9ce8ad8c68c74494a7d9a8f665b2bba4 : FAILURE in 3m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bd7a61804f074971a730b9eea1b8da26 : FAILURE in 4m 02s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/d2ff038595474f229caca674ed68d302 : FAILURE in 3m 34s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/21240ce3287043768e124585b5f1160a : FAILURE in 46m 41s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/5d21d1915c86470793081ee39217a45f : SUCCESS in 2m 56s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/b4a550b8678d412abc785282806177b1 : SUCCESS in 4m 33s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/0cb68a8a738547f193219bbc939b0271 : SUCCESS in 5m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4979bd24814a4490b0af0ca231f0e367 : SUCCESS in 9m 54s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/5c22b24d68124440aca736a22dc9e6d6 : SUCCESS in 1h 00m 50s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/26c8de86e1a34082839e9623c6539a8c : SUCCESS in 14m 32s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/2bf2085671044936a371165f7edc6496 : SUCCESS in 33m 43s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c58debab618b44d69de945d9c2326a98 : FAILURE in 55m 26s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/46ebee2e96c740ef81e9dbeecfbd7187 : FAILURE in 1h 59m 09s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/95a533488f1e4c12b499f6d52bcadabd : FAILURE in 1h 20m 38s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/5ba5b143894745aeb27fa44d80d09142 : FAILURE in 56m 51s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/61699abea05945b88f379435f94a2a6b : FAILURE in 1h 01m 03s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/34fce41a24c446b79ba6ce472da1b398 : SUCCESS in 40m 12s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/4a6235ef7d1a4cc5b95b6ec01f5ceac8 : SUCCESS in 38m 31s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/ecae4aca3b7648d0a1e58677ae3fc697 : SUCCESS in 41m 47s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/a35a5f1aa0ea4089818c77cd6dcbe1c3 : SUCCESS in 1h 10m 10s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/54c6a1eae50a47b1918558b3af740c14 : FAILURE in 46m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"166e8b2deae29b00da50be876eaa4129b234f572","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2023-12-25 11:36:18.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"1b1c5d2a4673ee60792f60bf06f8509554f9fbc4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-25 13:36:21.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/bbd441673957472296b9f168a72d7d44\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/0f07f37502304488802884832e1b2d42 : SUCCESS in 39m 18s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/52344f8c1e7248519e820696ea709fbd : FAILURE in 2m 18s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ad2b5dcc509640819fe21051f75d199b : SUCCESS in 4m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3e9b1ff573324713b67438f2cfa0aedc : FAILURE in 4m 20s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/aa07efc085d249f4b7c3fbd56a4f7f5c : FAILURE in 4m 20s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/dd6a765b53cc4c5e93cad54e936c867f : FAILURE in 1h 04m 08s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/3c77809ac0194a12b062332876848d13 : SUCCESS in 5m 50s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/de79637138bc45fab6e0a7e011e1033b : SUCCESS in 4m 23s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/c05c10c459c3463fac1b03b79b07e97f : SUCCESS in 5m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/36b9952282fd40378f589c4eb2c3a374 : SUCCESS in 8m 58s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/60b6bff08f374bbfa91d0e11c209c455 : SUCCESS in 59m 45s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/68e3caecf81f45ea9004d3851ab6eea5 : SUCCESS in 13m 40s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/baa520928fff48918c14e1df2510523c : SUCCESS in 32m 33s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/bce461a93dba4097bd32a6cc33163070 : FAILURE in 1h 09m 51s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/58d3bc80aede44c79c211da967c519f0 : FAILURE in 1h 24m 01s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/47961f8c2671473f93180c390f40e633 : FAILURE in 1h 20m 05s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/c1b91751ac83433eadd3dc1f1790d3ac : FAILURE in 37m 45s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/ef0839a24a68405b9e38c6ac5db2ed7e : FAILURE in 40m 24s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/d07369bc8ca241788f38ffb54360ae08 : SUCCESS in 25m 10s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/35e4f47e5e704a66b3fefe6b2cb24d2b : SUCCESS in 19m 03s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/5101dc05a5134190988cfaf3df83436b : SUCCESS in 26m 46s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/171bff2273c0447d9d28837786295fd8 : SUCCESS in 44m 49s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/21096e1b28404fedaad1fd800c620146 : FAILURE in 48m 46s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"cc68dcb20d2ad2aa1fcc91ddc24a3018d0a6c3ff","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2024-02-12 10:46:45.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c3aed095186488e4db55a08ec3b29bbdb752e512","revisions":{"1ac6b8efae1e0dd5a33f235d9db57d39ca120cd7":{"kind":"REWORK","_number":1,"created":"2023-12-22 21:40:31.000000000","uploader":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"ref":"refs/changes/02/904302/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/02/904302/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/1"}}},"commit":{"parents":[{"commit":"de87212558504bca0f0410546dd4a83901384a9e","subject":"Remove resource_key for dns floating IP","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/de87212558504bca0f0410546dd4a83901384a9e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-22 17:47:43.000000000","tz":60},"committer":{"name":"Vlad Gusev","email":"vlad.esten@gmail.com","date":"2023-12-22 21:40:16.000000000","tz":120},"subject":"compute: Allow deleting of other users\u0027 keypairs","message":"compute: Allow deleting of other users\u0027 keypairs\n\nAdmins are allowed to delete keypairs belonging to another user by\npassing the \u0027user_id\u0027 query string parameter, for example:\n\n  DELETE /keypairs/{keypair}?user_id\u003dfoo\n\nUnfortunately while we were passing through a \u0027user_id\u0027 argument to the\nunderlying \u0027openstack.proxy.Proxy._delete\u0027 call, this was being used to\npopulate the \u0027user_id\u0027 body parameter of the \u0027Keypair\u0027 resource as\nopposed to the query string parameter. We can\u0027t easily change this\nbecause a number of calls to this function involve nested resources, for\nexample \u0027openstack.image.v2._proxy.Proxy.remove_member\u0027, which must\nactually pass the arguments through to the \u0027Resource\u0027.\n\nResolve this by adding a \u0027param\u0027 argument to the underlying\n\u0027openstack.proxy.Proxy._delete\u0027 API, which can be used to pass through\nthe additional query string parameters to the delete call.\n\nChange-Id: I51843a5f94ae0210ab42b0b83f869a9d18955206\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nStory: 2009000\nTask: 42670\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/1ac6b8efae1e0dd5a33f235d9db57d39ca120cd7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/1ac6b8efae1e0dd5a33f235d9db57d39ca120cd7"}]},"branch":"refs/heads/master"},"c3aed095186488e4db55a08ec3b29bbdb752e512":{"kind":"REWORK","_number":2,"created":"2023-12-25 11:36:18.000000000","uploader":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"ref":"refs/changes/02/904302/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/02/904302/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/02/904302/2"}}},"commit":{"parents":[{"commit":"de87212558504bca0f0410546dd4a83901384a9e","subject":"Remove resource_key for dns floating IP","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/de87212558504bca0f0410546dd4a83901384a9e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-06-22 17:47:43.000000000","tz":60},"committer":{"name":"Vlad Gusev","email":"vlad.esten@gmail.com","date":"2023-12-25 11:35:54.000000000","tz":120},"subject":"compute: Allow deleting of other users\u0027 keypairs","message":"compute: Allow deleting of other users\u0027 keypairs\n\nAdmins are allowed to delete keypairs belonging to another user by\npassing the \u0027user_id\u0027 query string parameter, for example:\n\n  DELETE /keypairs/{keypair}?user_id\u003dfoo\n\nUnfortunately while we were passing through a \u0027user_id\u0027 argument to the\nunderlying \u0027openstack.proxy.Proxy._delete\u0027 call, this was being used to\npopulate the \u0027user_id\u0027 body parameter of the \u0027Keypair\u0027 resource as\nopposed to the query string parameter. We can\u0027t easily change this\nbecause a number of calls to this function involve nested resources, for\nexample \u0027openstack.image.v2._proxy.Proxy.remove_member\u0027, which must\nactually pass the arguments through to the \u0027Resource\u0027.\n\nResolve this by adding a \u0027param\u0027 argument to the underlying\n\u0027openstack.proxy.Proxy._delete\u0027 API, which can be used to pass through\nthe additional query string parameters to the delete call.\n\nChange-Id: I51843a5f94ae0210ab42b0b83f869a9d18955206\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nStory: 2009000\nTask: 42670\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/c3aed095186488e4db55a08ec3b29bbdb752e512"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/c3aed095186488e4db55a08ec3b29bbdb752e512"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}