)]}'
{"id":"openstack%2Fopenstacksdk~904488","triplet_id":"openstack%2Fopenstacksdk~master~Iecaf73c9fd89257e32478c622407b0a3883b9e0d","project":"openstack/openstacksdk","branch":"master","topic":"remove-keys-calls","attention_set":{},"removed_from_attention_set":{"13252":{"account":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"last_update":"2024-01-04 06:49:12.000000000","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change","reason_account":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}},"31412":{"account":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"last_update":"2024-01-03 00:51:10.000000000","reason":"\u003cGERRIT_ACCOUNT_31412\u003e replied on the change","reason_account":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"}},"35916":{"account":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"last_update":"2024-01-10 10:58:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iecaf73c9fd89257e32478c622407b0a3883b9e0d","subject":"Remove unnecessary `keys` calls","status":"MERGED","created":"2024-01-02 11:20:37.000000000","updated":"2024-01-10 11:03:33.000000000","submitted":"2024-01-10 10:58:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"904488-remove-keys-calls","meta_rev_id":"2289ef967c9e26157b37be9dbe944051ec5bba08","_number":904488,"virtual_id_number":904488,"owner":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-01-10 10:58:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"all":[{"value":2,"date":"2024-01-03 00:51:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-01-10 08:43:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-01-10 08:43:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-02 12:53:24.000000000","updated_by":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"reviewer":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"state":"REVIEWER"},{"updated":"2024-01-02 13:08:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-03 01:47:50.000000000","updated_by":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2024-01-10 08:43:41.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"833c7753a961a7a2b53bc0e645f10fccb256d8d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"date":"2024-01-02 11:20:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99229afdbff3dc717d430388f8052bfbf4396ed5","author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"date":"2024-01-02 12:53:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e8aba9ac620da6cf01baa49eed02dd353cc3f706","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-02 13:08:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7d72dbb14d0f4913acb27f6eb68101fa\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/f9e713adaf664293a813a2f345b1b78c : SUCCESS in 57m 53s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/f620fc5ca57b42e1a53fa7d66a58dfc2 : FAILURE in 2m 23s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c5bb4e818c404815b12f206e467e9cb9 : SUCCESS in 4m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/785af84b06f7440a875e7096bcaea135 : SUCCESS in 3m 45s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/243f8477a0274fb3bd27242720166d46 : SUCCESS in 3m 36s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/6b1f473ad3374d63a71846bb0a0cc64c : SUCCESS in 1h 00m 11s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/737dccf4e4d540c987d16ad4bc38dd11 : SUCCESS in 3m 35s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/c4bd0d6d922e43bebb74e7774be8922a : SUCCESS in 4m 23s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/3aaefbe63b0f4901a5453589f5f0e4c7 : SUCCESS in 4m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f154413eac2e46edb281fadeafa3f97d : SUCCESS in 9m 23s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/16ed34df500e40548fdc21ab0f53869a : SUCCESS in 1h 07m 29s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/922cdb8a3b4d43d2b2dc113892f80fb6 : SUCCESS in 15m 31s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/2ea1178b1695475398f13f4bb207652b : SUCCESS in 36m 06s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/8665fc08524e426bbf5691d31e754a90 : SUCCESS in 1h 02m 39s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/9097c2b848394a15aa86030ecfe6e2dc : SUCCESS in 1h 21m 44s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/a28c374c79ab4a27897bafbdb96aaf4f : SUCCESS in 1h 15m 26s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/7b81507ff4474ff18885e6bba62b87ca : SUCCESS in 39m 16s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/6d7df8b8c5994c42877fd3eab62501af : SUCCESS in 1h 00m 24s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/df1ba7e44b97498eb48873130041620b : SUCCESS in 37m 31s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/7c49787821fb423fa0403689b4f0932c : SUCCESS in 22m 10s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/e4395306206143339306b403415b25f5 : SUCCESS in 44m 03s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/f1561c3f47984f1fa8c1e66d130c7a69 : SUCCESS in 50m 07s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/f5466716dd0a4175a455b31ac8a5a41f : FAILURE in 50m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f58fd8127579eed550ac16d34deae7fe26c86e7c","author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"date":"2024-01-03 00:51:10.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8bf68d7e9a9cb6377c8b7cff8d70845c37ac5706","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2024-01-04 06:49:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b59a8529521f244d9503d6f6d8f833dba5e970af","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2024-01-10 08:43:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"270a0c396473a9d71578766ebd59221a61c41fd1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 08:44:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"865e35ac4e0b5f85e9a5663a2a711bd32f407344","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 10:58:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d892fa46cc1f4666aae3ef82ef510aa0\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c2d06b304ba44938ae6570e09d02816d : SUCCESS in 3m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/af3e2224634749eca98b5380775e5717 : SUCCESS in 5m 03s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/705352fbcbf8421a9c66f3034d5df2b9 : SUCCESS in 5m 33s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/2f444124788b4cabb6e85f535fcefc67 : SUCCESS in 31m 58s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/e7f59160a95a4e2396383a12eb167246 : SUCCESS in 4m 50s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/53ca68666c2d48f9965447d9980b97d4 : SUCCESS in 5m 00s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/d7659e1682ac463aa98bb705322466d3 : SUCCESS in 4m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a9ce43c719345beae1ec6b7d762b1d2 : SUCCESS in 9m 41s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/890499c858d24310a9afead4e49a0176 : SUCCESS in 1h 05m 40s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/0b437803476645e5855f6b5cbc713b84 : SUCCESS in 16m 20s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/26c03e0936944a4982f6c57a9d9260c5 : SUCCESS in 35m 07s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3f653e66e6104c1394eaee651cd09a76 : SUCCESS in 35m 21s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/c1dc0758df92481584ede10b0148afec : SUCCESS in 36m 37s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/d29336cd245e49cdaf5eeb383250ce76 : SUCCESS in 38m 58s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/4533af28406b4894be7463d6d26baf1c : SUCCESS in 38m 42s","accounts_in_message":[],"_revision_number":1},{"id":"1c071b764d6bd989b754d17c8337dc61c66c1ad8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 10:58:51.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"2289ef967c9e26157b37be9dbe944051ec5bba08","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 11:03:33.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fbbd74dd467a40ff96aeb7e9277549e9\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a04d3c96f99d49b3ac6e1d059075e893 : SUCCESS in 57s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f59019da2c7d3c55a7b08bc9201c7e5736d973b1","revisions":{"f59019da2c7d3c55a7b08bc9201c7e5736d973b1":{"kind":"REWORK","_number":1,"created":"2024-01-02 11:20:37.000000000","uploader":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"ref":"refs/changes/88/904488/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/88/904488/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/904488/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/904488/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/88/904488/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/88/904488/1"}}},"commit":{"parents":[{"commit":"de87212558504bca0f0410546dd4a83901384a9e","subject":"Remove resource_key for dns floating IP","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/de87212558504bca0f0410546dd4a83901384a9e"}]}],"author":{"name":"Pham Le Gia Dai","email":"daiplg@fpt.com","date":"2024-01-02 11:19:48.000000000","tz":420},"committer":{"name":"Pham Le Gia Dai","email":"daiplg@fpt.com","date":"2024-01-02 11:19:48.000000000","tz":420},"subject":"Remove unnecessary `keys` calls","message":"Remove unnecessary `keys` calls\n\nPython \u003e\u003d 3.5 alternative: unpack into a list literal\nUnpacking with * works with any object that is iterable and, since dictionaries return their keys when iterated through, you can easily create a list by using it within a list literal.\n\nAdding .keys() i.e [*newdict.keys()] might help in making your intent a bit more explicit though it will cost you a function look-up and invocation. (which, in all honesty, isn\u0027t something you should really be worried about).\n Refer [PEP 448](https://peps.python.org/pep-0448/)\n\nChange-Id: Iecaf73c9fd89257e32478c622407b0a3883b9e0d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f59019da2c7d3c55a7b08bc9201c7e5736d973b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f59019da2c7d3c55a7b08bc9201c7e5736d973b1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}