)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bab40e608231187671fabc2103bcb397980e8cf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24a7e6c2_ee052dcc","updated":"2024-01-02 13:49:31.000000000","message":"This is dependent on a new feature in Nova, presumably? You\u0027re going to need to stick a \u0027Depends-on\u0027 here so that this doesn\u0027t merge before the feature is merged into Nova. You\u0027re also going to need to bump \u0027min_microversion\u0027 so that SDK will attempt to use the correct API version for the field.","commit_id":"ef0658c75f4210284c49e302c02ce27311ff0790"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"25073fa7de11a35d66e6d3c2cb7b97ad595b6b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc7811bc_676ee09f","in_reply_to":"24a7e6c2_ee052dcc","updated":"2024-01-10 13:05:50.000000000","message":"Done.","commit_id":"ef0658c75f4210284c49e302c02ce27311ff0790"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a078524bcea53dcc127c930fe8cc8b37f2b53a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bae8b9b1_8dbd0f7c","updated":"2024-02-23 11:46:18.000000000","message":"the nova patch has not merged yet but assuming it does i think this is ok.\nso as long as dmitry is happy with it form an sdk point of view i think this is ok form a nova point of view hence +2.\n\ni have commented inline with a little more detail but i dont think that need to be added to the code comment so this looks ok as is.","commit_id":"06ef1fa4bd530fc6563c80f5a90c658d16eeffee"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1cf13d2ced2c68b9939b7f3014c664615eea09fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"413bf8f6_edba6063","in_reply_to":"bae8b9b1_8dbd0f7c","updated":"2024-02-27 13:58:52.000000000","message":"Thanks!","commit_id":"06ef1fa4bd530fc6563c80f5a90c658d16eeffee"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ea53b9e377f9fe1f3c9decf781c6c9d1a918297d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf9b0669_962011ed","updated":"2024-03-04 15:59:57.000000000","message":"I think it\u0027s valid","commit_id":"4f46ab3f8bf200b227065ea80f34fb2736e3ba18"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"65dc58e5bbcd1aa8143a58cfaeafa53de97f13eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19b7f88b_69046a3a","updated":"2024-03-07 14:02:26.000000000","message":"Oooops, sorry.","commit_id":"4f46ab3f8bf200b227065ea80f34fb2736e3ba18"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"66b2f5b992673368b4a3365812bf9f881f4711bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"88f0a2fd_45f415a4","updated":"2024-03-07 13:43:16.000000000","message":"no merging yet, we are in code freeze","commit_id":"4f46ab3f8bf200b227065ea80f34fb2736e3ba18"}],"openstack/compute/v2/server.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dffda239a20ccff7171d3109587301178b44fd15","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    )"},{"line_number":117,"context_line":"    #: The name of the availability zone this server is a part of."},{"line_number":118,"context_line":"    availability_zone \u003d resource.Body(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":119,"context_line":"    requested_availability_zone \u003d resource.Body(\u0027requested_availability_zone\u0027)"},{"line_number":120,"context_line":"    #: Enables fine grained control of the block device mapping for an"},{"line_number":121,"context_line":"    #: instance. This is typically used for booting servers from volumes."},{"line_number":122,"context_line":"    block_device_mapping \u003d resource.Body(\u0027block_device_mapping_v2\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f98371b_72fb6cd2","line":119,"updated":"2024-01-10 08:43:17.000000000","message":"Please keep the items sorted and add an explanatory comment","commit_id":"c469bffefa0703af5eb09dac3d36b3dd92109c34"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"25073fa7de11a35d66e6d3c2cb7b97ad595b6b69","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    )"},{"line_number":117,"context_line":"    #: The name of the availability zone this server is a part of."},{"line_number":118,"context_line":"    availability_zone \u003d resource.Body(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":119,"context_line":"    requested_availability_zone \u003d resource.Body(\u0027requested_availability_zone\u0027)"},{"line_number":120,"context_line":"    #: Enables fine grained control of the block device mapping for an"},{"line_number":121,"context_line":"    #: instance. This is typically used for booting servers from volumes."},{"line_number":122,"context_line":"    block_device_mapping \u003d resource.Body(\u0027block_device_mapping_v2\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"462b9c7f_f220684c","line":119,"in_reply_to":"9f98371b_72fb6cd2","updated":"2024-01-10 13:05:50.000000000","message":"Done","commit_id":"c469bffefa0703af5eb09dac3d36b3dd92109c34"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"393a402f4935c6e71db30f22287312b5b051b54f","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        **tag.TagMixin._tag_query_parameters,"},{"line_number":93,"context_line":"    )"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    _max_microversion \u003d \u00272.91\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    #: A list of dictionaries holding links relevant to this server."},{"line_number":98,"context_line":"    links \u003d resource.Body(\u0027links\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e277f141_d6bcabfe","line":95,"updated":"2024-02-23 12:09:33.000000000","message":"Sorry, missed that it\u0027s a new feature. I suspect you want to bump this to 2.96, otherwise the new field will never be returned. Please do check what happened between 2.91 and 2.96.","commit_id":"06ef1fa4bd530fc6563c80f5a90c658d16eeffee"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1cf13d2ced2c68b9939b7f3014c664615eea09fd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        **tag.TagMixin._tag_query_parameters,"},{"line_number":93,"context_line":"    )"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    _max_microversion \u003d \u00272.91\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    #: A list of dictionaries holding links relevant to this server."},{"line_number":98,"context_line":"    links \u003d resource.Body(\u0027links\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2e32580c_c120657c","line":95,"in_reply_to":"e277f141_d6bcabfe","updated":"2024-02-27 13:58:52.000000000","message":"Done","commit_id":"06ef1fa4bd530fc6563c80f5a90c658d16eeffee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a078524bcea53dcc127c930fe8cc8b37f2b53a31","unresolved":true,"context_lines":[{"line_number":195,"context_line":"    networks \u003d resource.Body(\u0027networks\u0027)"},{"line_number":196,"context_line":"    #: The availability zone requested during server creation OR pinned"},{"line_number":197,"context_line":"    #: availability zone, which is configured using default_schedule_zone"},{"line_number":198,"context_line":"    #: config option."},{"line_number":199,"context_line":"    pinned_availability_zone \u003d resource.Body(\u0027pinned_availability_zone\u0027)"},{"line_number":200,"context_line":"    #: The power state of this server."},{"line_number":201,"context_line":"    power_state \u003d resource.Body(\u0027OS-EXT-STS:power_state\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d4368b5b_9c6d8e6e","line":198,"updated":"2024-02-23 11:46:18.000000000","message":"this is fine. for those with more knowladge of nova internals another way to say it is this is the AZ specifed in the Request Spec stored in the api db and is therefore the AZ that is used by the schduler when selecting hosts.\n\nthis is typically either specified by the user in the server create request or set via a config option (default_schedule_zone) or set for bfv guest when cross_az_attach\u003dfalse.\n\nthis is diffenet to  availability_zone \u003d resource.Body(\u0027OS-EXT-AZ:availability_zone\u0027)\n\nthe instance availability_zone will always be set but the pinned_availability_zone can be empty as by default isntance are allwoed to move between AZs when cold/live migrated.\n\nso exposeing both allows a user or admin to tell at a glance if the instance is in AZ x becaue it was requested or becuase the host thtat the schduler selected happend to be in az X.\n\nthis is useful for admin when doing maintance to know  if its safe to move the instance or not and to what hosts.","commit_id":"06ef1fa4bd530fc6563c80f5a90c658d16eeffee"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1cf13d2ced2c68b9939b7f3014c664615eea09fd","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    networks \u003d resource.Body(\u0027networks\u0027)"},{"line_number":196,"context_line":"    #: The availability zone requested during server creation OR pinned"},{"line_number":197,"context_line":"    #: availability zone, which is configured using default_schedule_zone"},{"line_number":198,"context_line":"    #: config option."},{"line_number":199,"context_line":"    pinned_availability_zone \u003d resource.Body(\u0027pinned_availability_zone\u0027)"},{"line_number":200,"context_line":"    #: The power state of this server."},{"line_number":201,"context_line":"    power_state \u003d resource.Body(\u0027OS-EXT-STS:power_state\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"327b229c_37f940ef","line":198,"in_reply_to":"d4368b5b_9c6d8e6e","updated":"2024-02-27 13:58:52.000000000","message":"Acknowledged","commit_id":"06ef1fa4bd530fc6563c80f5a90c658d16eeffee"}]}