)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"9cf97442ddfd7e386422641f5bdea9c6f3da37cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d300c006_becdb5a9","updated":"2024-07-09 14:54:42.000000000","message":"nit inline, otherwise looks good to me!","commit_id":"6be33251de108c650178425c60299a3a0ba4bcaa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"73512ca6faa0f0fda242c8f9fa3c69b5f3c219ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78ee0615_d39943ac","updated":"2024-12-19 16:29:17.000000000","message":"A couple issues with the patch, otherwise looks good!","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b2ced4942ae225c55120dd56d2f2fb26c9b86a3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7d209dc5_7be71531","updated":"2025-07-29 15:25:27.000000000","message":"@akekane@redhat.com The comments will be addressed in the next patchset","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"c4cf998247efb43c64db66b03f4721101e90c00d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0e3bbf05_cc23173c","updated":"2025-02-20 05:27:06.000000000","message":"recheck","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"edbc03dc02bd66ca9ee57bb03a6b7e2304f09249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6e83173f_21062b73","updated":"2025-07-31 17:18:13.000000000","message":"There\u0027s things I\u0027d do differently, but this has been here so long that I think we should just get it in and fix issues later.","commit_id":"b2ada579cecf45e04d19a3de60b073ac09c51fc5"}],"openstack/image/v2/_proxy.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d46804c0105b2b0a4c76e7952af94f132357b418","unresolved":true,"context_lines":[{"line_number":357,"context_line":"                remote_image_id\u003dremote_image_id,"},{"line_number":358,"context_line":"                remote_service_interface\u003dremote_service_interface,"},{"line_number":359,"context_line":"                stores\u003dstores,"},{"line_number":360,"context_line":"                all_stores\u003dall_stores,"},{"line_number":361,"context_line":"                all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":362,"context_line":"                **image_kwargs,"},{"line_number":363,"context_line":"            )"},{"line_number":364,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"664623cd_c9c2d5be","line":361,"range":{"start_line":360,"start_character":16,"end_line":361,"end_character":64},"updated":"2024-03-04 07:01:27.000000000","message":"I think this should be fixed in different patch.","commit_id":"8601f5605abd9cb1f0e14b5873d35a50bcb543a5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15b718783090f03c43a04da1f41c5ab653814cbc","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                remote_image_id\u003dremote_image_id,"},{"line_number":358,"context_line":"                remote_service_interface\u003dremote_service_interface,"},{"line_number":359,"context_line":"                stores\u003dstores,"},{"line_number":360,"context_line":"                all_stores\u003dall_stores,"},{"line_number":361,"context_line":"                all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":362,"context_line":"                **image_kwargs,"},{"line_number":363,"context_line":"            )"},{"line_number":364,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"045978ef_0692c23b","line":361,"range":{"start_line":360,"start_character":16,"end_line":361,"end_character":64},"in_reply_to":"052d566c_96ff6d2e","updated":"2024-08-09 10:04:23.000000000","message":"This was done in I4d2c81d19d295aae8a77007a1c7de7083d061f24","commit_id":"8601f5605abd9cb1f0e14b5873d35a50bcb543a5"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d82cd48d069c797bda6d38ed1c8406817f8c1d62","unresolved":true,"context_lines":[{"line_number":357,"context_line":"                remote_image_id\u003dremote_image_id,"},{"line_number":358,"context_line":"                remote_service_interface\u003dremote_service_interface,"},{"line_number":359,"context_line":"                stores\u003dstores,"},{"line_number":360,"context_line":"                all_stores\u003dall_stores,"},{"line_number":361,"context_line":"                all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":362,"context_line":"                **image_kwargs,"},{"line_number":363,"context_line":"            )"},{"line_number":364,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"052d566c_96ff6d2e","line":361,"range":{"start_line":360,"start_character":16,"end_line":361,"end_character":64},"in_reply_to":"664623cd_c9c2d5be","updated":"2024-03-07 08:11:54.000000000","message":"in a different patch?","commit_id":"8601f5605abd9cb1f0e14b5873d35a50bcb543a5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d46804c0105b2b0a4c76e7952af94f132357b418","unresolved":true,"context_lines":[{"line_number":701,"context_line":"                response \u003d image.upload(self)"},{"line_number":702,"context_line":"                exceptions.raise_from_response(response)"},{"line_number":703,"context_line":"            if use_import:"},{"line_number":704,"context_line":"                if import_method \u003d\u003d \u0027glance-direct\u0027:"},{"line_number":705,"context_line":"                    image.stage(self)"},{"line_number":706,"context_line":"                    self.import_image("},{"line_number":707,"context_line":"                        image, stores\u003dstores, all_stores\u003dall_stores"},{"line_number":708,"context_line":"                    )"},{"line_number":709,"context_line":"                if import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":710,"context_line":"                    self.import_image("},{"line_number":711,"context_line":"                        image,"},{"line_number":712,"context_line":"                        method\u003dimport_method,"},{"line_number":713,"context_line":"                        uri\u003duri,"},{"line_number":714,"context_line":"                        stores\u003dstores,"},{"line_number":715,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":716,"context_line":"                    )"},{"line_number":717,"context_line":"                if import_method \u003d\u003d \u0027glance-download\u0027:"},{"line_number":718,"context_line":"                    self.import_image("},{"line_number":719,"context_line":"                        image,"},{"line_number":720,"context_line":"                        method\u003dimport_method,"},{"line_number":721,"context_line":"                        remote_region\u003dremote_region,"},{"line_number":722,"context_line":"                        remote_image_id\u003dremote_image_id,"},{"line_number":723,"context_line":"                        remote_service_interface\u003dremote_service_interface,"},{"line_number":724,"context_line":"                        stores\u003dstores,"},{"line_number":725,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":726,"context_line":"                    )"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"            # image_kwargs are flat here"},{"line_number":729,"context_line":"            md5 \u003d image_kwargs.get(self._IMAGE_MD5_KEY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5210b6ef_c4899de1","line":726,"range":{"start_line":704,"start_character":16,"end_line":726,"end_character":21},"updated":"2024-03-04 07:01:27.000000000","message":"why are we not passing all_stores_must_succeed param here?","commit_id":"8601f5605abd9cb1f0e14b5873d35a50bcb543a5"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d82cd48d069c797bda6d38ed1c8406817f8c1d62","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                response \u003d image.upload(self)"},{"line_number":702,"context_line":"                exceptions.raise_from_response(response)"},{"line_number":703,"context_line":"            if use_import:"},{"line_number":704,"context_line":"                if import_method \u003d\u003d \u0027glance-direct\u0027:"},{"line_number":705,"context_line":"                    image.stage(self)"},{"line_number":706,"context_line":"                    self.import_image("},{"line_number":707,"context_line":"                        image, stores\u003dstores, all_stores\u003dall_stores"},{"line_number":708,"context_line":"                    )"},{"line_number":709,"context_line":"                if import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":710,"context_line":"                    self.import_image("},{"line_number":711,"context_line":"                        image,"},{"line_number":712,"context_line":"                        method\u003dimport_method,"},{"line_number":713,"context_line":"                        uri\u003duri,"},{"line_number":714,"context_line":"                        stores\u003dstores,"},{"line_number":715,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":716,"context_line":"                    )"},{"line_number":717,"context_line":"                if import_method \u003d\u003d \u0027glance-download\u0027:"},{"line_number":718,"context_line":"                    self.import_image("},{"line_number":719,"context_line":"                        image,"},{"line_number":720,"context_line":"                        method\u003dimport_method,"},{"line_number":721,"context_line":"                        remote_region\u003dremote_region,"},{"line_number":722,"context_line":"                        remote_image_id\u003dremote_image_id,"},{"line_number":723,"context_line":"                        remote_service_interface\u003dremote_service_interface,"},{"line_number":724,"context_line":"                        stores\u003dstores,"},{"line_number":725,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":726,"context_line":"                    )"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"            # image_kwargs are flat here"},{"line_number":729,"context_line":"            md5 \u003d image_kwargs.get(self._IMAGE_MD5_KEY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e89178a0_6fcaf48a","line":726,"range":{"start_line":704,"start_character":16,"end_line":726,"end_character":21},"in_reply_to":"5210b6ef_c4899de1","updated":"2024-03-07 08:11:54.000000000","message":"Done","commit_id":"8601f5605abd9cb1f0e14b5873d35a50bcb543a5"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"9cf97442ddfd7e386422641f5bdea9c6f3da37cd","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        :param import_method: Method to use for importing the image. Not all"},{"line_number":207,"context_line":"            deployments support all methods. One of: ``glance-direct``"},{"line_number":208,"context_line":"            (default), ``web-download``, ``glance-download``, or"},{"line_number":209,"context_line":"            ``copy-image``. Use of ``glance-direct`` requires the image be"},{"line_number":210,"context_line":"            first staged."},{"line_number":211,"context_line":"        :param uri: Required only if using the ``web-download`` import method."},{"line_number":212,"context_line":"            This url is where the data is made available to the Image"}],"source_content_type":"text/x-python","patch_set":2,"id":"cbe89808_8a556609","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":27},"updated":"2024-07-09 14:54:42.000000000","message":"nit: copy-image? not allowed while creating image, right?","commit_id":"6be33251de108c650178425c60299a3a0ba4bcaa"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"136bafc5f84097e5a50601b87d0560d525e09743","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        :param import_method: Method to use for importing the image. Not all"},{"line_number":207,"context_line":"            deployments support all methods. One of: ``glance-direct``"},{"line_number":208,"context_line":"            (default), ``web-download``, ``glance-download``, or"},{"line_number":209,"context_line":"            ``copy-image``. Use of ``glance-direct`` requires the image be"},{"line_number":210,"context_line":"            first staged."},{"line_number":211,"context_line":"        :param uri: Required only if using the ``web-download`` import method."},{"line_number":212,"context_line":"            This url is where the data is made available to the Image"}],"source_content_type":"text/x-python","patch_set":2,"id":"d30fa519_609dff37","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":27},"in_reply_to":"cbe89808_8a556609","updated":"2024-08-09 07:23:07.000000000","message":"Yes, it\u0027s not used while creating image","commit_id":"6be33251de108c650178425c60299a3a0ba4bcaa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b2ced4942ae225c55120dd56d2f2fb26c9b86a3d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        :param import_method: Method to use for importing the image. Not all"},{"line_number":207,"context_line":"            deployments support all methods. One of: ``glance-direct``"},{"line_number":208,"context_line":"            (default), ``web-download``, ``glance-download``, or"},{"line_number":209,"context_line":"            ``copy-image``. Use of ``glance-direct`` requires the image be"},{"line_number":210,"context_line":"            first staged."},{"line_number":211,"context_line":"        :param uri: Required only if using the ``web-download`` import method."},{"line_number":212,"context_line":"            This url is where the data is made available to the Image"}],"source_content_type":"text/x-python","patch_set":2,"id":"7764ce58_a2f63de4","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":27},"in_reply_to":"d30fa519_609dff37","updated":"2025-07-29 15:25:27.000000000","message":"Done","commit_id":"6be33251de108c650178425c60299a3a0ba4bcaa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"73512ca6faa0f0fda242c8f9fa3c69b5f3c219ae","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        timeout\u003d3600,"},{"line_number":132,"context_line":"        validate_checksum\u003dFalse,"},{"line_number":133,"context_line":"        use_import\u003dFalse,"},{"line_number":134,"context_line":"        import_method\u003dNone,"},{"line_number":135,"context_line":"        uri\u003dNone,"},{"line_number":136,"context_line":"        remote_region\u003dNone,"},{"line_number":137,"context_line":"        remote_image_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fe0888f2_7679e2d0","line":134,"range":{"start_line":134,"start_character":26,"end_line":134,"end_character":27},"updated":"2024-12-19 16:29:17.000000000","message":"I think currently, python-openstackcli is calling this without passing \"import_method\", is this breaking it?","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b2ced4942ae225c55120dd56d2f2fb26c9b86a3d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        timeout\u003d3600,"},{"line_number":132,"context_line":"        validate_checksum\u003dFalse,"},{"line_number":133,"context_line":"        use_import\u003dFalse,"},{"line_number":134,"context_line":"        import_method\u003dNone,"},{"line_number":135,"context_line":"        uri\u003dNone,"},{"line_number":136,"context_line":"        remote_region\u003dNone,"},{"line_number":137,"context_line":"        remote_image_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fdf59845_62b7b41a","line":134,"range":{"start_line":134,"start_character":26,"end_line":134,"end_character":27},"in_reply_to":"f5f29ff4_7b49d307","updated":"2025-07-29 15:25:27.000000000","message":"Acknowledged","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"a25cf5f1b3aee6d4d755733a7000fce6c600b394","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        timeout\u003d3600,"},{"line_number":132,"context_line":"        validate_checksum\u003dFalse,"},{"line_number":133,"context_line":"        use_import\u003dFalse,"},{"line_number":134,"context_line":"        import_method\u003dNone,"},{"line_number":135,"context_line":"        uri\u003dNone,"},{"line_number":136,"context_line":"        remote_region\u003dNone,"},{"line_number":137,"context_line":"        remote_image_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5f29ff4_7b49d307","line":134,"range":{"start_line":134,"start_character":26,"end_line":134,"end_character":27},"in_reply_to":"fe0888f2_7679e2d0","updated":"2025-01-20 09:58:09.000000000","message":"No, the current functionality will remain as it is.\nThe new functionality will be used when we set use_import\u003dTrue.","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"73512ca6faa0f0fda242c8f9fa3c69b5f3c219ae","unresolved":true,"context_lines":[{"line_number":707,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":708,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":709,"context_line":"                    )"},{"line_number":710,"context_line":"                if import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":711,"context_line":"                    self.import_image("},{"line_number":712,"context_line":"                        image,"},{"line_number":713,"context_line":"                        method\u003dimport_method,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3d60dbdc_236ebfe5","line":710,"range":{"start_line":710,"start_character":19,"end_line":710,"end_character":32},"updated":"2024-12-19 16:29:17.000000000","message":"I think you should use \"elif\" here.","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"a25cf5f1b3aee6d4d755733a7000fce6c600b394","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":708,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":709,"context_line":"                    )"},{"line_number":710,"context_line":"                if import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":711,"context_line":"                    self.import_image("},{"line_number":712,"context_line":"                        image,"},{"line_number":713,"context_line":"                        method\u003dimport_method,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ca13b290_ffd670d3","line":710,"range":{"start_line":710,"start_character":19,"end_line":710,"end_character":32},"in_reply_to":"3d60dbdc_236ebfe5","updated":"2025-01-20 09:58:09.000000000","message":"Acknowledged","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"73512ca6faa0f0fda242c8f9fa3c69b5f3c219ae","unresolved":true,"context_lines":[{"line_number":716,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":717,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":718,"context_line":"                    )"},{"line_number":719,"context_line":"                if import_method \u003d\u003d \u0027glance-download\u0027:"},{"line_number":720,"context_line":"                    self.import_image("},{"line_number":721,"context_line":"                        image,"},{"line_number":722,"context_line":"                        method\u003dimport_method,"}],"source_content_type":"text/x-python","patch_set":5,"id":"721f8850_0a6e1a4c","line":719,"range":{"start_line":719,"start_character":19,"end_line":719,"end_character":32},"updated":"2024-12-19 16:29:17.000000000","message":"Ditto","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"a25cf5f1b3aee6d4d755733a7000fce6c600b394","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":717,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":718,"context_line":"                    )"},{"line_number":719,"context_line":"                if import_method \u003d\u003d \u0027glance-download\u0027:"},{"line_number":720,"context_line":"                    self.import_image("},{"line_number":721,"context_line":"                        image,"},{"line_number":722,"context_line":"                        method\u003dimport_method,"}],"source_content_type":"text/x-python","patch_set":5,"id":"95404cd7_1103ad15","line":719,"range":{"start_line":719,"start_character":19,"end_line":719,"end_character":32},"in_reply_to":"721f8850_0a6e1a4c","updated":"2025-01-20 09:58:09.000000000","message":"Acknowledged","commit_id":"1680979795f37df6fe8b2fdd1efe49b459025c4d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a0b3aa7f35ad2789f9527581178bc457ec299944","unresolved":true,"context_lines":[{"line_number":703,"context_line":"                    image.stage(self)"},{"line_number":704,"context_line":"                    self.import_image("},{"line_number":705,"context_line":"                        image,"},{"line_number":706,"context_line":"                        stores\u003dstores,"},{"line_number":707,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":708,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":709,"context_line":"                    )"},{"line_number":710,"context_line":"                elif import_method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f73c119_f11a68e6","line":707,"range":{"start_line":706,"start_character":24,"end_line":707,"end_character":46},"updated":"2025-03-06 14:11:28.000000000","message":"I think if stores are set then we should not pass all_stores","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"a2356385b9b2c49f45402d45ee48370c1b635fc0","unresolved":true,"context_lines":[{"line_number":703,"context_line":"                    image.stage(self)"},{"line_number":704,"context_line":"                    self.import_image("},{"line_number":705,"context_line":"                        image,"},{"line_number":706,"context_line":"                        stores\u003dstores,"},{"line_number":707,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":708,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":709,"context_line":"                    )"},{"line_number":710,"context_line":"                elif import_method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3647d683_3dc5a5af","line":707,"range":{"start_line":706,"start_character":24,"end_line":707,"end_character":46},"in_reply_to":"1f73c119_f11a68e6","updated":"2025-03-19 07:35:20.000000000","message":"If we only use stores and what if the user wants the image to be in all stores wouldn\u0027t it be better to simply pass this parameter as True instead of passing all stores list/names.\nBy default we have set all_stores as none","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"56a16fb925281075dc8dce4b6392fe11f4fe3837","unresolved":true,"context_lines":[{"line_number":703,"context_line":"                    image.stage(self)"},{"line_number":704,"context_line":"                    self.import_image("},{"line_number":705,"context_line":"                        image,"},{"line_number":706,"context_line":"                        stores\u003dstores,"},{"line_number":707,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":708,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":709,"context_line":"                    )"},{"line_number":710,"context_line":"                elif import_method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"41e6b95c_3d58ad35","line":707,"range":{"start_line":706,"start_character":24,"end_line":707,"end_character":46},"in_reply_to":"3647d683_3dc5a5af","updated":"2025-03-19 08:27:19.000000000","message":"Here you need to check if stores is None then  pass all_stores and if not the pass stores and not all_stores","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b2ced4942ae225c55120dd56d2f2fb26c9b86a3d","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                    image.stage(self)"},{"line_number":704,"context_line":"                    self.import_image("},{"line_number":705,"context_line":"                        image,"},{"line_number":706,"context_line":"                        stores\u003dstores,"},{"line_number":707,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":708,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":709,"context_line":"                    )"},{"line_number":710,"context_line":"                elif import_method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d5e0f33_6f1da332","line":707,"range":{"start_line":706,"start_character":24,"end_line":707,"end_character":46},"in_reply_to":"41e6b95c_3d58ad35","updated":"2025-07-29 15:25:27.000000000","message":"Done","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a0b3aa7f35ad2789f9527581178bc457ec299944","unresolved":true,"context_lines":[{"line_number":713,"context_line":"                        method\u003dimport_method,"},{"line_number":714,"context_line":"                        uri\u003duri,"},{"line_number":715,"context_line":"                        stores\u003dstores,"},{"line_number":716,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":717,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":718,"context_line":"                    )"},{"line_number":719,"context_line":"                elif import_method \u003d\u003d \u0027glance-download\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"4fcfb197_a2cb4e14","line":716,"range":{"start_line":716,"start_character":24,"end_line":716,"end_character":46},"updated":"2025-03-06 14:11:28.000000000","message":"ditto","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b2ced4942ae225c55120dd56d2f2fb26c9b86a3d","unresolved":false,"context_lines":[{"line_number":713,"context_line":"                        method\u003dimport_method,"},{"line_number":714,"context_line":"                        uri\u003duri,"},{"line_number":715,"context_line":"                        stores\u003dstores,"},{"line_number":716,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":717,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":718,"context_line":"                    )"},{"line_number":719,"context_line":"                elif import_method \u003d\u003d \u0027glance-download\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"f941b6af_a3811aca","line":716,"range":{"start_line":716,"start_character":24,"end_line":716,"end_character":46},"in_reply_to":"4fcfb197_a2cb4e14","updated":"2025-07-29 15:25:27.000000000","message":"Done","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a0b3aa7f35ad2789f9527581178bc457ec299944","unresolved":true,"context_lines":[{"line_number":724,"context_line":"                        remote_image_id\u003dremote_image_id,"},{"line_number":725,"context_line":"                        remote_service_interface\u003dremote_service_interface,"},{"line_number":726,"context_line":"                        stores\u003dstores,"},{"line_number":727,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":728,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":729,"context_line":"                    )"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e27e220c_b5d768b9","line":727,"range":{"start_line":727,"start_character":24,"end_line":727,"end_character":46},"updated":"2025-03-06 14:11:28.000000000","message":"ditto","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b2ced4942ae225c55120dd56d2f2fb26c9b86a3d","unresolved":false,"context_lines":[{"line_number":724,"context_line":"                        remote_image_id\u003dremote_image_id,"},{"line_number":725,"context_line":"                        remote_service_interface\u003dremote_service_interface,"},{"line_number":726,"context_line":"                        stores\u003dstores,"},{"line_number":727,"context_line":"                        all_stores\u003dall_stores,"},{"line_number":728,"context_line":"                        all_stores_must_succeed\u003dall_stores_must_succeed,"},{"line_number":729,"context_line":"                    )"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb8773e_5aac30d4","line":727,"range":{"start_line":727,"start_character":24,"end_line":727,"end_character":46},"in_reply_to":"e27e220c_b5d768b9","updated":"2025-07-29 15:25:27.000000000","message":"Done","commit_id":"535a81445be6f8132da9067f7d1eb4355987f68c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"edbc03dc02bd66ca9ee57bb03a6b7e2304f09249","unresolved":true,"context_lines":[{"line_number":595,"context_line":"        try:"},{"line_number":596,"context_line":"            # This makes me want to die inside"},{"line_number":597,"context_line":"            if self._connection.image_api_use_tasks:"},{"line_number":598,"context_line":"                if use_import:"},{"line_number":599,"context_line":"                    raise exceptions.SDKException("},{"line_number":600,"context_line":"                        \"The Glance Task API and Import API are mutually \""},{"line_number":601,"context_line":"                        \"exclusive. Either disable image_api_use_tasks in \""}],"source_content_type":"text/x-python","patch_set":7,"id":"daab66d9_fcfb58f8","line":598,"updated":"2025-07-31 17:18:13.000000000","message":"You should probably check for the value of the new parameters here, since they all apply exclusively to the import API?","commit_id":"b2ada579cecf45e04d19a3de60b073ac09c51fc5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"edbc03dc02bd66ca9ee57bb03a6b7e2304f09249","unresolved":true,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def _upload_image_put("},{"line_number":653,"context_line":"        self,"},{"line_number":654,"context_line":"        name,"},{"line_number":655,"context_line":"        filename,"},{"line_number":656,"context_line":"        data,"},{"line_number":657,"context_line":"        meta,"}],"source_content_type":"text/x-python","patch_set":7,"id":"0b5e11c6_91fa94ca","line":654,"updated":"2025-07-31 17:18:13.000000000","message":"nit: unrelated but\n\n```suggestion\n        name,\n        *,\n```","commit_id":"b2ada579cecf45e04d19a3de60b073ac09c51fc5"}]}