)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"45d9039aed1fd380b0f7649e3a4010d54c46838c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"777d69e3_64783770","updated":"2024-02-26 16:55:59.000000000","message":"Could you please add a release note? :)","commit_id":"e176910171e97d1c91b6049eb8c5ac6ff372174a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ca4e6505d2dbf0b6e3fb6865db950c881dfb450c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"435682d9_f8f12cae","updated":"2024-03-25 14:30:57.000000000","message":"Looking good, Manuel! thank you for your work on this change.\nHave some minor comments inline, but would like to ask you something else:\nCould you please write some functional tests? :)","commit_id":"fa2054f32ba9bea8263ba55eb04a183c3b9fe7df"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"237035369aee386d3f6346769c5a2532b60a60fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f70521cc_b85830a6","updated":"2024-04-22 16:37:56.000000000","message":"Very soft -1. This is pretty much there but we should revert the changes to quotas to avoid unnecessary side-effects from the test suite.","commit_id":"e15ef088dee34081b7fa230c19145972ded61384"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3efc2ac997913e45ed13bb2684579db6000cac5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1198a669_b3fe74f8","updated":"2024-04-23 12:54:04.000000000","message":"LGTM, thank you for working on this change, Manuel!","commit_id":"f73335df5a112604ddcdda0ad34d25d3392240d3"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ca4e6505d2dbf0b6e3fb6865db950c881dfb450c","unresolved":true,"context_lines":[{"line_number":1205,"context_line":"        \"\"\"Get quota class set."},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"        :param quota_class_name: The name of the quota class"},{"line_number":1208,"context_line":"        :returns: A :class:`~openstack.shared_file_system.v2.quota_class_set.QuotaClassSet`"},{"line_number":1209,"context_line":"        \"\"\""},{"line_number":1210,"context_line":"        return self._get(_quota_class_set.QuotaClassSet, quota_class_name)"},{"line_number":1211,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"201d60ea_514350f1","line":1208,"range":{"start_line":1208,"start_character":76,"end_line":1208,"end_character":91},"updated":"2024-03-25 14:30:57.000000000","message":"please keep this within 79 characters... you can break the line just as done in the method above","commit_id":"fa2054f32ba9bea8263ba55eb04a183c3b9fe7df"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"237035369aee386d3f6346769c5a2532b60a60fe","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        \"\"\"Get quota class set."},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"        :param quota_class_name: The name of the quota class"},{"line_number":1208,"context_line":"        :returns: A :class:`~openstack.shared_file_system.v2.quota_class_set.QuotaClassSet`"},{"line_number":1209,"context_line":"        \"\"\""},{"line_number":1210,"context_line":"        return self._get(_quota_class_set.QuotaClassSet, quota_class_name)"},{"line_number":1211,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7cfc0a0e_6cf2b981","line":1208,"range":{"start_line":1208,"start_character":76,"end_line":1208,"end_character":91},"in_reply_to":"201d60ea_514350f1","updated":"2024-04-22 16:37:56.000000000","message":"Done","commit_id":"fa2054f32ba9bea8263ba55eb04a183c3b9fe7df"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ca4e6505d2dbf0b6e3fb6865db950c881dfb450c","unresolved":true,"context_lines":[{"line_number":1215,"context_line":"        :param quota_class_name: The name of the quota class"},{"line_number":1216,"context_line":"        :param attrs: The attributes to update on the quota class set"},{"line_number":1217,"context_line":"        :returns: the updated quota class set"},{"line_number":1218,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2.quota_class_set.QuotaClassSet`"},{"line_number":1219,"context_line":"        \"\"\""},{"line_number":1220,"context_line":"        return self._update("},{"line_number":1221,"context_line":"            _quota_class_set.QuotaClassSet, quota_class_name, **attrs"}],"source_content_type":"text/x-python","patch_set":5,"id":"de476f02_8e94255d","line":1218,"range":{"start_line":1218,"start_character":73,"end_line":1218,"end_character":86},"updated":"2024-03-25 14:30:57.000000000","message":"same","commit_id":"fa2054f32ba9bea8263ba55eb04a183c3b9fe7df"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"237035369aee386d3f6346769c5a2532b60a60fe","unresolved":false,"context_lines":[{"line_number":1215,"context_line":"        :param quota_class_name: The name of the quota class"},{"line_number":1216,"context_line":"        :param attrs: The attributes to update on the quota class set"},{"line_number":1217,"context_line":"        :returns: the updated quota class set"},{"line_number":1218,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2.quota_class_set.QuotaClassSet`"},{"line_number":1219,"context_line":"        \"\"\""},{"line_number":1220,"context_line":"        return self._update("},{"line_number":1221,"context_line":"            _quota_class_set.QuotaClassSet, quota_class_name, **attrs"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f950612_6fcfb35b","line":1218,"range":{"start_line":1218,"start_character":73,"end_line":1218,"end_character":86},"in_reply_to":"de476f02_8e94255d","updated":"2024-04-22 16:37:56.000000000","message":"Done","commit_id":"fa2054f32ba9bea8263ba55eb04a183c3b9fe7df"}],"openstack/tests/functional/shared_file_system/test_quota_class_set.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"237035369aee386d3f6346769c5a2532b60a60fe","unresolved":true,"context_lines":[{"line_number":24,"context_line":"        quota_class_set \u003d self.operator_cloud.share.update_quota_class_set("},{"line_number":25,"context_line":"            self.operator_cloud.current_project_id,"},{"line_number":26,"context_line":"            **{"},{"line_number":27,"context_line":"                \"backups\": 51,"},{"line_number":28,"context_line":"            }"},{"line_number":29,"context_line":"        )"},{"line_number":30,"context_line":"        self.assertIn(\u0027shares\u0027, quota_class_set)"}],"source_content_type":"text/x-python","patch_set":8,"id":"608b4246_dc5cc3ff","line":27,"updated":"2024-04-22 16:37:56.000000000","message":"You should revert this afterwards. Alternatively we could create a new project and modify quotas of that. This would be better but is likely far more work.\n\nAlso, rather than setting to 51, consider setting to `{current_value} + 1` and then reverting back.","commit_id":"e15ef088dee34081b7fa230c19145972ded61384"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06087e0a4c73ca0b1eb7630d1af88c08368614e2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        quota_class_set \u003d self.operator_cloud.share.update_quota_class_set("},{"line_number":25,"context_line":"            self.operator_cloud.current_project_id,"},{"line_number":26,"context_line":"            **{"},{"line_number":27,"context_line":"                \"backups\": 51,"},{"line_number":28,"context_line":"            }"},{"line_number":29,"context_line":"        )"},{"line_number":30,"context_line":"        self.assertIn(\u0027shares\u0027, quota_class_set)"}],"source_content_type":"text/x-python","patch_set":8,"id":"0c19a8ab_f53c5df3","line":27,"in_reply_to":"608b4246_dc5cc3ff","updated":"2024-04-23 09:26:04.000000000","message":"Done","commit_id":"e15ef088dee34081b7fa230c19145972ded61384"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"237035369aee386d3f6346769c5a2532b60a60fe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4df9e298_680d5e35","line":31,"updated":"2024-04-22 16:37:56.000000000","message":"nit: We normally do things in one test now, to minimise the amount of time taken between test cases and avoid duplication. If you are reworking to add the revert, consider merging these tests. Look at e.g. `openstack/tests/functional/identity/v3/test_domain_config.py` for an example.","commit_id":"e15ef088dee34081b7fa230c19145972ded61384"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06087e0a4c73ca0b1eb7630d1af88c08368614e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3dc14f11_e05bd5e7","line":31,"in_reply_to":"4df9e298_680d5e35","updated":"2024-04-23 09:26:04.000000000","message":"Done","commit_id":"e15ef088dee34081b7fa230c19145972ded61384"}]}