)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"0a8a85dbf2855d6298f8bf9b514b9b964f3a60bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2c0f3df5_5dd2edfc","updated":"2024-04-10 03:11:36.000000000","message":"TODO: fix the failure reported in the Ansible test suite (it\u0027s non-voting so Zuul marked it as +1, but the failure seems to be caused by my changes so I will need to look into it still)","commit_id":"5f2c98262d9b4a38b359f9adbc43716b2e26121f"}],"openstack/cloud/_floating_ip.py":[{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"50f4647ba0c961bc44b1007ffb83d91cb0b48fb1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            os_warnings.OpenStackDeprecationWarning,"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":"        if self._use_neutron_floating() and isinstance(filters, dict):"},{"line_number":56,"context_line":"            return list(self.network.ips(**filters, allow_unknown_params\u003dTrue))"},{"line_number":57,"context_line":"        else:"},{"line_number":58,"context_line":"            floating_ips \u003d self.list_floating_ips()"},{"line_number":59,"context_line":"            return _utils._filter_list(floating_ips, id, filters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"59c6caf6_6e80d2a3","line":56,"updated":"2024-04-09 23:34:42.000000000","message":"Since `search_floating_ips()` is supposed to be different from `_neutron_list_floating_ips()` specifically in that it looks at those cases where client-side filtering is necessary, it seemed appropriate here to allow unknown params so the client could handle the ones the server doesn\u0027t know. (At least, that is how I am understanding it... please let me know if this doesn\u0027t work the way I think it does :) )","commit_id":"d64df954d5f1cbce83b369d40b73e7fb06b1d093"}],"openstack/tests/functional/shared_file_system/test_share_access_rule.py":[{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"b2d31b2c45a1885fe8ee187f27c63fa9c29dc16b","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_list_access_rules(self):"},{"line_number":61,"context_line":"        rules \u003d self.user_cloud.shared_file_system.access_rules("},{"line_number":62,"context_line":"            self.SHARE, details\u003dTrue"},{"line_number":63,"context_line":"        )"},{"line_number":64,"context_line":"        self.assertGreater(len(list(rules)), 0)"},{"line_number":65,"context_line":"        for rule in rules:"}],"source_content_type":"text/x-python","patch_set":4,"id":"4b7e9d03_2bf6d28b","side":"PARENT","line":62,"updated":"2024-04-05 23:35:54.000000000","message":"In `openstack/shared_file_system/v2/_proxy.py`, I see some list functions using `details` and some not. (If `details` is True, `base_path\u003d/[resource]/detail` is passed in to `_list()`; otherwise the default `base_path` i.e. None is passed in.) `access_rules()` does not have a `details` parameter and doesn\u0027t pass in a special `base_path`; is the correct move here to remove `details\u003dTrue` from the test like I did here, or should `details` be added to `access_rules()`?","commit_id":"4d9c40b74c2aca4c55403bbdb97769960acba518"}],"openstack/tests/unit/cloud/test_keypair.py":[{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"3f05df74d252ac5d9cbffe66762880fb103b71cd","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            ]"},{"line_number":178,"context_line":"        )"},{"line_number":179,"context_line":"        keypairs \u003d self.cloud.list_keypairs("},{"line_number":180,"context_line":"            filters\u003d{\u0027user_id\u0027: \u0027b\u0027, \u0027fake\u0027: \u0027dummy\u0027}"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        self.assertEqual(len(keypairs), 1)"},{"line_number":183,"context_line":"        self.assertEqual(keypairs[0].name, self.key[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"4879e476_2e2e7a5f","side":"PARENT","line":180,"updated":"2024-04-05 21:11:44.000000000","message":"Is there a specific reason that `user_id` is the only query parameter listed in the query mapping in `openstacksdk/openstack/compute/v2/keypair.py` (line 21)?","commit_id":"4d9c40b74c2aca4c55403bbdb97769960acba518"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"a819809044e1f3bf53864823489729e4a0801953","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            ]"},{"line_number":178,"context_line":"        )"},{"line_number":179,"context_line":"        keypairs \u003d self.cloud.list_keypairs("},{"line_number":180,"context_line":"            filters\u003d{\u0027user_id\u0027: \u0027b\u0027, \u0027fake\u0027: \u0027dummy\u0027}"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        self.assertEqual(len(keypairs), 1)"},{"line_number":183,"context_line":"        self.assertEqual(keypairs[0].name, self.key[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7b6ea6e_a70ee0d9","side":"PARENT","line":180,"in_reply_to":"4879e476_2e2e7a5f","updated":"2024-04-10 00:17:41.000000000","message":"After fixing the floating_ip search function, I would guess that the reasoning here is that `user_id` is the only one that can appear in the URI using the list function, and all others can only be passed in as parameters to the search function; is this correct? And in that case, should all the search functions allow unknown parameters, since they all seem to do a second pass of filtering on the client side?","commit_id":"4d9c40b74c2aca4c55403bbdb97769960acba518"}]}