)]}'
{"id":"openstack%2Fopenstacksdk~915199","triplet_id":"openstack%2Fopenstacksdk~master~I0a5f57346c7ff469ffe1b93051e470141117ada9","project":"openstack/openstacksdk","branch":"master","topic":"support-python3.8","attention_set":{},"removed_from_attention_set":{"27900":{"account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"last_update":"2024-04-22 17:04:41.000000000","reason":"Change was submitted"},"2271":{"account":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"last_update":"2024-04-22 17:04:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0a5f57346c7ff469ffe1b93051e470141117ada9","subject":"Remove mypy union line which breaks older pythons.","status":"MERGED","created":"2024-04-06 23:12:21.000000000","updated":"2024-04-22 17:05:59.000000000","submitted":"2024-04-22 17:04:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"915199-support-python3.8","meta_rev_id":"eea7eab9403fda0626e3b51d1da02c1250e544f6","_number":915199,"virtual_id_number":915199,"owner":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-04-22 17:04:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2024-04-22 15:06:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2024-04-22 15:06:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"CC":[{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-07 00:24:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-12 07:37:45.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2024-04-12 10:07:30.000000000","updated_by":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"reviewer":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"state":"CC"},{"updated":"2024-04-12 10:07:30.000000000","updated_by":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"reviewer":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"state":"CC"},{"updated":"2024-04-12 14:09:28.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"CC"},{"updated":"2024-04-22 15:06:05.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"df3b5fb3abad43cde49827d5175e086053147801","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2024-04-06 23:12:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"361716d726a72df27818d34e834ce990c534974f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-07 00:24:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/311ba10e24e847ffb2e8f2a13a127dc6\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/34066e33f5b84a0e95428cfd31e56f7b : SUCCESS in 40m 06s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/cb793e68c7ce40f4a9c434df505397ae : SUCCESS in 31m 37s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cc1bb7fbd5984fa799c7abdc4134d95a : SUCCESS in 4m 02s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ca8c1132da4d42b4b4d6187f641475d4 : SUCCESS in 6m 23s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/68fae095c40c458d996666ccb3d91338 : SUCCESS in 3m 19s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/a59dee33f2044b36bb2eb224347e5e4c : FAILURE in 8m 52s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/cf664908621346a09e360ed896106ea1 : SUCCESS in 42m 57s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/da49a2f200004cea8b10242f30ad7bcc : SUCCESS in 5m 38s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/38d1fb16e03140409c1f8014e6624c02 : SUCCESS in 4m 33s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/9fe28616f89a4fc8a9e41277b35e9d66 : SUCCESS in 4m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3e9ebe611e6848d9b3e08b35fe1ae921 : SUCCESS in 7m 38s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/bff4d14a421740648e3cea3bbb6fbc09 : SUCCESS in 1h 06m 38s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/b64966d629804cac86b55374a7ff5c01 : SUCCESS in 10m 52s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/57a053d6bee34da3899b8f4ada815f1f : SUCCESS in 24m 23s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/34a35ae3ad004651aaafc8f987275fd3 : SUCCESS in 38m 40s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/9d2e058ee9414f16aa6b2d71fb5a5db5 : SUCCESS in 1h 04m 18s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/f2229c1d2c404d128c1338adbf22f9db : SUCCESS in 1h 08m 03s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/7ee14701d9ba4464a3c2a838d3e39d7b : SUCCESS in 49m 18s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/a4ef887e61f642579d76dc89c08c761c : FAILURE in 37m 13s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/c9c00a12610e483faf0416955d9b3fd3 : SUCCESS in 31m 14s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/54b44dd3233543eabe51317737273b9e : SUCCESS in 18m 19s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/1d69d67c9c2b47bba604ae04101d65c4 : FAILURE in 40m 15s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/d3d115c2d6fc45f9b0735d5cdf8a1bcf : SUCCESS in 42m 56s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/34d3ff45d2174ca39d8551fb4a5b596f : FAILURE in 38m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9dea33ff2166efafb7e4ecdd320bc1d1d2d180fd","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2024-04-12 07:37:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b32ded43f0c4a5cae9c918d6cde511621b0c0e12","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2024-04-12 12:34:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cd444f1cc4b5b02b638a2a77f6f578103ada9b71","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2024-04-12 13:02:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"91a13f98a7a1e46132c35e3065ad7eb06eb1ee6d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-04-12 14:09:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9f17186235a12c6eb8244472e8adc85d5b426651","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2024-04-21 05:40:29.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"1fa7edc3031fa3c6d5d120a02470e53255ff370c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-21 07:18:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/66e0f8e2942d424e85a339f4ec0150b5\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/b4c819755da343cd987266342fd55f54 : SUCCESS in 39m 18s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/4510856d39b540e5898d6de784f4256a : SUCCESS in 29m 10s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f5e138c994bc4d6cbc1f72bd70454417 : SUCCESS in 3m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/da12c1c9514b486fa449274aebd93001 : SUCCESS in 3m 43s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ac02e351d5594e18acad8dd7a405114d : SUCCESS in 4m 31s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/6b9bfc8e0b6341218e84332124d7e32d : FAILURE in 6m 15s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/67bd8bf99ff140d9acbf4492dc7b331c : SUCCESS in 38m 41s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/d9388e6516114d35b6c485845bddeab9 : SUCCESS in 3m 34s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/68d328c15b3c4a059b33917ebcc00b22 : SUCCESS in 4m 21s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/cf55960d234e491b9de39a5e2250fa4e : SUCCESS in 3m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1341d1fcd84c4012839230c5ebf98bdf : SUCCESS in 7m 47s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/fd63a95961314d7ea02ae4064a322dc9 : SUCCESS in 1h 21m 46s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/add8d5f85f3f4fcb860f26065a0e8fe1 : SUCCESS in 14m 04s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/37500c208d1a4a35b40ae4c0f1f6eecb : SUCCESS in 46m 07s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ddbfcb4f8110411092f63cfa95e6fe64 : SUCCESS in 1h 00m 09s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/ef27b299de3e419699fb2a394bba2f0f : SUCCESS in 1h 03m 33s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/be39792f20f64733be1859819afc79f4 : SUCCESS in 1h 31m 20s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/9f6eeb571bc34262bf95f056710c2690 : SUCCESS in 34m 19s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/84e471a1136142e18e8e4e3db1fada3e : FAILURE in 37m 11s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/0c7d268b8dc64fbebf30134d54a313d3 : SUCCESS in 23m 35s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/488c21abf86748b0a4664717d75c04f5 : SUCCESS in 33m 16s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/f44920b4c24948f98ba237bebd7205da : FAILURE in 44m 09s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/aca7b65813b64af09846d2fec424a2f9 : SUCCESS in 41m 35s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/3b67ac33fef4415abd46d2772f0d424d : SUCCESS in 1h 14m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"764a0748ba4ade42db77ec40b65054deb6eb9fc4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-04-22 15:06:05.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"09128e53a6ce2153327aa9c91faf6a8299c2ee32","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-22 15:07:13.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b2cf920ddbe495a8ba87cdaea2a609a4b8019f4d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-22 17:04:41.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e8a1fc53c46841eaa921e95782707927\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7a612dab10794acba6b7985b400fd226 : SUCCESS in 6m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4f2263c75d3c47d881452651eee46b6e : SUCCESS in 5m 08s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/a4dbadf35d4c4c4ab7d933be684ac601 : SUCCESS in 5m 38s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/8bac7b7d774249269e4d2d11c14e8b78 : SUCCESS in 49m 48s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/2745486448ce4bd6a8096305f6fe5a33 : SUCCESS in 3m 52s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/d259a7944ca445f59de132a63ef9f6a4 : SUCCESS in 5m 07s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/8fe539c63d1a47eb891fd11c1fee87d5 : SUCCESS in 5m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/43cf84be78b84c0f868b9d043f40c9fd : SUCCESS in 9m 36s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/e258100438b74421b290c0a6f99241cc : SUCCESS in 59m 02s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/b979f9d20ead4217b62d4484467e1d73 : SUCCESS in 14m 28s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/995969abaf3a4f58b4cc6b267dd6e354 : SUCCESS in 31m 22s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/63b9324493f64964910c3f37f5d6fe5a : SUCCESS in 1h 01m 43s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/16631f32b45f4de69aa649b302e2a907 : SUCCESS in 1h 08m 25s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/5b50e026a32b4f89960b2c844856d521 : SUCCESS in 1h 22m 19s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/219a8c5efe544e7facf73154212cd1a7 : SUCCESS in 57m 14s","accounts_in_message":[],"_revision_number":2},{"id":"7f6b169b7cd1905c7429daafc0244d9ddd4e6e2a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-22 17:04:41.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"eea7eab9403fda0626e3b51d1da02c1250e544f6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-22 17:05:59.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/13ad07ec91ca4324abe593e1fb081221\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e125c6437a6a4d1299233b20023cb0c1 : SUCCESS in 54s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7131781adb04c00d8977bc27e993d1f7315b4c8a","revisions":{"e6aeba9b3ea55df0b4d29b8861e6948bf1b89843":{"kind":"REWORK","_number":1,"created":"2024-04-06 23:12:21.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/99/915199/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/99/915199/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/1"}}},"commit":{"parents":[{"commit":"4d9c40b74c2aca4c55403bbdb97769960acba518","subject":"Merge \"Update master for stable/2024.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/4d9c40b74c2aca4c55403bbdb97769960acba518"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2024-04-06 23:09:57.000000000","tz":600},"committer":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2024-04-06 23:12:08.000000000","tz":600},"subject":"Remove mypy union line which breaks older pythons.","message":"Remove mypy union line which breaks older pythons.\n\nChange I084336ba41147f824b92dc07235e5f19b7ac4a9c introduced mypy\nsyntax which breaks Python releases before 3.10. Unfortunately, for\n2024.1 we commit to supporting Python back to 3.8.\n\nSpecifically, you receive this error message if you run pep8:\n\npep8 mypy.....................................................................Failed\npep8 - hook id: mypy\npep8 - exit code: 1\npep8\npep8 openstack/object_store/v1/_proxy.py: note: In member \"generate_temp_url\" of class \"Proxy\":\npep8 openstack/object_store/v1/_proxy.py:1049:21: error: X | Y syntax for unions requires Python 3.10  [syntax]\npep8 Found 1 error in 1 file (checked 410 source files)\n\nI asked some buddies, and we\u0027re fairly sure that this line would\ncrash the runtime on Python 3.8, because its a syntax error.\n\nSo instead, let\u0027s remove this line until we\u0027ve dropped support for\nPython versions before 3.10.\n\nChange-Id: I0a5f57346c7ff469ffe1b93051e470141117ada9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/e6aeba9b3ea55df0b4d29b8861e6948bf1b89843"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/e6aeba9b3ea55df0b4d29b8861e6948bf1b89843"}]},"branch":"refs/heads/master"},"7131781adb04c00d8977bc27e993d1f7315b4c8a":{"kind":"REWORK","_number":2,"created":"2024-04-21 05:40:29.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/99/915199/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/99/915199/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/99/915199/2"}}},"commit":{"parents":[{"commit":"4d9c40b74c2aca4c55403bbdb97769960acba518","subject":"Merge \"Update master for stable/2024.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/4d9c40b74c2aca4c55403bbdb97769960acba518"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2024-04-06 23:09:57.000000000","tz":600},"committer":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2024-04-21 05:39:39.000000000","tz":600},"subject":"Remove mypy union line which breaks older pythons.","message":"Remove mypy union line which breaks older pythons.\n\nChange I084336ba41147f824b92dc07235e5f19b7ac4a9c introduced mypy\nsyntax which breaks Python releases before 3.10. Unfortunately, for\n2024.1 we commit to supporting Python back to 3.8.\n\nSpecifically, you receive this error message if you run pep8:\n\npep8 mypy.....................................................................Failed\npep8 - hook id: mypy\npep8 - exit code: 1\npep8\npep8 openstack/object_store/v1/_proxy.py: note: In member \"generate_temp_url\" of class \"Proxy\":\npep8 openstack/object_store/v1/_proxy.py:1049:21: error: X | Y syntax for unions requires Python 3.10  [syntax]\npep8 Found 1 error in 1 file (checked 410 source files)\n\nI asked some buddies, and we\u0027re fairly sure that this line would\ncrash the runtime on Python 3.8, because its a syntax error.\n\nSo instead, let\u0027s use typing syntax compatible with other pythons.\n\nChange-Id: I0a5f57346c7ff469ffe1b93051e470141117ada9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/7131781adb04c00d8977bc27e993d1f7315b4c8a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/7131781adb04c00d8977bc27e993d1f7315b4c8a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}