)]}'
{"id":"openstack%2Fopenstacksdk~917012","triplet_id":"openstack%2Fopenstacksdk~stable%2F2024.1~I0a5f57346c7ff469ffe1b93051e470141117ada9","project":"openstack/openstacksdk","branch":"stable/2024.1","attention_set":{},"removed_from_attention_set":{"2271":{"account":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"last_update":"2024-04-25 13:00:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0a5f57346c7ff469ffe1b93051e470141117ada9","subject":"Remove mypy union line which breaks older pythons.","status":"MERGED","created":"2024-04-25 09:58:55.000000000","updated":"2024-04-25 13:01:59.000000000","submitted":"2024-04-25 13:00:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"917012","meta_rev_id":"925a07bf3ec8998395995747e4847644f920acf7","_number":917012,"virtual_id_number":917012,"owner":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-04-25 13:00:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2024-04-25 11:45:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2024-04-25 11:45:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-25 11:39:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-25 11:45:00.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"f0c904ab2dfbcd3a86eebc5721f8cc019bede350","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2024-04-25 09:58:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9e27aab23cc91e648d8f8507fc3faf0f95eb0085","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-25 11:39:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c781c333ab0b437e97fb0bf44ff423c7\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/8fe43890923049e8aea8d8e0f2c6d474 : SUCCESS in 54m 16s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/194d274dfa7f4dc2aea1f6980e1a2486 : SUCCESS in 46m 10s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/58379b0c46e84e49ab4838208e2d284f : SUCCESS in 4m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/61d5348f46264e389717a8f5b1f5e9bd : SUCCESS in 4m 11s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/5c6d6076997e4084ba0a53b3c247d52b : SUCCESS in 3m 40s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/d6dfb6cc1bf64a1fab467ff9f104da41 : SUCCESS in 47m 57s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/02f30df3849a46978277fade23d151c7 : SUCCESS in 3m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2590aa982f6b499d87136e8df7346199 : SUCCESS in 8m 17s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/4e49b3205d14496987fcb610b763add8 : SUCCESS in 56m 58s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/08fe7a1e921049ecb05fcc15a09fc52a : SUCCESS in 14m 53s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/b1319cc858d848acb9c3c9cc1786afc9 : SUCCESS in 32m 56s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/a63442f63ae44a0a8210a1b68ffd18a3 : SUCCESS in 49m 58s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/2daea90342fe459985b0629bf2184b57 : SUCCESS in 1h 21m 54s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/4e28ed0a5a154dca9bf7fc5c1bae11d1 : SUCCESS in 1h 26m 19s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/066013a50df64dfa917f21aaeb0f90e5 : SUCCESS in 51m 00s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/5fde64abfcb849299050995312db0245 : FAILURE in 51m 47s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/ce2b03c8af51491386b40ca374d5be23 : SUCCESS in 35m 16s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/97927d9f98f34240b1cd4c39b5c460b3 : SUCCESS in 30m 57s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/bda11095c8174bfab71c57fef9d79340 : FAILURE in 41m 49s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/b63fafad0c2545a7a90796fe6ab0ffec : SUCCESS in 58m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1737b64ec096af832a8f7adbd315ae9d35688ae1","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-04-25 11:45:00.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b3e1bf1dd4789dd63514615ae7b16eb3959caf01","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-25 11:45:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b768893e52a0b3884af01c679aa554ee3bbfad52","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-25 13:00:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f1d311e48d4b439eb5b0dba746f88e4a\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/796a240ddc12423db2340d6271603787 : SUCCESS in 3m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/49fde0621e3f4a329f79e91b78e4e85e : SUCCESS in 4m 03s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/a08c5870444140b4b2427ca629894c99 : SUCCESS in 4m 17s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/33b1d8c5713e4b738d0a809a3d5472fd : SUCCESS in 1h 00m 24s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/0d8cb2bff6204f288f1526c564f999a3 : SUCCESS in 3m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/27878fb93f314570b5bfe676f6fbbb58 : SUCCESS in 7m 37s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7997b507664d493dae98e39c446c859b : SUCCESS in 51m 02s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/27dc408f79d243b7bc9df51387f072a8 : SUCCESS in 12m 30s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/1b3af1fc68b243459c3eedbde6ddb9b1 : SUCCESS in 24m 38s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3195f961a7c0421e9da2a166818a5968 : SUCCESS in 46m 04s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/a7c6c60d41cf48ea8c03328adbe3f021 : SUCCESS in 1h 14m 48s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/d12443a78e64491e94bf777926bffa88 : SUCCESS in 1h 09m 57s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/cf8b3e431b494964b0c82a8a95ec8780 : SUCCESS in 53m 50s","accounts_in_message":[],"_revision_number":1},{"id":"b6adb6b9667c92f7dc7233539abdc7c120c3b0e4","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-25 13:00:56.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"925a07bf3ec8998395995747e4847644f920acf7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-25 13:01:59.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0720ad629fec4617be0430e34bd2ed52\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/23aa18fec19f49048b5a5532521b461c : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d48584547771bddac98f465772b3d447f24301b5","revisions":{"d48584547771bddac98f465772b3d447f24301b5":{"kind":"REWORK","_number":1,"created":"2024-04-25 09:58:55.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/12/917012/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/12/917012/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/12/917012/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/12/917012/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/12/917012/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/12/917012/1"}}},"commit":{"parents":[{"commit":"465464b2f533b0d276fdbcbd82ba35c35f39fa7a","subject":"Update TOX_CONSTRAINTS_FILE for stable/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/465464b2f533b0d276fdbcbd82ba35c35f39fa7a"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2024-04-06 23:09:57.000000000","tz":600},"committer":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2024-04-25 09:58:31.000000000","tz":600},"subject":"Remove mypy union line which breaks older pythons.","message":"Remove mypy union line which breaks older pythons.\n\nChange I084336ba41147f824b92dc07235e5f19b7ac4a9c introduced mypy\nsyntax which breaks Python releases before 3.10. Unfortunately, for\n2024.1 we commit to supporting Python back to 3.8.\n\nSpecifically, you receive this error message if you run pep8:\n\npep8 mypy.....................................................................Failed\npep8 - hook id: mypy\npep8 - exit code: 1\npep8\npep8 openstack/object_store/v1/_proxy.py: note: In member \"generate_temp_url\" of class \"Proxy\":\npep8 openstack/object_store/v1/_proxy.py:1049:21: error: X | Y syntax for unions requires Python 3.10  [syntax]\npep8 Found 1 error in 1 file (checked 410 source files)\n\nI asked some buddies, and we\u0027re fairly sure that this line would\ncrash the runtime on Python 3.8, because its a syntax error.\n\nSo instead, let\u0027s use typing syntax compatible with other pythons.\n\nChange-Id: I0a5f57346c7ff469ffe1b93051e470141117ada9\n(cherry picked from commit 7131781adb04c00d8977bc27e993d1f7315b4c8a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/d48584547771bddac98f465772b3d447f24301b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/d48584547771bddac98f465772b3d447f24301b5"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}