)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8930da5056c9d484b8b17dc33e29676525c1c3c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ab0a32cc_11c2fe65","updated":"2024-07-19 14:05:19.000000000","message":"Looks good to me other than some nits. We do need a release note though since this is a potentially breaking change.","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f96cdec56c27e4637832909398f20b3fe1605d4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ed2c4749_a735eae9","in_reply_to":"ab0a32cc_11c2fe65","updated":"2024-07-22 09:51:45.000000000","message":"Thanks for the review","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"}],"openstack/network/v2/agent.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8930da5056c9d484b8b17dc33e29676525c1c3c0","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        \"\"\"List BGP speakers hosted by a Dynamic Routing Agent"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param session: The session to communicate through."},{"line_number":115,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027bgp-drinstances\u0027)"},{"line_number":118,"context_line":"        resp \u003d session.get(url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"35584642_017bcef8","line":115,"updated":"2024-07-19 14:05:19.000000000","message":"Can you add return information here (and ideally type annotations to match)?","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f96cdec56c27e4637832909398f20b3fe1605d4b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \"\"\"List BGP speakers hosted by a Dynamic Routing Agent"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param session: The session to communicate through."},{"line_number":115,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027bgp-drinstances\u0027)"},{"line_number":118,"context_line":"        resp \u003d session.get(url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"363ee5ab_8850de7f","line":115,"in_reply_to":"35584642_017bcef8","updated":"2024-07-22 09:51:45.000000000","message":"Done","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8930da5056c9d484b8b17dc33e29676525c1c3c0","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        exceptions.raise_from_response(resp)"},{"line_number":120,"context_line":"        self._body.attributes.update(resp.json())"},{"line_number":121,"context_line":"        speaker_ids \u003d [sp[\u0027id\u0027] for sp in resp.json()[\u0027bgp_speakers\u0027]]"},{"line_number":122,"context_line":"        speakers \u003d _speaker.BgpSpeaker.list(session\u003dsession)"},{"line_number":123,"context_line":"        return [sp for sp in speakers if sp.id in speaker_ids]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"de602993_1c1726db","line":122,"updated":"2024-07-19 14:05:19.000000000","message":"No `ids` filter we can use here, I assume?","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5104dff08512852da4d9ade356c44ce9e193a71","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        exceptions.raise_from_response(resp)"},{"line_number":120,"context_line":"        self._body.attributes.update(resp.json())"},{"line_number":121,"context_line":"        speaker_ids \u003d [sp[\u0027id\u0027] for sp in resp.json()[\u0027bgp_speakers\u0027]]"},{"line_number":122,"context_line":"        speakers \u003d _speaker.BgpSpeaker.list(session\u003dsession)"},{"line_number":123,"context_line":"        return [sp for sp in speakers if sp.id in speaker_ids]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8c7bf347_eb5fca57","line":122,"in_reply_to":"bcdb748a_172ffcc9","updated":"2024-07-22 11:01:18.000000000","message":"Acknowledged","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f96cdec56c27e4637832909398f20b3fe1605d4b","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        exceptions.raise_from_response(resp)"},{"line_number":120,"context_line":"        self._body.attributes.update(resp.json())"},{"line_number":121,"context_line":"        speaker_ids \u003d [sp[\u0027id\u0027] for sp in resp.json()[\u0027bgp_speakers\u0027]]"},{"line_number":122,"context_line":"        speakers \u003d _speaker.BgpSpeaker.list(session\u003dsession)"},{"line_number":123,"context_line":"        return [sp for sp in speakers if sp.id in speaker_ids]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bcdb748a_172ffcc9","line":122,"in_reply_to":"de602993_1c1726db","updated":"2024-07-22 09:51:45.000000000","message":"No, at least it is not worked for me.","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"}],"openstack/network/v2/bgp_speaker.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8930da5056c9d484b8b17dc33e29676525c1c3c0","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        :param session: The session to communicate through."},{"line_number":137,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":138,"context_line":"        :returns: The response as a list of dragents hosting a specific"},{"line_number":139,"context_line":"                  BGP Speaker."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        :raises: :class:`~openstack.exceptions.SDKException` on error."},{"line_number":142,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"0f462191_e83559bc","line":139,"updated":"2024-07-19 14:05:19.000000000","message":"Does this need rewording now? Also, how about type information?","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f96cdec56c27e4637832909398f20b3fe1605d4b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        :param session: The session to communicate through."},{"line_number":137,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":138,"context_line":"        :returns: The response as a list of dragents hosting a specific"},{"line_number":139,"context_line":"                  BGP Speaker."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        :raises: :class:`~openstack.exceptions.SDKException` on error."},{"line_number":142,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"f271887a_71077270","line":139,"in_reply_to":"0f462191_e83559bc","updated":"2024-07-22 09:51:45.000000000","message":"Done","commit_id":"ccb5187a353a59c17b804f1913256c2380dff798"}],"openstack/tests/unit/network/v2/test_bgp_speaker.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c030e6440cd2c257620a6de779fd2f0d0a816778","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        url \u003d \u0027bgp-speakers/IDENTIFIER/bgp-dragents\u0027"},{"line_number":169,"context_line":"        sess.get.assert_called_with(url)"},{"line_number":170,"context_line":"        print(\u0027BBBBB0  \u0027, ret)"},{"line_number":171,"context_line":"        self.assertEqual(ret, [agent.Agent(**response.body[\u0027agents\u0027][0])])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_add_bgp_speaker_to_dragent(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"d7986687_1c534872","line":170,"updated":"2025-01-06 18:47:34.000000000","message":"is the print() intentional or a leftover from debugging? we don\u0027t usually do that in unit tests, do we?","commit_id":"bd757116c2bf5162452f7aef2321183f6282eb89"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ebdbfefdf6219b21ee2379065a0f361edf6405ff","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        url \u003d \u0027bgp-speakers/IDENTIFIER/bgp-dragents\u0027"},{"line_number":169,"context_line":"        sess.get.assert_called_with(url)"},{"line_number":170,"context_line":"        print(\u0027BBBBB0  \u0027, ret)"},{"line_number":171,"context_line":"        self.assertEqual(ret, [agent.Agent(**response.body[\u0027agents\u0027][0])])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_add_bgp_speaker_to_dragent(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"80a02d3e_1364bd86","line":170,"in_reply_to":"9c5883fa_550a8dc3","updated":"2025-01-07 08:58:44.000000000","message":"https://review.opendev.org/c/openstack/openstacksdk/+/938539","commit_id":"bd757116c2bf5162452f7aef2321183f6282eb89"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"97520f88e3d0142ffbb7f9cc17574f8a9c97ee38","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        url \u003d \u0027bgp-speakers/IDENTIFIER/bgp-dragents\u0027"},{"line_number":169,"context_line":"        sess.get.assert_called_with(url)"},{"line_number":170,"context_line":"        print(\u0027BBBBB0  \u0027, ret)"},{"line_number":171,"context_line":"        self.assertEqual(ret, [agent.Agent(**response.body[\u0027agents\u0027][0])])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_add_bgp_speaker_to_dragent(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9c5883fa_550a8dc3","line":170,"in_reply_to":"d7986687_1c534872","updated":"2025-01-07 08:54:11.000000000","message":"oh, thanks, it happened again ....","commit_id":"bd757116c2bf5162452f7aef2321183f6282eb89"}]}