)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f3e2f5ca43d90297a5bb67c96e42432a0e56bc74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6dfd0b9f_881d073c","updated":"2024-06-12 16:52:09.000000000","message":"You should definitely split adding options as a property and fixing assignments into separate changes.\nMy current idea on assignments would be very different (since I want to move more into the declarative approach):\n- we have stuff like https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/identity/v3/role_domain_group_assignment.py as a representation for the normal role assignments. They are currently only used in the proxy for listing, but I would change that.\n- I propose to duplicate those individual role assignment resources into the OS-INHERITED ones with normal static urls\n- the proxy method to do assign/unassign/validate/etc could be extended with \u0027inherited\u0027 parameter and corresponding to that instantiate a matching resource.\n- Also I would delete (or probably first mark deprecated) the individual assign/unassign/verify methods inside of the domain/project resources. But that should be an independent change.","commit_id":"3682ef71bf0c14203e45c27107f3e1a4c4d1e215"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"7c8757e53df79240dbe86aff8dad134092079d5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c09b38e_1639c3f9","updated":"2024-09-16 22:18:38.000000000","message":"Moved changes related to assigning inherited roles to another branch: https://review.opendev.org/c/openstack/openstacksdk/+/929578","commit_id":"a2da5727d0575a573f997e08a0aa9e3f68397a2f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d7d3f249c0ae978eaeb79e78b4262c1b92d3420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a22e36c_0b70c239","updated":"2024-09-17 10:32:45.000000000","message":"Still needs tests and a release note. I also have a comment inline.","commit_id":"a2da5727d0575a573f997e08a0aa9e3f68397a2f"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"78397d8394b7ca306a3f7fcbc6a555a3aae50a56","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"916d3fc8_cfffdc13","in_reply_to":"4a22e36c_0b70c239","updated":"2024-09-17 21:26:04.000000000","message":"I added a release note; what kind of additional tests should I add? I referenced `openstack/tests/unit/identity/v3/test_project.py` which also has tests for an `options` property, but I didn\u0027t see anything beyond what I already have for `test_role.py`.","commit_id":"a2da5727d0575a573f997e08a0aa9e3f68397a2f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"526b49ca15f1b55f751bf3d75386979b9f0745bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de81b27d_00e3360e","in_reply_to":"916d3fc8_cfffdc13","updated":"2024-09-18 09:07:29.000000000","message":"Ah, you\u0027re right. This is likely good enough so","commit_id":"a2da5727d0575a573f997e08a0aa9e3f68397a2f"}],"openstack/identity/v3/role.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d7d3f249c0ae978eaeb79e78b4262c1b92d3420","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    commit_method \u003d \u0027PATCH\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    _query_mapping \u003d resource.QueryParameters(\u0027name\u0027, \u0027domain_id\u0027, \u0027options\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # Properties"},{"line_number":32,"context_line":"    #: Unique role name, within the owning domain. *Type: string*"}],"source_content_type":"text/x-python","patch_set":3,"id":"1436fa39_c61e431f","line":29,"updated":"2024-09-17 10:32:45.000000000","message":"Everything in query mapping should correspond to a query string parameter for the \"list\" operation (i.e. `GET /resource`, or `GET /roles` in this case). Unless I\u0027ve missed something, options is not a valid query parameter ([per api-ref](https://docs.openstack.org/api-ref/identity/v3/index.html#list-roles)) so you don\u0027t want this here?","commit_id":"a2da5727d0575a573f997e08a0aa9e3f68397a2f"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"096f0bda3a0d256681fd4a34ac8d855af1687c37","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    commit_method \u003d \u0027PATCH\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    _query_mapping \u003d resource.QueryParameters(\u0027name\u0027, \u0027domain_id\u0027, \u0027options\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # Properties"},{"line_number":32,"context_line":"    #: Unique role name, within the owning domain. *Type: string*"}],"source_content_type":"text/x-python","patch_set":3,"id":"e7798f35_f54ed91c","line":29,"in_reply_to":"1436fa39_c61e431f","updated":"2024-09-17 20:24:58.000000000","message":"Oh yeah, you\u0027re right - fixed!","commit_id":"a2da5727d0575a573f997e08a0aa9e3f68397a2f"}]}