)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"- Updated the `attach_vif_to_node` method in the `Proxy` class to pass these parameters to the `attach_vif` method."},{"line_number":13,"context_line":"- Included a check to ensure only one of `vif_port_uuid` and `vif_portgroup_uuid` can be set at a time in both methods."},{"line_number":14,"context_line":"- Modified the request body in the `attach_vif` method to include these parameters if provided."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4b8487b45ae04f387c2f02a9505916072edc96aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ea1fcb88_2047a4f0","line":15,"updated":"2024-07-12 08:58:03.000000000","message":"Can you please wrap this at \u003c\u003d 72 characters (and ideally keep subjects to \u003c\u003d 50 characters, but that\u0027s less important)","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- Updated the `attach_vif_to_node` method in the `Proxy` class to pass these parameters to the `attach_vif` method."},{"line_number":13,"context_line":"- Included a check to ensure only one of `vif_port_uuid` and `vif_portgroup_uuid` can be set at a time in both methods."},{"line_number":14,"context_line":"- Modified the request body in the `attach_vif` method to include these parameters if provided."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4b8487b45ae04f387c2f02a9505916072edc96aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fb9cb7e2_a9f23679","line":15,"in_reply_to":"ea1fcb88_2047a4f0","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a481b180945c3e95450cbf6ce655982fee31db3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"baremetal: Enhance VIF attachment with port and portgroup UUIDs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change extends the `attach_vif` and `attach_vif_to_node` methods"},{"line_number":10,"context_line":"    to accept optional parameters for VIF port UUID and"},{"line_number":11,"context_line":"    VIF portgroup UUID."},{"line_number":12,"context_line":"This enhancement allows for more flexible VIF attachment scenarios while"},{"line_number":13,"context_line":"    ensuring that only one of these parameters can be set at a time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"a8697c1e_9f749f1e","line":10,"updated":"2024-07-16 11:29:26.000000000","message":"Um, how have you wrapped this? What\u0027s the purpose of the indents? Would you be able to strip those and wrap this as a normal paragraph? Ditto for everything below.","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ce4bbb3d2af806041e17a22a389ef7fd3fe68b5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"baremetal: Enhance VIF attachment with port and portgroup UUIDs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change extends the `attach_vif` and `attach_vif_to_node` methods"},{"line_number":10,"context_line":"    to accept optional parameters for VIF port UUID and"},{"line_number":11,"context_line":"    VIF portgroup UUID."},{"line_number":12,"context_line":"This enhancement allows for more flexible VIF attachment scenarios while"},{"line_number":13,"context_line":"    ensuring that only one of these parameters can be set at a time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"e0ac4b2b_8b182f0d","line":10,"in_reply_to":"a8697c1e_9f749f1e","updated":"2024-07-16 11:31:16.000000000","message":"Done","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a2eb57a6bb430ae56c62ddebbdb60a9dbd4319ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51a3a01d_bd3c5682","updated":"2024-06-13 17:19:00.000000000","message":"Please add a release note describing this change.","commit_id":"4eb652ef3ac1ed69ac78ec412ba4552a2eb1afca"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"26e0ba45626b64bfb2761da541fa7c23004f0085","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb1e85a7_a7ed051a","updated":"2024-06-20 11:30:27.000000000","message":"LGTM","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ba2556865036c4b3f9472dd1690f9b00ed34333e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f297a5c3_d133f997","updated":"2024-06-21 12:46:02.000000000","message":"Hey Salman, great job here, we should correct the parameters and add unit tests for this the following tests cases would be enough I think\n- sending port_uuid\n- sending portgroup_uuid\n- sending both port_uuid and portgroup_uuid","commit_id":"11feac5583ea4c0ea552a9b1fc207c68560b7b7b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bbd9d198b95360d27cc8c313494baa0835524d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a3ee4c65_bb1de87a","updated":"2024-06-27 06:29:25.000000000","message":"recheck unrelated failure in neutron auto_allocated_topology cleanup","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d4b10b175a783c7e8a09363ddff6654ffa0cd2d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"466517f3_a288174e","updated":"2024-07-04 12:28:05.000000000","message":"recheck failures seems unrelated","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"ac149252e8b09fd4f2709ed98f8c16f43acad575","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5b1b799d_f4178430","updated":"2024-07-03 17:39:10.000000000","message":"recheck unrelated failure","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"8f95ab683e9a4973fcd84ae052390c2563008a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d6f35903_95caa304","updated":"2024-07-10 13:03:11.000000000","message":"Looks good except the 2 comments.","commit_id":"f60bc4ab84493f8337d6831f37f3e2d974b5e39d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d3c723415074effd9d6ad2b299c510826806574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"16b5fa94_ba4aafef","updated":"2024-07-10 13:26:31.000000000","message":"Please fix the issues spotted by Mahnoor, then it\u0027s good to go.","commit_id":"f60bc4ab84493f8337d6831f37f3e2d974b5e39d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cdce3e4e_8bd0ebbd","updated":"2024-07-12 08:58:03.000000000","message":"All minor enough tweaks but there\u0027s enough here to warrant the -1 I suspect. This is looking pretty good once those are addressed.","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"8a86f3834e4f6d72d454c5bf5185a73449579146","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"04fa41ba_1621afbc","updated":"2024-07-11 15:16:21.000000000","message":"Looks good to me! Great job 😊","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a481b180945c3e95450cbf6ce655982fee31db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f93a2b1b_25a6211b","updated":"2024-07-16 11:29:26.000000000","message":"I feel bad leaving a -1 for such small comments, but seeing as this is the first patch it would be good to get everything in order so we can repeat going forward.","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7774a28b8b019e40e6d79dd06873f04fb2da529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f0b07313_3a15f915","updated":"2024-07-16 11:31:27.000000000","message":"Fixed my own nits.","commit_id":"346756097714b93d389c52a2c280cbe766983ed8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"09debe5aa5e9de4456d82f59b5662b983247de6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0ed71603_3920ea36","updated":"2024-07-22 18:39:49.000000000","message":"recheck openstacksdk-functional-devstack-networking-ext failure","commit_id":"346756097714b93d389c52a2c280cbe766983ed8"}],"openstack/baremetal/v1/_proxy.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1d17f64af7e1f0ac357659cad382e55ad926048e","unresolved":true,"context_lines":[{"line_number":983,"context_line":"            a :class:`~openstack.baremetal.v1.node.Node` instance."},{"line_number":984,"context_line":"        :param string vif_id: Backend-specific VIF ID."},{"line_number":985,"context_line":"        :param string vif_port_uuid: The UUID of the port to attach the VIF to."},{"line_number":986,"context_line":"        :param string vif_portgroup_uuid: The UUID of the portgroup to attach the VIF to."},{"line_number":987,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":988,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":989,"context_line":"            the node is locked. Since the latter happens more often, the"}],"source_content_type":"text/x-python","patch_set":2,"id":"8bc50663_c9683ec0","line":986,"updated":"2024-06-21 07:27:12.000000000","message":"let\u0027s keep the lines below 80 characters for consistency","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"9b8b3ac0069f0010d9287f5c2cedd9cdde01fd28","unresolved":false,"context_lines":[{"line_number":983,"context_line":"            a :class:`~openstack.baremetal.v1.node.Node` instance."},{"line_number":984,"context_line":"        :param string vif_id: Backend-specific VIF ID."},{"line_number":985,"context_line":"        :param string vif_port_uuid: The UUID of the port to attach the VIF to."},{"line_number":986,"context_line":"        :param string vif_portgroup_uuid: The UUID of the portgroup to attach the VIF to."},{"line_number":987,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":988,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":989,"context_line":"            the node is locked. Since the latter happens more often, the"}],"source_content_type":"text/x-python","patch_set":2,"id":"746e5bb3_42e98b47","line":986,"in_reply_to":"8bc50663_c9683ec0","updated":"2024-06-25 08:47:38.000000000","message":"Done","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac21ced9c0b920f0bbd94a37b91a9a0dcf0eb965","unresolved":true,"context_lines":[{"line_number":968,"context_line":"        self,"},{"line_number":969,"context_line":"        node,"},{"line_number":970,"context_line":"        vif_id,"},{"line_number":971,"context_line":"        vif_port_uuid\u003dNone,"},{"line_number":972,"context_line":"        vif_portgroup_uuid\u003dNone,"},{"line_number":973,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":974,"context_line":"    ):"},{"line_number":975,"context_line":"        \"\"\"Attach a VIF to the node."}],"source_content_type":"text/x-python","patch_set":6,"id":"79d75a7c_19849fbd","line":972,"range":{"start_line":971,"start_character":0,"end_line":972,"end_character":31},"updated":"2024-07-01 12:58:50.000000000","message":"By convention, openstacksdk uses \"id\" even when the actual API uses \"uuid\"","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"5ccbc52db5388d6c160d64ab4cb6d19154739ac0","unresolved":false,"context_lines":[{"line_number":968,"context_line":"        self,"},{"line_number":969,"context_line":"        node,"},{"line_number":970,"context_line":"        vif_id,"},{"line_number":971,"context_line":"        vif_port_uuid\u003dNone,"},{"line_number":972,"context_line":"        vif_portgroup_uuid\u003dNone,"},{"line_number":973,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":974,"context_line":"    ):"},{"line_number":975,"context_line":"        \"\"\"Attach a VIF to the node."}],"source_content_type":"text/x-python","patch_set":6,"id":"31224065_b3c0ad86","line":972,"range":{"start_line":971,"start_character":0,"end_line":972,"end_character":31},"in_reply_to":"79d75a7c_19849fbd","updated":"2024-07-03 13:44:34.000000000","message":"Done","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cd84001e9e2ebeabb110b87dfa529eff5a09f662","unresolved":true,"context_lines":[{"line_number":994,"context_line":"            does not support the VIF API."},{"line_number":995,"context_line":"        \"\"\""},{"line_number":996,"context_line":"        res \u003d self._get_resource(_node.Node, node)"},{"line_number":997,"context_line":"        if vif_port_id and vif_portgroup_id:"},{"line_number":998,"context_line":"            raise exceptions.SDKException("},{"line_number":999,"context_line":"                \"Only one of vif_port_id and vif_portgroup_id can be set.\""},{"line_number":1000,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":7,"id":"cbb39467_85ec57b4","line":997,"updated":"2024-07-08 15:19:45.000000000","message":"You already check this in attach_vif, not need to duplicate","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ed46b6d89aba8867a8cccbad833a26397fc4d114","unresolved":false,"context_lines":[{"line_number":994,"context_line":"            does not support the VIF API."},{"line_number":995,"context_line":"        \"\"\""},{"line_number":996,"context_line":"        res \u003d self._get_resource(_node.Node, node)"},{"line_number":997,"context_line":"        if vif_port_id and vif_portgroup_id:"},{"line_number":998,"context_line":"            raise exceptions.SDKException("},{"line_number":999,"context_line":"                \"Only one of vif_port_id and vif_portgroup_id can be set.\""},{"line_number":1000,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":7,"id":"e254c609_b90ad835","line":997,"in_reply_to":"cbb39467_85ec57b4","updated":"2024-07-09 13:04:54.000000000","message":"Done","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"8f95ab683e9a4973fcd84ae052390c2563008a28","unresolved":true,"context_lines":[{"line_number":986,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":987,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach"},{"line_number":988,"context_line":"            the VIF to."},{"line_number":989,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":990,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":991,"context_line":"            default value is True."},{"line_number":992,"context_line":"        :return: ``None``"}],"source_content_type":"text/x-python","patch_set":8,"id":"6e8a6225_d73a1e1c","line":989,"updated":"2024-07-10 13:03:11.000000000","message":"Looks like this statement belongs with the retry_on_conflict param.","commit_id":"f60bc4ab84493f8337d6831f37f3e2d974b5e39d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"599645caad6a5023527a942535bbf2734ce3ddeb","unresolved":false,"context_lines":[{"line_number":986,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":987,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach"},{"line_number":988,"context_line":"            the VIF to."},{"line_number":989,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":990,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":991,"context_line":"            default value is True."},{"line_number":992,"context_line":"        :return: ``None``"}],"source_content_type":"text/x-python","patch_set":8,"id":"7d041d9d_7b186533","line":989,"in_reply_to":"013e4d84_dc4cf38f","updated":"2024-07-11 14:40:48.000000000","message":"Done","commit_id":"f60bc4ab84493f8337d6831f37f3e2d974b5e39d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d3c723415074effd9d6ad2b299c510826806574","unresolved":true,"context_lines":[{"line_number":986,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":987,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach"},{"line_number":988,"context_line":"            the VIF to."},{"line_number":989,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":990,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":991,"context_line":"            default value is True."},{"line_number":992,"context_line":"        :return: ``None``"}],"source_content_type":"text/x-python","patch_set":8,"id":"013e4d84_dc4cf38f","line":989,"in_reply_to":"6e8a6225_d73a1e1c","updated":"2024-07-10 13:26:31.000000000","message":"+1","commit_id":"f60bc4ab84493f8337d6831f37f3e2d974b5e39d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":964,"context_line":"            _portgroup.PortGroup, port_group, ignore_missing\u003dignore_missing"},{"line_number":965,"context_line":"        )"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    def attach_vif_to_node("},{"line_number":968,"context_line":"        self,"},{"line_number":969,"context_line":"        node,"},{"line_number":970,"context_line":"        vif_id,"},{"line_number":971,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":972,"context_line":"        port_id\u003dNone,"},{"line_number":973,"context_line":"        port_group_id\u003dNone,"},{"line_number":974,"context_line":"    ):"},{"line_number":975,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        The exact form of the VIF ID depends on the network interface used by"}],"source_content_type":"text/x-python","patch_set":9,"id":"0b0d6c8a_44ff0304","line":974,"range":{"start_line":967,"start_character":0,"end_line":974,"end_character":6},"updated":"2024-07-12 08:58:03.000000000","message":"Also, rather than encoding the type information in the docstring, you could do it in the signature:\n\n```suggestion\n    def attach_vif_to_node(\n        self,\n        node: ty.Union[_node.Node, str],\n        vif_id: str,\n        retry_on_conflict: bool \u003d True,\n        *,\n        port_id: ty.Optional[str] \u003d None,\n        port_group_id: ty.Optional[str] \u003d None,\n    ):\n```\n\nEntirely up to you, but seeing as you need to tweak this...\n\n(PS: `ty` is the alias we use for `typing` to keep things short yet avoid importing objects)","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":964,"context_line":"            _portgroup.PortGroup, port_group, ignore_missing\u003dignore_missing"},{"line_number":965,"context_line":"        )"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    def attach_vif_to_node("},{"line_number":968,"context_line":"        self,"},{"line_number":969,"context_line":"        node,"},{"line_number":970,"context_line":"        vif_id,"},{"line_number":971,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":972,"context_line":"        port_id\u003dNone,"},{"line_number":973,"context_line":"        port_group_id\u003dNone,"},{"line_number":974,"context_line":"    ):"},{"line_number":975,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        The exact form of the VIF ID depends on the network interface used by"}],"source_content_type":"text/x-python","patch_set":9,"id":"5802516e_dd442f34","line":974,"range":{"start_line":967,"start_character":0,"end_line":974,"end_character":6},"updated":"2024-07-12 08:58:03.000000000","message":"Can you make these kwarg-only arguments? It allows us to change ordering freely down the line.\n\n```suggestion\n    def attach_vif_to_node(\n        self,\n        node,\n        vif_id,\n        retry_on_conflict\u003dTrue,\n        *,\n        port_id\u003dNone,\n        port_group_id\u003dNone,\n    ):\n```","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            _portgroup.PortGroup, port_group, ignore_missing\u003dignore_missing"},{"line_number":965,"context_line":"        )"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    def attach_vif_to_node("},{"line_number":968,"context_line":"        self,"},{"line_number":969,"context_line":"        node,"},{"line_number":970,"context_line":"        vif_id,"},{"line_number":971,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":972,"context_line":"        port_id\u003dNone,"},{"line_number":973,"context_line":"        port_group_id\u003dNone,"},{"line_number":974,"context_line":"    ):"},{"line_number":975,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        The exact form of the VIF ID depends on the network interface used by"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fac0173_761a6aed","line":974,"range":{"start_line":967,"start_character":0,"end_line":974,"end_character":6},"in_reply_to":"0b0d6c8a_44ff0304","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            _portgroup.PortGroup, port_group, ignore_missing\u003dignore_missing"},{"line_number":965,"context_line":"        )"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    def attach_vif_to_node("},{"line_number":968,"context_line":"        self,"},{"line_number":969,"context_line":"        node,"},{"line_number":970,"context_line":"        vif_id,"},{"line_number":971,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":972,"context_line":"        port_id\u003dNone,"},{"line_number":973,"context_line":"        port_group_id\u003dNone,"},{"line_number":974,"context_line":"    ):"},{"line_number":975,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        The exact form of the VIF ID depends on the network interface used by"}],"source_content_type":"text/x-python","patch_set":9,"id":"0d55b962_e7b2e633","line":974,"range":{"start_line":967,"start_character":0,"end_line":974,"end_character":6},"in_reply_to":"5802516e_dd442f34","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":986,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":987,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":988,"context_line":"            default value is True."},{"line_number":989,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":990,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach to."},{"line_number":991,"context_line":"        :return: ``None``"},{"line_number":992,"context_line":"        :raises: :exc:`~openstack.exceptions.NotSupported` if the server"}],"source_content_type":"text/x-python","patch_set":9,"id":"f7e83413_43a6ba6f","line":989,"updated":"2024-07-12 08:58:03.000000000","message":"If you encode type information as suggested above, you can drop it here.\n\n```suggestion\n        :param port_id: The UUID of the port to attach the VIF to.\n```","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":986,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":987,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":988,"context_line":"            default value is True."},{"line_number":989,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":990,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach to."},{"line_number":991,"context_line":"        :return: ``None``"},{"line_number":992,"context_line":"        :raises: :exc:`~openstack.exceptions.NotSupported` if the server"}],"source_content_type":"text/x-python","patch_set":9,"id":"42c4b444_efd7b780","line":989,"in_reply_to":"f7e83413_43a6ba6f","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f3770d5b0c17c243fd034c49ec0862a79cfc1748","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import typing as ty"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from openstack.baremetal.v1 import _common"},{"line_number":16,"context_line":"from openstack.baremetal.v1 import allocation as _allocation"}],"source_content_type":"text/x-python","patch_set":11,"id":"4ce2f6c7_01289f57","line":13,"updated":"2024-07-19 08:23:33.000000000","message":"nit: no need to shorten this, when importing entire modules leaving them explicit helps clarifying what that is and prevents confusing with other functions/modules","commit_id":"346756097714b93d389c52a2c280cbe766983ed8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a6b94a3c2bc92b2af7a9b3b1a3f061e0d1596da2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import typing as ty"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from openstack.baremetal.v1 import _common"},{"line_number":16,"context_line":"from openstack.baremetal.v1 import allocation as _allocation"}],"source_content_type":"text/x-python","patch_set":11,"id":"634240b5_c1044595","line":13,"in_reply_to":"4ce2f6c7_01289f57","updated":"2024-07-22 13:15:56.000000000","message":"while I do agree with this, the same pattern is already in place all across the existing code, so I think it should be fine to keep this consistent","commit_id":"346756097714b93d389c52a2c280cbe766983ed8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0c2d5b4d8f0475428cbe60fc5f4e73073bee87c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import typing as ty"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from openstack.baremetal.v1 import _common"},{"line_number":16,"context_line":"from openstack.baremetal.v1 import allocation as _allocation"}],"source_content_type":"text/x-python","patch_set":11,"id":"0dd0c619_2010db60","line":13,"in_reply_to":"634240b5_c1044595","updated":"2024-07-22 13:55:28.000000000","message":"Yeah, let\u0027s keep with `ty` like we\u0027ve done elsewhere. I think `typing` might end up being added to the [exception list](https://docs.openstack.org/hacking/latest/user/hacking.html#imports) for imports, which currently only includes `migrate`, `sqlalchemy` and `i18n`. Importing the library makes things too clunky looking, given the abundant use of variables from this module","commit_id":"346756097714b93d389c52a2c280cbe766983ed8"}],"openstack/baremetal/v1/node.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1d17f64af7e1f0ac357659cad382e55ad926048e","unresolved":true,"context_lines":[{"line_number":809,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":810,"context_line":"        :param string vif_id: Backend-specific VIF ID."},{"line_number":811,"context_line":"        :param string vif_port_uuid: The UUID of the port to attach the VIF to."},{"line_number":812,"context_line":"        :param string vif_portgroup_uuid: The UUID of the portgroup to attach the VIF to."},{"line_number":813,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":814,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":815,"context_line":"            the node is locked. Since the latter happens more often, the"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef12e258_f1f9aeb6","line":812,"updated":"2024-06-21 07:27:12.000000000","message":"here too","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"9b8b3ac0069f0010d9287f5c2cedd9cdde01fd28","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":810,"context_line":"        :param string vif_id: Backend-specific VIF ID."},{"line_number":811,"context_line":"        :param string vif_port_uuid: The UUID of the port to attach the VIF to."},{"line_number":812,"context_line":"        :param string vif_portgroup_uuid: The UUID of the portgroup to attach the VIF to."},{"line_number":813,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":814,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":815,"context_line":"            the node is locked. Since the latter happens more often, the"}],"source_content_type":"text/x-python","patch_set":2,"id":"af8e1cb0_017540a5","line":812,"in_reply_to":"ef12e258_f1f9aeb6","updated":"2024-06-25 08:47:38.000000000","message":"Done","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1d17f64af7e1f0ac357659cad382e55ad926048e","unresolved":true,"context_lines":[{"line_number":831,"context_line":"        body \u003d {\u0027id\u0027: vif_id}"},{"line_number":832,"context_line":"        if vif_port_uuid and vif_portgroup_uuid:"},{"line_number":833,"context_line":"            raise ValueError("},{"line_number":834,"context_line":"                \"Only one of vif_port_uuid and vif_portgroup_uuid can be provided\""},{"line_number":835,"context_line":"            )"},{"line_number":836,"context_line":"        if vif_port_uuid:"},{"line_number":837,"context_line":"            body[\u0027port_id\u0027] \u003d vif_port_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f46780a_80ad0a77","line":834,"updated":"2024-06-21 07:27:12.000000000","message":"weird that this was not caught by the pep8 test","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"9b8b3ac0069f0010d9287f5c2cedd9cdde01fd28","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        body \u003d {\u0027id\u0027: vif_id}"},{"line_number":832,"context_line":"        if vif_port_uuid and vif_portgroup_uuid:"},{"line_number":833,"context_line":"            raise ValueError("},{"line_number":834,"context_line":"                \"Only one of vif_port_uuid and vif_portgroup_uuid can be provided\""},{"line_number":835,"context_line":"            )"},{"line_number":836,"context_line":"        if vif_port_uuid:"},{"line_number":837,"context_line":"            body[\u0027port_id\u0027] \u003d vif_port_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f8eda19_857d4904","line":834,"in_reply_to":"7f46780a_80ad0a77","updated":"2024-06-25 08:47:38.000000000","message":"Done","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ba2556865036c4b3f9472dd1690f9b00ed34333e","unresolved":true,"context_lines":[{"line_number":836,"context_line":"        if vif_port_uuid and vif_portgroup_uuid:"},{"line_number":837,"context_line":"            raise ValueError(msg)"},{"line_number":838,"context_line":"        if vif_port_uuid:"},{"line_number":839,"context_line":"            body[\u0027port_id\u0027] \u003d vif_port_uuid"},{"line_number":840,"context_line":"        if vif_portgroup_uuid:"},{"line_number":841,"context_line":"            body[\u0027portgroup_id\u0027] \u003d vif_portgroup_uuid"},{"line_number":842,"context_line":"        retriable_status_codes \u003d _common.RETRIABLE_STATUS_CODES"}],"source_content_type":"text/x-python","patch_set":3,"id":"e425a0cc_eb0b9e4e","line":839,"updated":"2024-06-21 12:46:02.000000000","message":"You are setting a wrong option in the body, according to the API it should be port_uuid \n\nhttps://docs.openstack.org/api-ref/baremetal/#attach-a-vif-to-a-node","commit_id":"11feac5583ea4c0ea552a9b1fc207c68560b7b7b"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"9b8b3ac0069f0010d9287f5c2cedd9cdde01fd28","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        if vif_port_uuid and vif_portgroup_uuid:"},{"line_number":837,"context_line":"            raise ValueError(msg)"},{"line_number":838,"context_line":"        if vif_port_uuid:"},{"line_number":839,"context_line":"            body[\u0027port_id\u0027] \u003d vif_port_uuid"},{"line_number":840,"context_line":"        if vif_portgroup_uuid:"},{"line_number":841,"context_line":"            body[\u0027portgroup_id\u0027] \u003d vif_portgroup_uuid"},{"line_number":842,"context_line":"        retriable_status_codes \u003d _common.RETRIABLE_STATUS_CODES"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb9c9b9a_dcd0ceca","line":839,"in_reply_to":"e425a0cc_eb0b9e4e","updated":"2024-06-25 08:47:38.000000000","message":"Done","commit_id":"11feac5583ea4c0ea552a9b1fc207c68560b7b7b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ba2556865036c4b3f9472dd1690f9b00ed34333e","unresolved":true,"context_lines":[{"line_number":838,"context_line":"        if vif_port_uuid:"},{"line_number":839,"context_line":"            body[\u0027port_id\u0027] \u003d vif_port_uuid"},{"line_number":840,"context_line":"        if vif_portgroup_uuid:"},{"line_number":841,"context_line":"            body[\u0027portgroup_id\u0027] \u003d vif_portgroup_uuid"},{"line_number":842,"context_line":"        retriable_status_codes \u003d _common.RETRIABLE_STATUS_CODES"},{"line_number":843,"context_line":"        if not retry_on_conflict:"},{"line_number":844,"context_line":"            retriable_status_codes \u003d list(set(retriable_status_codes) - {409})"}],"source_content_type":"text/x-python","patch_set":3,"id":"e971a80b_eb9eeaca","line":841,"updated":"2024-06-21 12:46:02.000000000","message":"same problem here.","commit_id":"11feac5583ea4c0ea552a9b1fc207c68560b7b7b"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"9b8b3ac0069f0010d9287f5c2cedd9cdde01fd28","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        if vif_port_uuid:"},{"line_number":839,"context_line":"            body[\u0027port_id\u0027] \u003d vif_port_uuid"},{"line_number":840,"context_line":"        if vif_portgroup_uuid:"},{"line_number":841,"context_line":"            body[\u0027portgroup_id\u0027] \u003d vif_portgroup_uuid"},{"line_number":842,"context_line":"        retriable_status_codes \u003d _common.RETRIABLE_STATUS_CODES"},{"line_number":843,"context_line":"        if not retry_on_conflict:"},{"line_number":844,"context_line":"            retriable_status_codes \u003d list(set(retriable_status_codes) - {409})"}],"source_content_type":"text/x-python","patch_set":3,"id":"807f461d_5be94c3f","line":841,"in_reply_to":"e971a80b_eb9eeaca","updated":"2024-06-25 08:47:38.000000000","message":"Done","commit_id":"11feac5583ea4c0ea552a9b1fc207c68560b7b7b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4e169f1bf9f5aa98d7bf5659c3db9030e6c04d93","unresolved":true,"context_lines":[{"line_number":810,"context_line":"        :param string vif_id: Backend-specific VIF ID."},{"line_number":811,"context_line":"        :param string vif_port_uuid: The UUID of the port to attach the VIF to."},{"line_number":812,"context_line":"        :param string vif_portgroup_uuid: The UUID of the portgroup to attach"},{"line_number":813,"context_line":"        the VIF to."},{"line_number":814,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":815,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":816,"context_line":"            the node is locked. Since the latter happens more often, the"}],"source_content_type":"text/x-python","patch_set":4,"id":"a978088d_3bc2e808","line":813,"updated":"2024-06-25 11:38:05.000000000","message":"you need to ident here, otherwise tox -e docs will fail \u003d)","commit_id":"3573642b0d05081c6eb7a08d630723344a5c4b74"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"146f6463197b41c6a0bc31da368a4c30489a4f9c","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        :param string vif_id: Backend-specific VIF ID."},{"line_number":811,"context_line":"        :param string vif_port_uuid: The UUID of the port to attach the VIF to."},{"line_number":812,"context_line":"        :param string vif_portgroup_uuid: The UUID of the portgroup to attach"},{"line_number":813,"context_line":"        the VIF to."},{"line_number":814,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":815,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":816,"context_line":"            the node is locked. Since the latter happens more often, the"}],"source_content_type":"text/x-python","patch_set":4,"id":"3d132590_e55eb9b5","line":813,"in_reply_to":"a978088d_3bc2e808","updated":"2024-06-26 04:13:46.000000000","message":"Done","commit_id":"3573642b0d05081c6eb7a08d630723344a5c4b74"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac21ced9c0b920f0bbd94a37b91a9a0dcf0eb965","unresolved":true,"context_lines":[{"line_number":794,"context_line":"        self,"},{"line_number":795,"context_line":"        session,"},{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        vif_port_uuid\u003dNone,"},{"line_number":798,"context_line":"        vif_portgroup_uuid\u003dNone,"},{"line_number":799,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."}],"source_content_type":"text/x-python","patch_set":6,"id":"fab691fe_35315ddc","line":798,"range":{"start_line":797,"start_character":1,"end_line":798,"end_character":32},"updated":"2024-07-01 12:58:50.000000000","message":"Same about s/uuid/id/","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"5ccbc52db5388d6c160d64ab4cb6d19154739ac0","unresolved":false,"context_lines":[{"line_number":794,"context_line":"        self,"},{"line_number":795,"context_line":"        session,"},{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        vif_port_uuid\u003dNone,"},{"line_number":798,"context_line":"        vif_portgroup_uuid\u003dNone,"},{"line_number":799,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."}],"source_content_type":"text/x-python","patch_set":6,"id":"76778f6d_26b2d4b4","line":798,"range":{"start_line":797,"start_character":1,"end_line":798,"end_character":32},"in_reply_to":"fab691fe_35315ddc","updated":"2024-07-03 13:44:34.000000000","message":"Done","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac21ced9c0b920f0bbd94a37b91a9a0dcf0eb965","unresolved":true,"context_lines":[{"line_number":834,"context_line":"            \"Only one of vif_port_uuid and vif_portgroup_uuid can be provided\""},{"line_number":835,"context_line":"        )"},{"line_number":836,"context_line":"        if vif_port_uuid and vif_portgroup_uuid:"},{"line_number":837,"context_line":"            raise exceptions.InvalidRequest"},{"line_number":838,"context_line":"        if vif_port_uuid:"},{"line_number":839,"context_line":"            body[\u0027port_uuid\u0027] \u003d vif_port_uuid"},{"line_number":840,"context_line":"        if vif_portgroup_uuid:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0002ba_3a792b9f","line":837,"updated":"2024-07-01 12:58:50.000000000","message":"I think you meant to pass \"msg\" to the exception?","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"5ccbc52db5388d6c160d64ab4cb6d19154739ac0","unresolved":false,"context_lines":[{"line_number":834,"context_line":"            \"Only one of vif_port_uuid and vif_portgroup_uuid can be provided\""},{"line_number":835,"context_line":"        )"},{"line_number":836,"context_line":"        if vif_port_uuid and vif_portgroup_uuid:"},{"line_number":837,"context_line":"            raise exceptions.InvalidRequest"},{"line_number":838,"context_line":"        if vif_port_uuid:"},{"line_number":839,"context_line":"            body[\u0027port_uuid\u0027] \u003d vif_port_uuid"},{"line_number":840,"context_line":"        if vif_portgroup_uuid:"}],"source_content_type":"text/x-python","patch_set":6,"id":"0dab450e_636d4e5e","line":837,"in_reply_to":"da0002ba_3a792b9f","updated":"2024-07-03 13:44:34.000000000","message":"Done","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac21ced9c0b920f0bbd94a37b91a9a0dcf0eb965","unresolved":true,"context_lines":[{"line_number":846,"context_line":"            request.url,"},{"line_number":847,"context_line":"            json\u003dbody,"},{"line_number":848,"context_line":"            headers\u003drequest.headers,"},{"line_number":849,"context_line":"            microversion\u003dversion,"},{"line_number":850,"context_line":"            retriable_status_codes\u003dretriable_status_codes,"},{"line_number":851,"context_line":"        )"},{"line_number":852,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbdf0d4_5baf1058","line":849,"updated":"2024-07-01 12:58:50.000000000","message":"Per https://docs.openstack.org/ironic/latest/contributor/webapi-version-history.html#victoria-15-1, this feature was added in API version 1.67, but this code currently requires the minimum of VIF_VERSION, which is 1.28. If the new parameters are provided, you need a higher minimum (probably modify the logic on line 823).","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"5ccbc52db5388d6c160d64ab4cb6d19154739ac0","unresolved":false,"context_lines":[{"line_number":846,"context_line":"            request.url,"},{"line_number":847,"context_line":"            json\u003dbody,"},{"line_number":848,"context_line":"            headers\u003drequest.headers,"},{"line_number":849,"context_line":"            microversion\u003dversion,"},{"line_number":850,"context_line":"            retriable_status_codes\u003dretriable_status_codes,"},{"line_number":851,"context_line":"        )"},{"line_number":852,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4cec818e_7109bb75","line":849,"in_reply_to":"dfbdf0d4_5baf1058","updated":"2024-07-03 13:44:34.000000000","message":"Done","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cd84001e9e2ebeabb110b87dfa529eff5a09f662","unresolved":true,"context_lines":[{"line_number":795,"context_line":"        session,"},{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        vif_port_id\u003dNone,"},{"line_number":798,"context_line":"        vif_portgroup_id\u003dNone,"},{"line_number":799,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."}],"source_content_type":"text/x-python","patch_set":7,"id":"e1b9e773_17a6ba47","line":798,"updated":"2024-07-08 15:19:45.000000000","message":"By the way, why prefix the new arguments with vif_? The original API does not have it, and the context is quite clear. Maybe just use port_id and portgroup_id?\n\nBy the way, we seem to be using port_group, not portgroup, here in the SDK.","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ed46b6d89aba8867a8cccbad833a26397fc4d114","unresolved":false,"context_lines":[{"line_number":795,"context_line":"        session,"},{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        vif_port_id\u003dNone,"},{"line_number":798,"context_line":"        vif_portgroup_id\u003dNone,"},{"line_number":799,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."}],"source_content_type":"text/x-python","patch_set":7,"id":"696c87c3_5a995cb8","line":798,"in_reply_to":"e1b9e773_17a6ba47","updated":"2024-07-09 13:04:54.000000000","message":"Done","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cd84001e9e2ebeabb110b87dfa529eff5a09f662","unresolved":true,"context_lines":[{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        vif_port_id\u003dNone,"},{"line_number":798,"context_line":"        vif_portgroup_id\u003dNone,"},{"line_number":799,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a23b017d_2a3bcf85","line":799,"updated":"2024-07-08 15:19:45.000000000","message":"Although I hope never does it, in reality someone may be calling this function as attach_vif(session, vif_id, False) right now. Your change breaks it in a confusing way. I suggest adding new arguments to the end.","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ed46b6d89aba8867a8cccbad833a26397fc4d114","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        vif_port_id\u003dNone,"},{"line_number":798,"context_line":"        vif_portgroup_id\u003dNone,"},{"line_number":799,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"0b257dc6_e9917910","line":799,"in_reply_to":"a23b017d_2a3bcf85","updated":"2024-07-09 13:04:54.000000000","message":"Done","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cd84001e9e2ebeabb110b87dfa529eff5a09f662","unresolved":true,"context_lines":[{"line_number":827,"context_line":"            error_message\u003d(\"Cannot use VIF attachment API\"),"},{"line_number":828,"context_line":"        )"},{"line_number":829,"context_line":"        if vif_port_id or vif_portgroup_id:"},{"line_number":830,"context_line":"            version \u003d self._assert_microversion_for("},{"line_number":831,"context_line":"                session,"},{"line_number":832,"context_line":"                \u0027commit\u0027,"},{"line_number":833,"context_line":"                _common.VIF_OPTIONAL_PARAMS_VERSION,"}],"source_content_type":"text/x-python","patch_set":7,"id":"f9c5d83b_7f2de5ec","line":830,"updated":"2024-07-08 15:19:45.000000000","message":"You shouldn\u0027t call assert_microversion_for twice, once per variant is enough","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ed46b6d89aba8867a8cccbad833a26397fc4d114","unresolved":false,"context_lines":[{"line_number":827,"context_line":"            error_message\u003d(\"Cannot use VIF attachment API\"),"},{"line_number":828,"context_line":"        )"},{"line_number":829,"context_line":"        if vif_port_id or vif_portgroup_id:"},{"line_number":830,"context_line":"            version \u003d self._assert_microversion_for("},{"line_number":831,"context_line":"                session,"},{"line_number":832,"context_line":"                \u0027commit\u0027,"},{"line_number":833,"context_line":"                _common.VIF_OPTIONAL_PARAMS_VERSION,"}],"source_content_type":"text/x-python","patch_set":7,"id":"82ca6df6_a7b49b63","line":830,"in_reply_to":"f9c5d83b_7f2de5ec","updated":"2024-07-09 13:04:54.000000000","message":"Done","commit_id":"00ecbd28c2036efb96e8b96691bd766796d44801"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"8f95ab683e9a4973fcd84ae052390c2563008a28","unresolved":true,"context_lines":[{"line_number":812,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":813,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach"},{"line_number":814,"context_line":"            the VIF to."},{"line_number":815,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":816,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":817,"context_line":"            default value is True."},{"line_number":818,"context_line":"        :return: ``None``"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aac0922_8814b491","line":815,"updated":"2024-07-10 13:03:11.000000000","message":"Same here.","commit_id":"f60bc4ab84493f8337d6831f37f3e2d974b5e39d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"599645caad6a5023527a942535bbf2734ce3ddeb","unresolved":false,"context_lines":[{"line_number":812,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":813,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach"},{"line_number":814,"context_line":"            the VIF to."},{"line_number":815,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":816,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":817,"context_line":"            default value is True."},{"line_number":818,"context_line":"        :return: ``None``"}],"source_content_type":"text/x-python","patch_set":8,"id":"ef91a4df_24f3c9e3","line":815,"in_reply_to":"7aac0922_8814b491","updated":"2024-07-11 14:40:48.000000000","message":"Done","commit_id":"f60bc4ab84493f8337d6831f37f3e2d974b5e39d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":790,"context_line":"        if wait:"},{"line_number":791,"context_line":"            self.wait_for_power_state(session, expected, timeout\u003dtimeout)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def attach_vif("},{"line_number":794,"context_line":"        self,"},{"line_number":795,"context_line":"        session,"},{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":798,"context_line":"        port_id\u003dNone,"},{"line_number":799,"context_line":"        port_group_id\u003dNone,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        The exact form of the VIF ID depends on the network interface used by"}],"source_content_type":"text/x-python","patch_set":9,"id":"58c5bd9d_63ca192e","line":800,"range":{"start_line":793,"start_character":0,"end_line":800,"end_character":6},"updated":"2024-07-12 08:58:03.000000000","message":"Same comments around using kwarg-only arguments and potentially adding typing.\n\n```suggestion\n    def attach_vif(\n        self,\n        session: adapter.Adapter,\n        vif_id: str,\n        retry_on_conflict: bool \u003d True,\n        port_id: ty.Optional[str] \u003d None,\n        port_group_id: ty.Optional[str] \u003d None,\n    ) -\u003e None:\n```\n\n(`adapter` is from `keystoneauth1` and, as before, `ty` is the alias we use for `typing` to keep things short yet avoid importing objects)","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":790,"context_line":"        if wait:"},{"line_number":791,"context_line":"            self.wait_for_power_state(session, expected, timeout\u003dtimeout)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def attach_vif("},{"line_number":794,"context_line":"        self,"},{"line_number":795,"context_line":"        session,"},{"line_number":796,"context_line":"        vif_id,"},{"line_number":797,"context_line":"        retry_on_conflict\u003dTrue,"},{"line_number":798,"context_line":"        port_id\u003dNone,"},{"line_number":799,"context_line":"        port_group_id\u003dNone,"},{"line_number":800,"context_line":"    ):"},{"line_number":801,"context_line":"        \"\"\"Attach a VIF to the node."},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        The exact form of the VIF ID depends on the network interface used by"}],"source_content_type":"text/x-python","patch_set":9,"id":"329bca04_17e64ad2","line":800,"range":{"start_line":793,"start_character":0,"end_line":800,"end_character":6},"in_reply_to":"58c5bd9d_63ca192e","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":812,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":813,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":814,"context_line":"            default value is True."},{"line_number":815,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":816,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach to."},{"line_number":817,"context_line":"        :return: ``None``"},{"line_number":818,"context_line":"        :raises: :exc:`~openstack.exceptions.NotSupported` if the server"}],"source_content_type":"text/x-python","patch_set":9,"id":"62acb3fb_d8fe6281","line":815,"updated":"2024-07-12 08:58:03.000000000","message":"Do you want to add a note indicating that you can only set this or `port_group_id` (XOR)? Ditto for `port_group_id` and the docstring in proxy API.","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            This can happen when either the VIF is already used on a node or"},{"line_number":813,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":814,"context_line":"            default value is True."},{"line_number":815,"context_line":"        :param string port_id: The UUID of the port to attach the VIF to."},{"line_number":816,"context_line":"        :param string port_group_id: The UUID of the portgroup to attach to."},{"line_number":817,"context_line":"        :return: ``None``"},{"line_number":818,"context_line":"        :raises: :exc:`~openstack.exceptions.NotSupported` if the server"}],"source_content_type":"text/x-python","patch_set":9,"id":"b2d17a37_4debe323","line":815,"in_reply_to":"62acb3fb_d8fe6281","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":835,"context_line":"        body \u003d {\u0027id\u0027: vif_id}"},{"line_number":836,"context_line":"        msg \u003d \"Only one of vif_port_id and vif_portgroup_id can be provided\""},{"line_number":837,"context_line":"        if port_id and port_group_id:"},{"line_number":838,"context_line":"            raise exceptions.InvalidRequest(msg)"},{"line_number":839,"context_line":"        if port_id:"},{"line_number":840,"context_line":"            body[\u0027port_uuid\u0027] \u003d port_id"},{"line_number":841,"context_line":"        if port_group_id:"}],"source_content_type":"text/x-python","patch_set":9,"id":"17471efb_13f3025f","line":838,"updated":"2024-07-12 08:58:03.000000000","message":"Any reason we do this so late? This feels like something we should do at the very top of the method before any other (potentially much more expensive) logic.","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        body \u003d {\u0027id\u0027: vif_id}"},{"line_number":836,"context_line":"        msg \u003d \"Only one of vif_port_id and vif_portgroup_id can be provided\""},{"line_number":837,"context_line":"        if port_id and port_group_id:"},{"line_number":838,"context_line":"            raise exceptions.InvalidRequest(msg)"},{"line_number":839,"context_line":"        if port_id:"},{"line_number":840,"context_line":"            body[\u0027port_uuid\u0027] \u003d port_id"},{"line_number":841,"context_line":"        if port_group_id:"}],"source_content_type":"text/x-python","patch_set":9,"id":"408c5a99_0509783a","line":838,"in_reply_to":"17471efb_13f3025f","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a481b180945c3e95450cbf6ce655982fee31db3","unresolved":true,"context_lines":[{"line_number":824,"context_line":"        :raises: :exc:`~openstack.exceptions.InvalidRequest` if both port_id"},{"line_number":825,"context_line":"            and port_group_id are provided."},{"line_number":826,"context_line":"        \"\"\""},{"line_number":827,"context_line":"        msg \u003d \"Only one of vif_port_id and vif_portgroup_id can be provided\""},{"line_number":828,"context_line":"        if port_id and port_group_id:"},{"line_number":829,"context_line":"            raise exceptions.InvalidRequest(msg)"},{"line_number":830,"context_line":"        session \u003d self._get_session(session)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9e9c9dca_f76873b4","line":827,"updated":"2024-07-16 11:29:26.000000000","message":"nit: Can you move this into the `if` block for scoping","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ce4bbb3d2af806041e17a22a389ef7fd3fe68b5","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        :raises: :exc:`~openstack.exceptions.InvalidRequest` if both port_id"},{"line_number":825,"context_line":"            and port_group_id are provided."},{"line_number":826,"context_line":"        \"\"\""},{"line_number":827,"context_line":"        msg \u003d \"Only one of vif_port_id and vif_portgroup_id can be provided\""},{"line_number":828,"context_line":"        if port_id and port_group_id:"},{"line_number":829,"context_line":"            raise exceptions.InvalidRequest(msg)"},{"line_number":830,"context_line":"        session \u003d self._get_session(session)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5d694b84_00d8465d","line":827,"in_reply_to":"9e9c9dca_f76873b4","updated":"2024-07-16 11:31:16.000000000","message":"Done","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a481b180945c3e95450cbf6ce655982fee31db3","unresolved":true,"context_lines":[{"line_number":844,"context_line":"        body \u003d {\u0027id\u0027: vif_id}"},{"line_number":845,"context_line":"        if port_id:"},{"line_number":846,"context_line":"            body[\u0027port_uuid\u0027] \u003d port_id"},{"line_number":847,"context_line":"        if port_group_id:"},{"line_number":848,"context_line":"            body[\u0027portgroup_uuid\u0027] \u003d port_group_id"},{"line_number":849,"context_line":"        retriable_status_codes \u003d _common.RETRIABLE_STATUS_CODES"},{"line_number":850,"context_line":"        if not retry_on_conflict:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ad7bb45c_26a5cf15","line":847,"updated":"2024-07-16 11:29:26.000000000","message":"nit:\n\n```suggestion\n        elif port_group_id:\n```","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ce4bbb3d2af806041e17a22a389ef7fd3fe68b5","unresolved":false,"context_lines":[{"line_number":844,"context_line":"        body \u003d {\u0027id\u0027: vif_id}"},{"line_number":845,"context_line":"        if port_id:"},{"line_number":846,"context_line":"            body[\u0027port_uuid\u0027] \u003d port_id"},{"line_number":847,"context_line":"        if port_group_id:"},{"line_number":848,"context_line":"            body[\u0027portgroup_uuid\u0027] \u003d port_group_id"},{"line_number":849,"context_line":"        retriable_status_codes \u003d _common.RETRIABLE_STATUS_CODES"},{"line_number":850,"context_line":"        if not retry_on_conflict:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ce3a736_ae09306f","line":847,"in_reply_to":"ad7bb45c_26a5cf15","updated":"2024-07-16 11:31:16.000000000","message":"Done","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f3770d5b0c17c243fd034c49ec0862a79cfc1748","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import collections"},{"line_number":14,"context_line":"import enum"},{"line_number":15,"context_line":"import typing as ty"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstack.baremetal.v1 import _common"},{"line_number":18,"context_line":"from openstack import exceptions"}],"source_content_type":"text/x-python","patch_set":11,"id":"4a836cc3_b3daa90a","line":15,"updated":"2024-07-19 08:23:33.000000000","message":"ditto","commit_id":"346756097714b93d389c52a2c280cbe766983ed8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0c2d5b4d8f0475428cbe60fc5f4e73073bee87c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import collections"},{"line_number":14,"context_line":"import enum"},{"line_number":15,"context_line":"import typing as ty"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstack.baremetal.v1 import _common"},{"line_number":18,"context_line":"from openstack import exceptions"}],"source_content_type":"text/x-python","patch_set":11,"id":"f122c550_eae38929","line":15,"in_reply_to":"4a836cc3_b3daa90a","updated":"2024-07-22 13:55:28.000000000","message":"Ditto","commit_id":"346756097714b93d389c52a2c280cbe766983ed8"}],"openstack/tests/unit/baremetal/v1/test_node.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b74b709e3c3aaebe3beacbbcd56903709ae4e0a2","unresolved":true,"context_lines":[{"line_number":564,"context_line":"            id\u003d\u0027c29db401-b6a7-4530-af8e-20a720dee946\u0027, driver\u003dFAKE[\u0027driver\u0027]"},{"line_number":565,"context_line":"        )"},{"line_number":566,"context_line":"        self.vif_id \u003d \u0027714bdf6d-2386-4b5e-bd0d-bc036f04b1ef\u0027"},{"line_number":567,"context_line":"        self.vif_port_uuid \u003d \u0027port-uuid\u0027"},{"line_number":568,"context_line":"        self.vif_portgroup_uuid \u003d \u0027portgroup-uuid\u0027"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_attach_vif(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ee2dd7f_ebba60f8","line":567,"updated":"2024-06-27 11:20:01.000000000","message":"worth using an uuid","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f69d9e6f2d4996f0453a7c1ca561feea561b94d2","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            id\u003d\u0027c29db401-b6a7-4530-af8e-20a720dee946\u0027, driver\u003dFAKE[\u0027driver\u0027]"},{"line_number":565,"context_line":"        )"},{"line_number":566,"context_line":"        self.vif_id \u003d \u0027714bdf6d-2386-4b5e-bd0d-bc036f04b1ef\u0027"},{"line_number":567,"context_line":"        self.vif_port_uuid \u003d \u0027port-uuid\u0027"},{"line_number":568,"context_line":"        self.vif_portgroup_uuid \u003d \u0027portgroup-uuid\u0027"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_attach_vif(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ecfa6193_c78ea931","line":567,"in_reply_to":"9ee2dd7f_ebba60f8","updated":"2024-07-05 12:30:59.000000000","message":"we do the same in ironic tests, so I\u0027m marking this as Resolved","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b74b709e3c3aaebe3beacbbcd56903709ae4e0a2","unresolved":true,"context_lines":[{"line_number":565,"context_line":"        )"},{"line_number":566,"context_line":"        self.vif_id \u003d \u0027714bdf6d-2386-4b5e-bd0d-bc036f04b1ef\u0027"},{"line_number":567,"context_line":"        self.vif_port_uuid \u003d \u0027port-uuid\u0027"},{"line_number":568,"context_line":"        self.vif_portgroup_uuid \u003d \u0027portgroup-uuid\u0027"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_attach_vif(self):"},{"line_number":571,"context_line":"        self.assertIsNone(self.node.attach_vif(self.session, self.vif_id))"}],"source_content_type":"text/x-python","patch_set":6,"id":"8acd1396_8d398502","line":568,"updated":"2024-06-27 11:20:01.000000000","message":"ditto","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f69d9e6f2d4996f0453a7c1ca561feea561b94d2","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        )"},{"line_number":566,"context_line":"        self.vif_id \u003d \u0027714bdf6d-2386-4b5e-bd0d-bc036f04b1ef\u0027"},{"line_number":567,"context_line":"        self.vif_port_uuid \u003d \u0027port-uuid\u0027"},{"line_number":568,"context_line":"        self.vif_portgroup_uuid \u003d \u0027portgroup-uuid\u0027"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_attach_vif(self):"},{"line_number":571,"context_line":"        self.assertIsNone(self.node.attach_vif(self.session, self.vif_id))"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d3e33f2_1a2bdb8f","line":568,"in_reply_to":"8acd1396_8d398502","updated":"2024-07-05 12:30:59.000000000","message":"ditto","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac21ced9c0b920f0bbd94a37b91a9a0dcf0eb965","unresolved":true,"context_lines":[{"line_number":601,"context_line":"            \u0027nodes/%s/vifs\u0027 % self.node.id,"},{"line_number":602,"context_line":"            json\u003d{\u0027id\u0027: self.vif_id, \u0027port_uuid\u0027: self.vif_port_uuid},"},{"line_number":603,"context_line":"            headers\u003dmock.ANY,"},{"line_number":604,"context_line":"            microversion\u003d\u00271.28\u0027,"},{"line_number":605,"context_line":"            retriable_status_codes\u003d[409, 503],"},{"line_number":606,"context_line":"        )"},{"line_number":607,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d3e97aff_83ce93af","line":604,"updated":"2024-07-01 12:58:50.000000000","message":"This is invalid: the version 1.28 did not have these parameters (see my comment in node.py).","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"5ccbc52db5388d6c160d64ab4cb6d19154739ac0","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            \u0027nodes/%s/vifs\u0027 % self.node.id,"},{"line_number":602,"context_line":"            json\u003d{\u0027id\u0027: self.vif_id, \u0027port_uuid\u0027: self.vif_port_uuid},"},{"line_number":603,"context_line":"            headers\u003dmock.ANY,"},{"line_number":604,"context_line":"            microversion\u003d\u00271.28\u0027,"},{"line_number":605,"context_line":"            retriable_status_codes\u003d[409, 503],"},{"line_number":606,"context_line":"        )"},{"line_number":607,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f59681e5_699b11a3","line":604,"in_reply_to":"d3e97aff_83ce93af","updated":"2024-07-03 13:44:34.000000000","message":"Done","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac21ced9c0b920f0bbd94a37b91a9a0dcf0eb965","unresolved":true,"context_lines":[{"line_number":620,"context_line":"                \u0027portgroup_uuid\u0027: self.vif_portgroup_uuid,"},{"line_number":621,"context_line":"            },"},{"line_number":622,"context_line":"            headers\u003dmock.ANY,"},{"line_number":623,"context_line":"            microversion\u003d\u00271.28\u0027,"},{"line_number":624,"context_line":"            retriable_status_codes\u003d[409, 503],"},{"line_number":625,"context_line":"        )"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"6245eb1a_6bccf0f1","line":623,"updated":"2024-07-01 12:58:50.000000000","message":"same","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"5ccbc52db5388d6c160d64ab4cb6d19154739ac0","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                \u0027portgroup_uuid\u0027: self.vif_portgroup_uuid,"},{"line_number":621,"context_line":"            },"},{"line_number":622,"context_line":"            headers\u003dmock.ANY,"},{"line_number":623,"context_line":"            microversion\u003d\u00271.28\u0027,"},{"line_number":624,"context_line":"            retriable_status_codes\u003d[409, 503],"},{"line_number":625,"context_line":"        )"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a54c32a_bb532891","line":623,"in_reply_to":"6245eb1a_6bccf0f1","updated":"2024-07-03 13:44:34.000000000","message":"Done","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"}],"releasenotes/notes/add-vif-optional-params-abb755b74f076eb2.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1d17f64af7e1f0ac357659cad382e55ad926048e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change extends the `attach_vif` and `attach_vif_to_node` methods to accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"13210bfa_99cf3f3f","line":4,"updated":"2024-06-21 07:27:12.000000000","message":"use multiple lines here too","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"9b8b3ac0069f0010d9287f5c2cedd9cdde01fd28","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change extends the `attach_vif` and `attach_vif_to_node` methods to accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3d32fccf_ed1a0202","line":4,"in_reply_to":"13210bfa_99cf3f3f","updated":"2024-06-25 08:47:38.000000000","message":"Done","commit_id":"2a103f58cb74076ab4f5e2bc44f2b37875a9d939"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac21ced9c0b920f0bbd94a37b91a9a0dcf0eb965","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change extends the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"26835952_01758e04","line":4,"updated":"2024-07-01 12:58:50.000000000","message":"The final page won\u0027t have any reference to \"This change\" (this is how it looks https://docs.openstack.org/releasenotes/openstacksdk/unreleased.html). Just drop \"This change\" and start with \"Extend\".","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"5ccbc52db5388d6c160d64ab4cb6d19154739ac0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change extends the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"21cc2fd8_a07508f8","line":4,"in_reply_to":"26835952_01758e04","updated":"2024-07-03 13:44:34.000000000","message":"Done","commit_id":"113f217fc46e84311b098363fe17c24d461119d0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4c5015f1_c95060d1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2024-07-12 08:58:03.000000000","message":"```suggestion\nfeatures:\n```\n\nThis is a wholly new feature rather than a bugfix on an existing feature.","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"89c85f52_ea58c72b","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"4c5015f1_c95060d1","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6fe20dbf_d7479212","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":52},"updated":"2024-07-12 08:58:03.000000000","message":"```suggestion\n    Extend the ``attach_vif`` and ``attach_vif_to_node`` methods of the\n    baremetal proxy to\n```\n\nThe methods of what?\n\nAlso this is reStructuredText (rST) rather than Markdown. rST uses double backticks for code and single backticks for the \"default role\" (which I think is _italics_ unless configured otherwise)","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"2eeff831_22890ca4","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":52},"in_reply_to":"6fe20dbf_d7479212","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31add820588e274dd5dd2195b33989a35fc279c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a9809754_758e714e","line":6,"updated":"2024-07-12 08:58:03.000000000","message":"nit: Can you drop the unnecessary extra newline","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"4438ac29228d0cc0cc893b0651bb2f14af5a4e9f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the `attach_vif` and `attach_vif_to_node` methods to"},{"line_number":5,"context_line":"    accept optional parameters for VIF port UUID and VIF portgroup UUID."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b1a72464_c9689391","line":6,"in_reply_to":"a9809754_758e714e","updated":"2024-07-15 11:46:50.000000000","message":"Done","commit_id":"56236d6fb778964ca50a69cda43812e1f7e2deca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a481b180945c3e95450cbf6ce655982fee31db3","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the ``attach_vif`` and ``attach_vif_to_node`` methods of the"},{"line_number":5,"context_line":"    baremetal proxy to to accept optional parameters for VIF port UUID and"},{"line_number":6,"context_line":"    VIF portgroup UUID."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"cfe09d69_d9c0d0b2","line":6,"updated":"2024-07-16 11:29:26.000000000","message":"nit: you need *a* trailing newline here, just not two 😄","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ce4bbb3d2af806041e17a22a389ef7fd3fe68b5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Extend the ``attach_vif`` and ``attach_vif_to_node`` methods of the"},{"line_number":5,"context_line":"    baremetal proxy to to accept optional parameters for VIF port UUID and"},{"line_number":6,"context_line":"    VIF portgroup UUID."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"8f8c90e1_245d5b47","line":6,"in_reply_to":"cfe09d69_d9c0d0b2","updated":"2024-07-16 11:31:16.000000000","message":"Done","commit_id":"afe0f0baa26f38ad215751028b98ae0470945b52"}]}