)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"528a63b9c862e90a2a2c21542c0c77457b7c0af1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ef03946f_26451f46","updated":"2024-06-25 12:35:48.000000000","message":"pep8 error is legit","commit_id":"a04b97a3e490343860a74ea54e8b50773756637c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"68034736259b7bc2063882d6b8381114412fec50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cb1b6840_c3e8553a","updated":"2024-06-26 07:58:22.000000000","message":"recheck hiccup?","commit_id":"312b66e9c75adc6f8a9f3ad69b4ab435612211f4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"55e7ddbb663a9a05bac1c9261a69ca7bfd448671","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dfa209c7_f8b26a4f","updated":"2024-07-04 13:15:57.000000000","message":"looks good, just one minor thing if you have time","commit_id":"eeac87d5d0c9b6d4711c9ec678e4c859ae639ea9"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"1834acdf6d723aaf435fdbbcad2d64103381e206","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f8570683_5f7a1b9c","updated":"2024-07-03 17:39:29.000000000","message":"recheck unrelated failure","commit_id":"eeac87d5d0c9b6d4711c9ec678e4c859ae639ea9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f23cf0a79fed10ef161e43882d0a3ea7046c855f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5358c379_1f4dd0eb","updated":"2024-07-23 12:41:57.000000000","message":"Also merge conflict.","commit_id":"b9ad334e38aef32fa13ded4ceb490292e40ce345"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"def1a71f1b244fb9f1e6f87b5392d749aa529688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b2547cd9_00387a47","updated":"2025-04-04 15:32:09.000000000","message":"Fixed the docs job failure","commit_id":"873e5a899e4a92bfc53a9e8a2c1b77d0cc551651"}],"openstack/baremetal/v1/_common.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bdb1025beaf962218051e53341c3a829f25f711","unresolved":true,"context_lines":[{"line_number":70,"context_line":"VIF_VERSION \u003d \u00271.28\u0027"},{"line_number":71,"context_line":"\"\"\"API version in which the VIF operations were introduced.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"VMEDIA_VERSION \u003d \u00271.89\u0027"},{"line_number":74,"context_line":"\"\"\"API version in which the virtual media operations were introduced.\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"INJECT_NMI_VERSION \u003d \u00271.29\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"93621671_7c02053d","line":73,"updated":"2024-07-08 15:23:05.000000000","message":"Please add to the end to keep the versions more or less sorted","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"216a1d78e12c8fcbe0a028068f52d471e9d96191","unresolved":false,"context_lines":[{"line_number":70,"context_line":"VIF_VERSION \u003d \u00271.28\u0027"},{"line_number":71,"context_line":"\"\"\"API version in which the VIF operations were introduced.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"VMEDIA_VERSION \u003d \u00271.89\u0027"},{"line_number":74,"context_line":"\"\"\"API version in which the virtual media operations were introduced.\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"INJECT_NMI_VERSION \u003d \u00271.29\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"98c10116_97a41a8a","line":73,"in_reply_to":"93621671_7c02053d","updated":"2024-07-13 12:28:31.000000000","message":"Done","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"}],"openstack/baremetal/v1/_proxy.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0995fc6d7edd53bf81677966eb2ba01557b1bb64","unresolved":true,"context_lines":[{"line_number":980,"context_line":"        :param image_url: The URL of the image to attach."},{"line_number":981,"context_line":"        :param image_download_source: The source of the image download."},{"line_number":982,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":983,"context_line":"            This can happen when either the virtual media is already used on a node or"},{"line_number":984,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":985,"context_line":"            default value is True."},{"line_number":986,"context_line":"        :return: ``None``"}],"source_content_type":"text/x-python","patch_set":6,"id":"ac654b36_74bf3f55","line":983,"updated":"2024-06-21 07:27:43.000000000","message":"let\u0027s stay below 80 characters per line, here and in the rest of the patch","commit_id":"0ee9c70e78a33767ed58e1942578aec1b516add3"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"823b3ab0dee5002c5f9d2bf1595a03f4b4d80720","unresolved":false,"context_lines":[{"line_number":980,"context_line":"        :param image_url: The URL of the image to attach."},{"line_number":981,"context_line":"        :param image_download_source: The source of the image download."},{"line_number":982,"context_line":"        :param retry_on_conflict: Whether to retry HTTP CONFLICT errors."},{"line_number":983,"context_line":"            This can happen when either the virtual media is already used on a node or"},{"line_number":984,"context_line":"            the node is locked. Since the latter happens more often, the"},{"line_number":985,"context_line":"            default value is True."},{"line_number":986,"context_line":"        :return: ``None``"}],"source_content_type":"text/x-python","patch_set":6,"id":"86e9fa80_10ef10b7","line":983,"in_reply_to":"ac654b36_74bf3f55","updated":"2024-06-25 08:51:07.000000000","message":"Done","commit_id":"0ee9c70e78a33767ed58e1942578aec1b516add3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"55e7ddbb663a9a05bac1c9261a69ca7bfd448671","unresolved":true,"context_lines":[{"line_number":999,"context_line":"    def detach_vmedia_from_node(self, node, ignore_missing\u003dTrue):"},{"line_number":1000,"context_line":"        \"\"\"Detach virtual media from the node."},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        :param node: The value can be either the name or ID of a node or"},{"line_number":1003,"context_line":"            a :class:`~openstack.baremetal.v1.node.Node` instance."},{"line_number":1004,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":1005,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"}],"source_content_type":"text/x-python","patch_set":13,"id":"27b15b4b_d283b785","line":1002,"updated":"2024-07-04 13:15:57.000000000","message":"can you please adjust the indentation in the entire docstring?","commit_id":"eeac87d5d0c9b6d4711c9ec678e4c859ae639ea9"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"7ab0130024da7e5704370eb40318d4893099cd96","unresolved":false,"context_lines":[{"line_number":999,"context_line":"    def detach_vmedia_from_node(self, node, ignore_missing\u003dTrue):"},{"line_number":1000,"context_line":"        \"\"\"Detach virtual media from the node."},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        :param node: The value can be either the name or ID of a node or"},{"line_number":1003,"context_line":"            a :class:`~openstack.baremetal.v1.node.Node` instance."},{"line_number":1004,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":1005,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"}],"source_content_type":"text/x-python","patch_set":13,"id":"7d706c12_77f65283","line":1002,"in_reply_to":"27b15b4b_d283b785","updated":"2024-07-04 14:23:19.000000000","message":"Done","commit_id":"eeac87d5d0c9b6d4711c9ec678e4c859ae639ea9"}],"openstack/baremetal/v1/node.py":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"f7c57b9d33ee63a82fe03c5345535ae64b80889b","unresolved":true,"context_lines":[{"line_number":836,"context_line":"            headers\u003drequest.headers,"},{"line_number":837,"context_line":"            microversion\u003dversion,"},{"line_number":838,"context_line":"            retriable_status_codes\u003dretriable_status_codes,"},{"line_number":839,"context_line":"        )"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        msg \u003d ("},{"line_number":842,"context_line":"            \"Failed to attach Virtual Media to bare metal node {node}\".format("}],"source_content_type":"text/x-python","patch_set":5,"id":"5240834e_3073d2a7","line":839,"updated":"2024-06-20 11:50:09.000000000","message":"Is there a missing return statement here? Won\u0027t this function always raise an exception?","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"4e86fe3b15a2c0b56e431a807d50a18031234be0","unresolved":true,"context_lines":[{"line_number":836,"context_line":"            headers\u003drequest.headers,"},{"line_number":837,"context_line":"            microversion\u003dversion,"},{"line_number":838,"context_line":"            retriable_status_codes\u003dretriable_status_codes,"},{"line_number":839,"context_line":"        )"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        msg \u003d ("},{"line_number":842,"context_line":"            \"Failed to attach Virtual Media to bare metal node {node}\".format("}],"source_content_type":"text/x-python","patch_set":5,"id":"fe2cc0f5_ecd0202f","line":839,"in_reply_to":"5240834e_3073d2a7","updated":"2024-06-20 13:02:51.000000000","message":"Based on other usages of the exceptions.raise_from_response() method, this looks okay!","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"823b3ab0dee5002c5f9d2bf1595a03f4b4d80720","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            headers\u003drequest.headers,"},{"line_number":837,"context_line":"            microversion\u003dversion,"},{"line_number":838,"context_line":"            retriable_status_codes\u003dretriable_status_codes,"},{"line_number":839,"context_line":"        )"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        msg \u003d ("},{"line_number":842,"context_line":"            \"Failed to attach Virtual Media to bare metal node {node}\".format("}],"source_content_type":"text/x-python","patch_set":5,"id":"ad9e6518_f81003cd","line":839,"in_reply_to":"fe2cc0f5_ecd0202f","updated":"2024-06-25 08:51:07.000000000","message":"Done","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"a290475e48754ccbaaa5a50b709b8c72c3779395","unresolved":true,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        if ignore_missing and response.status_code \u003d\u003d 400:"},{"line_number":879,"context_line":"            session.log.debug("},{"line_number":880,"context_line":"                \"Virtual media doesn\u0027t exists for node %(node)s\","},{"line_number":881,"context_line":"                {\u0027node\u0027: self.id},"},{"line_number":882,"context_line":"            )"},{"line_number":883,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"360acbd8_b812559f","line":880,"updated":"2024-06-20 11:42:32.000000000","message":"Very small nit: Virtual media doesn\u0027t exist, (not exists)","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"823b3ab0dee5002c5f9d2bf1595a03f4b4d80720","unresolved":false,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        if ignore_missing and response.status_code \u003d\u003d 400:"},{"line_number":879,"context_line":"            session.log.debug("},{"line_number":880,"context_line":"                \"Virtual media doesn\u0027t exists for node %(node)s\","},{"line_number":881,"context_line":"                {\u0027node\u0027: self.id},"},{"line_number":882,"context_line":"            )"},{"line_number":883,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff466b08_89c0bc00","line":880,"in_reply_to":"360acbd8_b812559f","updated":"2024-06-25 08:51:07.000000000","message":"Done","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1da8b2c4288f77dcf6cc67619c2843484b983878","unresolved":true,"context_lines":[{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        :param session: The session to use for making this request."},{"line_number":852,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":853,"context_line":"        :param bool ignore_missing: When set to ``False``, "},{"line_number":854,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":855,"context_line":"            raised when virtual media is not attached. Otherwise,"},{"line_number":856,"context_line":"            ``False`` is returned."}],"source_content_type":"text/x-python","patch_set":10,"id":"2cdaf41b_79b8cc14","line":853,"range":{"start_line":853,"start_character":58,"end_line":853,"end_character":59},"updated":"2024-06-25 12:41:57.000000000","message":"This trailing whitespace is the problem, when running locally I got:\n\npep8: commands[0]\u003e pre-commit run --all-files --show-diff-on-failure\ntrim trailing whitespace.................................................Failed\n- hook id: trailing-whitespace\n- exit code: 1\n- files were modified by this hook\n\nFixing openstack/baremetal/v1/node.py\n\nmixed line ending........................................................Passed\ncheck BOM - deprecated: use fix-byte-order-marker........................Passed\ncheck that executables have shebangs.....................................Passed\ncheck for merge conflicts................................................Passed\ndebug statements (python)................................................Passed\ncheck yaml...............................................................Passed\ndoc8.....................................................................Passed\npyupgrade................................................................Passed\nblack....................................................................Passed\nhacking..................................................................Passed\nmypy.....................................................................Passed\npre-commit hook(s) made changes.\nIf you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.\nTo run `pre-commit` as part of git workflow, use `pre-commit install`.\nAll changes made by hooks:\ndiff --git a/openstack/baremetal/v1/node.py b/openstack/baremetal/v1/node.py\nindex b75fbc712..9d6fc4edb 100644\n--- a/openstack/baremetal/v1/node.py\n+++ b/openstack/baremetal/v1/node.py\n@@ -850,7 +850,7 @@ class Node(_common.Resource):\n \n         :param session: The session to use for making this request.\n         :type session: :class:`~keystoneauth1.adapter.Adapter`\n-        :param bool ignore_missing: When set to ``False``, \n+        :param bool ignore_missing: When set to ``False``,\n             :class:`~openstack.exceptions.ResourceNotFound` will be\n             raised when virtual media is not attached. Otherwise,\n             ``False`` is returned.\npep8: exit 1 (34.99 seconds) /home/iurygregory/workspace/openstacksdk\u003e pre-commit run --all-files --show-diff-on-failure pid\u003d178653\n  pep8: FAIL code 1 (35.08\u003dsetup[0.09]+cmd[34.99] seconds)\n  evaluation failed :( (35.22 seconds)","commit_id":"a04b97a3e490343860a74ea54e8b50773756637c"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"da2eb378b39b6253ec9f7dadef5c9e0c931efece","unresolved":false,"context_lines":[{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        :param session: The session to use for making this request."},{"line_number":852,"context_line":"        :type session: :class:`~keystoneauth1.adapter.Adapter`"},{"line_number":853,"context_line":"        :param bool ignore_missing: When set to ``False``, "},{"line_number":854,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":855,"context_line":"            raised when virtual media is not attached. Otherwise,"},{"line_number":856,"context_line":"            ``False`` is returned."}],"source_content_type":"text/x-python","patch_set":10,"id":"823aa716_2eee0fa6","line":853,"range":{"start_line":853,"start_character":58,"end_line":853,"end_character":59},"in_reply_to":"2cdaf41b_79b8cc14","updated":"2024-06-26 04:14:27.000000000","message":"Done","commit_id":"a04b97a3e490343860a74ea54e8b50773756637c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff58df4513adab32365ee4fec1c73fe7d97379c4","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    )"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # Ability to have a firmware_interface on a node."},{"line_number":103,"context_line":"    _max_microversion \u003d \u00271.87\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # Properties"},{"line_number":106,"context_line":"    #: The UUID of the allocation associated with this node. Added in API"}],"source_content_type":"text/x-python","patch_set":14,"id":"4a1e0981_da257aec","line":103,"updated":"2024-07-08 15:27:32.000000000","message":"You need to raise this to 1.89 otherwise _assert_microversion_for will fail for the default version.","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"216a1d78e12c8fcbe0a028068f52d471e9d96191","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    )"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # Ability to have a firmware_interface on a node."},{"line_number":103,"context_line":"    _max_microversion \u003d \u00271.87\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # Properties"},{"line_number":106,"context_line":"    #: The UUID of the allocation associated with this node. Added in API"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a1d5d39_c7f03928","line":103,"in_reply_to":"4a1e0981_da257aec","updated":"2024-07-13 12:28:31.000000000","message":"Done","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bdb1025beaf962218051e53341c3a829f25f711","unresolved":true,"context_lines":[{"line_number":845,"context_line":"        )"},{"line_number":846,"context_line":"        exceptions.raise_from_response(response, error_message\u003dmsg)"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def detach_vmedia(self, session, ignore_missing\u003dTrue):"},{"line_number":849,"context_line":"        \"\"\"Detach virtual media from a node"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        :param session: The session to use for making this request."}],"source_content_type":"text/x-python","patch_set":14,"id":"e15f2491_e1168a57","line":848,"updated":"2024-07-08 15:23:05.000000000","message":"This call accepts an optional argument (device_types)","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"216a1d78e12c8fcbe0a028068f52d471e9d96191","unresolved":false,"context_lines":[{"line_number":845,"context_line":"        )"},{"line_number":846,"context_line":"        exceptions.raise_from_response(response, error_message\u003dmsg)"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def detach_vmedia(self, session, ignore_missing\u003dTrue):"},{"line_number":849,"context_line":"        \"\"\"Detach virtual media from a node"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        :param session: The session to use for making this request."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa01d2c2_8dbba13b","line":848,"in_reply_to":"e15f2491_e1168a57","updated":"2024-07-13 12:28:31.000000000","message":"Done","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bdb1025beaf962218051e53341c3a829f25f711","unresolved":true,"context_lines":[{"line_number":853,"context_line":"        :param bool ignore_missing: When set to ``False``,"},{"line_number":854,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":855,"context_line":"            raised when virtual media is not attached. Otherwise,"},{"line_number":856,"context_line":"            ``False`` is returned."},{"line_number":857,"context_line":"        :return: ``True`` if the virtual media was detached,"},{"line_number":858,"context_line":"            otherwise ``False``."},{"line_number":859,"context_line":"        :raises: :exc:`~openstack.exceptions.NotSupported` if the server"}],"source_content_type":"text/x-python","patch_set":14,"id":"75ffc46a_b8f6f022","line":856,"updated":"2024-07-08 15:23:05.000000000","message":"I don\u0027t think it\u0027s possible: the call is completely asynchronous.","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"216a1d78e12c8fcbe0a028068f52d471e9d96191","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        :param bool ignore_missing: When set to ``False``,"},{"line_number":854,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":855,"context_line":"            raised when virtual media is not attached. Otherwise,"},{"line_number":856,"context_line":"            ``False`` is returned."},{"line_number":857,"context_line":"        :return: ``True`` if the virtual media was detached,"},{"line_number":858,"context_line":"            otherwise ``False``."},{"line_number":859,"context_line":"        :raises: :exc:`~openstack.exceptions.NotSupported` if the server"}],"source_content_type":"text/x-python","patch_set":14,"id":"ecee5eaf_6babb809","line":856,"in_reply_to":"75ffc46a_b8f6f022","updated":"2024-07-13 12:28:31.000000000","message":"Done","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"88163a720f27d663291b5707c9e84f28fb4c3d91","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        :param bool ignore_missing: When set to ``False``,"},{"line_number":854,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":855,"context_line":"            raised when virtual media is not attached. Otherwise,"},{"line_number":856,"context_line":"            ``False`` is returned."},{"line_number":857,"context_line":"        :return: ``True`` if the virtual media was detached,"},{"line_number":858,"context_line":"            otherwise ``False``."},{"line_number":859,"context_line":"        :raises: :exc:`~openstack.exceptions.NotSupported` if the server"}],"source_content_type":"text/x-python","patch_set":14,"id":"472f725d_f863eaef","line":856,"in_reply_to":"ecee5eaf_6babb809","updated":"2024-07-15 09:43:14.000000000","message":"Dmitry, what do you mean when you say the call is async so we can not use the ignore_missing logic? Does that mean that this function can not perform operations on the response at all?","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2d01f0c1e1b58f9c8480747baf7cf7fa6dc85571","unresolved":true,"context_lines":[{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        request \u003d self._prepare_request(requires_id\u003dTrue)"},{"line_number":871,"context_line":"        request.url \u003d utils.urljoin(request.url, \u0027vmedia\u0027)"},{"line_number":872,"context_line":"        response \u003d session.delete("},{"line_number":873,"context_line":"            request.url,"},{"line_number":874,"context_line":"            headers\u003drequest.headers,"},{"line_number":875,"context_line":"            microversion\u003dversion,"}],"source_content_type":"text/x-python","patch_set":14,"id":"d1a23deb_a540e5b7","line":872,"updated":"2024-07-10 14:07:50.000000000","message":"Session can receive params. so you can pass them there to deal with the device_types, from what I saw it\u0027s a dict, so you can probably pass\n{\u0027device_types\u0027:\u0027device_1\u0027}\nthe value can be the device_types param converted  with comma_separated_list","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"216a1d78e12c8fcbe0a028068f52d471e9d96191","unresolved":false,"context_lines":[{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        request \u003d self._prepare_request(requires_id\u003dTrue)"},{"line_number":871,"context_line":"        request.url \u003d utils.urljoin(request.url, \u0027vmedia\u0027)"},{"line_number":872,"context_line":"        response \u003d session.delete("},{"line_number":873,"context_line":"            request.url,"},{"line_number":874,"context_line":"            headers\u003drequest.headers,"},{"line_number":875,"context_line":"            microversion\u003dversion,"}],"source_content_type":"text/x-python","patch_set":14,"id":"d6569575_a61410dd","line":872,"in_reply_to":"d1a23deb_a540e5b7","updated":"2024-07-13 12:28:31.000000000","message":"Done","commit_id":"873ddc2348efb1395f8da7f9325882d2ddd35d49"}],"openstack/tests/functional/baremetal/test_baremetal_node.py":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"a290475e48754ccbaaa5a50b709b8c72c3779395","unresolved":true,"context_lines":[{"line_number":450,"context_line":"        self.device_type \u003d \"CDROM\""},{"line_number":451,"context_line":"        self.image_url \u003d \"http://image\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def test_node_vmedia_attach_detach(self):"},{"line_number":454,"context_line":"        self.conn.baremetal.attach_vmedia_to_node("},{"line_number":455,"context_line":"            self.node, self.device_type, self.image_url"},{"line_number":456,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"beed886b_721c5db1","line":453,"updated":"2024-06-20 11:42:32.000000000","message":"Perhaps adding another test case for attach_vmedia_to_node would be better.","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"f7c57b9d33ee63a82fe03c5345535ae64b80889b","unresolved":true,"context_lines":[{"line_number":450,"context_line":"        self.device_type \u003d \"CDROM\""},{"line_number":451,"context_line":"        self.image_url \u003d \"http://image\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def test_node_vmedia_attach_detach(self):"},{"line_number":454,"context_line":"        self.conn.baremetal.attach_vmedia_to_node("},{"line_number":455,"context_line":"            self.node, self.device_type, self.image_url"},{"line_number":456,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"edacac06_6fb01ac0","line":453,"in_reply_to":"beed886b_721c5db1","updated":"2024-06-20 11:50:09.000000000","message":"I see that there are tests in openstack/tests/unit/baremetal/v1/test_node.py;","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"823b3ab0dee5002c5f9d2bf1595a03f4b4d80720","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        self.device_type \u003d \"CDROM\""},{"line_number":451,"context_line":"        self.image_url \u003d \"http://image\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def test_node_vmedia_attach_detach(self):"},{"line_number":454,"context_line":"        self.conn.baremetal.attach_vmedia_to_node("},{"line_number":455,"context_line":"            self.node, self.device_type, self.image_url"},{"line_number":456,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"27f07621_e332db1f","line":453,"in_reply_to":"edacac06_6fb01ac0","updated":"2024-06-25 08:51:07.000000000","message":"Done","commit_id":"2c6ce91086f4d8cf88d8c30226779b973bf98301"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f23cf0a79fed10ef161e43882d0a3ea7046c855f","unresolved":true,"context_lines":[{"line_number":455,"context_line":"            self.node, self.device_type, self.image_url"},{"line_number":456,"context_line":"        )"},{"line_number":457,"context_line":"        res \u003d self.conn.baremetal.detach_vmedia_from_node(self.node)"},{"line_number":458,"context_line":"        self.asserNone(res)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_node_vmedia_negative(self):"},{"line_number":461,"context_line":"        uuid \u003d \"5c9dcd04-2073-49bc-9618-99ae634d8971\""}],"source_content_type":"text/x-python","patch_set":17,"id":"c5a6ca6f_5b71f67e","line":458,"updated":"2024-07-23 12:41:57.000000000","message":"typo? asserNone?","commit_id":"b9ad334e38aef32fa13ded4ceb490292e40ce345"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"1c0d27c12cc40a7d09642fca9b2785c71e855d27","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            self.node, self.device_type, self.image_url"},{"line_number":456,"context_line":"        )"},{"line_number":457,"context_line":"        res \u003d self.conn.baremetal.detach_vmedia_from_node(self.node)"},{"line_number":458,"context_line":"        self.asserNone(res)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_node_vmedia_negative(self):"},{"line_number":461,"context_line":"        uuid \u003d \"5c9dcd04-2073-49bc-9618-99ae634d8971\""}],"source_content_type":"text/x-python","patch_set":17,"id":"92ca37b7_e5185256","line":458,"in_reply_to":"c5a6ca6f_5b71f67e","updated":"2024-07-24 14:23:31.000000000","message":"Done","commit_id":"b9ad334e38aef32fa13ded4ceb490292e40ce345"}],"openstack/tests/unit/baremetal/v1/test_node.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"383c556023ab820e240972e5f0cae8acc2bd2918","unresolved":true,"context_lines":[{"line_number":723,"context_line":"        )"},{"line_number":724,"context_line":"        self.assertRaises("},{"line_number":725,"context_line":"            exceptions.NotSupported,"},{"line_number":726,"context_line":"            self.node.attach_vmedia,"},{"line_number":727,"context_line":"            self.session,"},{"line_number":728,"context_line":"            self.device_type,"},{"line_number":729,"context_line":"            self.image_url,"}],"source_content_type":"text/x-python","patch_set":12,"id":"241f25c0_e255d5be","line":726,"updated":"2024-07-03 09:18:26.000000000","message":"I think you want to test detach here?\notherwise you\u0027re testing attach twice","commit_id":"cde2088cbafd14e0d85d92c2f2442707d3ffcd68"},{"author":{"_account_id":37057,"name":"Salman Hajizada","display_name":"Salman Hajizada","email":"salmanhajizade2005@gmail.com","username":"shajizad"},"change_message_id":"64e64976dd537ab4ee7bb09c66ab6ab9ce6320b6","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        )"},{"line_number":724,"context_line":"        self.assertRaises("},{"line_number":725,"context_line":"            exceptions.NotSupported,"},{"line_number":726,"context_line":"            self.node.attach_vmedia,"},{"line_number":727,"context_line":"            self.session,"},{"line_number":728,"context_line":"            self.device_type,"},{"line_number":729,"context_line":"            self.image_url,"}],"source_content_type":"text/x-python","patch_set":12,"id":"d993f3a2_e31b2776","line":726,"in_reply_to":"241f25c0_e255d5be","updated":"2024-07-03 13:51:35.000000000","message":"Done","commit_id":"cde2088cbafd14e0d85d92c2f2442707d3ffcd68"}]}