)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"fe6dbd810ebb89b4d1de15cbe3bdbcbfac566c8b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"deda14bc_089cc5f0","updated":"2024-09-13 05:55:22.000000000","message":"(Resending as an unresolved comment.)\n\nThere are currently two issues with this change:\n\n* `netifaces-plus` is not defined in `upper-constraints.txt`.\n  This can be done, but there needs to be consideration\n  made to the fact that `netifaces` and `netifaces-plus`\n  cannot be installed at the same time, as they both supply\n  the `netifaces` package.\n* On closer inspection of the dependencies of the OpenStack\n  API clients that are typically installed in a CLI environment,\n  `oslo.utils` also depends on `netifaces`. Both `openstacksdk`\n  and `oslo.utils` will need to be updated to switch to\n  `netifaces-plus` to ensure they can be installed at the same time.","commit_id":"72a3a941f91e75a522714777b9404565eea8bf7a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"483308766f3c76b38d23594d81ebd1777a838d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d899f7e_9188c433","updated":"2024-09-12 10:50:28.000000000","message":"How about dropping it entirely? I\u0027ve proposed that [here](https://review.opendev.org/c/openstack/openstacksdk/+/928997).","commit_id":"72a3a941f91e75a522714777b9404565eea8bf7a"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"63951f8d31f473a383c0fec6c1fc6908f394a738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"186344aa_b84d7a34","updated":"2024-07-31 03:36:05.000000000","message":"There are currently two issues with this change:\n\n* netifaces-plus is not defined in upper-constraints.txt.\n  This can be done, but there might need to be consideration\n  made to the face that netifaces and netifaces-plus cannot\n  be installed at the same time.\n* On closer inspection of the dependencies of the OpenStack\n  API clients that are typically installed in a CLI environment,\n  oslo.utils also depends on netifaces. Both openstacksdk\n  and oslo.utils will need to be updated to switch to\n  netifaces-plus to ensure they can be installed at the same time.","commit_id":"72a3a941f91e75a522714777b9404565eea8bf7a"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"8a44d9bce04910a9a5a8e5ed93742e0138c5369b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a582a5f4_89797903","in_reply_to":"3d899f7e_9188c433","updated":"2024-09-13 05:52:01.000000000","message":"Hi Stephen, thanks for the comment. I\u0027d love for openstacksdk to remove its dependency on netifaces entirely.\n\nThe issue with doing it is that Python doesn\u0027t appear to have a *reliable* built-in method for detecting whether or not IPv6 works. `socket.has_ipv6`, as you\u0027ve proposed in your change, returns `True` if IPv6 is supported by the platform (which is almost always the days).\n\nSo I think we need to come up with something more accurate.","commit_id":"72a3a941f91e75a522714777b9404565eea8bf7a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cf22518b196597630379e22e6b7463a76c5491ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ced93cd4_211a9fea","in_reply_to":"96ba0443_bf404c23","updated":"2024-09-13 10:07:51.000000000","message":"Yeah, you\u0027re right. Those are testing different things (system support vs. actual IPv6 connectivity).\n\nThis is easy to do on Linux using e.g. iproute2, but the tricky part is supporting Windows. This probably warrants a wider discussion on openstack-discuss since the resolution will probably have to be consistent across projects.","commit_id":"72a3a941f91e75a522714777b9404565eea8bf7a"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"62e31f41dcc171d7a1845f41f9be6e9c3962a27b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96ba0443_bf404c23","in_reply_to":"a582a5f4_89797903","updated":"2024-09-13 05:58:18.000000000","message":"If merely checking whether or not the host supports IPv6 is sufficient, please disregard my comment. As far as solutions go, I 100% agree that removing the dependency on `netifaces` entirely is better.","commit_id":"72a3a941f91e75a522714777b9404565eea8bf7a"}]}