)]}'
{"id":"openstack%2Fopenstacksdk~925867","triplet_id":"openstack%2Fopenstacksdk~master~I51fd19054fed25ed0b07147240cd497918403817","project":"openstack/openstacksdk","branch":"master","topic":"trivial","hashtags":[],"change_id":"I51fd19054fed25ed0b07147240cd497918403817","subject":"image: Check path is a file before attempting to use it (redux)","status":"MERGED","created":"2024-08-07 12:34:27.000000000","updated":"2024-08-09 11:35:22.000000000","submitted":"2024-08-09 11:34:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"925867-trivial","meta_rev_id":"99593611657042531ca35690f7ed10c18bf67ea9","_number":925867,"virtual_id_number":925867,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-08-09 11:34:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2024-08-09 10:06:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2024-08-09 10:06:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-07 14:00:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7568fd79b036df93184d8ac8fd572de6f7206954","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-08-07 12:34:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"003d139dadad0701ecb39836c13b9991269bef32","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 14:00:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bafe1c11ca8e4e498ffd511e1acc308e\n\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/15d5dadcd5aa43568bc83efbb63c70ab : SUCCESS in 53m 20s (non-voting)\n- bifrost-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/eebe9a1aa2334791871a0588ca408e38 : SUCCESS in 45m 23s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6a91293c5f254ceb81eecff7b1a0706f : SUCCESS in 4m 02s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c99c687d0fbc46839fdf4b2f4c02e925 : SUCCESS in 3m 48s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/6cd771c0c6c0455595cbf448ff1ea984 : SUCCESS in 3m 38s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/841fa3b0c4f74e348260e49a88a59295 : SUCCESS in 5m 32s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/3aa464ccbb1d4213a5ed09299dae7c29 : SUCCESS in 56m 44s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/2b213adbb4d641a6a6029998ccf245b7 : SUCCESS in 3m 30s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/f307b1e1c97d4fbda571cb87fcf8726d : SUCCESS in 3m 57s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/8c060a153ea84337a9ffe3345102d29e : SUCCESS in 3m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cb123fe6efd94140ac79dfa209802f40 : SUCCESS in 7m 53s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/58981e173fd2454ca74618e923b410af : SUCCESS in 44m 50s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/5a1ba1528b0b452a9dff44f3b09d6276 : SUCCESS in 10m 53s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/1e9c2af1440e42b2b5e23c3d4b678f85 : SUCCESS in 30m 21s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4160272d1863437ea2d3b09d42a407e6 : SUCCESS in 47m 40s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/fe2e7264eb7344ea92a2a67c632c1808 : SUCCESS in 1h 12m 29s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/1661a23858ec4a27bfecb871438549ec : SUCCESS in 1h 21m 18s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/0826a79bbed144d39cfb948eab057445 : FAILURE in 44m 14s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/673e1b9272784c2cbeb24165f3c3fe66 : SUCCESS in 24m 20s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/66845234f7a34dd6bcbbe9b26af59684 : SUCCESS in 30m 58s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/477c0fd3d56048efb6e96d708a8f0b1e : FAILURE in 40m 46s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/66084e4ce0d74a2d90b822601474ee5e : SUCCESS in 1h 17m 42s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/313accf4819c4bc1bb1668b76483544b : FAILURE in 47m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"570df37c534946cf0fe4b80e527e4abdc069bb76","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-08-09 10:06:28.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"96bc2163c0e276179d722992d3c4d166130b7a86","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-09 10:07:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"37344e4eb616e2b802c183aba7900387903ae002","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-09 11:34:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4b895353961149a3b71badfc1247ee08\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/355e49e2d4b24974864f1eca4d5a8223 : SUCCESS in 4m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/722e9e3275534e0597ef1212ecf75e39 : SUCCESS in 5m 37s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/a095c6d9373349f5aa289fc6c1ca932d : SUCCESS in 4m 01s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/07e3210b26814e4095e057857816ed4d : SUCCESS in 1h 00m 02s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/5b1bbf8e43e24d90ac93cd94f369bdd3 : SUCCESS in 3m 48s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/924519d4f9c64e2e89f7c6be96cdbd16 : SUCCESS in 6m 07s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/4ca561ca2a634463b20e6b4417e9a0fe : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cb1ce257513e43068d0fd2cb2a2fae24 : SUCCESS in 12m 36s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/023fbdf1ea98428dafe35a5666ef75cd : SUCCESS in 3m 01s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/dd495bb6cdd64755b662a73c28acf3ae : SUCCESS in 1h 01m 12s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/30747ac3636e44ed8f2f0ce4a231d343 : SUCCESS in 1h 18m 40s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/3af3c200858b4488889ad6d7a4057d65 : SUCCESS in 1h 22m 46s","accounts_in_message":[],"_revision_number":1},{"id":"d896df7506be49da46f338a6b566f8e2d3578b92","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-09 11:34:14.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"99593611657042531ca35690f7ed10c18bf67ea9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-09 11:35:22.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d7a59996825b4123a2c67b14d9981d6d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0ffae7f5a660439bae0477f5c274e053 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"12ed1a34331147926d286ad2f12b389a1edd9957","revisions":{"12ed1a34331147926d286ad2f12b389a1edd9957":{"kind":"REWORK","_number":1,"created":"2024-08-07 12:34:27.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/67/925867/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/67/925867/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/67/925867/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/67/925867/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/67/925867/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/67/925867/1"}}},"commit":{"parents":[{"commit":"d921892f5d1cd4fc41e134cc5701a6271224cc15","subject":"Merge \"tests: Remove errant print\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/d921892f5d1cd4fc41e134cc5701a6271224cc15"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-08-07 12:33:42.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-08-07 12:33:42.000000000","tz":60},"subject":"image: Check path is a file before attempting to use it (redux)","message":"image: Check path is a file before attempting to use it (redux)\n\nWe missed one.\n\nChange-Id: I51fd19054fed25ed0b07147240cd497918403817\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/12ed1a34331147926d286ad2f12b389a1edd9957"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/12ed1a34331147926d286ad2f12b389a1edd9957"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
