)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2ad16cadfe19c6165aaacc25ccf96bf2f2cb0213","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0d29425_cb5fc930","updated":"2024-08-21 17:15:03.000000000","message":"Please add additional validation.","commit_id":"b91865617ebce1fc2677e03a32af9c1ede1a9773"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"fa9a9dec1dd6b2df3b7e7aee96ad59cb6c637692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"830a52bb_4c61ee49","updated":"2024-08-16 10:53:15.000000000","message":"recheck - I could not recreate the JSONDecodeError locally, was that a random failure?\n\n``File \"/usr/lib/python3.9/json/decoder.py\", line 355, in raw_decode\n    raise JSONDecodeError(\"Expecting value\", s, err.value) from None\n\n    json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)``","commit_id":"b91865617ebce1fc2677e03a32af9c1ede1a9773"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"20b15a85c49d339002ccecd8ddfc715fbf0fad85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f5461654_d847c663","updated":"2024-08-23 19:04:52.000000000","message":"It looks like osdk uses reno for release notes too, and it\u0027d be nice to have one for this IMO.\n\nLGTM from a code perspective.","commit_id":"9410d5a316de8a72239e620a36bbfd2f061e217a"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"867e732c174136b1b65ba6edcdd1328f209d6abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4db649b_49574e3c","updated":"2024-08-23 12:50:51.000000000","message":"recheck - openstack.exceptions.ResourceFailure: Server:2c132ca0-79c8-484b-837d-2ec45ddd661f transitioned to failure state ERROR","commit_id":"9410d5a316de8a72239e620a36bbfd2f061e217a"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"6291e4ae658a4612444a53a7c26ceead5a6e5506","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6b58ab2d_796c953d","updated":"2024-09-27 17:15:02.000000000","message":"LGTM","commit_id":"604d29bc9b71fd4c78fad325b4ff1a5f0b2a690b"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b0cce044fa4c694c23ab4ed36bc6964bc774f5ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8682caac_60ffceba","updated":"2024-09-27 19:13:02.000000000","message":"TIL ironic-core as core reviewers on openstacksdk","commit_id":"604d29bc9b71fd4c78fad325b4ff1a5f0b2a690b"}],"openstack/baremetal/v1/node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2ad16cadfe19c6165aaacc25ccf96bf2f2cb0213","unresolved":true,"context_lines":[{"line_number":497,"context_line":"            body[\u0027clean_steps\u0027] \u003d clean_steps"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        if deploy_steps is not None:"},{"line_number":500,"context_line":"            if target not in (\u0027active\u0027, \u0027rebuild\u0027):"},{"line_number":501,"context_line":"                raise ValueError("},{"line_number":502,"context_line":"                    \u0027Deploy steps can only be provided with \u0027"},{"line_number":503,"context_line":"                    \u0027\"deploy\" and \"rebuild\" target\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d04b415_d2c0fdfe","line":500,"updated":"2024-08-21 17:15:03.000000000","message":"I\u0027m seeing lots of validation in this we aren\u0027t doing for runbook -- should we be asserting that runbook is only set if service_steps and clean_steps are None and target is clean or service?","commit_id":"b91865617ebce1fc2677e03a32af9c1ede1a9773"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"df025380fadd0469c87aa4e742ea0e967326167c","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            body[\u0027clean_steps\u0027] \u003d clean_steps"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        if deploy_steps is not None:"},{"line_number":500,"context_line":"            if target not in (\u0027active\u0027, \u0027rebuild\u0027):"},{"line_number":501,"context_line":"                raise ValueError("},{"line_number":502,"context_line":"                    \u0027Deploy steps can only be provided with \u0027"},{"line_number":503,"context_line":"                    \u0027\"deploy\" and \"rebuild\" target\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c753b765_5fb8b056","line":500,"in_reply_to":"5d04b415_d2c0fdfe","updated":"2024-08-26 13:39:24.000000000","message":"Done","commit_id":"b91865617ebce1fc2677e03a32af9c1ede1a9773"}]}